On Thu Sep 15 22:27:44 2022 +0000, Bernhard Kölbl wrote:
> > Rebase failed: Rebase locally, resolve all conflicts, then push the
> branch. Try again.
lol now another issue popped up, the rebase worked properly earlier
this gitlab is really weird, litterally nothing has worked correctly for me
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/778#note_8695
My Windows SDK has `REG_APP_HIVE` defined to 0x10. It also has `REG_PROCESS_PRIVATE` as 0x20, which is presumably what `REG_PROCESS_APPKEY` gets mapped to.
If the tests aren't going to work on Win 7, then skip them as soon as the first call returns `STATUS_INVALID_PARAMETER_6`.
Since you've found that the key return is only available for an app key, then I don't think it makes sense to split this MR up as I'd previously suggested. That means we need the filename logic back in.
A couple of notes on that: When passing strings to the server, we typically don't nul-terminate them and pass the length instead. Also, there is logic there already that copes with loading and saving branches i.e. the `save_branch_info` stuff. Have you looked into adapting that?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/820#note_8694
Windows when using cached credentials will use them on the first challenge,
if then a second 403 (ACCESS_DENIED) is received, the user is prompted again
but this time with the password and save checkbox cleared.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/837
On Fri Sep 16 01:12:18 2022 +0000, **** wrote:
> Marvin replied on the mailing list:
> ```
> Hi,
> It looks like your patch introduced the new failures shown below.
> Please investigate and fix them before resubmitting your patch.
> If they are not new, fixing them anyway would help a lot. Otherwise
> please ask for the known failures list to be updated.
> The full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=123494
> Your paranoid android.
> === debian11 (32 bit report) ===
> ntdll:
> reg.c:2348: Test succeeded inside todo block: got 0xc00000f5
> === debian11 (32 bit zh:CN report) ===
> ntdll:
> reg.c:2348: Test succeeded inside todo block: got 0xc00000f5
> === debian11 (32 bit WoW report) ===
> ntdll:
> reg.c:2348: Test succeeded inside todo block: got 0xc00000f5
> === debian11 (64 bit WoW report) ===
> ntdll:
> reg.c:2348: Test succeeded inside todo block: got 0xc00000f5
> ```
This test report is from the other force push, now I fixed it with the last push.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/820#note_8684
--
v7: winecoreaudio: Switch to mmdevapi's unixlib.h.
winecoreaudio: Adapt "get_capture_buffer_params" struct to mmdevapi's.
winecoreaudio: Adapt "release_render_buffer_params" struct to mmdevapi's.
winecoreaudio: Adapt "release_stream_params" struct to mmdevapi's.
winecoreaudio: Adapt "create_stream_params" struct to mmdevapi's.
winecoreaudio: Drop "unix_" prefix in unixlib enum, apply it to the functions instead.
mmdevapi: Integrate winecoreaudio's additions in unixlib.h.
winecoreaudio: Switch to string as device identifier, to match other drivers.
winecoreaudio: Fix RegEnumKeyExW() call passing wrong unit for the buffer size.
https://gitlab.winehq.org/wine/wine/-/merge_requests/813
--
v6: winecoreaudio: Switch to mmdevapi's unixlib.h.
winecoreaudio: Adapt "get_capture_buffer_params" struct to mmdevapi's.
winecoreaudio: Adapt "release_render_buffer_params" struct to mmdevapi's.
winecoreaudio: Adapt "release_stream_params" struct to mmdevapi's.
winecoreaudio: Adapt "create_stream_params" struct to mmdevapi's.
winecoreaudio: Drop "unix_" prefix in unixlib enum, apply it to the functions instead.
mmdevapi: Integrate winecoreaudio's additions in unixlib.h.
winecoreaudio: Switch to string as device identifier, to match other drivers.
https://gitlab.winehq.org/wine/wine/-/merge_requests/813