September 2022 - wine-gitlab

Re: [PATCH v4 0/2] MR787: notepad: Add status bar and goto line dialog
by Huw Davies (＠huw) 07 Sep '22

07 Sep '22

Generally I think this MR should be split into two separate ones. That'll give us a chance to get the status bar work in before we worry about the goto dialog box. So, just concentrating on the status bar commit, I'd start off by splitting that into two commits. First add the code that creates and displays the status bar (it doesn't need to display any text at this point). Then add a second commit that updates the status bar with line / col info. As @besentv mentioned, the commit messages are still not quite there - we terminate the subject with a period. I'll comment on some of the code below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/787#note_7869

1 0

[PATCH v2 0/2] MR796: include/test.h: Don't use strcasecmp.
by Stefan Dösinger (＠stefan) 07 Sep '22

07 Sep '22

Fixes building tests in Visual Studio with msvc's own crt headers. --- This follows patches in other places that replaced it first with _strnicmp(a, b, -1), and later with _stricmp(a, b), because _strnicmp with size=-1 raises a runtime error. -- v2: test.h: Don't use \e. include/test.h: Don't use strcasecmp. https://gitlab.winehq.org/wine/wine/-/merge_requests/796

2 2

[PATCH v6 0/1] MR766: advapi32/test: Add tests for RegLoadAppKey.
by Santino Mazza (＠tati1454) 07 Sep '22

07 Sep '22

-- v6: advapi32/tests: Add tests for RegLoadAppKey. https://gitlab.winehq.org/wine/wine/-/merge_requests/766

3 3

Re: [PATCH v3 0/1] MR794: evr/filter: Initial implementation of sample rendering.
by Nikolay Sivov (＠nsivov) 07 Sep '22

07 Sep '22

On Tue Sep 6 20:28:13 2022 +0000, **** wrote: > Zebediah Figura replied on the mailing list: > ``` > On 9/6/22 09:12, Nikolay Sivov wrote: > > +static HRESULT evr_get_service(void *unk, REFGUID service, REFIID > riid, void **obj) > > +{ > > + IMFGetService *gs; > > + HRESULT hr; > > + > > + if (SUCCEEDED(hr = IUnknown_QueryInterface((IUnknown *)unk, > &IID_IMFGetService, (void **)&gs))) > > + { > > + hr = IMFGetService_GetService(gs, service, riid, obj); > > + IMFGetService_Release(gs); > > + } > > + > > + return hr; > > +} > > + > Isn't this MFGetService()? > (It also isn't really evr-specific, so I'd be inclined to omit the evr_ > prefix, but that's a rather minor quibble.) > ``` Yes, it is, but I don't want to link to mf.dll just for that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/794#note_7860

1 0

[PATCH 0/1] MR800: crypt32/tests: Use CRT allocation functions.
by Nikolay Sivov (＠nsivov) 07 Sep '22

07 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/800

2 1

[PATCH v3 0/7] MR551: win32u: Complete support for display modes in nulldrv.
by Rémi Bernon (＠rbernon) 07 Sep '22

07 Sep '22

With this series it's now possible to run and pass `user32:monitor` and `user32:sysparams` tests with nulldrv, and so most `user32` tests (except for a few desktop cursor position tests). This still requires some prefix configuration to enable the nulldrv driver, or a change like https://gitlab.winehq.org/rbernon/wine/-/commit/753368ad0ec52f03f8d6e78ca79… to enable it when `DISPLAY` environment variable is unset. This then shows that some of the user32 tests are failing with winex11 but passing with nulldrv, as in https://gitlab.winehq.org/rbernon/wine/-/commit/6d5f4109a514a0dc266899fcacf…. -- v3: win32u: Return DISP_CHANGE_SUCCESSFUL from nulldrv_ChangeDisplaySettingsEx. win32u: Read current display settings from the registry if GetCurrentDisplaySettings fails. win32u: Write current display settings to the registry in apply_display_settings. win32u: Force update display cache after NtUserChangeDisplaySettingsEx. win32u: Introduce a new VirtualScreenRectChanged display driver callback. win32u: Broadcast WM_DISPLAYCHANGE message on display settings change. win32u: Move enumeration of available modes out of graphics drivers. https://gitlab.winehq.org/wine/wine/-/merge_requests/551

4 24

[PATCH 0/2] MR798: msvcrt: Fix strncmp return value.
by Shaun Ren (＠shaunren) 06 Sep '22

06 Sep '22

Some programs, such as Final Fantasy IV (3D remake), expect strncmp to return exactly +/-1 when the strings are not equal. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/798

3 3

Re: [PATCH v3 0/6] MR788: winevulkan: Move dispatchable handles allocation to PE code. - approved
by Alexandre Julliard (＠julliard) 06 Sep '22

06 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/788

1 0

Re: [PATCH v2 0/4] MR792: include: Add some more MFT / DMO class ids and WMV media type ids. - approved
by Alexandre Julliard (＠julliard) 06 Sep '22

06 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/792

1 0

Re: [PATCH v3 0/1] MR794: evr/filter: Initial implementation of sample rendering. - approved
by Alexandre Julliard (＠julliard) 06 Sep '22

06 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/794

1 0

2025

2024

2023

2022

wine-gitlab September 2022