January 2023 - wine-gitlab

Re: [PATCH v2 0/1] MR2029: dmime: Store WAVE data when Loading.
by Michael Stefaniuc (＠mstefani) 30 Jan '23

30 Jan '23

Michael Stefaniuc (@mstefani) commented about dlls/dmime/segment.c: > + case FOURCC_LIST: { > + FIXME("Skipping LIST tag\n"); > + break; > + } > + case mmioFOURCC('I','S','F','T'): { > + FIXME("Skipping ISFT tag\n"); > + break; > + } > + case mmioFOURCC('f','a','c','t'): { > + FIXME("Skipping fact tag\n"); > + break; > + } > + } > + } > + > + return S_OK; The stream_next_chunk() in the while loop can fail too and you'll need to return that failure too. S_FALSE indicates "no more chunks". -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2029#note_22348

1 0

Re: [PATCH v2 0/1] MR2029: dmime: Store WAVE data when Loading.
by Michael Stefaniuc (＠mstefani) 30 Jan '23

30 Jan '23

Michael Stefaniuc (@mstefani) commented about dlls/dmime/segment.c: > return CONTAINING_RECORD(iface, IDirectMusicSegment8Impl, dmobj.IPersistStream_iface); > } > > +static HRESULT parse_wave_form(IDirectMusicSegment8Impl *This, IStream *stream, const struct chunk_entry *riff) > +{ > + HRESULT hr; > + struct chunk_entry chunk = {.parent = riff}; > + > + TRACE("Parsing segment wave in %p: %s\n", stream, debugstr_chunk(riff)); > + > + while ((hr = stream_next_chunk(stream, &chunk)) == S_OK) { > + switch (chunk.id) { > + case mmioFOURCC('f','m','t',' '): { > + if (FAILED(hr = stream_chunk_get_data(stream, &chunk, &This->wave_format, chunk.size))) Don't use the chunk.size there; use the sizeof the destination object, here sizeof(This->wave_format) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2029#note_22347

1 0

Re: [PATCH v2 0/1] MR2029: dmime: Store WAVE data when Loading.
by Michael Stefaniuc (＠mstefani) 30 Jan '23

30 Jan '23

Michael Stefaniuc (@mstefani) commented about dlls/dmime/segment.c: > > if (riff.type == DMUS_FOURCC_SEGMENT_FORM) > hr = parse_segment_form(This, stream, &riff); > - else { > - FIXME("WAVE form loading not implemented\n"); > - hr = S_OK; > - } > + else Please check that the RIFF has the proper type and add an else for the error case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2029#note_22346

1 0

[PATCH v5 0/3] MR65: hlsl: More function-related tests.
by Zebediah Figura (＠zfigura) 30 Jan '23

30 Jan '23

-- v5: tests: Test entry point semantics on function declarations. tests: Add more tests for early return from the entry point. tests: Add some tests for early return from user-defined functions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/65

2 3

[PATCH 0/1] MR2068: Draft: comdlg32: Enable visual styles when showing IFileDialog.
by Vladislav Timonin (＠vt) 30 Jan '23

30 Jan '23

Required for !1857 to not break when comctl32 version 6 isn't requested by application (in particular, found this in [qapitrace](https://github.com/apitrace/apitrace)). Manifest resource id and assembly identity name match with Windows. For isolation purposes, activation context is disabled while emitting events. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2068

3 2

[PATCH 0/1] MR2067: wine32u: fix off-by-one bugs in MsgWaitForMultipleObjectsEx drivers
by Ivan Chikish (＠nekotekina) 30 Jan '23

30 Jan '23

When count = 0, returned value may become -1 which seems wrong in the case of successful process_events() call. Also MSDN suggests that `count` may be a valid return value in this case. When -1 is returned, it may cause SetLastError to -1 as well which is not a valid error code AFAIK. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54405 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2067

4 7

[PATCH v5 0/2] MR2051: include/msvcrt: Add noreturn attribute to _assert.
by Jinoh Kang (＠iamahuman) 30 Jan '23

30 Jan '23

This informs the compiler that no code will ever run after an assertion failure (unless NDEBUG is defined), which increases accuracy of compiler warnings and static analyses. -- v5: include/msvcrt: Add noreturn attribute to _assert. include: Add noreturn attribute to RtlRaiseStatus. https://gitlab.winehq.org/wine/wine/-/merge_requests/2051

3 4

[PATCH 0/1] MR2066: gdi32/tests: Mark another D3DKMTCheckOcclusion() test as flaky.
by Hans Leidekker (＠hans) 30 Jan '23

30 Jan '23

It shows the same behavior as the one marked by commit 2d19baa6b576. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=51313 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2066

3 2

[PATCH 0/2] MR2065: ws2_32/tests: Fix some test failures on Windows 11.
by Hans Leidekker (＠hans) 30 Jan '23

30 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2065

2 2

[PATCH 0/7] MR2064: Implement kernelbase.EnumProcessModulesEx
by eric pouech (＠epo) 30 Jan '23

30 Jan '23

This series implements kernelbase.EnumProcessModulesEx(). This series: - implements EnumProcessModulesEx() - ensure it passes a bunch of new tests - fix GetModuleBaseName, GetModuleFileNameEx, GetModuleInformation() to cope with HMODULES returned from EnumProcessModulesEx(). Notes: as EnumProcessModules() doesn't return the same list as Windows on a Wow64 setup, and that there's no use of EnumProcessModulesEx() in Wine code, this first series will implement EnumProcessModulesEx() and if accepted, it will be followed by a second serie which, firstly, adapt all places in Wine code with bad expectations on EnumProcessModules(), and secondly reimlement EnumProcessModules() using EnumProcessModulesEx(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2064

2 7

2025

2024

2023

2022

wine-gitlab January 2023