January 2023 - wine-gitlab

[PATCH 0/1] MR2026: ws2_32/test: Fix sockaddr buffer overflow in test_reuseaddr.
by Jinoh Kang (＠iamahuman) 25 Jan '23

25 Jan '23

Today, test_reuseaddr() triggers a buffer overflow when accept()-ing an IPv6 client due to the supplied peer name buffer (`struct sockaddr`) being too small to hold an AF_INET6 address (`struct sockaddr_in6`). Fix this by changing the type of `saddr` from `struct sockaddr` to `struct sockaddr_storage`. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54376 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2026

4 3

[PATCH 0/4] MR2024: wbemprox: Implement Win32_Volume.
by Hans Leidekker (＠hans) 25 Jan '23

25 Jan '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54030 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2024

4 6

[PATCH v9 0/3] MR1578: ntdll: TlsIndex should not actually contain tls indices
by Evan Tang (＠etang-cw) 25 Jan '23

25 Jan '23

> (The TlsIndex field in the LDR_DATA_TABLE_ENTRY structure appears to be unused except as a flag that the module has TLS (being always set to -1), at least as far back as Windows XP. It is worth mentioning that the WINE implementation of implicit TLS incorrectly uses TlsIndex as the real module TLS index, so it may be unreliable to assume that it is always -1 if you care about working on WINE.) > > \- http://www.nynaeve.net/?p=186 and the "links to that article but still doesn't work in wine" award goes to... [the D runtime](https://github.com/dlang/dmd/blob/6bf60ea0eb174631ede0074a77d3898d…! (Admittedly, there aren't too many ways to do what they're trying to do.) With this, the D runtime will now work in Wine, even if in a dll loaded into an exe with no tls (which gets it the tls index 0) ~~The changes to the debugger are a bit icky, a possible alternative is to find some other easily-debugger-accessible place to stuff the tls index.~~ Resolved -- v9: ntdll: TlsIndex should not actually contain tls indices winedbg: Fix read access to variables with thread local storage. winedbg: Track loaded modules https://gitlab.winehq.org/wine/wine/-/merge_requests/1578

3 4

[PATCH v10 0/6] MR1948: Draft: windows.media.speech: Recognition session work the second.
by Bernhard Kölbl (＠besentv) 25 Jan '23

25 Jan '23

First relevant commit: windows.media.speech: Add a worker thread to the recognition session. -- v10: windows.media.speech: Store recorded audio in a temporary ringbuffer. windows.media.speech: Partially implement the speech recognizer state. windows.media.speech: Add an audio capturing system. windows.media.speech: Allow the recognition session worker to be paused. windows.media.speech/tests: Check if stopping the session resets the paused state. windows.media.speech: Add a worker thread to the recognition session. https://gitlab.winehq.org/wine/wine/-/merge_requests/1948

3 18

[PATCH v3 0/5] MR1733: mshtml/jscript/vbscript: Implement SID_GetCaller and misc fixes.
by Gabriel Ivăncescu (＠insn) 25 Jan '23

25 Jan '23

-- v3: vbscript: Implement SID_GetCaller for QueryService. vbscript: Add a ServiceProvider stub. jscript: Implement SID_GetCaller for QueryService. mshtml: Set SCRIPTPROP_ABBREVIATE_GLOBALNAME_RESOLUTION properly. mshtml: Implement location props when there's no URI. https://gitlab.winehq.org/wine/wine/-/merge_requests/1733

3 9

[PATCH v2 0/3] MR2009: cryptnet: Also hash issuer cert for cache id.
by Paul Gofman (＠gofman) 25 Jan '23

25 Jan '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54353 There are two issues which the patchset is fixing: 1. Using cert's serial is not quite right, we need to hash full certificate contents as the check result depends on the other certificate data. 2. The check result also depends on revocation check parameters. I think currently it is only issuer certificate from the parameters which can affect the result which is cached. -- v2: cryptnet: Also hash issuer cert for cache id. cryptnet: Use cert data hash as cache id instead of serial number. cryptnet: Cache revocation status in verify_cert_revocation(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2009

3 5

[PATCH 0/1] MR2025: advapi32: Bump random buffer size.
by Hans Leidekker (＠hans) 25 Jan '23

25 Jan '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54364 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2025

3 4

[PATCH 0/2] MR64: hlsl: Write SM4 thread ID registers.
by Zebediah Figura (＠zfigura) 25 Jan '23

25 Jan '23

The last major feature for compute shader support. The tests are a bit ad-hoc, and ideally would be extended beyond d3d12. The nonuniform readback is what makes this difficult. My plan is to refactor the shader runner so that it exposes an interface usable both from a file interpreter frontend and also directly from C code. That would allow, in this case, declaring the shaders and drawing as a shader_test file would, but then making use of C loops to test the readback. It would also make it generally easier to port loop-based tests in e.g. d3d12.c. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/64

4 4

[PATCH v4 0/2] MR58: vkd3d-shader/hlsl: Reinterpret minimum precision types as their regular counterparts.
by Francisco Casas (＠fcasas) 25 Jan '23

25 Jan '23

Reinterpret min16float, min10float, min16int, min12int, and min16uint as their regular counterparts: float, float, int, int, uint, respectively. A proper implementation would require adding minimum precision indicators to all the dxbc-tpf instructions that use these types. Consider the output of fxc 10.1 with the following shader: ```hlsl uniform int i; float4 main() : sv_target { min16float4 a = {0, 1, 2, i}; min16int2 b = {4, i}; min10float3 c = {6.4, 7, i}; min12int d = 9.4; min16uint4x2 e = {14.4, 15, 16, 17, 18, 19, 20, i}; return mul(e, b) + a + c.xyzx + d; } ``` ``` ps_5_0 dcl_globalFlags refactoringAllowed | enableMinimumPrecision dcl_constantbuffer CB0[1], immediateIndexed dcl_output o0.xyzw dcl_temps 3 imad r0.xyz {min16u}, l(15, 17, 19, 0) {def32 as min16u}, cb0[0].xxxx {def32 as min16u}, l(56, 64, 72, 0) {def32 as min16u} utof r0.xyz {min16f}, r0.xyzx {min16u} imad r1.x {min16u}, cb0[0].x {def32 as min16u}, cb0[0].x {def32 as min16u}, l(80) {def32 as min16u} utof r0.w {min16f}, r1.x {min16u} mov r1.xyz {min16f}, l(0,1.000000,2.000000,0) {def32 as min16f} itof r1.w {min16f}, cb0[0].x add r0.xyzw {min16f}, r0.xyzw {min16f}, r1.xyzw {min16f} mov r2.y {min2_8f}, l(7.000000) {def32 as min2_8f} itof r2.z {min2_8f}, cb0[0].x add r0.yz {min16f}, r0.yyzy {min16f}, r2.yyzy {min2_8f as min16f} add r0.xyzw {min16f}, r0.xyzw {min16f}, l(15.400000, 9.000000, 9.000000, 15.400000) {def32 as min16f} mov o0.xyzw, r0.xyzw {min16f as def32} ret ``` However, if the graphics driver doesn't have minimum precision support, it ignores the minimum precision indicators and runs at 32-bit precision, which is equivalent as working with regular types. -- v4: vkd3d-shader/hlsl: Reinterpret minimum precision types as their regular counterparts. tests: Test minimum-precision numeric types. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/58

3 3

Re: [PATCH v2 0/5] MR70: vkd3d-shader/hlsl: Make single-component swizzles retrieve a scalar and add more swizzle tests.
by Francisco Casas (＠fcasas) 25 Jan '23

25 Jan '23

On Wed Jan 25 05:04:12 2023 +0000, Zebediah Figura wrote: > Not a big deal, but it looks like you fixed up the wrong commit :-) Oh, right! Fixed it now. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/70#note_21788

1 0

2025

2024

2023

2022

wine-gitlab January 2023