November 2023 - wine-gitlab

[PATCH v6 0/4] MR450: vkd3d-shader/ir: Flatten structured control flow instructions.
by Conor McCarthy (＠cmccarthy) 09 Nov '23

09 Nov '23

-- v6: vkd3d-shader/ir: Store code block names in struct vkd3d_shader_desc. vkd3d-shader/ir: Flatten structured control flow instructions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/450

2 4

[PATCH v3 0/1] MR4002: oleaut32: Fix typelib cache race condition.
by Connor McAdams (＠cmcadams) 09 Nov '23

09 Nov '23

This fixes the following issue: - Thread X holds the typelib cache list CS, and is iterating through the list. - Thread Y calls Release on the typelib interface, reference count hits 0, it's waiting for the cache list CS to remove this typelib. - Thread X finds the typelib in the cache list, returns it, exits the CS. - Thread Y enters now the CS, removes the typelib from the cache list, and proceeds to free all of the resources associated with the typelib. - Thread X tries to use the typelib, use after free. The method used here to prevent incrementing the reference count is borrowed from MR !2752. An alternative could be to decouple the actual typelib data from the `ITypeLib2` interface itself, e.g what gets stored into the typelib cache is just the data for the typelib, which would have its own private reference count locked behind the cache list CS. When the public `ITypeLib2` interface's reference count hits 0, it'd lock the typelib cache list CS, decrement the private reference count, and if the private reference count is 0 remove it from the list. The alternative method would require major restructuring of the code, which is why I'd prefer to use the one in this MR. -- v3: oleaut32: Lock ITypeLib2 interface reference count behind the typelib cache critical section on Release. https://gitlab.winehq.org/wine/wine/-/merge_requests/4002

2 2

[PATCH v2 0/1] MR4002: oleaut32: Fix typelib cache race condition.
by Connor McAdams (＠cmcadams) 09 Nov '23

09 Nov '23

This fixes the following issue: - Thread X holds the typelib cache list CS, and is iterating through the list. - Thread Y calls Release on the typelib interface, reference count hits 0, it's waiting for the cache list CS to remove this typelib. - Thread X finds the typelib in the cache list, returns it, exits the CS. - Thread Y enters now the CS, removes the typelib from the cache list, and proceeds to free all of the resources associated with the typelib. - Thread X tries to use the typelib, use after free. The method used here to prevent incrementing the reference count is borrowed from MR !2752. An alternative could be to decouple the actual typelib data from the `ITypeLib2` interface itself, e.g what gets stored into the typelib cache is just the data for the typelib, which would have its own private reference count locked behind the cache list CS. When the public `ITypeLib2` interface's reference count hits 0, it'd lock the typelib cache list CS, decrement the private reference count, and if the private reference count is 0 remove it from the list. The alternative method would require major restructuring of the code, which is why I'd prefer to use the one in this MR. -- v2: oleaut32: Lock ITypeLib2 interface reference count behind the typelib cache critical section. https://gitlab.winehq.org/wine/wine/-/merge_requests/4002

4 8

[PATCH 0/1] MR4351: uxtheme: Remove DECLSPEC_HIDDEN usage.
by Alistair Leslie-Hughes (＠alesliehughes) 09 Nov '23

09 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4351

3 2

[PATCH 0/1] MR4354: uxtheme: Fix a test failure.
by Zhiyi Zhang (＠zhiyi) 09 Nov '23

09 Nov '23

pszAppName should not be changed as it's used in the loop to check if window application name is set. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4354

2 1

[PATCH v4 0/7] MR4339: dmsynth, dmloader: Fix memory leaks.
by Anton Baskanov (＠baskanov) 09 Nov '23

09 Nov '23

-- v4: dmloader: Mark cached objects as loaded. dmsynth: Don't leak modulators. dmsynth: Free the allocated presets manually. dmsynth: Remove useless private data checks. dmsynth: Create one FluidSynth sample per wave. dmsynth: Use generators to set root key and fine tune. dmsynth: Keep track of voice/wave mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/4339

3 12

[PATCH 0/3] MR4349: Miscl decl hidden
by Alistair Leslie-Hughes (＠alesliehughes) 09 Nov '23

09 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4349

3 4

[PATCH v3 0/7] MR4341: msvcrt: Add implementation of more localized functions
by Bartosz Kosiorek (＠gang65) 09 Nov '23

09 Nov '23

-- v3: msvcrt: Add _mblen_l implementation. msvcrt: Add _mbsset_l implementation. msvcrt: Add _mbsrev_l implementation. msvcrt: Add _mbsncmp_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4341

3 9

[PATCH 0/1] MR4353: kernel32/tests: Remove unused variable.
by Jacek Caban (＠jacek) 09 Nov '23

09 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4353

2 1

[PATCH v3 0/1] MR4233: winmm: Fix pszSound allocation in PlaySound_Alloc().
by Paul Gofman (＠gofman) 09 Nov '23

09 Nov '23

In general, ucrtbase allocation are used here (and later ucrtbase.free for freeing memory). RtlCreateUnicodeStringFromAsciiz() is using RtlAllocateHeap(GetProcessHeap(),...) for allocation. Using ucrtbase.free() may results in freeing from a different heap which leaks the string as best or aborts the program when heap validation is enabled. -- v3: winmm: Fix pszSound allocation in PlaySound_Alloc(). https://gitlab.winehq.org/wine/wine/-/merge_requests/4233

3 2

2025

2024

2023

2022

wine-gitlab November 2023