November 2023 - wine-gitlab

Re: [PATCH v2 0/1] MR4342: mfplat/tests: Shut down the media source in test_create_from_file_handler_callback_Invoke().
by Zebediah Figura (＠zfigura) 08 Nov '23

08 Nov '23

On Wed Nov 8 20:19:31 2023 +0000, Nikolay Sivov wrote: > Maybe check for MF_OBJECT_MEDIASOURCE instead? Sure. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4342#note_51568

1 0

[PATCH v14 0/2] MR4310: ntdll: Tweak the binary representation of SRWLOCK.
by Yuxuan Shui (＠yshui) 08 Nov '23

08 Nov '23

There are applications that uses SRWLOCK in an invalid way and then checks its binary representation. ~~Specifically they releases an unlocked SRWLOCK then check its bit pattern is all-ones.~~ Tweak the representation a bit so they are happy. -- v14: ntdll: Tweak the binary representation of SRWLOCK. https://gitlab.winehq.org/wine/wine/-/merge_requests/4310

3 4

[PATCH v2 0/2] MR4313: MSVCRT _(w)environ[] has a separate allocation chunk for each entry.
by eric pouech (＠epo) 08 Nov '23

08 Nov '23

_(w)environ[] do have a distinct allocation chunk for each entry, so that _(w)environ[i] pointer and (pointed) string don't change when updating/deleting any other entry. Proposed implementation still differs from native: - allocation is done on process heap, while native uses msvcrt's heap - first ANSI allocated _environ[] doesn't have per entry allocation. This is only activated after a change (update/deletion) to _environ[] is made. -- v2: msvcrt: Let each _environ[] entry have a distinct allocation block. msvcrt: Add test about _environ[] entries allocation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4313

4 13

Re: [PATCH v2 0/1] MR4342: mfplat/tests: Shut down the media source in test_create_from_file_handler_callback_Invoke().
by Nikolay Sivov (＠nsivov) 08 Nov '23

08 Nov '23

Nikolay Sivov (@nsivov) commented about dlls/mfplat/tests/mfplat.c: > > hr = IMFSchemeHandler_EndCreateObject(handler, result, &obj_type, &object); > ok(hr == S_OK, "Failed to create an object, hr %#lx.\n", hr); > + todo_wine ok(obj_type == MF_OBJECT_BYTESTREAM, "Got object type %#x.\n", obj_type); > > - if (SUCCEEDED(hr)) > + hr = IMFAsyncResult_GetObject(result, (IUnknown **)&object2); > + ok(hr == E_POINTER, "Unexpected hr %#lx.\n", hr); > + > + if (obj_type != MF_OBJECT_BYTESTREAM) Maybe check for MF_OBJECT_MEDIASOURCE instead? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4342#note_51565

1 0

[PATCH 0/1] MR4283: wmvcore: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 08 Nov '23

08 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4283

3 2

[PATCH 0/1] MR4264: devenum: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 08 Nov '23

08 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4264

3 2

[PATCH v2 0/1] MR4306: rpcrt4/tests: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 08 Nov '23

08 Nov '23

-- v2: rpcrt4/tests: Use CRT allocation functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/4306

4 3

[PATCH 0/1] MR4342: mfplat/tests: Shut down the media source in test_create_from_file_handler_callback_Invoke().
by Zebediah Figura (＠zfigura) 08 Nov '23

08 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4342

2 1

[PATCH 0/2] MR4316: winegstreamer: Implement wg_muxer_push_sample.
by Ziqing Hui (＠zhui) 08 Nov '23

08 Nov '23

This MR is split from !3810. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4316

4 4

[PATCH 0/2] MR4328: ntdll: Don't allocate vprot entries until commit.
by Evan Tang (＠etang-cw) 08 Nov '23

08 Nov '23

Prevents applications that accidentally attempt to allocate massive amounts of memory from getting OOM killed (An example of such an application is EverQuest's DX11 beta, which has some corrupted asset files that result in it trying to allocate ~18TB of memory) BTW, is it okay to have a test that's likely to get OOM killed on a failing implementation? If not, any recommendations on how else to test this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4328

4 7

2025

2024

2023

2022

wine-gitlab November 2023