November 2023 - wine-gitlab

Re: [PATCH v4 0/1] MR496: vkd3d-shader: Handle 'linear centroid' modifier. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/496

1 0

Re: [PATCH v2 0/3] MR494: Remove some unnecessary local variables. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/494

1 0

Re: [PATCH v3 0/5] MR493: vkd3d: Clang warning fixes - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/493

1 0

Re: [PATCH v3 0/1] MR492: include: D3D12_RT_FORMAT_ARRAY remove typedef to make header compatible with windows - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/492

1 0

Re: [PATCH v3 0/2] MR488: vkd3d: Improve the EnqueueMakeResident stub - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/488

1 0

[PATCH 0/1] MR499: tests: Print the line number of the probe when a test fails.
by Petrichor Park (＠petrathekat) 27 Nov '23

27 Nov '23

Currently, if a probe fails, it will print the line number of the [test] block the probe is in, not the line number of the probe itself. This makes it somewhat difficult to debug. This commit makes it print the line number of the probe as well. CC @zfigura -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/499

2 1

[PATCH v3 0/6] MR4507: Add coml2 and start migrating a few functions from ole32
by Fabian Maurer (＠DarkShadow44) 27 Nov '23

27 Nov '23

Split off from https://gitlab.winehq.org/wine/wine/-/merge_requests/3106 -- v3: coml2: Move WriteClassStg from ole32 coml2: Move WriteClassStm from ole32 coml2: Move ReadClassStg from ole32 coml2: Move ReadClassStm from ole32 coml2: Move GetConvertStg from ole32 https://gitlab.winehq.org/wine/wine/-/merge_requests/4507

6 15

[PATCH 0/1] MR4524: dmime: Add Release() on some codepath.
by eric pouech (＠epo) 27 Nov '23

27 Nov '23

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4524

3 4

Re: [PATCH v4 0/8] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Jacek Caban (＠jacek) 27 Nov '23

27 Nov '23

On Mon Nov 27 20:35:08 2023 +0000, Gabriel Ivăncescu wrote: > Yeah. As I said below, I can easily just get rid of the tests and do the > right thing with a comment. Silently dropping events sounds like a bad > idea to me, it will make it hard to debug if something broken ever > depends on it. And it's not like it's more code, either, so better make > it correct. My guess is that you wouldn't be able to reproduce that with JS. If that's the case, then web pages can't depend on that (otherwise we'd have a way to crash web browser from JS). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4380#note_53978

1 0

Re: [PATCH v4 0/8] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Jacek Caban (＠jacek) 27 Nov '23

27 Nov '23

> As for the "hide problems in the future", I actually think the exact opposite. Right now, we use the document's outer_window in same way, except it's completely broken and can access invalid memory if the outer window happens to die, which would be very hard to debug (especially considering most apps using mshtml are bloated and slow with millions of frameworks). Yes, it would be nice to fix that. One fix for that is to simply reset the pointer to NULL. My understanding is that the actual reason we can't do that is iframe navigation test and we already know that the test works because on native, the document interface doesn't change. So what you do is essentially working around that problem, not fixing it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4380#note_53977

1 0

2025

2024

2023

2022

wine-gitlab November 2023