November 2023 - wine-gitlab

[PATCH v12 0/23] MR1088: ntdll: Avoid calling pthread_exit on thread exit.
by Rémi Bernon (＠rbernon) 21 Nov '23

21 Nov '23

Using a dedicated exit jmpbuf and removing the need for assembly routines. When Wine handles an exception in unix code, we return to user mode by jumping to the last syscall frame. This can leave some pthread cancel cleanups registered, in the pthread internal linked list, and at the same time later overwrite the stack frame they were registered for. In the same way, jumping to the exit frame on thread exit or abort, can also leave some cleanup handlers registered for invalid stack frames. Depending on the implementation, calling pthread_exit will cause all the registered pthread cleanup handlers to be called, possibly jumping back to now overwritten stack frames and causing segmentation faults. Exiting a pthread normally, by returning from its procedure, or calling exit(0) for the main thread doesn't run pthread_exit and doesn't call cleanup handlers, avoiding that situation. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52213 ### Additional note: For robustness, we should probably try to execute these cleanup handlers when unwinding the stack frames, as we would otherwise leave pthread objects in a potential problematic state (like a mutex locked, etc). It is however hard to do so when the handlers are registered from some C code: pthread C implementation is done by calling some internal pthread functions to register the handlers, and they aren't registered as standard unwind handlers. Only pthread_cancel and pthread_exit can unwind and call / unregister the C handlers, but interrupting that procedure, for instance calling setjmp / longjmp from withing our own handler isn't supported. From C++ code, pthread cleanup handlers are registered through C++ class constructors / destructors, and it would then be possible to partially unwind and call them at the same time. -- v12: ntdll: Remove the signal_exit_thread wrapper. ntdll: Get rid of the thread exit frame on ARM. ntdll: Get rid of the thread exit frame on ARM64. ntdll: Get rid of the thread exit frame on x86-64. ntdll: Get rid of the thread exit frame on i386. ntdll: Switch to the kernel stack to abort a thread on ARM. ntdll: Switch to the kernel stack to abort a thread on ARM64. ntdll: Switch to the kernel stack to abort a thread on x86-64. ntdll: Switch to the kernel stack to abort a thread on i386. ntdll: Connect syscall frames across user callbacks on ARM. ntdll: Connect syscall frames across user callbacks on ARM64. ntdll: Connect syscall frames across user callbacks on x86-64. ntdll: Connect syscall frames across user callbacks on i386. ntdll: Add a syscall_cfa member to the ARM syscall frame. ntdll: Add a syscall_cfa member to the ARM64 syscall frame. ntdll: Add a syscall_cfa member to the x86_64 syscall frame. ntdll: Add a syscall_cfa member to the i386 syscall frame. ntdll: Remove unnecessary stack pointer CFI rules. ntdll: Add comments to stack switches in dispatchers. ntdll: Directly access the syscall table variable on ARM64. ntdll: Directly access the syscall table variable on x86-64. ntdll: Store the syscall table in the TEB on ARM. ntdll: Store the syscall table in the TEB on i386. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/1088

1 0

[PATCH v3 0/2] MR482: vkd3d-shader/hlsl: Fix infinite loops when applying copy-prop to swizzles.
by Francisco Casas (＠fcasas) 21 Nov '23

21 Nov '23

Current copy-prop of swizzle instructions can result in infinite loops, as with the included test before this commit. Consider the following sequence of instructions where a load is stored in the same variable it loads: 1 : A 2 : A = @1 3 : @1.x In this case @3 would call copy_propagation_get_value() on A.x and would get @1, without detecting that that is indeed the same node it is already using as swizzle->value. So it would return true, keeping copy-prop spinning. To avoid this, it is check that the replacement instruction is not the same as the swizzle->load instruction. --- This was discovered when trying to compile shaders from [Bug 19499](https://www.codeweavers.com/support/bugs/browse?cmd=bug_edit;bug_id=…. -- v3: vkd3d-shader/hlsl: Avoid replacing with the same swizzle in copy-prop. vkd3d-shader/hlsl: Move index_instructions() up. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/482

4 14

Re: [PATCH v2 0/1] MR4454: winegstreamer: Store duration in the duration field. - approved
by Alexandre Julliard (＠julliard) 21 Nov '23

21 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4454

1 0

Re: [PATCH v3 0/2] MR4346: winegstreamer: Implement wg_muxer_read_data. - approved
by Alexandre Julliard (＠julliard) 21 Nov '23

21 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4346

1 0

Re: [PATCH v2 0/1] MR4413: advapi32/tests: Fix a service stop race condition. - approved
by Alexandre Julliard (＠julliard) 21 Nov '23

21 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4413

1 0

[PATCH v4 0/5] MR4450: winegstreamer: WMA DMO support
by Alfred Agrell (＠Alcaro) 21 Nov '23

21 Nov '23

Along with !4449, this fixes WMV videos in microkiri (https://bugs.winehq.org/show_bug.cgi?id=9127#c102) and Wagamama High Spec Trial Edition (https://wagahigh.com/download_trial.php#normal ; ダウンロード means download). -- v4: winegstreamer/tests: Test IMediaObject_GetOutputSizeInfo. winegstreamer: Implement DMO interface for WMA decoder. winegstreamer: Switch WMA decoder to use wg_format internally. winegstreamer: Implement WMA <-> AMT conversion. https://gitlab.winehq.org/wine/wine/-/merge_requests/4450

4 22

Re: [PATCH v6 0/7] MR4377: Reimplement msvcrt env functions to match native. - approved
by Alexandre Julliard (＠julliard) 21 Nov '23

21 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4377

1 0

Re: [PATCH v3 0/1] MR4446: msvcp110: Implement std::_Xbad_function_call(). - approved
by Alexandre Julliard (＠julliard) 21 Nov '23

21 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4446

1 0

Re: [PATCH v2 0/1] MR4447: msado15: Correct logic when setting field value. - approved
by Alexandre Julliard (＠julliard) 21 Nov '23

21 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4447

1 0

Re: [PATCH v2 0/1] MR4448: winemac.drv: Return success from query_ime_char_rect. - approved
by Alexandre Julliard (＠julliard) 21 Nov '23

21 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4448

1 0

2025

2024

2023

2022

wine-gitlab November 2023