November 2023 - wine-gitlab

Re: [PATCH v3 0/12] MR471: Draft: vkd3d-shader/dxil: Implement the DXIL GEP and LOAD instructions.
by Conor McCarthy (＠cmccarthy) 15 Nov '23

15 Nov '23

On Wed Nov 15 06:54:38 2023 +0000, Henri Verbeet wrote: > > This needs spirv changes to make any tests pass, but this series is > already long enough. Not sure what to do about initialisers; we can't > use `DCL_IMMEDIATE_CONSTANT_BUFFER` because it emits a variable, > Is the issue purely that the shader may write to the variable, or are > there other reasons that can't work? If what we want is essentially a > writeable icb, we could perhaps consider adding a "data[]" field to the > vkd3d_shader_indexable_temp structure, analogous to struct vkd3d_shader_immediate_constant_buffer. What it really needed was a new value type to hold ICBs. Storing an ICB in the indexable temp declaration works well now. Constant arrays should be declared with `DCL_IMMEDIATE_CONSTANT_BUFFER`, but that must wait for the next MR. It's not broken, just ignores the constant attribute. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/471#note_52336

1 0

Re: [PATCH v3 0/1] MR4343: setupapi: Add stub for DriverStoreFindDriverPackageW
by Alex Henrie (＠alexhenrie) 15 Nov '23

15 Nov '23

Alex Henrie (@alexhenrie) commented about dlls/setupapi/tests/query.c: > + WCHAR buffer[500]; > + DWORD len; > + HRESULT (WINAPI *pDriverStoreFindDriverPackageW)(const WCHAR*, void*, void*, DWORD, void*, WCHAR*, DWORD*); > + > + library = LoadLibraryA("setupapi.dll"); > + ok(library != NULL, "Failed to load setupapi.dll\n"); > + if (!library) return; > + > + pDriverStoreFindDriverPackageW = (void *)GetProcAddress(library, "DriverStoreFindDriverPackageW"); > + if (!pDriverStoreFindDriverPackageW) > + { > + win_skip("Can't find DriverStoreFindDriverPackageW\n"); > + return; > + } > + > + len = 500; Rather than initializing len with a magic number here, it would be more clear declare the variable as `DWORD len = ARRAY_SIZE(buffer)` to begin with. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4343#note_52331

1 0

Re: [PATCH v3 0/1] MR4343: setupapi: Add stub for DriverStoreFindDriverPackageW
by Alex Henrie (＠alexhenrie) 15 Nov '23

15 Nov '23

Alex Henrie (@alexhenrie) commented about dlls/setupapi/tests/query.c: > + ok(result == HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND), "Got %lx\n", result); > + else > + todo_wine > + ok(result == E_INVALIDARG, "Got %lx\n", result); /* Win64 needs flags 0x9, or it gives invalid parameter */ > + > + /* Invalid parameter tests */ > + > + result = pDriverStoreFindDriverPackageW(L"c:\\nonexistant.inf", 0, 0, 9, 0, 0, &len); > + ok(result == E_INVALIDARG, "Got %lx\n", result); > + > + result = pDriverStoreFindDriverPackageW(0, 0, 0, 9, 0, buffer, &len); > + ok(result == E_INVALIDARG, "Got %lx\n", result); > + > + result = pDriverStoreFindDriverPackageW(L"", 0, 0, 9, 0, buffer, &len); > + todo_wine > + ok(result == 0x8007007b || result == E_INVALIDARG, "Got %lx\n", result); /* Win7 and Win10 have different results */ 0x8007007b is HRESULT_FROM_WIN32(ERROR_INVALID_NAME). Let's use the macro instead of a magic number, assume that ERROR_INVALID_NAME is broken behavior, and make Wine return E_INVALIDARG in this situation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4343#note_52330

1 0

[PATCH 0/2] MR4388: user32: Return DEFAULT_CHARSET from SPI_GETICONTITLELOGFONT and SPI_GETNONCLIENTMETRICS.
by Dmitry Timoshkov (＠dmitry) 15 Nov '23

15 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4388

3 3

[PATCH v10 0/1] MR4372: kernel32: impl sync barrier
by quininer (＠quininer) 15 Nov '23

15 Nov '23

This is my first time contributing wine and there are a lot of things I'm not sure about, so any comments are welcome. :) -- v10: kernel32: impl sync barrier https://gitlab.winehq.org/wine/wine/-/merge_requests/4372

4 4

[PATCH v8 0/1] MR4372: kernel32: impl sync barrier
by quininer (＠quininer) 15 Nov '23

15 Nov '23

This is my first time contributing wine and there are a lot of things I'm not sure about, so any comments are welcome. :) -- v8: kernel32: impl sync barrier https://gitlab.winehq.org/wine/wine/-/merge_requests/4372

4 9

[PATCH v7 0/6] MR461: vkd3d: Implement ID3D12Device2::CreatePipelineState().
by Conor McCarthy (＠cmccarthy) 15 Nov '23

15 Nov '23

-- v7: vkd3d: Support depth bounds test. tests: Test CreatePipelineState(). vkd3d: Implement ID3D12Device2::CreatePipelineState(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/461

2 6

[PATCH v12 0/6] MR459: vkd3d-shader/dxil: Implement the DXIL VSELECT instruction.
by Conor McCarthy (＠cmccarthy) 15 Nov '23

15 Nov '23

-- v12: vkd3d-shader/spirv: Avoid invalid bool-to-bool conversion in spirv_compiler_emit_movc(). vkd3d-shader/dxil: Implement the DXIL VSELECT instruction. tests/shader-runner: Add tests for 64-bit casts. vkd3d-shader/spirv: Return an error if an invalid handler is encountered. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/459

2 7

[PATCH v2 0/1] MR4393: gdiplus: Boost performance of GdipDrawImagePointsRect.
by Bartosz Kosiorek (＠gang65) 15 Nov '23

15 Nov '23

By not using floorf from external library ucrtbase.dll the performance of GdipDrawImagePointsRect was improved. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53947 After applying patch the game performance is similar to native gdiplus.dll. Result of oprofile before patch: ``` samples % image name app name symbol name 895705 33.4761 ucrtbase.dll.so wine floor 351683 13.1438 no-vmlinux wine /no-vmlinux 330995 12.3706 gdiplus.dll.so wine resample_bitmap_pixel 300093 11.2157 win32u.so wine blend_rects_8888 272645 10.1898 gdiplus.dll.so wine GdipDrawImagePointsRect 137421 5.1360 gdiplus.dll.so wine sample_bitmap_pixel 112476 4.2037 gdiplus.dll.so wine convert_32bppARGB_to_32bppPARGB 35455 1.3251 no-vmlinux wineserver /no-vmlinux 35223 1.3164 no-vmlinux wine64-preloader /no-vmlinux 30252 1.1306 libc.so.6 wine /usr/lib/i386-linux-gnu/libc.so.6 ``` and after patch: ``` samples % image name app name symbol name 248581 18.3279 no-vmlinux wine /no-vmlinux 200141 14.7564 gdiplus.dll.so wine resample_bitmap_pixel 199840 14.7342 win32u.so wine blend_rects_8888 179135 13.2076 gdiplus.dll.so wine GdipDrawImagePointsRect 105785 7.7995 no-vmlinux wine-preloader /no-vmlinux 89534 6.6013 gdiplus.dll.so wine sample_bitmap_pixel 83947 6.1894 no-vmlinux wine64-preloader /no-vmlinux 74132 5.4658 gdiplus.dll.so wine convert_32bppARGB_to_32bppPARGB 22978 1.6942 anon (tgid:374066 range:0x7bc10000-0x7bffffff) wine anon (tgid:374066 range:0x7bc10000-0x7bffffff) 19747 1.4559 libc.so.6 wine /usr/lib/i386-linux-gnu/libc.so.6 14570 1.0742 win32u.so wine solid_rects_32 ``` Can we stop using floorf and ceilf from `math.h`? -- v2: gdiplus: Boost performance of GdipDrawImagePointsRect. https://gitlab.winehq.org/wine/wine/-/merge_requests/4393

4 6

Re: [PATCH v2 0/3] MR4385: Msxml add get xml - approved
by Alexandre Julliard (＠julliard) 14 Nov '23

14 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4385

1 0

2025

2024

2023

2022

wine-gitlab November 2023