November 2023 - wine-gitlab

[PATCH v2 0/1] MR3410: advpack: Add nullcheck for parameter that can be null (Coverity)
by Fabian Maurer (＠DarkShadow44) 11 Nov '23

11 Nov '23

-- v2: advpack: Add nullcheck for parameter that can be null (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/3410

2 1

[PATCH v12 0/11] MR1074: Draft: ntdll: Improve Valgrind and GDB integration.
by Rémi Bernon (＠rbernon) 11 Nov '23

11 Nov '23

Valgrind support requires a fork, which I've published to https://gitlab.winehq.org/rbernon/valgrind. The fork implements loading DWARF debug info from PE files, instead of the old and broken upstream PDB support. I've tried to upstream these changes a long time ago but didn't receive any feedback. I think we could maybe consider keeping a fork, which I'm happy to maintain, as the changes aren't too large. We may want to investigate adding 32-on-64 support, which may require a bit more changes (to VEX specifically, because its amd64 guest doesn't support segment register manipulation). The changes here are not all related to Valgrind, and I'll create separate MR for those which may make sense independently from Valgrind / GDB. Also included is a suppression file to silent some annoying false positives, many of which are coming from the cross-stack accesses during syscalls, which are confusing Valgrind's stack heuristics. One can try this out with something like: `WINELOADERNOEXEC=1 valgrind --suppressions=tools/valgrind.supp wine64/loader/wine64 wine64/programs/winecfg/winecfg.exe` -- v12: ntdll: Avoid writing to invalid memory in i386 unix dispatcher. ntdll: Fix incorrect i386 call_user_mode_callback CFI. ntdll: Avoid marking freed block header as undefined for valgrind. ntdll: Force HEAP_TAIL_CHECKING_ENABLED flag with valgrind. ntdll: Fix valgrind notifications from ntdll.so. ntdll: Import valgrind headers for PE side ntdll. loader: Implement SystemTap RTLD probes. configure.ac: Check for systemtap sys/sdt.h header. gitlab: Install systemtap-sdt-dev packages. ntdll: Maintain a PE module link map and expose it to GDB. loader: Expose a shadow copy of ld.so link map to GDB. https://gitlab.winehq.org/wine/wine/-/merge_requests/1074

2 11

Re: [PATCH v3 0/7] MR3909: winewayland.drv: part 7: Basic window management
by Alexandros Frantzis (＠afrantzis) 11 Nov '23

11 Nov '23

On Fri Nov 10 20:03:47 2023 +0000, Vixea wrote: > It's probably because it's being software rendered so it takes a second > to actually update the content of the window > Side note: you can still see it on xWayland it's just less noticeable > like I said it's noticable on wayland because of software rendering Hi! This is a known issue, see https://gitlab.winehq.org/wine/wine/-/merge_requests/3686#note_43830 for a description of why this is happening more (but not exclusively) with the Wayland driver. The aforementioned comment describes the effect with motion events, but it's the same cause for sustained resize events. Unfortunately we don't have a good solution yet. `regedit` is particularly prone to this, because it takes a surprisingly long time to render its contents. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3909#note_52024

1 0

Re: [PATCH v2 0/1] MR4253: winmm/tests: Use CRT allocation functions.
by Rémi Bernon (＠rbernon) 11 Nov '23

11 Nov '23

Fwiw tests are crashing on Windows since this was merged. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4253#note_52023

1 0

Re: [PATCH v3 0/1] MR4249: gdi32/tests: Use CRT allocation functions.
by Rémi Bernon (＠rbernon) 11 Nov '23

11 Nov '23

Fwiw tests are crashing on Windows since this was merged. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4249#note_52022

1 0

Re: [PATCH v2 0/1] MR4252: user32/tests: Use CRT allocation functions.
by Rémi Bernon (＠rbernon) 11 Nov '23

11 Nov '23

Fwiw tests are crashing on Windows since this was merged. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4252#note_52021

1 0

Re: [PATCH v2 0/1] MR4211: d3d8/tests: Use CRT allocation functions.
by Rémi Bernon (＠rbernon) 11 Nov '23

11 Nov '23

Fwiw tests are crashing on Windows since this was merged. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4211#note_52020

1 0

[PATCH v2 0/1] MR4365: opengl32: Skip filter_extensions_index() on GL contexts < 3.0.
by Matteo Bruni (＠Mystral) 11 Nov '23

11 Nov '23

glGetStringi() is not available before 3.0. We can't trust its function pointer being NULL since the GL implementation is allowed to return anything in this case (*cough* macOS's GL on Metal *cough*). This probably regressed when fd92954df8cf12c61e08c7ef7acf172efb7c44ad removed the "if (!disabled[0]) return FALSE;" exit from filter_extensions(), although that simply exposed an existing issue. -- v2: opengl32: Skip filter_extensions_index() on GL contexts < 3.0. https://gitlab.winehq.org/wine/wine/-/merge_requests/4365

2 1

[PATCH 0/4] MR4366: wined3d: More fixes related to texture binding.
by Zebediah Figura (＠zfigura) 11 Nov '23

11 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4366

3 4

[PATCH 0/1] MR4292: d3dcompiler_43/tests: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 10 Nov '23

10 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4292

3 2

2025

2024

2023

2022

wine-gitlab November 2023