December 2023 - wine-gitlab

[PATCH 0/1] MR4655: ntdll: loader_init() invoke breakpoint before loading dlls
by Dāvis Mosāns (davispuh) (＠davispuh) 08 Dec '23

08 Dec '23

While using [x64dbg](https://x64dbg.com/) I was experiencing incredibly strange issue - `int3` was swallowed and `KiUserExceptionDispatcher` was never invoked. Turns out that x64dbg ([TitanEngine](https://github.com/x64dbg/TitanEngine/blob/x64dbg/TitanEngine/…) expects system breakpoint to be first breakpoint that will be triggered and it always swallows it (it's hardcoded no setting to change it's behavior). That means if you have a DLL with `int3` for example ```c LONG ExceptionHandler(EXCEPTION_POINTERS *ExceptionInfo) { ExceptionInfo->ContextRecord->Rip++; return EXCEPTION_CONTINUE_EXECUTION; } BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) { if (fdwReason == DLL_PROCESS_ATTACH) { AddVectoredExceptionHandler(1, ExceptionHandler); asm("int $0x03; nop; nop;"); } return TRUE; } ``` That `int3` would be swallowed and `ExceptionHandler` never invoked when running under x64dbg. Now with this MR applied it works correctly and as expected (same as on Windows). Another interesting thing is that without this MR it wouldn't just swallow `int3` but even skip first `nop` aswell and RIP would end up on 2nd `nop`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4655

2 1

[PATCH v3 0/1] MR4620: kernel32: Implement GetProcessInformation(ProcessMachineTypeInfo).
by Nikolay Sivov (＠nsivov) 08 Dec '23

08 Dec '23

Marking as a draft for now, until !4605 is merged first. -- v3: kernel32: Implement GetProcessInformation(ProcessMachineTypeInfo). https://gitlab.winehq.org/wine/wine/-/merge_requests/4620

3 3

[PATCH 0/1] MR4630: explorer: Add an "Exit desktop" button to the Start menu.
by Alex Henrie (＠alexhenrie) 08 Dec '23

08 Dec '23

When running `wine explorer.exe /desktop=shell` as a full-screen app, there is no obvious way to close it and return to the Linux desktop. Remedy that problem by adding an "Exit desktop" button to the Start menu in the same place as the "Shut Down" button on Windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4630

3 2

[PATCH v9 0/6] MR4484: comctl32: Use selected font to determine default min tab width
by Brendan McGrath (＠redmcg) 08 Dec '23

08 Dec '23

This fixes the layout of the tabcontrol when a font other than the system font is used. -- v9: comctl32/tests: Modify test_width to try different fonts comctl32/tests: Check size initially and after changing padding only comctl32/tests: Fix tabcontrol tests to work with different fonts comctl32: Use selected font to determine default min tab width https://gitlab.winehq.org/wine/wine/-/merge_requests/4484

3 8

Re: [PATCH v4 0/1] MR4393: gdiplus: Boost performance of GdipDrawImagePointsRect.
by Esme Povirk (＠madewokherd) 08 Dec '23

08 Dec '23

I agree, there's no reason to essentially inline floorf here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4393#note_55554

1 0

Re: [PATCH v4 0/1] MR4393: gdiplus: Boost performance of GdipDrawImagePointsRect. - closed
by Esme Povirk (＠madewokherd) 08 Dec '23

08 Dec '23

This merge request was closed by Esme Povirk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4393

1 0

[PATCH v2 0/2] MR4638: gdiplus: Partially implement GdipDrawImageFX.
by Jinoh Kang (＠iamahuman) 08 Dec '23

08 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55945 Based on https://gitlab.winehq.org/gang65/wine/-/merge_requests/12. cc/ @gang65 -- v2: gdiplus: Partially implement GdipDrawImageFX. https://gitlab.winehq.org/wine/wine/-/merge_requests/4638

3 7

[PATCH v4 0/4] MR292: vkd3d: Write Vulkan descriptors in a worker thread.
by Conor McCarthy (＠cmccarthy) 08 Dec '23

08 Dec '23

-- v4: vkd3d: Co-locate all descriptor-related members. vkd3d: Rename the device mutex to pipeline_cache_mutex. vkd3d: Write Vulkan descriptors in a worker thread. vkd3d: Update the descriptor `next` index before getting a reference for writing. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/292

2 6

[PATCH v3 0/3] MR2343: Collection of small fixes for Fusion 360
by novenary * (＠novenary) 08 Dec '23

08 Dec '23

This fixes various problems I've run into while trying to use Fusion 360 in wine. - stacking issues in unmanaged mode - I also attempted to apply the same fix for managed mode, but it looks difficult to do this in a way that plays well with window managers; I think it's best left up to them to keep override_redirect windows at the top of the stack) - when the window manager sets our state to withdrawn, tell the window that it's been minimized, since the semantics are very similar - the last one is a hack because I don't really know what to do about it, when clicking on the floating popups, they gain focus, which causes wine to incorrectly make them managed and that breaks everything -- v3: winex11: don't let captionless popups be managed winex11: pass ICCCM withdrawn state as minimized winex11: restack a window's owned popups above it https://gitlab.winehq.org/wine/wine/-/merge_requests/2343

4 6

Re: [PATCH v6 0/5] MR4593: winewayland.drv: part 11: Mouselook support
by Alexandros Frantzis (＠afrantzis) 08 Dec '23

08 Dec '23

On Thu Dec 7 18:47:06 2023 +0000, Rémi Bernon wrote: > Well, code freeze is tomorrow so I don't intend to do anything soon. > You can submit it in a separate MR if you think it's critical for the > well behaving of the driver, and then @julliard will decide what to do > with it, but I would personally wait until we try to fix these > activation issues. Thanks. As a possibly more freeze-safe alternative, I proposed a mitigation in the driver itself https://gitlab.winehq.org/wine/wine/-/merge_requests/4651 . -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4593#note_55533

1 0

2025

2024

2023

2022

wine-gitlab December 2023