December 2023 - wine-gitlab

[PATCH 0/4] MR4587: kernelbase: Implement flag validation in `LoadLibraryEx()` to work like in Win10
by Dāvis Mosāns (davispuh) (＠davispuh) 04 Dec '23

04 Dec '23

While debugging League of Legends I noticed that `LoadLibraryEx()` is invoked with binary filename (non-text) and non-NULL `hFile`. In Windows such call would return `NULL` with LastError set as `ERROR_INVALID_PARAMETER` but current Wine implementation would try to proceed ahead. I don't know if this is intentional trick to mess up debugging/reversing tools or if we have some memory corruption before that overwrites filename buffer. But then I can't imagine how `hFile` could have gotten corrupted since shouldn't that be simple static value in register... Having this MR causes very noticeable difference in LoL: * without it - process deadlocks * with it - no deadlock Also while looking at this, I tried a lot of different flag combinations on Windows 10 and here I implemented so it works exactly like that. I also implemented test case for non-NULL `hFile` but I didn't bother for other flags since I don't know if we even care about those. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4587

3 5

[PATCH v2 0/2] MR4468: ntdll: Use posix_spawn() to start the server.
by Brendan Shanks (＠bshanks) 04 Dec '23

04 Dec '23

-- v2: ntdll: Use posix_spawn() to start the server. ntdll: Factor out generating possible paths to wineserver. https://gitlab.winehq.org/wine/wine/-/merge_requests/4468

2 2

[PATCH v6 0/6] MR4484: comctl32: Use selected font to determine default min tab width
by Brendan McGrath (＠redmcg) 04 Dec '23

04 Dec '23

This fixes the layout of the tabcontrol when a font other than the system font is used. -- v6: comctl32/tests: Modify test_width to try different fonts comctl32/tests: Check size initially and after changing padding only comctl32/tests: Fix tabcontrol tests to work with different fonts comctl32: Use selected font to determine default min tab width comctl32: Fix TAB_SetItemSize comctl32/tests: Add test for setitemsize return value https://gitlab.winehq.org/wine/wine/-/merge_requests/4484

3 8

Re: [PATCH v3 0/1] MR4555: shcore: Add stub for CreateRandomAccessStreamOverStream.
by Mohamad Al-Jaf (＠maljaf) 04 Dec '23

04 Dec '23

> I do test , if the program is free, but this one isn't, so cannot test. In that case, you can simply attach the patch to the Wine-Bug report and ask the user to test it like I did here: https://bugs.winehq.org/show_bug.cgi?id=54623. > I think it's just fine to add the stub so that user can test it in the next release to see if it helps workaround the bug and report back. I don't think this is fine as users often abandon bugs. Another user might file a bug report for another program that happens to call the stub. The stub can make it difficult to pinpoint the cause of a crash or issue, especially since Wine is rife with stubs. Of course, there are functions which are reasonably safe to stub. However, in this case, it's obvious a stub does not help. Since the function is creating something, it's safe to assume the program might attempt to access the object. Returning failure like E_NOTIMPL is often no different than returning success like S_OK since a lot of programs don't bother to check for failure and assume functions always succeed. > Apparently you have access to this program, and already knew the answer. Please share this info in future in bugreport then. I had access to the program when I was working on it. Well, if you read the info in the bug report you would know the bug started after adding in MediaControl. I sent multiple patches for Roon. I would have sent an MR for a simple stub if it helped. Also, sharing the info in the bug report is apparently pointless. See the previous bug: https://bugs.winehq.org/show_bug.cgi?id=54623 The info was ignored and an MR created nonetheless: https://gitlab.winehq.org/wine/wine/-/merge_requests/4579 Lastly, I'm not paid to work on Wine. I have no obligation to share anything, especially since a lot of bug reporters are unappreciative and even hostile. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4555#note_54808

1 0

[PATCH v3 0/9] MR498: Draft: vkd3d-shader/dxil: Implement the DXIL ALLOCA and STORE instructions.
by Conor McCarthy (＠cmccarthy) 04 Dec '23

04 Dec '23

Goes atop !477. The last two commits belong to this MR. -- v3: vkd3d-shader/dxil: Implement the DXIL STORE instruction. vkd3d-shader/dxil: Implement the DXIL ALLOCA instruction. tests/shader-runner: Test an uninitialised indexable temp. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/498

2 9

[PATCH v2 0/9] MR498: Draft: vkd3d-shader/dxil: Implement the DXIL ALLOCA and STORE instructions.
by Conor McCarthy (＠cmccarthy) 04 Dec '23

04 Dec '23

Goes atop !477. The last two commits belong to this MR. -- v2: vkd3d-shader/dxil: Implement the DXIL STORE instruction. vkd3d-shader/dxil: Implement the DXIL ALLOCA instruction. tests/shader-runner: Test an uninitialised indexable temp. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/498

2 10

[PATCH v5 0/5] MR4484: comctl32: Use selected font to determine default min tab width
by Brendan McGrath (＠redmcg) 04 Dec '23

04 Dec '23

This fixes the layout of the tabcontrol when a font other than the system font is used. -- v5: comctl32/tests: Modify test_width to try different fonts comctl32/tests: Check size initially and after changing padding only comctl32/tests: Fix tabcontrol tests to work with different fonts comctl32: Fix TAB_SetItemSize comctl32: Use selected font to determine default min tab width https://gitlab.winehq.org/wine/wine/-/merge_requests/4484

3 6

[PATCH v30 0/4] MR2808: SNI tray implementation
by Cherser-s (＠Cherser-s) 03 Dec '23

03 Dec '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v30: win32u: add SNI driver for systray handling win32u: add a SystrayRunLoop driver interface win32u: Refactor NotifyIcon driver interface into separate calls. https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

2 4

[PATCH v29 0/4] MR2808: SNI tray implementation
by Cherser-s (＠Cherser-s) 03 Dec '23

03 Dec '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v29: win32u: add SNI driver for systray handling win32u: add a SystrayRunLoop driver interface win32u: Refactor NotifyIcon driver interface into separate calls. https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

2 4

[PATCH v4 0/3] MR4484: comctl32: Use selected font to determine default min tab width
by Brendan McGrath (＠redmcg) 03 Dec '23

03 Dec '23

This fixes the layout of the tabcontrol when a font other than the system font is used. -- v4: comctl32: Modify test_width to try different fonts comctl32: Fix tabcontrol tests to work with different fonts comctl32: Use selected font to determine default min tab width https://gitlab.winehq.org/wine/wine/-/merge_requests/4484

4 5

2025

2024

2023

2022

wine-gitlab December 2023