On Sat Dec 2 18:00:47 2023 +0000, Petrichor Park wrote:
> (the change is to remove the `vkd3d_test_push_context` call on L1439,
> and then I'd need to remove the matching `vkd3d_test_pop_context` call
> that's somewhere)
Currently we push the debug context when entering a section and pop it just before entering the following one. It would be enough to keep doing this for all except for the `[test]` section, and push and pull at each line inside a `[test]` section. Does this make sense for you?
--
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/499#note_54833
*pszTmpFileName will be freed with free() but it's allocated with HeapAlloc().
--
v2: ntdll: Fix a memory leak (Coverity).
shell32: Fix a memory leak (Coverity).
wininet: Fix a use-after-free (Coverity).
tasklist: Fix a possible buffer overrun (Coverity).
https://gitlab.winehq.org/wine/wine/-/merge_requests/4590
While debugging League of Legends I noticed that `LoadLibraryEx()` is invoked with binary filename (non-text) and non-NULL `hFile`.
In Windows such call would return `NULL` with LastError set as `ERROR_INVALID_PARAMETER` but current Wine implementation would try to proceed ahead.
I don't know if this is intentional trick to mess up debugging/reversing tools or if we have some memory corruption before that overwrites filename buffer. But then I can't imagine how `hFile` could have gotten corrupted since shouldn't that be simple static value in register...
Having this MR causes very noticeable difference in LoL:
* without it - process deadlocks
* with it - no deadlock
Also while looking at this, I tried a lot of different flag combinations on Windows 10 and here I implemented so it works exactly like that.
I also implemented test case for non-NULL `hFile` but I didn't bother for other flags since I don't know if we even care about those.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4587
This fixes the layout of the tabcontrol when a font other than the
system font is used.
--
v6: comctl32/tests: Modify test_width to try different fonts
comctl32/tests: Check size initially and after changing padding only
comctl32/tests: Fix tabcontrol tests to work with different fonts
comctl32: Use selected font to determine default min tab width
comctl32: Fix TAB_SetItemSize
comctl32/tests: Add test for setitemsize return value
https://gitlab.winehq.org/wine/wine/-/merge_requests/4484