December 2023 - wine-gitlab

Re: [PATCH v7 0/7] MR4449: winegstreamer: WMReader compressed output
by Alfred Agrell (＠Alcaro) 01 Dec '23

01 Dec '23

On Thu Nov 30 22:00:39 2023 +0000, Zebediah Figura wrote: > I don't like this pattern; in cases like this we should instead just > split up the init_stream() helper to the part that's done on > initialization and the part that's done on recreation. That said I would > imagine more of this should be done on initialization...? They're a bit intertwined; reader->streams can't be allocated before stream_count is known, which requires creating the wg_parser. But yes, creating the reader from two places is cleaner than these conditionals, even if it's a few more lines of code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4449#note_54577

1 0

Re: [PATCH v7 0/7] MR4449: winegstreamer: WMReader compressed output
by Alfred Agrell (＠Alcaro) 01 Dec '23

01 Dec '23

On Thu Nov 30 22:00:38 2023 +0000, Zebediah Figura wrote: > This cast should be unnecessary. I'd also make this an ERR or FIXME. My thinking was that uint32_t is unsigned long, so it needs a cast. But you're right, that's wrong. This is Unix side code, so uint32_t is not unsigned long. Fixed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4449#note_54576

1 0

Re: [PATCH v7 0/7] MR4449: winegstreamer: WMReader compressed output
by Alfred Agrell (＠Alcaro) 01 Dec '23

01 Dec '23

On Thu Nov 30 22:00:39 2023 +0000, Zebediah Figura wrote: > This is ugly. Either we should explicitly block the read thread, or shut > it down and restart it. The latter is probably simpler. Recreating the thread throws approximately 99999 test failures about being called from wrong thread. Should I throw some todo_wine or something at them instead? Some of those tests feel kinda overzealous. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4449#note_54575

1 0

[PATCH v3 0/5] MR4551: Server-side thread priorities implementation (Part 1)
by Marc-Aurel Zent (＠mzent) 01 Dec '23

01 Dec '23

This is the current proton thread priority implementation by @rbernon rebased for upstream with a few `#ifdef`s added since AFAIK Linux is the only operating system where threads have a unique PID which can be used to set niceness on. I also ran `./tools/make_requests` on https://gitlab.winehq.org/mzent/wine/-/commit/6705d3481be0409f7e971c1d2c7a3… as well and `autoconf` on https://gitlab.winehq.org/mzent/wine/-/commit/d7bafe40c411753662b2ad97148a6… (which does blow up the line count a bit). A few tiny changes (with the ready variable for example) are in anticipation for Part 2, which also adds Mach thread priorities and recalculates thread priorities on process priority change. Since this is a rather large MR, I hope the split here is appropriate (with the second part being slightly smaller), but I think logically it makes the most sense here. -- v3: server: Check wineserver privileges on init with -20 server: Use setpriority to update thread niceness when safe. https://gitlab.winehq.org/wine/wine/-/merge_requests/4551

4 10

[PATCH 0/1] MR4539: d3dx9_36: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 01 Dec '23

01 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4539

3 16

Re: [PATCH v4 0/1] MR4458: user32: Add SetDisplayAutoRotationPreferences stub.
by Myah Caron (＠qsniyg) 01 Dec '23

01 Dec '23

On Fri Dec 1 11:34:59 2023 +0000, Vijay Kiran Kamuju wrote: > Please add the function signature to winuser.h Thanks, done. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4458#note_54552

1 0

[PATCH v4 0/5] MR4436: wined3d: Set d3d 1-9 textures in the state as SRVs.
by Zebediah Figura (＠zfigura) 01 Dec '23

01 Dec '23

-- v4: wined3d: Set d3d 1-9 textures in the state as SRVs. d3d9: Use wined3d_texture_acquire_identity_srv(). wined3d: Introduce an API for creating an identity SRV on a texture. https://gitlab.winehq.org/wine/wine/-/merge_requests/4436

4 9

[PATCH v2 0/1] MR4458: user32: Add SetDisplayAutoRotationPreferences stub.
by Myah Caron (＠qsniyg) 01 Dec '23

01 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55920 Signed-off-by: Myah Caron <qsniyg(a)protonmail.com> -- v2: user32: Add SetDisplayAutoRotationPreferences stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/4458

3 2

[PATCH v3 0/1] MR4458: user32: Add SetDisplayAutoRotationPreferences stub.
by Myah Caron (＠qsniyg) 01 Dec '23

01 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55920 Signed-off-by: Myah Caron <qsniyg(a)protonmail.com> -- v3: user32: Add SetDisplayAutoRotationPreferences stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/4458

2 1

[PATCH 0/1] MR4571: msxml3: Handle null prefix in get_item.
by Daniel Lehman (＠dlehman25) 01 Dec '23

01 Dec '23

this is the first of 5 merge requests that will remove all the todos i added the combined, end result is here: https://gitlab.winehq.org/dlehman25/wine/-/tree/msxml-nullpfx-combined -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4571

3 2

2025

2024

2023

2022

wine-gitlab December 2023