February 2023 - wine-gitlab

[PATCH 0/1] MR2268: oleaut32: Allocate a full pointer when unmarshalling byref arrays.
by Rémi Bernon (＠rbernon) 24 Feb '23

24 Feb '23

Instead of the 4 bytes array wire size returned by get_type_size, which will truncate the pointer on 64-bit. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54562 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2268

3 2

[PATCH 0/1] MR2253: gdi32/tests: add some last error checks
by Ivan Chikish (＠nekotekina) 24 Feb '23

24 Feb '23

Related bug report: #54405 The game engine (FVP) does compare GetGlyphOutlineA result with zero and checks GetLastError in that case. Maybe I'm missing something but I believe the last error shouldn't be set for "empty" characters. I don't know why it was omitted in tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2253

3 2

[PATCH 0/5] MR2038: server: Track cursor handle and window changes.
by Rémi Bernon (＠rbernon) 24 Feb '23

24 Feb '23

The idea here is to track the cursor changes on the server side, ultimately [1] using a private message to notify user drivers of changes to apply, instead of tracking the changes in user drivers with throttle mechanisms. This would greatly simplify winex11 mouse message handling as we would not need to try syncing the window cursor on every mouse move, and ultimately it would also make it possible to have a single thread listening to input in the background. Currently the input thread needs to own the windows that are under the cursor to be able to set it. Having a single input thread (per-process at least, but ideally and ultimately per-prefix), will solve several issues with input not being received when the foreground thread isn't actively checking their message, as well as issues with DInput incorrectly checking window messages when it should not. [1] See https://gitlab.winehq.org/rbernon/wine/-/merge_requests/8/commits -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2038

3 9

[PATCH 0/1] MR1240: gitlab: Run related tests on every commit.
by Rémi Bernon (＠rbernon) 24 Feb '23

24 Feb '23

This restores the feature we had with the testbot running related on intermediate commits, though it only does it on Linux and it would be nice to have it on Windows too. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1240

2 2

[PATCH 0/5] MR2062: winex11: Expose supported and configured keyboard layout in winecfg.
by Rémi Bernon (＠rbernon) 24 Feb '23

24 Feb '23

This adds a new Input tab to winecfg, moving the mouse grab settings there. Then this makes winex11 keyboard layout detection configurable as well, allowing the user to override the keyboard layout detection if for some reason it was incorrect. This isn't solving anything yet, but I then intend to make keyboard scancode detection configurable as well, and optional. As I described in https://www.winehq.org/pipermail/wine-devel/2020-October/175641.html, I believe that X11 keyboard keycode to scancode mapping is most of the time a fixed mapping, except in some rare cases. Trying to detect it from the keyboard layout will never work reliably, especially nowadays where keyboard layouts are completely made up from Linux IME (for instance a GNOME language settings with up to four keyboard layouts translates to a single Xkb mapping using groups for each layout). The X11 keycode are remapped only in some more rarely used implementations, such as XVNC and we should try to detect it only in such cases. Many Windows applications are depending on accurate scancodes, and making the mapping detection optional (and disabled by default) will solve all the issues we have in the most common case (https://bugs.winehq.org/show_bug.cgi?id=30984, https://bugs.winehq.org/show_bug.cgi?id=45605). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2062

2 7

[PATCH v4 0/4] MR2258: winegstreamer: Support WMV DMO decoder.
by Ziqing Hui (＠zhui) 24 Feb '23

24 Feb '23

-- v4: winegstreamer: Implement ProcessInput and ProcessOutput for WMV decoder DMO. winegstreamer: Create wg_transform for WMV decoder. https://gitlab.winehq.org/wine/wine/-/merge_requests/2258

3 5

[PATCH v6 0/1] MR2263: evr: Fix crash when clear input type for the mixer
by Tingzhong Luo (＠tzluo) 24 Feb '23

24 Feb '23

In the implementation of [`evr_disconnect()`](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/evr.c#L325-333), it will try to clear types of mixer by pass null to `IMFTransform_SetInputType()`: ```c static void evr_disconnect(struct strmbase_renderer *iface) { struct evr *filter = impl_from_strmbase_renderer(iface); if (filter->mixer) IMFTransform_SetInputType(filter->mixer, 0, NULL, 0); evr_set_input_type(filter, NULL); evr_release_services(filter); } ``` This null ptr (`media_type`) will be pass to [`video_mixer_collect_output_types()`](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/mixer.c#L869) and cause a [crash](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/mixer.c…: ```c static HRESULT WINAPI video_mixer_transform_SetInputType(IMFTransform *iface, DWORD id, IMFMediaType *media_type, DWORD flags) { ... if (!mixer->device_manager) hr = MF_E_NOT_INITIALIZED; else { if (SUCCEEDED(hr = video_mixer_get_processor_service(mixer, &service))) { if (SUCCEEDED(hr = video_mixer_init_dxva_videodesc(media_type, &video_desc))) ... ``` In this patch, `video_mixer_transform_SetInputType()` will only clear types when got a NULL `media_type` and return `S_OK`. -- v6: evr: Fix crash when clear input type for the mixer https://gitlab.winehq.org/wine/wine/-/merge_requests/2263

3 3

[PATCH 0/1] MR2272: winemac: Fix return type of ProcessEvents().
by Huw Davies (＠huw) 24 Feb '23

24 Feb '23

Introduced by commit a97fd9f29e7dbeee2dc06415a34a9f7669ea2e0d -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2272

2 1

[PATCH 0/1] MR2271: include: Add DBCOLUMNFLAGS_ enums values
by Alistair Leslie-Hughes (＠alesliehughes) 24 Feb '23

24 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2271

2 1

[PATCH v4 0/1] MR2262: winspool: Check dmSize in IsValidDevmodeW
by Tingzhong Luo (＠tzluo) 24 Feb '23

24 Feb '23

When dmSize is zero or greter than size of input buffer, `IsValidDevmodeW()` failed in Windows 10. But current implementation in wine, it will return `true` because there is no check to `dm.dmSize`. -- v4: winspool: Check dmSize in IsValidDevmodeW https://gitlab.winehq.org/wine/wine/-/merge_requests/2262

2 1

2025

2024

2023

2022

wine-gitlab February 2023