February 2023 - wine-gitlab

[PATCH v9 0/4] MR1088: ntdll: Avoid calling pthread_exit on thread exit.
by Rémi Bernon (＠rbernon) 21 Feb '23

21 Feb '23

Using a dedicated exit jmpbuf and removing the need for assembly routines. When Wine handles an exception in unix code, we return to user mode by jumping to the last syscall frame. This can leave some pthread cancel cleanups registered, in the pthread internal linked list, and at the same time later overwrite the stack frame they were registered for. In the same way, jumping to the exit frame on thread exit or abort, can also leave some cleanup handlers registered for invalid stack frames. Depending on the implementation, calling pthread_exit will cause all the registered pthread cleanup handlers to be called, possibly jumping back to now overwritten stack frames and causing segmentation faults. Exiting a pthread normally, by returning from its procedure, or calling exit(0) for the main thread doesn't run pthread_exit and doesn't call cleanup handlers, avoiding that situation. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52213 ### Additional note: For robustness, we should probably try to execute these cleanup handlers when unwinding the stack frames, as we would otherwise leave pthread objects in a potential problematic state (like a mutex locked, etc). It is however hard to do so when the handlers are registered from some C code: pthread C implementation is done by calling some internal pthread functions to register the handlers, and they aren't registered as standard unwind handlers. Only pthread_cancel and pthread_exit can unwind and call / unregister the C handlers, but interrupting that procedure, for instance calling setjmp / longjmp from withing our own handler isn't supported. From C++ code, pthread cleanup handlers are registered through C++ class constructors / destructors, and it would then be possible to partially unwind and call them at the same time. -- v9: ntdll: Remove now unnecessary arch-specific exit frame. ntdll: Avoid calling pthread_exit on thread exit. ntdll: Return entry and suspend from server_init_process_done. ntdll: Create a pthread for the main thread. https://gitlab.winehq.org/wine/wine/-/merge_requests/1088

4 10

[PATCH 0/3] MR2247: mf/tests: Test ProcessInput and ProcessOutput for WMV decoder DMO.
by Ziqing Hui (＠zhui) 21 Feb '23

21 Feb '23

SetInputType tests will randomly failed after PATCH 3 (It was OK in PATCH 2). I spend many time on figuring out why. And I found a weird thing: If I comment out the compare_nv12() in check_dmo_output_data_buffer_(), the test failures will be gone. I can't think out the reason. I don't understand why compare_nv12() in check_dmo_output_data_buffer_() affects SetInputType tests. And I don't want to waste too much time on the test stuff. Implementing the decoder is more important, so I marked the failed tests as flaky. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2247

4 9

[PATCH v2 0/4] MR101: vkd3d-shader/hlsl: Improvements to builtin typenames handling.
by Nikolay Sivov (＠nsivov) 21 Feb '23

21 Feb '23

-- v2: vkd3d-shader/hlsl: Allow case-insenstive names for shader objects types. vkd3d-shader/hlsl: Initial support for string constants. vkd3d-shader/hlsl: Use unsigned type for "dword" alias. vkd3d-shader/hlsl: Support case-insensitive lookup for selected builtin types. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/101

3 7

[PATCH v7 0/4] MR1889: bluetoothapis: Add BluetoothRegisterForAuthenticationEx stub.
by Mohamad Al-Jaf (＠maljaf) 21 Feb '23

21 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54112 -- v7: bluetoothapis: Add BluetoothUnregisterAuthentication stub. bluetoothapis: Add BluetoothRegisterForAuthenticationEx stub. include: Add BluetoothRegisterForAuthenticationEx prototype. bthprops.cpl: Move implementations to bluetoothapis and import them. https://gitlab.winehq.org/wine/wine/-/merge_requests/1889

4 8

[PATCH v3 0/2] MR2231: cfgmgr32: Implement CM_MapCrToWin32Err.
by Mohamad Al-Jaf (＠maljaf) 21 Feb '23

21 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53781 The Matrix Awakens MegaCity Unreal Engine 5.1 demo and Hogwarts Legacy call this. Duplicate Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54513 -- v3: cfgmgr32/tests: Add CM_MapCrToWin32Err tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/2231

3 8

[PATCH v2 0/1] MR2244: msado15: Support "Optimize" in Properties get_Item
by Alistair Leslie-Hughes (＠alesliehughes) 21 Feb '23

21 Feb '23

The Optimize property tells msado15 to create index maps for lookups in Recordset Find. Just store the value for now until Find is implemented. This property only appears on a Field when created from a real database connection. Just Appending of a Column doesn't give it this property. Currently this is the only Property that is set/query for that I found during testing. -- v2: msado15: Support "Optimize" in Properties get_Item https://gitlab.winehq.org/wine/wine/-/merge_requests/2244

2 1

[PATCH v2 0/2] MR2231: cfgmgr32: Implement CM_MapCrToWin32Err.
by Mohamad Al-Jaf (＠maljaf) 21 Feb '23

21 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53781 The Matrix Awakens MegaCity Unreal Engine 5.1 demo and Hogwarts Legacy call this. Duplicate Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54513 -- v2: cfgmgr32/tests: Add CM_MapCrToWin32Err tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/2231

3 5

[PATCH 0/5] MR2243: dcomp: Add IDCompositionDevice2 stub.
by Zhiyi Zhang (＠zhiyi) 21 Feb '23

21 Feb '23

Note that IDCompositionDevice2 is not inherited from IDCompositionDevice. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2243

3 7

[PATCH v6 0/2] MR2183: winecfg: Add an option to enable WinRT app dark theme.
by Mohamad Al-Jaf (＠maljaf) 21 Feb '23

21 Feb '23

This is what it looks like: **v1** ![Screenshot_20230213_212244](/uploads/14156031c91d4da29fc49ed9831b599a/Screenshot_20230213_212244.png) **v2** ![winecfg](/uploads/f610908b8ed2fbece6ef09ee5bd4d13e/winecfg.png) -- v6: winecfg: Add an option to enable WinRT app dark theme. https://gitlab.winehq.org/wine/wine/-/merge_requests/2183

4 6

[PATCH 0/1] MR2244: msado15: Support "Optimize" in Properties get_Item
by Alistair Leslie-Hughes (＠alesliehughes) 21 Feb '23

21 Feb '23

The Optimize property tells msado15 to create index maps for lookups in Recordset Find. Just store the value for now until Find is implemented. This property only appears on a Field when created from a real database connection. Just Appending of a Column doesn't give it this property. Currently this is the only Property that is set/query for that I found during testing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2244

3 2

2025

2024

2023

2022

wine-gitlab February 2023