February 2023 - wine-gitlab

[PATCH 0/4] MR2002: Draft: RFC: Extend winetest with multi-arch capabilities.
by eric pouech (＠epo) 12 May '23

12 May '23

Rationale: - currently, winetest is built either as a 32bit exec or a 64bit exec, containaing a bunch of tests of same bitness. - there's no simple support for having parent process in one bitness, and child process in a different bitness. - lots of cases are not covered in ntdll, kernel32 and kernelbase tests. - there are here and there a couple of tweaks to workaround this, but nothing a bit solid. Attached is a proposal to extend winetest to support better these use cases: - the idea is to add an extra-option to winetest.exe (64bit) passing the path to the corresponding winetest.exe (32bit). - when running test X (64bit), the path to corresponding test X (32bit) will be passed to test X (64 bit), allowing it to trigger test with test X (32bit). - nothing more is provided: it's up to the test designer to decide whether to use the 32bit child (and to adapt potentially the test) to cope with the difference in bitness between parent and child. - this can be used either in current wow64 setup, and also in multi-arch wow64 setup (just need to change the patch to 32bit winetest.exe) There's an example of such test at the end of the serie. Comments, ideas welcomed. And especially if it's something worth continuing. Note: - this is first shot at it, it should be improved (especially in ensuring that the 32bit/64bit pair is correct). A+ -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2002

2 5

[PATCH 0/1] MR2230: webservices: Avoid uninitialized variable warning in format_double
by Gerald Pfeifer (＠gerald) 09 May '23

09 May '23

GCC 13 was going to diagnose dlls/webservices/writer.c:960:18: warning: 'mag2' may be used uninitialized -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2230

3 6

[PATCH 0/1] MR2241: makedep: Better differentiate between compiling and linking commands.
by Bernhard Kölbl (＠besentv) 06 May '23

06 May '23

This makes one able to see what is being built as PE and UNIX code and shows 'LINK' for linking in silent configuration `--enable-silent-rules`. For example: ``` make: Entering directory '/home/bernhard/Documents/programming/builds/wine/x64' UNIX dlls/windows.media.speech/unixlib.o PE dlls/windows.media.speech/x86_64-windows/async.o PE dlls/windows.media.speech/x86_64-windows/main.o PE dlls/windows.media.speech/x86_64-windows/recognizer.o PE dlls/windows.media.speech/x86_64-windows/event_handlers.o PE dlls/windows.media.speech/x86_64-windows/listconstraint.o PE dlls/windows.media.speech/x86_64-windows/synthesizer.o PE dlls/windows.media.speech/x86_64-windows/vector.o WIDL dlls/windows.media.speech/x86_64-windows/classes_r.res LINK dlls/windows.media.speech/x86_64-windows/windows.media.speech.dll LINK dlls/windows.media.speech/windows.media.speech.so Wine build complete. ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2241

3 3

[PATCH 0/1] MR2205: winspool: Fix crash when dmSize is 0
by Tingzhong Luo (＠tzluo) 26 Apr '23

26 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2205

4 5

[PATCH 0/1] MR71: Draft: vkd3d: Update Vulkan descriptors only when submitted to a command queue.
by Conor McCarthy (＠cmccarthy) 26 Apr '23

26 Apr '23

Unpolished. Raises framerate by around 15% in SotTR because vk_sets_mutex is locked only once for each descriptor heap. It's possible to collate multiple writes for a single vkUpdateDescriptorSets() call as was done in the optimised copying path, but it may not be worth it. A possible complication with this: if it becomes possible to remove the descriptor mutexes after the remaining problems with queue sequencing are fixed, we theoretically may still need them for this. Descriptors should not be updated while binding, but there's no reason more can't be written in another thread while a command list is submitted to a queue. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/71

2 2

[PATCH v3 0/1] MR1853: mf: Request more samples for MFT when needed.
by Shaun Ren (＠shaunren) 20 Apr '23

20 Apr '23

When an upstream node has not given enough samples to the transform, we need to request more samples from it to avoid stalling the pipeline. This fixes an issue where the intro audio of the game Airborne Kingdom stops playing after a few seconds. -- v3: mf: Request more samples for transforms when needed. https://gitlab.winehq.org/wine/wine/-/merge_requests/1853

2 3

[PATCH v3 0/3] MR2173: user32/tests: Fix WM_CHAR tests to use the input codepage.
by Akihiro Sagawa (＠sgwaki) 17 Apr '23

17 Apr '23

User32 uses the input codepage in Unicode edit control. However, it uses ANSI codepage, i.e. CP_ACP, in ANSI version control. Comctl32 is different from user32. It doesn't have A-W duality and uses the input codepage in it. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54424 -- v3: comctl32/tests: Add WM_CHAR tests for edit control. user32/edit: Use CP_ACP for WM_CHAR convresion in ANSI version control. user32/tests: Fix WM_CHAR tests to use the input codepage. https://gitlab.winehq.org/wine/wine/-/merge_requests/2173

2 5

[PATCH v3 0/5] MR2159: winegstreamer: Stride and RGB formats, part 2/2.
by Zebediah Figura (＠zfigura) 06 Apr '23

06 Apr '23

-- v3: winegstreamer: Output BGRx video from the media source. winegstreamer: Move flipping based on RGB to the frontends. winegstreamer: Translate the MF_MT_DEFAULT_STRIDE attribute to flipped video in mf_media_type_to_wg_format(). winegstreamer: Set the MF_MT_DEFAULT_STRIDE attribute in mf_media_type_from_wg_format(). winegstreamer: Initialize media source video types from a wg_video_format array. https://gitlab.winehq.org/wine/wine/-/merge_requests/2159

5 21

[PATCH v3 0/2] MR2068: Draft: comdlg32: Enable visual styles when showing IFileDialog.
by Vladislav Timonin (＠vt) 31 Mar '23

31 Mar '23

Required for !1857 to not break when comctl32 version 6 isn't requested by application (in particular, found this in [qapitrace](https://github.com/apitrace/apitrace)). Manifest resource id and assembly identity name match with Windows. For isolation purposes, activation context is disabled while emitting events. -- v3: comdlg32: Enable visual styles when showing IFileDialog. comdlg32: Return E_UNEXPECTED if IFileDialog is already shown https://gitlab.winehq.org/wine/wine/-/merge_requests/2068

4 8

[PATCH 0/1] MR989: d3d10core/tests: Mark tests failing randomly on Windows as flaky.
by Francois Gouget (＠fgouget) 29 Mar '23

29 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/989

6 6

2025

2024

2023

2022

wine-gitlab February 2023