February 2023 - wine-gitlab

Re: [PATCH v2 0/8] MR2179: Fix an assortment of comment and message typos - approved
by Alexandre Julliard (＠julliard) 14 Feb '23

14 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2179

1 0

Re: [PATCH v3 0/1] MR1963: d3dcompiler_43/tests: Allow more imprecision in test_trig() for NVIDIA. - approved
by Alexandre Julliard (＠julliard) 14 Feb '23

14 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1963

1 0

Re: [PATCH v2 0/2] MR2180: winetest: Avoid an infinite loop in vstrfmtmake() when the format is NULL. - approved
by Alexandre Julliard (＠julliard) 14 Feb '23

14 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2180

1 0

Re: [PATCH v2 0/1] MR2174: po: Update Lithuanian translation. - approved
by Alexandre Julliard (＠julliard) 14 Feb '23

14 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2174

1 0

Re: [PATCH v2 0/2] MR91: Two more fixes for functions. - approved
by Alexandre Julliard (＠julliard) 14 Feb '23

14 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/91

1 0

[PATCH v22 0/2] MR2100: ntdll: Do not send data to port 0.
by Jason Beetham (＠beef331) 14 Feb '23

14 Feb '23

On Windows it seems sending to port 0 does nothing and does not error. Presently sendmsg errors with EINVAL. This works around it, by checking if it's port 0 then skipping the data. -- v22: ntdll: Do not send data to port 0. https://gitlab.winehq.org/wine/wine/-/merge_requests/2100

2 2

[PATCH v9 0/2] MR2175: oleaut32: fix VarAbs function for BSTR with positive values
by Jason Millard (＠jsm174) 14 Feb '23

14 Feb '23

While working in vbscript, I noticed abs on a `BSTR` value with a positive number would come back with an invalid value. Given the following script: ``` Dim x x = "30000" Debug.Print "x" & "=" & abs(x) ``` Outputs: ``` Script.Print 'x=3.08221696253945E-314' ``` After debugging, `pVarIn` gets the R8 value but is never shallow copied into `pVarOut`. In addition to a test case in `oleaut32`, I've included a test case in `vbscript`. This fixes bug: https://bugs.winehq.org/show_bug.cgi?id=54489 -- v9: oleaut32: fix VarAbs function for BSTR with positive values https://gitlab.winehq.org/wine/wine/-/merge_requests/2175

4 3

Re: [PATCH v21 0/2] MR2100: ntdll: Do not send data to port 0.
by Zebediah Figura (＠zfigura) 14 Feb '23

14 Feb '23

Thanks, looks good now, I just have a couple more tweaks to keep the style consistent. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2100#note_24098

1 0

Re: [PATCH v21 0/2] MR2100: ntdll: Do not send data to port 0.
by Zebediah Figura (＠zfigura) 14 Feb '23

14 Feb '23

Zebediah Figura (@zfigura) commented about dlls/ntdll/unix/socket.c: > + * This causes 'sendmsg' to throw a EINVAL error, on Windows this does nothing but consume the data. > + */ > + ssize_t i; > + for(i = async->iov_cursor; i < async->count; i++) > + { > + async->sent_len += async->iov[i].iov_len; > + } > + > + WARN("Attempting to send to port 0, skipping over data.\n"); > + > + status = STATUS_SUCCESS; > + } > + else > + { > + status = try_send( fd, async ); > + } ```suggestion:-2+0 { status = try_send( fd, async ); } ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2100#note_24097

1 0

Re: [PATCH v21 0/2] MR2100: ntdll: Do not send data to port 0.
by Zebediah Figura (＠zfigura) 14 Feb '23

14 Feb '23

Zebediah Figura (@zfigura) commented about dlls/ntdll/unix/socket.c: > { > ULONG_PTR information; > > - status = try_send( fd, async ); > + if (protocol == WS_IPPROTO_UDP && async->addr && sockaddr_is_port0(async->addr, async->addr_len)) > + { > + /* Spellforce 3 is known to send to port 0. > + * This causes 'sendmsg' to throw a EINVAL error, on Windows this does nothing but consume the data. > + */ > + ssize_t i; > + for(i = async->iov_cursor; i < async->count; i++) > + { > + async->sent_len += async->iov[i].iov_len; > + } ```suggestion:-3+0 for (i = async->iov_cursor; i < async->count; i++) async->sent_len += async->iov[i].iov_len; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2100#note_24096

1 0

2025

2024

2023

2022

wine-gitlab February 2023