February 2023 - wine-gitlab

Re: [PATCH v2 0/1] MR2147: ws2_32: Forbid passing zero buffers to WSARecv(). - approved
by Alexandre Julliard (＠julliard) 09 Feb '23

09 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2147

1 0

Re: [PATCH v2 0/1] MR86: vkd3d-shader/hlsl: Support abs() for SM1. - approved
by Alexandre Julliard (＠julliard) 09 Feb '23

09 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/86

1 0

[PATCH 0/6] MR85: hlsl: Function inlining.
by Zebediah Figura (＠zfigura) 09 Feb '23

09 Feb '23

This is the last piece that's needed for function calls to basically work. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/85

4 23

[PATCH v16 0/2] MR2100: ntdll: Do not send data to port 0.
by Jason Beetham (＠beef331) 09 Feb '23

09 Feb '23

On Windows it seems sending to port 0 does nothing and does not error. Presently sendmsg errors with EINVAL. This works around it, by checking if it's port 0 then skipping the data. -- v16: ntdll: Do not send data to port 0. https://gitlab.winehq.org/wine/wine/-/merge_requests/2100

3 3

[PATCH v2 0/2] MR269: ntdll: Respect zero_bits when mapping a builtin or native PE file.
by Brendan Shanks (＠bshanks) 09 Feb '23

09 Feb '23

Without the changes, the test passes or fails based on the binutils version being used. v2.35 (used on the Debian 11 testbot) gives 64-bit DLLs an image base under 4GB, and the test always passes. On a system with binutils 2.37 or later, 64-bit DLLs are based above 4GBs, and the test will fail. The map_view() change fixes native DLLs, and virtual_map_section() for builtin DLLs. I wasn't sure how to test a native DLL. This showed up under Wow64 when running the 64-bit Notepad++ installer (a 32-bit EXE), which runs 32-bit regsvr32 to register a 64-bit DLL. regsvr32 calls LoadLibraryExW() with LOAD_LIBRARY_AS_IMAGE_RESOURCE, which was returning a truncated pointer to the DLLs base address. Accessing this then crashed. -- v2: ntdll: Respect zero_bits/limit when mapping a PE file. ntdll/tests: Test NtMapViewOfSection with a 64-bit DLL and zero_bits > 31. https://gitlab.winehq.org/wine/wine/-/merge_requests/269

2 3

[PATCH v17 0/2] MR2100: ntdll: Do not send data to port 0.
by Jason Beetham (＠beef331) 09 Feb '23

09 Feb '23

On Windows it seems sending to port 0 does nothing and does not error. Presently sendmsg errors with EINVAL. This works around it, by checking if it's port 0 then skipping the data. -- v17: ntdll: Do not send data to port 0. https://gitlab.winehq.org/wine/wine/-/merge_requests/2100

2 2

[PATCH v3 0/3] MR84: vkd3d-shader/spirv: Normalise inputs and outputs to the Shader Model 6 pattern.
by Conor McCarthy (＠cmccarthy) 09 Feb '23

09 Feb '23

Multiple fork and join phases are eliminated. Signature elements are merged where required, and all input/output parameters are rewritten. -- v3: vkd3d-shader/spirv: Move the function declaration from spirv_compiler_begin_shader_phase() to spirv_compiler_enter_shader_phase(). vkd3d-shader/spirv: Remove the hull shader phase array. vkd3d-shader/spirv: Merge all shader IR fork and join phases into a single phase. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/84

4 5

[PATCH 0/1] MR2153: win32u: invalidate all cached keys after input
by Henry Goffin (＠AMZN-hgoffin) 09 Feb '23

09 Feb '23

This patch addresses an issue in Second Life and potentially other multi-threaded applications which process WM_KEYDOWN in one thread and then verify that the key is "still down" with GetAsyncKeyState from another thread. Wine uses a per-thread key cache, resulting in inconsistent views of key status. Caches are now invalidated when an input event is injected by the driver or via SendInput. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2153

2 2

[PATCH v3 0/1] MR2141: vbscript: Fix memory leak in owned safearray iterator
by Jason Millard (＠jsm174) 09 Feb '23

09 Feb '23

While running in XCode's profiler, I noticed memory leaks when safearrays were used in `For Each` statements. The following code would leak a safearray allocation: ``` For Each obj In vpDict.Keys : Debug.Print "Key" : Next ``` This following code does not leak: ``` Dim x x = vpDict.Keys For Each obj In x : Debug.Print "Key" : Next ``` Fixes: https://bugs.winehq.org/show_bug.cgi?id=54456 -- v3: vbscript: Fix memory leak in owned safearray iterator https://gitlab.winehq.org/wine/wine/-/merge_requests/2141

3 3

[PATCH v2 0/1] MR2142: vbscript: fix compile when colon follows Else on new line
by Jason Millard (＠jsm174) 09 Feb '23

09 Feb '23

I ran into a script where someone placed a `:` on a new line after an `Else` but before another statement: ``` Else : VelCoef = LinearEnvelope(BallPos, VelocityIn, VelocityOut) if Enabled then aBall.Velx = aBall.Velx*VelCoef if Enabled then aBall.Vely = aBall.Vely*VelCoef end if ``` I confirmed that this is allowed and works. I've updated the grammar, and replaced `NL` with `StSep_opt` as it seems to cover all the bases. Fixes: https://bugs.winehq.org/show_bug.cgi?id=54234 -- v2: vbscript: fix compile when colon follows Else on new line https://gitlab.winehq.org/wine/wine/-/merge_requests/2142

3 2

2025

2024

2023

2022

wine-gitlab February 2023