February 2023 - wine-gitlab

Re: [PATCH v3 0/2] MR2059: combase: Generate apartment OXID in rpcss
by Huw Davies (＠huw) 01 Feb '23

01 Feb '23

Huw Davies (@huw) commented about programs/rpcss/rpcss_main.c: > } > > +/* Generates a new OXID suitable for use by an apartment. > + * Each call to this function returns a distinct OXID. > + * This function should not be invoked directly - use rpcss_get_new_apartment_oxid > + * instead. */ > +HRESULT __cdecl irpcss_get_new_apartment_oxid(handle_t h, OXID *oxid) > +{ > + HRESULT status; > + ULONG oxid_upper_bits; > + > + static LONG oxid_lower_bits; > + > + status = I_RpcBindingInqLocalClientPID(h, &oxid_upper_bits); > + ERR("Got client PID: %ld", oxid_upper_bits); > + if (status != S_OK) { Please put the opening brace on a new line. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2059#note_22594

1 0

Re: [PATCH v3 0/2] MR2059: combase: Generate apartment OXID in rpcss
by Huw Davies (＠huw) 01 Feb '23

01 Feb '23

Huw Davies (@huw) commented about programs/rpcss/rpcss_main.c: > return S_OK; > } > > +/* Generates a new OXID suitable for use by an apartment. > + * Each call to this function returns a distinct OXID. > + * This function should not be invoked directly - use rpcss_get_new_apartment_oxid > + * instead. */ > +HRESULT __cdecl irpcss_get_new_apartment_oxid(handle_t h, OXID *oxid) > +{ > + HRESULT status; > + ULONG oxid_upper_bits; > + > + static LONG oxid_lower_bits; > + > + status = I_RpcBindingInqLocalClientPID(h, &oxid_upper_bits); > + ERR("Got client PID: %ld", oxid_upper_bits); This looks like it's left-over from debugging. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2059#note_22593

1 0

Re: [PATCH v3 0/2] MR2059: combase: Generate apartment OXID in rpcss
by Huw Davies (＠huw) 01 Feb '23

01 Feb '23

Huw Davies (@huw) commented about programs/rpcss/rpcss_main.c: > return S_OK; > } > > +/* Generates a new OXID suitable for use by an apartment. > + * Each call to this function returns a distinct OXID. > + * This function should not be invoked directly - use rpcss_get_new_apartment_oxid > + * instead. */ > +HRESULT __cdecl irpcss_get_new_apartment_oxid(handle_t h, OXID *oxid) > +{ > + HRESULT status; > + ULONG oxid_upper_bits; > + I think we can get rid of this blank line. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2059#note_22592

1 0

Re: [PATCH v3 0/2] MR2059: combase: Generate apartment OXID in rpcss
by Huw Davies (＠huw) 01 Feb '23

01 Feb '23

Huw Davies (@huw) commented about dlls/combase/apartment.c: > > - if (apt->multi_threaded) > - { > - /* FIXME: should be randomly generated by in an RPC call to rpcss */ > - apt->oxid = ((OXID)GetCurrentProcessId() << 32) | 0xcafe; > - } > - else > - { > - /* FIXME: should be randomly generated by in an RPC call to rpcss */ > - apt->oxid = ((OXID)GetCurrentProcessId() << 32) | GetCurrentThreadId(); > - } > + /* Get a new OXID to use for this apartment. Note that re-creating > + * an apartment (by calling CoUninitialize and then CoInitializeEx) > + * will result in a new OXID. This ensures that we don't re-use a > + * proxy_manager` that refers to a dead apartment. */ > + rpcss_get_new_apartment_oxid(&apt->oxid); We would want to test for this failing (and probably clean up and return NULL). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2059#note_22591

1 0

Re: [PATCH v3 0/2] MR2059: combase: Generate apartment OXID in rpcss
by Huw Davies (＠huw) 01 Feb '23

01 Feb '23

Since the first commit just adds tests, could you change the commit msg prefix to `ole32/tests:` ? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2059#note_22590

1 0

[PATCH 0/1] MR2084: msi/tests: Avoid test failures when running with insufficient rights.
by Hans Leidekker (＠hans) 01 Feb '23

01 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51040 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2084

2 1

[PATCH v3 0/3] MR2077: Default to Windows 10.
by Hans Leidekker (＠hans) 01 Feb '23

01 Feb '23

-- v3: winecfg: Fix CurrentVersion registry string for Windows 10 and up. ntdll: Default to Windows 10. ntdll: Add Windows 11 version. https://gitlab.winehq.org/wine/wine/-/merge_requests/2077

2 4

[PATCH 0/7] MR2078: Fixes for debugging in new wow64 setup.
by eric pouech (＠epo) 01 Feb '23

01 Feb '23

This series brings some improvements for debugging support in the new wow64 environment: - detects and adapt to the new environement - fixes a couple of bugs appearing now - adds a couple of tests - extends winedbg to hide or display the modules when multiple machines are used in the same process -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2078

4 13

[PATCH 0/1] MR2082: opengl32/tests: Skip the wglCopyContext test on Nvidia on Windows.
by Alex Henrie (＠alexhenrie) 01 Feb '23

01 Feb '23

Fixes a testbot crash. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2082

3 3

Re: [PATCH v2 0/1] MR74: vkd3d-shader/hlsl: Support dot() for SM1.
by Nikolay Sivov (＠nsivov) 01 Feb '23

01 Feb '23

Please take a look, I added both mul+add and dp2add paths. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/74#note_22571

1 0

2025

2024

2023

2022

wine-gitlab February 2023