March 2023 - wine-gitlab

[PATCH v6 0/4] MR1895: Fixes for NtOpenFile of read-only files with FILE_WRITE_ATTRIBUTES
by Joel Holdsworth (＠jhol) 28 Mar '23

28 Mar '23

Previously, the Wine implementation of `NtOpenFile` would fail to open read-only files for `FILE_WRITE_ATTRIBUTES` access in wine-server, because it would attempt to open the file with `O_RDWR` or `O_WRONLY` access. This patch-set adds test cases to highlight the issue, and solves it by only opening the file with write access where necessary. * Wine Bug: [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771) * Related Wine-Staging Patches: * [0002-server-Allow-to-open-files-without-any-permission-bi.patch](https://gi… * [0006-ntdll-tests-Added-tests-for-open-behaviour-on-readon.patch](https://gi… * [0007-server-FILE_WRITE_ATTRIBUTES-should-succeed-for-read.patch](https://gi… -- v6: server: Allow to open read-only files with FILE_WRITE_ATTRIBUTES server: Open files for writing with O_WRONLY not O_RDWR if FILE_READ_ATTRIBUTES is also requested https://gitlab.winehq.org/wine/wine/-/merge_requests/1895

4 9

[PATCH v10 0/3] MR741: ntdll: Implement NtFlushProcessWriteBuffers.
by Torge Matthies (＠tmatthies) 28 Mar '23

28 Mar '23

Based on [a patch](https://www.winehq.org/mailman3/hyperkitty/list/wine-devel@winehq.or… by Jinoh Kang (@iamahuman) from February 2022. I removed the need for the event object and implemented fast paths for Linux. On macOS 10.14+ `thread_get_register_pointer_values` is called on every thread of the process. On Linux 4.14+ `membarrier(MEMBARRIER_CMD_GLOBAL_EXPEDITED, ...)` is used. On x86 Linux <= 4.13 and on other platforms `madvise(..., MADV_DONTNEED)` is used, which sends IPIs to all cores causing them to do a memory barrier. -- v10: ntdll: Add thread_get_register_pointer_values-based implementation of NtFlushProcessWriteBuffers. ntdll: Add sys_membarrier-based implementation of NtFlushProcessWriteBuffers. ntdll: Add MADV_DONTNEED-based implementation of NtFlushProcessWriteBuffers. https://gitlab.winehq.org/wine/wine/-/merge_requests/741

2 3

[PATCH 0/1] MR2418: ucrtbase: adding CxxFrameHandler4 to spec
by James McDonnell (＠ElementalWarrior) 28 Mar '23

28 Mar '23

Add missing function to spec for affinity photo -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2418

3 4

[PATCH 0/1] MR2519: wldap32: Stub out setting LDAP_OPT_REFERRAL_HOP_LIMIT.
by Alex Henrie (＠alexhenrie) 28 Mar '23

28 Mar '23

https://bugs.winehq.org/show_bug.cgi?id=54727 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2519

3 2

[PATCH 0/1] MR2521: msado15: Handle DBTYPE_STR type when loading recordset data
by Alistair Leslie-Hughes (＠alesliehughes) 28 Mar '23

28 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2521

3 2

[PATCH v2 0/7] MR2476: winewayland.drv: part 2: Display configuration enhancements
by Alexandros Frantzis (＠afrantzis) 28 Mar '23

28 Mar '23

This second MR in the Wayland series adds display configuration related enhancements, including providing more display information (like a proper/consistent name and position) to Wine and implementing GetCurrentDisplaySettings. To get additional information from the Wayland compositor we need to use a protocol from the wayland-protocols collection, so we introduce support in the build system for protocol .xml files. These changes are introduced on their own in the first commit in the series, but we can squash it with the next commit, where the functionality is first used, if preferred. To be able to provide a consistent view of the display settings across all processes, this MR adds a shared memory region containing an authoritative version of the Wayland output information (see the "winewayland.drv: Implement GetCurrentDisplaySettings." commit for more details). Thanks! -- v2: winewayland.drv: Update desktop window size on display changes. winewayland.drv: Update registry settings after monitor changes. winewayland.drv: Infer and report Windows monitor positions. winewayland.drv: Handle wl_output objects only in the desktop process. winewayland.drv: Implement GetCurrentDisplaySettings. winewayland.drv: Use the output name reported by the compositor. tools: Support building Wayland protocol source files. https://gitlab.winehq.org/wine/wine/-/merge_requests/2476

5 20

[PATCH v2 0/1] MR2521: msado15: Handle DBTYPE_STR type when loading recordset data
by Alistair Leslie-Hughes (＠alesliehughes) 28 Mar '23

28 Mar '23

-- v2: msado15: Handle DBTYPE_STR type when loading recordset data https://gitlab.winehq.org/wine/wine/-/merge_requests/2521

2 1

[PATCH v11 0/1] MR2183: winecfg: Add an option to set WinRT app dark theme.
by Mohamad Al-Jaf (＠maljaf) 28 Mar '23

28 Mar '23

This is what it looks like: ![Screenshot_20230310_015941](/uploads/99b3d279bcddbd40212808a045444a7b/Screenshot_20230310_015941.png) -- v11: winecfg: Add an option to set WinRT app dark theme. https://gitlab.winehq.org/wine/wine/-/merge_requests/2183

2 2

[PATCH v4 0/4] MR2387: winegstreamer: Use codec format in stream_props_GetMediaType.
by Ziqing Hui (＠zhui) 28 Mar '23

28 Mar '23

According to the tests in 23b72ad, when we are reading a compressed stream, the type returned by `stream_props_GetMediaType()` should reflect compressed format even if we finnally output uncomressed data. For example, if we use wmvcore reader to read a WMV3 stream and output RGB24, the format information returned by `stream_props_GetMediaType()` should be WMV3, not RGB24. This patch set is marked as draft now, because PATCH 2 and PATCH 3 is affected by 3e8936a2 in MR !2258. So I'll submit a newer version of this after !2258 get merged. -- v4: winegstreamer: Use codec format in stream_props_GetMediaType. winegstreamer: Implement amt_from_wg_format_video_wmv. winegstreamer: Implement wg_format_from_caps_video_wmv. winegstreamer: Implement wg_parser_stream_get_codec_format. https://gitlab.winehq.org/wine/wine/-/merge_requests/2387

3 5

[PATCH 0/6] MR2518: Fixes and improvements for taskschd:scheduler
by Francois Gouget (＠fgouget) 28 Mar '23

28 Mar '23

* Deleting tasks & folders requires elevated privileges on Windows 7. * Elevated privileges are needed to connect using a hostname. * Use a winetest context in the scheduler loops. * Use wide character string literals in scheduler.c. * Store the xml definitions as wide string literals in scheduler.c. * Use __HRESULT_FROM_WIN32() to initialize constants. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2518

2 6

2025

2024

2023

2022

wine-gitlab March 2023