March 2023 - wine-gitlab

[PATCH v3 0/108] MR2402: Release 7.0.2
by Michael Stefaniuc (＠mstefani) 27 Mar '23

27 Mar '23

-- v3: Release 7.0.2. gitlab: Add workaround for more strict git ownership check. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/2402

1 1

[PATCH v5 0/10] MR124: vkd3d-shader/hlsl: Introduce hlsl_ir_index, part 1/2.
by Francisco Casas (＠fcasas) 27 Mar '23

27 Mar '23

This node type is intended for use during parse-time. While we parse an indexing expression such as `a[3]`, we don't know if it will end up as part of an expression (in which case it must be folded into a load) or it is for the lhs of a store (in which case it must be folded into the store's deref). This node type is used to represent these accesses and no longer rely on building an `hlsl_ir_load` for each array index or struct record access. `hlsl_ir_index` chains are lowered into derefs when (and if) they are used to specify the lhs of an assignment. All `hlsl_ir_index`es are lowered into `hlsl_ir_load`s with a compilation pass. The changes introduced in these series allow to solve the problem with the return variable of function calls presented in !93, and to properly support assignment to matrix indexes, which is something we are not doing correctly. Further patches (in my [index node](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/index_node) branch) add support for indexing non-load expressions, such as `(a + b)[1]` and allowing to represent resource loads through `hlsl_ir_index`, so that `hlsl_ir_resource_store`s don't have to rely on `hlsl_ir_resource_load`s. -- v5: vkd3d-shader/hlsl: Evaluate index before array. vkd3d-shader/hlsl: Support column-major matrix indexing in the lhs. vkd3d-shader/hlsl: Always load from a synthetic copy in add_load_component(). vkd3d-shader/hlsl: Remove add_load_index(). vkd3d-shader/hlsl: Use hlsl_ir_index for array and record access. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/124

4 13

Re: [PATCH v4 0/5] MR2483: kernelbase: Add full support for shared Software\Classes keys.
by Alexandre Julliard (＠julliard) 27 Mar '23

27 Mar '23

Alexandre Julliard (@julliard) commented about dlls/kernelbase/registry.c: > return (len >= 11 && !wcsnicmp( name->Buffer, L"Wow6432Node\\", min( len, 12 ) )); > } > > -/* open the Wow6432Node subkey of the specified key */ > +static BOOL is_classes_root( const UNICODE_STRING *name ) > +{ > + return (name->Length >= wcslen(root_key_names[0]) * sizeof(WCHAR) && !wcsnicmp( name->Buffer, root_key_names[0], wcslen(root_key_names[0]) )); You again have to check the string terminator, matching a substring is not sufficient. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2483#note_27986

1 0

[PATCH v2 0/4] MR2470: uiautomationcore: Fix/extend some tests, implement UIA_ProviderDescriptionPropertyId.
by Connor McAdams (＠cmcadams) 27 Mar '23

27 Mar '23

This should lower the test todo count substantially. -- v2: uiautomationcore: Add support for UIA_ProviderDescriptionPropertyId. https://gitlab.winehq.org/wine/wine/-/merge_requests/2470

3 6

[PATCH v2 0/1] MR2508: wldap32: Implement setting LDAP_OPT_SSL and add tests.
by Alex Henrie (＠alexhenrie) 27 Mar '23

27 Mar '23

Windows has the LDAP_OPT_SSL option to turn SSL on or off after calling ldap_init but before connecting to the server. OpenLDAP doesn't have that option and instead expects a fully SSL connection to be requested by passing one or more "ldaps://" URIs to ldap_init. However, OpenLDAP also has an LDAP_OPT_URI option, which Windows does not have, that can be used to change the URIs before connecting. And OpenLDAP already takes care of converting "ldap://" or "ldaps://" to lowercase, so all we have to do is find and replace that exact string in each URI in the list. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54727 -- v2: wldap32: Implement setting LDAP_OPT_SSL and add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/2508

4 3

[PATCH 0/1] MR2513: win32u: Fix printf format warnings.
by Huw Davies (＠huw) 27 Mar '23

27 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2513

3 2

[PATCH 0/1] MR2514: widl: error_loc() messages must have a trailing linefeed.
by Francois Gouget (＠fgouget) 27 Mar '23

27 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2514

3 2

[PATCH 0/1] MR2515: imm32/tests: Document the WINE_LANGID value.
by Francois Gouget (＠fgouget) 27 Mar '23

27 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2515

3 2

[PATCH 0/2] MR2517: schtasks/tests: Deleting folders requires elevated privileges on Windows 7 & 8.
by Francois Gouget (＠fgouget) 27 Mar '23

27 Mar '23

This means skipping any test that requires creating a task as the test would be unable to clean up after itself. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=52193 Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54634 ---- taskschd:scheduler is able to delete folders without elevated privileges on Windows 8 but apparently not schtasks.exe:schtasks. There must be something different but I don't know what :-( I guess we don't care much about this special case so this patch just skips bluntly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2517

2 2

[PATCH 0/5] MR2516: Fixes and improvements for schedsvc:rpcapi
by Francois Gouget (＠fgouget) 27 Mar '23

27 Mar '23

* Deleting tasks & folders requires elevated privileges on Windows 7. * Document SchRpcGetTaskInfo() calls that crash on Windows. * Use a winetest context in the rpcapi loops. * Use wide character string literals in rpcapi.c. * Use __HRESULT_FROM_WIN32() to initialize constants. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2516

2 5

2025

2024

2023

2022

wine-gitlab March 2023