March 2023 - wine-gitlab

[PATCH v4 0/4] MR2127: ntdll: Load known dlls from system directory
by Paul Gofman (＠gofman) 20 Mar '23

20 Mar '23

The practical issue I am trying to solve is the following scenario (encountered with a game using some Uplay plugin) which has regressed with apisets implementation in Wine. The game imports ucrtbase.dll. Then, a plugin calls GetModuleHandle("api-ms-win-crt-runtime-l1-1-0.dll") and expects GetProcAddress("\_crt_atexit") to succeed on the returned handle. The problem is that the game has ucrtbase.dll in its .exe directory. That one currently gets loaded. Then, find_dll_file() resolves api-ms-win-crt-runtime-l1-1-0.dll to the ucrtbase with a full path in system32 and tries to find that one (this part matches Windows behaviour as far as tests show). Since we have ucrtbase loaded with another path this results in NULL module handle. Windows maintains the list of "Known DLLs" (probably aimed for speeding up processes startup by using pre-mapped dll images for commonly used system dlls). On Windows, known dlls have specifics in load path resolution when dll name doesn't contain path (relative or full): - they are loaded from system directory even if there is another dll with the same name in priority search path; - they are found even if library search paths do not contain system directory; Those "Known DLLs" are basically listed in HKLM\\System\\CurrentControlSet\\Control\\Session Manager\KnownDLLs registry key. But the actual list of "known dlls" is bigger (probably includes all dependencies of those listed under registry key). The full actual list of "known dlls" is in '\\KnownDlls\' directory object which contains image sections under dll names. Most notably, ucrtbase.dll (which is of the concern in the regression) is not listed in registry but is present in \\KnownDlls. Technically nothing prevents us from implementing these mechanics and creating directory object with mapped load dlls, also resolving the explicitly listed dlls' dependencies. But it is not apparent to me if that is going to improve load times noticably in Wine, and also that is worth the inherent complications until anything actually depends on that \\KnownDlls sections. So instead of implementing all of that throughout the loader I added a few missing dlls to registry. The current list in this pat chset corresponds to the contents of \\KnownDlls directory on an up to date Windows 10. -- v4: ntdll: Load known dlls from system directory. loader/wine.inf: Add known dlls key. ntdll: Factor out prepend_system_dir() function. kernel32/tests: Add tests for known dlls load specifics. https://gitlab.winehq.org/wine/wine/-/merge_requests/2127

3 6

[PATCH 0/4] MR2427: uiautomationcore: IUIAutomationTreeWalker implementation.
by Connor McAdams (＠cmcadams) 20 Mar '23

20 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2427

4 7

[PATCH 0/1] MR671: include: Add dxcore.idl
by Biswapriyo Nath (＠Biswa96) 20 Mar '23

20 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/671

3 5

Re: [PATCH v4 0/1] MR2413: comctl32: Fix the problem that listview cannot display all files. - approved
by Zhiyi Zhang (＠zhiyi) 20 Mar '23

20 Mar '23

This merge request was approved by Zhiyi Zhang. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2413

1 0

[PATCH 0/1] MR771: include: Add D3D10CalcSubresource definition in d3d10.idl.
by Biswapriyo Nath (＠Biswa96) 20 Mar '23

20 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/771

3 4

[PATCH v2 0/1] MR2380: quartz: Set filter sync source in FilterGraph2_AddFilter.
by Shaun Ren (＠shaunren) 20 Mar '23

20 Mar '23

This fixes a bug in the game "Nioh: The Complete Edition", where the videos after the first video are played too quickly. -- v2: quartz: Set filter sync source in FilterGraph2_AddFilter. https://gitlab.winehq.org/wine/wine/-/merge_requests/2380

2 2

[PATCH 0/1] MR2380: quartz: Set filter sync source in FilterGraph2_AddFilter.
by Shaun Ren (＠shaunren) 20 Mar '23

20 Mar '23

This fixes a bug in the game "Nioh: The Complete Edition", where the videos after the first video are played too quickly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2380

3 2

Re: [PATCH v2 0/7] MR2431: Fix the advapi32:service tests - approved
by Alexandre Julliard (＠julliard) 20 Mar '23

20 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2431

1 0

Re: [PATCH v3 0/1] MR2426: widl: Avoid freeing input_name in pop_import. - approved
by Alexandre Julliard (＠julliard) 20 Mar '23

20 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2426

1 0

Re: [PATCH v2 0/5] MR2424: widl: Cleanup lexer a bit and simplify string lexing. - approved
by Alexandre Julliard (＠julliard) 20 Mar '23

20 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2424

1 0

2025

2024

2023

2022

wine-gitlab March 2023