March 2023 - wine-gitlab

[PATCH 0/1] MR2383: shell32: Avoid stack corruption caused by long URLs
by Stefan Rentsch (＠restet) 11 Mar '23

11 Mar '23

Previously long URI/URLs (> 1024 characters) would cause a stack corruption and crash Wine. After this MR, Wine will no longer crash but the URL is not opened either primarily due to `SHELL_Argify` limitations. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2383

3 2

[PATCH 0/1] MR2375: wofutil: Stub WofIsExternalFile().
by Daniel Tang (＠danielzgtg) 11 Mar '23

11 Mar '23

This fixes a crash in `OneDriveSetup.exe`. It still doesn't install with "A supported version of Windows 10 or Windows 11 is required to proceed," but at least it doesn't crash. After this patch, we can now see the OneDrive logo, the progress bar, and the "Installing OneDrive" label. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2375

3 3

[PATCH v3 0/1] MR2377: sppc: Add stubs for MS Office.
by Daniel Tang (＠danielzgtg) 11 Mar '23

11 Mar '23

After this and the related MRs, MS Office 365 finally loads. We see the fancy start screen, and we need modify the options to trust the folder we have our Word documents in. This works for `WINWORD.EXE`, `EXCEL.EXE` and `POWERPNT.exe`. I am able to open an existing file and view it. This MR is limited to showing the first page or so of the Word document. It freezes with the Wine crash dialog basically the moment right after the screen is rendered. There is no backtrace in the dialog, but winedbg points to `v8jsi.dll` and so does the console output without winedbg. Creating new documents is not achieved by this MR either. -- v3: sppc: Add stubs for MS Office. https://gitlab.winehq.org/wine/wine/-/merge_requests/2377

4 4

[PATCH 0/3] MR2382: npptools: Add CreateBlob and DestroyBlob stubs.
by Alex Henrie (＠alexhenrie) 11 Mar '23

11 Mar '23

After stubbing the two functions, the program is able to at least print its help text and describe what it can do. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54671 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2382

2 3

[PATCH v2 0/1] MR2369: comdlg32/tests: Fix itemdlg tests on Windows.
by Florian Will (＠w-flo) 11 Mar '23

11 Mar '23

I'm not sure if the GetTempPathW() dir is okay for this. d3dx11 seems to do the same in tests, so I copied that approach. Commit message: The wine testbot runs tests with C:\Users\Public\Documents as the working directory. Itemdlg tests create test files in the working directory and then try to select them for opening in an IFileOpenDialog. The dialog has its SetFolder method called to point it to the current working directory before showing the dialog, in order for the test code to find the test files it had created there just before opening the dialog. On Windows, this failed because calling the dialog's SetFolder method with C:\Users\Public\Documents doesn't work as expected. The dialog points to the C:\Users\\[CURRENT_USER]\Documents directory instead. Subsequently, the test would be unable to select the test file because it doesn't exist in that directory. So the dialog wouldn't accept the file and close itself to finish the test, but show an error message instead, resulting in a test timeout. To fix this, set the current working directory to the temporary directory before calling individual itemdlg test_* functions. Switch back to the previous working directory after tests finish. -- v2: comdlg32/tests: Fix itemdlg tests on Windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/2369

2 1

[PATCH 0/1] MR2369: comdlg32/tests: Fix itemdlg tests on Windows.
by Florian Will (＠w-flo) 11 Mar '23

11 Mar '23

I'm not sure if the GetTempPathW() dir is okay for this. d3dx11 seems to do the same in tests, so I copied that approach. Commit message: The wine testbot runs tests with C:\Users\Public\Documents as the working directory. Itemdlg tests create test files in the working directory and then try to select them for opening in an IFileOpenDialog. The dialog has its SetFolder method called to point it to the current working directory before showing the dialog, in order for the test code to find the test files it had created there just before opening the dialog. On Windows, this failed because calling the dialog's SetFolder method with C:\Users\Public\Documents doesn't work as expected. The dialog points to the C:\Users\\[CURRENT_USER]\Documents directory instead. Subsequently, the test would be unable to select the test file because it doesn't exist in that directory. So the dialog wouldn't accept the file and close itself to finish the test, but show an error message instead, resulting in a test timeout. To fix this, set the current working directory to the temporary directory before calling individual itemdlg test_* functions. Switch back to the previous working directory after tests finish. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2369

3 3

[PATCH v2 0/1] MR2373: quartz: Update sync source when running or pausing a filter graph.
by Shaun Ren (＠shaunren) 11 Mar '23

11 Mar '23

This fixes a bug where after a sync source is assigned to a filter graph, subsequent filters added to the graph are not given the assigned sync source. This behaviour is expected by the game "Nioh: The Complete Edition", where multiple videos are rendered using the same filter graph. -- v2: quartz: Update sync source when running or pausing a filter graph. https://gitlab.winehq.org/wine/wine/-/merge_requests/2373

3 3

Re: [PATCH 0/1] MR45: ntdll: Always prefer native signal restorer over the custom one.
by Olivia/Isabelle Mahadevan (＠doubledge-spec) 11 Mar '23

11 Mar '23

Any updates on this, @iamahuman? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/45#note_26726

1 0

[PATCH v5 0/3] MR2374: sppc: Stub SLInstallLicense and SLGetSLIDList
by Daniel Tang (＠danielzgtg) 11 Mar '23

11 Mar '23

This allows Microsoft `OfficeSetup.exe` 365 to succeed again. It needs to be used with the revert described in https://bugs.winehq.org/show_bug.cgi?id=54667 . `OneDriveSetup.exe` crashes right after as before, but the Office 365 files get installed into the prefix. -- v5: sppc: Stub SLInstallLicense(). sppc: Stub SLGetSLIDList(). sppc: Declare implemented functions in slpublic.h https://gitlab.winehq.org/wine/wine/-/merge_requests/2374

2 4

[PATCH v2 0/1] MR2377: sppc: Add stubs for MS Office.
by Daniel Tang (＠danielzgtg) 11 Mar '23

11 Mar '23

After this and the related MRs, MS Office 365 finally loads. We see the fancy start screen, and we need modify the options to trust the folder we have our Word documents in. This works for `WINWORD.EXE`, `EXCEL.EXE` and `POWERPNT.exe`. I am able to open an existing file and view it. This MR is limited to showing the first page or so of the Word document. It freezes with the Wine crash dialog basically the moment right after the screen is rendered. There is no backtrace in the dialog, but winedbg points to `v8jsi.dll` and so does the console output without winedbg. Creating new documents is not achieved by this MR either. -- v2: sppc: Add stubs for MS Office. https://gitlab.winehq.org/wine/wine/-/merge_requests/2377

2 1

2025

2024

2023

2022

wine-gitlab March 2023