March 2023 - wine-gitlab

[PATCH v3 0/6] MR2275: winewayland.drv: part 1: Introduce the Wayland driver
by Alexandros Frantzis (＠afrantzis) 02 Mar '23

02 Mar '23

Introduction ------------ This is the first of (many) parts in the upstreaming of the Wayland driver for Wine. Since the amount of code and commits is large, my approach is to upstream the driver in multiple parts in a serial fashion, with each part being a cohesive (to the degree possible) set of not too many commits. When each part is reviewed and merged, I will move on to proposing the next part. My main goal with this approach is to make reviewing easier and more focused. If you have other ideas about how to improve this process for the reviewers, please let me know. A lot of pieces need to fall into place before the driver becomes even remotely functional, so, some MRs (especially the initial ones) will be a bit more preparatory in nature. To aid in the understanding of and justification for some of the code introduced in such MRs, all the remaining driver commits are always going to be available at https://gitlab.winehq.org/afrantzis/wine/-/tree/wayland. Part 1 ------- This MR introduces the Wayland driver PE and unixlib components with some basic code, and prepares the makedep tool to be able to handle Wayland protocol files. Please see the individual commit message for more details. Some questions I would appreciate some feedback on in the context of this MR: 1. Should the Wayland driver build be enabled by default at this point? (currently it's explicitly opt-in with --with-wayland) 2. How should the Wayland driver build be integrated with CI? (currently piggybacking on gitlab/build-linux by adding --with-wayland) Note that building the Wayland driver should not affect running/testing on X11/Xwayland etc, since it's placed lower in the driver priority list. Part 2 preview: We will handle basic Wayland wl_output (i.e., display) events and populate the Wine monitor information. -- v3: winewayland.drv: Introduce wayland_mutex. winewayland.drv: Initialize basic per-thread Wayland instance. https://gitlab.winehq.org/wine/wine/-/merge_requests/2275

3 9

[PATCH v2 0/5] MR1543: mmdevapi: Handle process_attach, process_detach and test_connect UNIX driver functions
by Davide Beatrici (＠davidebeatrici) 02 Mar '23

02 Mar '23

The goal is to eventually move all interfaces from each driver's `mmdevdrv.c` into `mmdevapi`. -- v2: wine{alsa,coreaudio,oss,pulse}: Move test_connect handling into mmdevapi. winepulse: Move process_attach and process_detach handling into mmdevapi. mmdevapi: Query MemoryWineUnixFuncs virtual memory and store the resulting handle. wine{alsa,coreaudio,oss,pulse}: Return STATUS_NOT_IMPLEMENTED for unused unixlib functions. include: Add missing "winternl.h" include to unixlib.h. https://gitlab.winehq.org/wine/wine/-/merge_requests/1543

3 11

[PATCH v8 0/2] MR2282: d3d9: Disable instancing for not-indexed drawing
by Illia Polishchuk (＠illia.a.polishchuk) 02 Mar '23

02 Mar '23

d3d9 does not do instancing for not-indexed draw calls on Windows Original issue in DXVK repo: https://github.com/doitsujin/dxvk/issues/3157 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54570 -- v8: d3d9: Always draw only a single instance for non-indexed draws. https://gitlab.winehq.org/wine/wine/-/merge_requests/2282

2 2

[PATCH v7 0/2] MR2282: d3d9: Disable instancing for not-indexed drawing
by Illia Polishchuk (＠illia.a.polishchuk) 02 Mar '23

02 Mar '23

d3d9 does not do instancing for not-indexed draw calls on Windows Original issue in DXVK repo: https://github.com/doitsujin/dxvk/issues/3157 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54570 -- v7: d3d9: Always draw only a single instance for non-indexed draws. d3d9/tests: Add test for non-indexed instancing drawing. https://gitlab.winehq.org/wine/wine/-/merge_requests/2282

2 2

[PATCH v2 0/6] MR2275: winewayland.drv: part 1: Introduce the Wayland driver
by Alexandros Frantzis (＠afrantzis) 02 Mar '23

02 Mar '23

Introduction ------------ This is the first of (many) parts in the upstreaming of the Wayland driver for Wine. Since the amount of code and commits is large, my approach is to upstream the driver in multiple parts in a serial fashion, with each part being a cohesive (to the degree possible) set of not too many commits. When each part is reviewed and merged, I will move on to proposing the next part. My main goal with this approach is to make reviewing easier and more focused. If you have other ideas about how to improve this process for the reviewers, please let me know. A lot of pieces need to fall into place before the driver becomes even remotely functional, so, some MRs (especially the initial ones) will be a bit more preparatory in nature. To aid in the understanding of and justification for some of the code introduced in such MRs, all the remaining driver commits are always going to be available at https://gitlab.winehq.org/afrantzis/wine/-/tree/wayland. Part 1 ------- This MR introduces the Wayland driver PE and unixlib components with some basic code, and prepares the makedep tool to be able to handle Wayland protocol files. Please see the individual commit message for more details. Some questions I would appreciate some feedback on in the context of this MR: 1. Should the Wayland driver build be enabled by default at this point? (currently it's explicitly opt-in with --with-wayland) 2. How should the Wayland driver build be integrated with CI? (currently piggybacking on gitlab/build-linux by adding --with-wayland) Note that building the Wayland driver should not affect running/testing on X11/Xwayland etc, since it's placed lower in the driver priority list. Part 2 preview: We will handle basic Wayland wl_output (i.e., display) events and populate the Wine monitor information. -- v2: winewayland.drv: Introduce wayland_mutex. winewayland.drv: Initialize basic per-thread Wayland instance. winewayland.drv: Add stub for per-thread data. winewayland.drv: Perform basic per-process Wayland initialization. winewayland.drv: Add initial unixlib stub. winewayland.drv: Add initial driver stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/2275

3 16

Re: [PATCH v2 0/3] MR2304: widl: Add parameterized signatures for more basic types.
by Mohamad Al-Jaf (＠maljaf) 02 Mar '23

02 Mar '23

On Wed Mar 1 08:06:29 2023 +0000, Huw Davies wrote: > @rbernon, note that you should explicitly approve this as it contains > commits from another author. I see, yeah, I tried to add the correct strings to the types, but couldn't find anything on array. The others were pretty straightforward. Also, the build error was misleading and I think it'd be helpful to add the equivalent of `TRACE` in widl. The existing debug parameters were not helpful. Thanks for the link, good info. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2304#note_25975

1 0

Re: [PATCH v7 0/2] MR2044: ntoskrnl.exe: Implement acquiring and releasing guarded mutexes
by Etaash Mathamsetty (＠etaash.mathamsetty) 02 Mar '23

02 Mar '23

tests failing for unrelated reasons -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2044#note_25966

1 0

[PATCH v6 0/2] MR2282: d3d9: Disable instancing for not-indexed drawing
by Illia Polishchuk (＠illia.a.polishchuk) 01 Mar '23

01 Mar '23

d3d9 does not do instancing for not-indexed draw calls on Windows Original issue in DXVK repo: https://github.com/doitsujin/dxvk/issues/3157 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54570 -- v6: d3d9: Always draw only a single instance for non-indexed draws. d3d9/tests: Add test for not-indexed instancing drawing https://gitlab.winehq.org/wine/wine/-/merge_requests/2282

3 9

[PATCH v2 0/2] MR2302: gdiplus: Use FILE_SHARE_READ in GdipPrivateAddFontFile().
by w-flo (＠w-flo) 01 Mar '23

01 Mar '23

ZusiDisplay sometimes loads the same font file into two different PrivateFontCollections using two threads, so there is a race condition when the file is opened without the FILE_SHARE_READ sharing mode. The second call to GdipPrivateAddFontFile() might fail if the first one hasn't closed the file handle yet. -- v2: gdiplus: Use FILE_SHARE_READ in GdipPrivateAddFontFile(). gdiplus/tests: Test for GdipPrivateAddFontFile() sharing violation. https://gitlab.winehq.org/wine/wine/-/merge_requests/2302

4 9

Re: [PATCH v2 0/5] MR2256: wined3d: move stubs out of state tables - approved
by Alexandre Julliard (＠julliard) 01 Mar '23

01 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2256

1 0

2025

2024

2023

2022

wine-gitlab March 2023