April 2023 - wine-gitlab

Re: [PATCH v2 0/28] MR2595: include: Add windows.ui.composition.idl file.
by Biswapriyo Nath (＠Biswa96) 17 Apr '23

17 Apr '23

On Mon Apr 17 04:50:13 2023 +0000, Mohamad Al-Jaf wrote: > Is the file windows.graphics.directx.idl in mingw updated? It has the > definitions of those enums. Yes, all the IDL files are updated wrt. wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2595#note_30195

1 0

Re: [PATCH v2 0/28] MR2595: include: Add windows.ui.composition.idl file.
by Mohamad Al-Jaf (＠maljaf) 17 Apr '23

17 Apr '23

On Mon Apr 17 04:50:14 2023 +0000, Biswapriyo Nath wrote: > The generated header file shows the following compiler warning in clang > mingw-w64 toolchain. > ``` > F:/msys64/clang64/include/windows.ui.composition.h:4919:30: error: ISO > C++ forbids forward references to 'enum' types > enum DirectXAlphaMode *value) = 0; > ^ > F:/msys64/clang64/include/windows.ui.composition.h:4922:30: error: ISO > C++ forbids forward references to 'enum' types > enum DirectXPixelFormat *value) = 0; > ^ > ``` > Is that related to this IDL file in some way? Is the file windows.graphics.directx.idl in mingw updated? It has the definitions of those enums. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2595#note_30194

1 0

Re: [PATCH v2 0/28] MR2595: include: Add windows.ui.composition.idl file.
by Biswapriyo Nath (＠Biswa96) 17 Apr '23

17 Apr '23

The generated header file shows the following compiler warning in clang mingw-w64 toolchain. ``` F:/msys64/clang64/include/windows.ui.composition.h:4919:30: error: ISO C++ forbids forward references to 'enum' types enum DirectXAlphaMode *value) = 0; ^ F:/msys64/clang64/include/windows.ui.composition.h:4922:30: error: ISO C++ forbids forward references to 'enum' types enum DirectXPixelFormat *value) = 0; ^ ``` Is that related to this IDL file in some way? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2595#note_30190

1 0

Re: [PATCH v7 0/2] MR2620: include: Add windows.ui.composition.interop.idl file.
by Mohamad Al-Jaf (＠maljaf) 17 Apr '23

17 Apr '23

On Mon Apr 17 01:22:12 2023 +0000, Biswapriyo Nath wrote: > Apology for hijacking this thread. Would you like to add > windows.graphics.capture.interop.idl please? Required for pywinrt > project. I have tried to add it like you did but get compiler error in > that project. No problem, happy to help. Sure, I took a look and it generates this error: tools/widl/widl -o include/windows.graphics.capture.interop.h -m32 --nostdinc -Ldlls/\* -Iinclude -Iinclude -D__WINESRC__ \ include/windows.graphics.capture.interop.idl include/windows.h:38:1: error: Unable to open include file stdarg.h make[1]: *** [Makefile:163589: include/windows.graphics.capture.interop.h] Error 1 It doesn't seem worth debugging the error so adding in the equivalent .h file should be fine. MR https://gitlab.winehq.org/wine/wine/-/merge_requests/2658 created. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2620#note_30184

1 0

Re: [PATCH v7 0/2] MR2620: include: Add windows.ui.composition.interop.idl file.
by Biswapriyo Nath (＠Biswa96) 16 Apr '23

16 Apr '23

Apology for hijacking this thread. Would you like to add windows.graphics.capture.interop.idl please? Required for pywinrt project. I have tried to add it like you did but get compiler error in that project. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2620#note_30181

1 0

[PATCH v3 0/1] MR2439: ntoskrnl: Free memory before pointer gets set to NULL.
by Bernhard Übelacker (＠bernhardu) 15 Apr '23

15 Apr '23

Without this patch the memory pointed to by context->in_buff gets leaked on each call to GetVolumeInformationByHandleW and the memory usage of winedevice.exe grows. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52322 -- v3: ntoskrnl: Do not leak memory by setting input buffer to NULL. https://gitlab.winehq.org/wine/wine/-/merge_requests/2439

2 2

Re: [PATCH v2 0/1] MR2439: ntoskrnl: Free memory before pointer gets set to NULL.
by Bernhard Übelacker (＠bernhardu) 15 Apr '23

15 Apr '23

On Tue Apr 11 18:16:38 2023 +0000, Zebediah Figura wrote: > This seems unrelated and unnecessary. Yes, this was just to make sure not to release the same buffer twice. At least, with this assignment removed, my test program from bugzilla behaves the same. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2439#note_30160

1 0

Re: [PATCH v2 0/7] MR2562: winex11: Preparatory XIM cleanup.
by Jinoh Kang (＠iamahuman) 15 Apr '23

15 Apr '23

Jinoh Kang (@iamahuman) commented about dlls/winex11.drv/xim.c: > - XNStatusAttributes, status, > - XNClientWindow, win, > - XNFocusWindow, win, > - XNDestroyCallback, &destroy, > - NULL); > - } > - else > - { > - xic = XCreateIC(xim, > - XNInputStyle, ximStyle, > - XNClientWindow, win, > - XNFocusWindow, win, > - XNDestroyCallback, &destroy, > - NULL); > - } > + preedit = XVaCreateNestedList( 0, XNFontSet, fontSet, Why is this code assuming that `fontSet` is not `NULL`, regardless of `(ximStyle & (XIMPreeditNothing | XIMPreeditNone)) == 0`? It appears to me that the code that actually sets `x11drv_thread_data()->font_set` does so only if the condition is true. (Yes, I'm aware that later commit changes font set handling, but bisection points to this one as the first bad commit.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2562#note_30159

1 0

[PATCH v8 0/1] MR150: vkd3d-shader/hlsl: Ignore "unroll" attribute for loops.
by Nikolay Sivov (＠nsivov) 14 Apr '23

14 Apr '23

-- v8: vkd3d-shader/hlsl: Ignore "unroll" attribute for loops. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/150

4 3

[PATCH v5 0/1] MR2390: winegstreamer: Cache wg_parser input data.
by Derek Lesho (＠dlesho) 14 Apr '23

14 Apr '23

On my Steam Deck, this reduces the time it takes to initialize the wg_parser radically (by around 1 second). This helps in the game WILD HEARTS, which doesn't present while loading help videos during gameplay, causing large stutters. Because GStreamer can randomly access the file with no known pattern on our side, I opted to implement this by buffering 4 chunks so that interleaved reads to different areas of the file don't cause us to discard and reload cached data more than we need to. -- v5: winegstreamer: Cache wg_parser input data. https://gitlab.winehq.org/wine/wine/-/merge_requests/2390

3 3

2025

2024

2023

2022

wine-gitlab April 2023