April 2023 - wine-gitlab

[PATCH 0/3] MR2497: Modules list handling in dbghelp.
by eric pouech (＠epo) 12 May '23

12 May '23

The aim of this series is to re-implement dbghelp.EnumerateLoadedModules* in order to match Windows' behavior (especially in wow64 environments). The serie includes: - a bunch of tests to compare 3 different sets of loaded modules: + the load DLL debug events (generated by kernel) + the output of dbghelp.EnumerateLoadedModules(), which is a wrapper around kernel32.EnumProcesModulesEx (yet modifying some information) + the actual list of loaded modules in dbghelp (SymEnumerateModules). => the later list can be populated automatically from the second if requested to dbghelp (this is what is tested). => for the record, winedbg uses the first set to populate the third set. We just test the content of first set, not the population to the third. - the reimplementation of EnumerateLoadedModules to match Window's behavior (especially regarding paths information) Despite the three sets look similar, they have quite a few differences to be taken care of (especially in wow64 setup). Note: having the correct paths (esp. in wow64) is important as dbghelp sometimes tries some wild guesses based on the path (like bitness <g>) or (in some other places) don't rely on path information and retries things on its own. The long target is to simplify the module lookup by relying on more solid information. @julliard: the paths for wow64 modules returned from kernel32 don't match windows behavior: wine returns 32bit system modules from c:\windows\syswow64 whereas windows returns them from c:\windows\system32 (except a couple of exceptions: 32bit ntdll and exe main module). Implementation in dbghelp includes the correction of this. (I opted not to change ntdll at once: testing on windows show that kernel32.EnumProcesModulesEx returns exactly the ldr_data list, and I didn't feel like adding this burden to this patch ;-). Let me know if you want ntdll to be fixed before this patch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2497

3 7

[PATCH v3 0/2] MR2578: Fixing module paths in LdrPath (corner case).
by eric pouech (＠epo) 12 May '23

12 May '23

The serie intent is to fix unexpected paths in module's list: This happens: - when running under old / (new) wow64 - when main module is located under the syswow64 directory - the 32 bit modules are stored in LdrData (and then exposed through a couple of ways) under syswow64 (they are normally stored under system32, letting the redirection come into play when needed) This triggers a couple of errors in winetest (as we're using c:\windows\syswow64\msinfo32.exe in many tests to trigger a wow64 process from a winetest program). This is the fix awaited in MR!2497. @julliard: I'm not 100% happy with the fix itself by reintroducting ref to the redirected DLLs in ntdll/PE but couldn't find a better idea. -- v3: ntdll,wow64: Unredirect DLLs filename before storing them into LdrData. kernel32: Harden some wow64 module tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/2578

2 4

[PATCH 0/1] MR2687: ntdll: Retry send on ECONNREFUSED in try_send().
by Paul Gofman (＠gofman) 09 May '23

09 May '23

Fixes low FPS in Ghost Recon Breakpoint in dx11 mode. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2687

3 6

[PATCH 0/1] MR2230: webservices: Avoid uninitialized variable warning in format_double
by Gerald Pfeifer (＠gerald) 09 May '23

09 May '23

GCC 13 was going to diagnose dlls/webservices/writer.c:960:18: warning: 'mag2' may be used uninitialized -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2230

3 6

[PATCH v9 0/1] MR2609: shlwapi: Implement StrFormatByteSizeEx
by David Kahurani (＠kahurani) 08 May '23

08 May '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54733 Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v9: shlwapi: Implement StrFormatByteSizeEx https://gitlab.winehq.org/wine/wine/-/merge_requests/2609

4 3

[PATCH 0/1] MR2241: makedep: Better differentiate between compiling and linking commands.
by Bernhard Kölbl (＠besentv) 06 May '23

06 May '23

This makes one able to see what is being built as PE and UNIX code and shows 'LINK' for linking in silent configuration `--enable-silent-rules`. For example: ``` make: Entering directory '/home/bernhard/Documents/programming/builds/wine/x64' UNIX dlls/windows.media.speech/unixlib.o PE dlls/windows.media.speech/x86_64-windows/async.o PE dlls/windows.media.speech/x86_64-windows/main.o PE dlls/windows.media.speech/x86_64-windows/recognizer.o PE dlls/windows.media.speech/x86_64-windows/event_handlers.o PE dlls/windows.media.speech/x86_64-windows/listconstraint.o PE dlls/windows.media.speech/x86_64-windows/synthesizer.o PE dlls/windows.media.speech/x86_64-windows/vector.o WIDL dlls/windows.media.speech/x86_64-windows/classes_r.res LINK dlls/windows.media.speech/x86_64-windows/windows.media.speech.dll LINK dlls/windows.media.speech/windows.media.speech.so Wine build complete. ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2241

3 3

[PATCH v3 0/2] MR2679: msvcrt110: Add stub _Cancellation_beacon::_Cancellation_beacon()
by Vijay Kiran Kamuju (＠infyquest) 04 May '23

04 May '23

Required for Forza Horizon 4 and other games https://bugs.winehq.org/show_bug.cgi?id=54756 -- v3: msvcr120_app: Fix spec file for 0_Cancellation_beacon@details@Concurrency https://gitlab.winehq.org/wine/wine/-/merge_requests/2679

6 7

[PATCH 0/4] MR2714: d3d8: Create swapchain textures from wined3d_swapchain_get_back_buffer() instead of using a callback.
by Zebediah Figura (＠zfigura) 04 May '23

04 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2714

3 5

[PATCH v5 0/2] MR2690: mfreadwrite/tests: Add more tests for MFCreateSinkWriterFromURL.
by Ziqing Hui (＠zhui) 04 May '23

04 May '23

The tests shows that, for sink writer created by MFCreateSinkWriterFromURL, we are not able to grab the media sink object immediately after the creation, unless the media sink object can be created without setting media type(MP3, ASF). -- v5: mfreadwrite/tests: Test GetService for MP4 sink writer. mfreadwrite/tests: Add more tests for MFCreateSinkWriterFromURL. https://gitlab.winehq.org/wine/wine/-/merge_requests/2690

3 4

[PATCH v2 0/4] MR168: hlsl: ps_1_* outputs.
by Zebediah Figura (＠zfigura) 03 May '23

03 May '23

-- v2: vkd3d-shader/hlsl: Map the colour output for ps_1_* to r0. vkd3d-shader/hlsl: Rewrite the register allocator to allow allocating in multiple passes. vkd3d-shader/hlsl: Avoid leaking the allocator register map in allocate_const_registers(). vkd3d-shader/hlsl: Rename struct liveness to struct register_allocator. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/168

4 10

2025

2024

2023

2022

wine-gitlab April 2023