April 2023 - wine-gitlab

[PATCH 0/1] MR2613: kernel32/tests: Improve the WideCharToMultiByte() null-termination and truncation tests.
by Francois Gouget (＠fgouget) 07 Apr '23

07 Apr '23

Check the content of the output buffer in addition to checking the return value. Also show that multibyte characters are not truncated when the output buffer is too small. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2613

2 1

Re: [PATCH v4 0/6] MR2598: imm32: Move IME UI window proc to the default implementation.
by Jacek Caban (＠jacek) 07 Apr '23

07 Apr '23

On Fri Apr 7 14:53:00 2023 +0000, Rémi Bernon wrote: > > I'm not sure what you mean by very integrated with win32u. Exposing > builtin IMEs as "normal" IMEs is not affected by changes that I suggest. > For driver interface, it would just replace one driver entry by another. > I think I was confused by the idea of adding win32u specific interface > for the callbacks. I'll consider doing this, as I think it also make > sense to pass NtUserNotifyIMEStatus calls. > I'm curious then, is there any advantage of using `NtUserMessageCall` vs > `NtUserCallOneParam` or one of the other flavor? `NtUserMessageCall` > takes a hwnd as first parameter, it feels a bit wrong to use an HIMC there. I'd expect that `NtUserMessageCall` would be a bit nicer for wow64, because it may just pass through arguments like `NtUserSpyGetMsgName`, but yeah, handle type mismatch is not that nice. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2598#note_29322

1 0

Re: [PATCH v4 0/6] MR2598: imm32: Move IME UI window proc to the default implementation.
by Rémi Bernon (＠rbernon) 07 Apr '23

07 Apr '23

v4: Fix macOS build by removing its ime_private definition early, and merging it with winex11 in ntuser.h. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2598#note_29321

1 0

[PATCH 0/1] MR2610: dinput/tests: Fix the spelling of an ok() message.
by Francois Gouget (＠fgouget) 07 Apr '23

07 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2610

3 2

[PATCH v3 0/6] MR2598: imm32: Move IME UI window proc to the default implementation.
by Rémi Bernon (＠rbernon) 07 Apr '23

07 Apr '23

This adds a new `wine/ime.h` header, to share the `IMEPRIVATE` structure between `imm32`, `winex11` and `winemac`. This structure will be internal to `imm32` ultimately, but I intend to keep the header to define a new internal interface for driver to call back into `imm32` (through the UI window), and for a new interface to call from `imm32` into host IME implemented by the drivers. -- v3: imm32: Remove unnecessary HIMC check in IME UI window proc. imm32: Call DefWindowProcW from IME UI for unhandled messages. imm32: Cleanup default IME UI window proc traces. winemac: Use the default IME UI window proc implementation. winex11: Move IME UI proc to default IME implementation. winex11: Cleanup spaces in IME UI window proc. https://gitlab.winehq.org/wine/wine/-/merge_requests/2598

2 8

[PATCH v2 0/4] MR2607: imm32/tests: Add more INPUTCONTEXT updates tests, and Imm(Set|Get)CompositionString.
by Rémi Bernon (＠rbernon) 07 Apr '23

07 Apr '23

-- v2: imm32/tests: Add more ImmSetCompositionString tests. imm32/tests: Add more ImmGetCompositionString(W|A) tests. imm32/tests: Test WM_IME_NOTIFY messages target window. imm32/tests: Test setting the same HIMC statuses twice. https://gitlab.winehq.org/wine/wine/-/merge_requests/2607

3 6

[PATCH v2 0/6] MR2598: imm32: Move IME UI window proc to the default implementation.
by Rémi Bernon (＠rbernon) 07 Apr '23

07 Apr '23

This adds a new `wine/ime.h` header, to share the `IMEPRIVATE` structure between `imm32`, `winex11` and `winemac`. This structure will be internal to `imm32` ultimately, but I intend to keep the header to define a new internal interface for driver to call back into `imm32` (through the UI window), and for a new interface to call from `imm32` into host IME implemented by the drivers. -- v2: imm32: Remove unnecessary HIMC check in IME UI window proc. imm32: Call DefWindowProcW from IME UI for unhandled messages. imm32: Cleanup default IME UI window proc traces. winemac: Use the default IME UI window proc implementation. winex11: Move IME UI proc to default IME implementation. winex11: Cleanup spaces in IME UI window proc. https://gitlab.winehq.org/wine/wine/-/merge_requests/2598

3 8

[PATCH 0/12] MR2608: msvcrt: Use still more functions from the bundled musl library.
by Alexandre Julliard (＠julliard) 07 Apr '23

07 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2608

3 13

[PATCH 0/6] MR2598: imm32: Move IME UI window proc to the default implementation.
by Rémi Bernon (＠rbernon) 07 Apr '23

07 Apr '23

This adds a new `wine/ime.h` header, to share the `IMEPRIVATE` structure between `imm32`, `winex11` and `winemac`. This structure will be internal to `imm32` ultimately, but I intend to keep the header to define a new internal interface for driver to call back into `imm32` (through the UI window), and for a new interface to call from `imm32` into host IME implemented by the drivers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2598

4 11

[PATCH v2 0/3] MR2455: wined3d: Avoid VK_IMAGE_LAYOUT_GENERAL.
by Stefan Dösinger (＠stefan) 07 Apr '23

07 Apr '23

This series aims to improve GPU-side performance by avoiding VK_IMAGE_LAYOUT_GENERAL for textures that are used as render target and shader resource view. To do so, we have to transition them between VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL and VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL depending on use (and likewise for depth stencils). It improves performance of Rocket League from 80 fps to 100 fps in a GPU limited configuration on my Radeon Polaris GPU. This MR is marked as draft for now because I am not convinced by patch 3 yet. For actual submission I think I'll create separate MRs for patches 1-3 and 4-8. Patch 2 introduces a validation layer error in the d3d11 tests that gets fixed in patch 3. No new test failures are introduced, although none of the existing ones are fixed either. -- v2: wined3d: Fall back to general layout if necessary. wined3d: Avoid VK_IMAGE_LAYOUT_GENERAL. wined3d: Sync depth stencils to both early and late depth test. https://gitlab.winehq.org/wine/wine/-/merge_requests/2455

3 5

2025

2024

2023

2022

wine-gitlab April 2023