May 2023 - wine-gitlab

Re: [PATCH v8 0/6] MR2786: Add support for AF_UNIX sockets
by Loïc Rebmeister (＠Fox2Code) 18 May '23

18 May '23

On Thu May 18 11:12:53 2023 +0000, Zebediah Figura wrote: > > "Unfortunately, last time I tried to write tests for Unix sockets, I > started triggering kernel panics in Windows." It seems like a Windows > specific issue! A kernel panic should never occur, even when provided > with invalid data. > Well... yes? I'm not sure what your point is. > > I think it's best to ignore Windows <-> Unix communications tests for > now as I don't think `winetest` allow running tests in both Windows and > Unix space at the same time, that would require `winetest` supporting > `wsl` when testing on Windows10+, and I think `wsl` support is out of > scope of this PR. > I'm not requesting tests for host interop here, and while I don't think > it's a bad idea (for some measure of stability) we don't have the > infrastructure to do those kinds of tests. "Well... yes? I'm not sure what your point is." It's just it made me laugh a bit that you made windows crash that easily by accident. I just pointed out the obvious cause I found it funny. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_33080

1 0

[PATCH v10 0/8] MR193: vkd3d-shader/hlsl: Add support for writing RWStructuredBuffer declarations.
by Nikolay Sivov (＠nsivov) 18 May '23

18 May '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v10: tests: Add RWBuffer writing test. tests: Add support for UAV buffers in the d3d11 runner. tests: Add support for UAV buffers to d3d12 runner. tests: Add support for UAV buffers in Vulkan runner. vkd3d-shader/hlsl: Improve UAV format type checking for buffer types. vkd3d-shader/hlsl: Add support for writing RWStructuredBuffer declarations. vkd3d-shader/hlsl: Add support for RWBuffer object. vkd3d-shader: Fix dcl_uav_typed_* formatting. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/193

4 10

[PATCH 0/1] MR2838: msvcrt: Fix dlopen() set bin-mode failed.
by Deqiang Chen (＠chendeqiang) 18 May '23

18 May '23

When open() used O_RDONLY,dpopen(fd,rb) set bin-mode failed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2838

4 6

[PATCH 0/1] MR2835: comctl32/toolbar: Always center bitmap for buttons.
by Jactry Zeng (＠jactry) 18 May '23

18 May '23

The current implementation doesn't work when we set the button with a size that is greater than the size of bitmap. Likely it isn't easy to test this automatically, attached is the testcase I wrote for it. And this is the comparison: ![comctl32_toolbar_button_bitmap](/uploads/427448b2aaaac1f03feca1eed2fe4bb9/comctl32_toolbar_button_bitmap.png) [toolbar_button_bitmap_testcase.tar.gz](/uploads/51b3018645f7aa46d444cd8d696716e1/toolbar_button_bitmap_testcase.tar.gz) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2835

2 2

Re: [PATCH v8 0/6] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 17 May '23

17 May '23

One real-world example of Windows software that has support for AF_UNIX sockets is cURL. This patch allows cURL running under Wine to, for example, query `dockerd`: $ wine curl.exe -s --unix-socket 'Z:/run/docker.sock' http://v1.42/version | jq -r .Version 23.0.6 > Although it's not quite clear to me that ws2_32 is the right place to do that translation; we may want to do it in ntdll instead. @zfigura Can you elaborate on this? I don't see a clean way of doing this in ntdll without modifying `struct afd_bind_params`, `struct afd_connect_params`, etc. to add a field for the Unix path, since none of the other `sock_ioctl` cases add on varargs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_33064

1 0

[PATCH v7 0/3] MR2808: Draft: SNI tray implementation
by Cherser-s (＠Cherser-s) 17 May '23

17 May '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v7: configure: fix winesni.drv not getting disabled https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

2 3

[PATCH v3 0/1] MR2848: mf: Don't try to clone non existent topo connections.
by Bernhard Kölbl (＠besentv) 17 May '23

17 May '23

I put the tests in the same commit as the implementation due to crashes, I can also split them again if needed. Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v3: mf: Don't try to clone non existent topo connections. https://gitlab.winehq.org/wine/wine/-/merge_requests/2848

4 4

[PATCH 0/4] MR2822: wined3d: Recreate swapchain textures in wined3d_swapchain_resize_buffers().
by Zebediah Figura (＠zfigura) 17 May '23

17 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2822

3 7

[PATCH v6 0/3] MR2808: Draft: SNI tray implementation
by Cherser-s (＠Cherser-s) 17 May '23

17 May '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v6: configure: fix winesni.drv not getting disabled https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

2 3

[PATCH v2 0/1] MR2848: mf: Don't try to clone non existent topo connections.
by Bernhard Kölbl (＠besentv) 17 May '23

17 May '23

I put the tests in the same commit as the implementation due to crashes, I can also split them again if needed. Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v2: mf: Don't try to clone non existent topo connections. https://gitlab.winehq.org/wine/wine/-/merge_requests/2848

2 1

2025

2024

2023

2022

wine-gitlab May 2023