June 2023 - wine-gitlab

[PATCH v2 0/9] MR3048: Media.speech improvements.
by eric pouech (＠epo) 20 Jun '23

20 Jun '23

This series adds a couple of features to WinRT's media.speech: - IVoiceInformation, and synthetizer's options are present (mainly use to store information, not yet to make fully use of it) - add a dummy implementation (1 single voice); that should be extended in future series by using ISpVoice instead - add a couple of more tests to go with implementation (the serie should prevent MS Flight simulator to crash on first connection. Crash is due to exception handling of C# generated exceptions from E_NOTIMPL with some X11 related critical resources). A+ -- v2: windows.media.speech: Implement get/put voice on synthesizer. windows.media.speech: Implement default voice. windows.media.speech: Add more tests about voice selection. windows.media.speech: Finish implement the voice information view. windows.media.speech/tests: Added tests about vector view's content. windows.media.speech: Add basic implementation of IVoiceInformation. windows.media.speech: Add more tests about IVoiceInformation. windows.media.speech: Add basic implementation on synthesizer options. windows.media.speech: Adding a couple of synthesizer's options tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3048

3 10

[PATCH v2 0/2] MR3120: win32u: Move virtual desktop display settings logic from winex11.
by Rémi Bernon (＠rbernon) 20 Jun '23

20 Jun '23

-- v2: win32u: Move virtual desktop display settings logic from winex11. win32u: Split default UpdateDisplayDevices implementation to a helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/3120

2 3

Re: [PATCH v5 0/4] MR3073: Implement FileDispositionInformationEx and FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE - closed
by Joel Holdsworth (＠jhol) 20 Jun '23

20 Jun '23

This merge request was closed by Joel Holdsworth. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3073

1 0

[PATCH v2 0/5] MR224: tests: Test coarse and fine derivates and demand less precision from ddx() and ddy().
by Francisco Casas (＠fcasas) 20 Jun '23

20 Jun '23

On my Nvidia GeForce GTX 1050 Ti `ddxddy.shader_test` doesn't pass because of considerably different numeric results. As Giovanni pointed out, this is because my GPU uses the fine derivate and not the coarse derivate to implement ddx() and ddy(). For this reason, the result for ddx|ddy() is quantized so that the test passes if the GPU uses either coarse or fine derivates. Additionally, tests for both ddx_coarse|ddy_coarse() and ddx_fine|ddy_fine() are added, that expect a more precise result. -- v2: vkd3d-shader/hlsl: Fine derivates support. vkd3d-shader/hlsl: Coarse derivates support. tests: Quantize ddx() and ddy() test. tests: Make ddx() and ddy() test behave correctly for shader models < 4. tests: Test coarse and fine derivates. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/224

5 11

[PATCH 0/5] MR3118: Implement dbghelp.SymSrvGetFileIndexesInfo().
by eric pouech (＠epo) 20 Jun '23

20 Jun '23

Implements SymSrvGetFileIndexesInfo() for PE images. (.dbg and .pdb are still to be done). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3118

2 5

[PATCH v3 0/1] MR3117: loader: Set the visibility of symbols in preloader to "hidden". (#55091)
by Jinoh Kang (＠iamahuman) 20 Jun '23

20 Jun '23

Today, the preloader is linked with -fPIE in spite of the fact that the preloader is a non-PIE statically linked binary. This is due to a limitation in tools/makedep that makes it difficult to specify CFLAGS for each individual object file's recipe. This can seemingly cause problems with some GOTPCREL(X) relocations inside the preloader. Since preloader does not link to the system library directly, there is no need for a Global Offset Table (GOT). However, a few extern (non-static) function symbols are declared, the use of which makes GCC emit instructions that references those symbols by indirection through GOT. The linker then tries to optimize such instructions to eliminate GOT references, which can fail due to various reasons. This stands in contradiction with Jinoh Kang's suggestion (in bug 55050) that "-fPIE is harmless even when applied to an object linked into non-PIE executables." The claim is theoretically true since position-independent code can in principle be relocated to any address (fixed or dynamic); however, it fails due to some peculiar practical issues, which is arguably a limitation in the linker's implementation (since it can be worked around with -Wl,--no-relax without issues). Fix this by eliminating GOT usage by setting the default visibility of non-static declarations to "hidden". Assuming GCC's medium code model (-mcmodel=medium; default code model for x86_64), this suppresses any unnecessary PLT or GOT relocations for defined symbols, and provides opportunity for GCC to optimize the code better. Fixes: 78ed343842dcd8ffb95c416420953e121959d40d Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55091 cc/ @epo -- v3: loader: Set the visibility of symbols in preloader to "hidden". https://gitlab.winehq.org/wine/wine/-/merge_requests/3117

2 2

[PATCH 0/1] MR3117: loader: Set the visibility of symbols in preloader to "hidden". (#55095)
by Jinoh Kang (＠iamahuman) 20 Jun '23

20 Jun '23

Today, the preloader is linked with -fPIE in spite of the fact that the preloader is a non-PIE statically linked binary. This is due to a limitation in tools/makedep that makes it difficult to specify CFLAGS for each individual object file's recipe. This can seemingly cause problems with some GOTPCREL(X) relocations inside the preloader. Since preloader does not link to the system library directly, there is no need for Global Offset Tables (GOT). However, a few extern (non-static) function symbols are declared, the use of which makes GCC emit instructions that references those symbols by indirection through GOT. The linker then tries to optimize such instructions to eliminate GOT references, which can fail due to various reasons. This stands in contradiction with Jinoh Kang's suggestion (in bug 55050) that "-fPIE is harmless even when applied to an object linked into non-PIE executables." The claim is theoretically true since position-independent code can in principle be relocated to any address (fixed or dynamic); however, it fails due to some peculiar practical issues, which is arguably a limitation in the linker's implementation (since it can be worked around --no-relax without issues). Fix this by eliminating GOT usage by setting the default visibility of non-static declarations to "hidden". Assuming GCC's medium code model (-mcmodel=medium; default code model for x86_64), this suppresses any unnecessary PLT or GOT relocations for defined symbols, and provides opportunity for GCC to optimize the code better. Fixes: 78ed343842dcd8ffb95c416420953e121959d40d Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55095 cc/ @epo -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3117

2 2

[PATCH v2 0/1] MR239: vkd3d-shader/codegen: Skip register allocation for unused object variables.
by Nikolay Sivov (＠nsivov) 20 Jun '23

20 Jun '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vkd3d-shader/codegen: Skip register allocation for unused object variables. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/239

3 3

[PATCH v7 0/9] MR2942: jscript: Misc fixes and improvements.
by Gabriel Ivăncescu (＠insn) 20 Jun '23

20 Jun '23

Some of these fixes are subtle (like the first patch) and very annoying to debug. Although the first patch looks like a hack, surprisingly, it's how the spec itself says it is! It's not even an IE quirk, but a special case in the spec. For example, the variable name (which holds the builtin eval func) **does** matter: if it's called something other than 'eval', it gets treated differently (as if indirect), and this is verified by the tests + the spec's wording (so Microsoft's implementation follows it). Most of the patches other than the first 2 are pretty small so they're in same MR. -- v7: jscript: Store ref to the function code instead of the function instance jscript: Start from the last argument when adding them to named locals. jscript: Store detached locals into a scope's specialized buffer. jscript: Detach the frame's scope before inserting eval() variables into it. jscript: Don't use iface_to_jsdisp where it's not necessary to grab it. jscript: Get rid of jsobj in scope_chain_t. jscript: Fix function leak in scope_init_locals. jscript: Fix addressing invalid memory if ref is an argument. jscript: Correctly implement context for indirect eval calls in ES5+ modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/2942

3 16

[PATCH v4 0/2] MR2875: shell32: add support for balloon icon copying
by Cherser-s (＠Cherser-s) 20 Jun '23

20 Jun '23

Currently shell32 only transfers the plain icon for `Shell_NotifyIcon` calls, ignoring balloon icons. This patch allows transferring both images to explorer.exe tray. -- v4: shell32: add support for balloon icon copying shell32: refactor notify_icon for multiple icons https://gitlab.winehq.org/wine/wine/-/merge_requests/2875

2 2

2025

2024

2023

2022

wine-gitlab June 2023