July 2023 - wine-gitlab

Re: [PATCH v14 0/2] MR2068: comdlg32: Enable visual styles when showing IFileDialog. - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2068

1 0

Re: [PATCH v2 0/10] MR3210: d3dx9/tests cleanup - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3210

1 0

Re: [PATCH v2 0/3] MR3217: wined3d: Reuse command buffers and fences. - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3217

1 0

Re: [PATCH v2 0/5] MR3212: wined3d: Reduce command stream CPU usage, part 1 - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3212

1 0

Re: [PATCH v4 0/6] MR3165: dxgi: Introduce a worker thread for each D3D12 swapchain (first part). - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3165

1 0

Re: [PATCH v4 0/1] MR3206: vbscript: Support one-line sub/function - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3206

1 0

Re: [PATCH v7 0/6] MR3220: windows.devices.bluetooth: Implement IBluetoothAdapterStatics::GetDeviceSelector(). - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3220

1 0

Re: [PATCH v6 0/8] MR3218: wine{alsa,coreaudio,oss,pulse}: Move session_init_vols, create_session into mmdevapi. - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3218

1 0

Re: [PATCH v2 0/3] MR254: hlsl: Fix constant allocation for sm1. - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/254

1 0

Re: [PATCH v2 0/2] MR257: vkd3d-shader: Two valgrind fixes. - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/257

1 0

Re: [PATCH v3 0/2] MR256: vkd3d-shader/hlsl: Improvements to static expression evaluation. - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/256

1 0

Re: [PATCH v5 0/3] MR255: vkd3d-shader: Scan for the maximum temporary register in d3dbc and emit a spirv temp array accordingly. - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/255

1 0

Re: [PATCH v3 0/1] MR252: vkd3d-shader/hlsl: Add constant folding for 'rcp'. - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/252

1 0

Re: [PATCH v4 0/3] MR251: vkd3d: Fix a few resource leaks here and there - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/251

1 0

Re: [PATCH v5 0/5] MR250: vkd3d-shader/hlsl: Declare vars individually when parsing declarations. - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/250

1 0

Re: [PATCH v5 0/5] MR224: tests: Test coarse and fine derivates and demand less precision from ddx() and ddy(). - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/224

1 0

[PATCH 0/7] MR3233: Remove DECLSPEC_HIDDEN in DirectShow
by Alistair Leslie-Hughes (＠alesliehughes) 04 Jul '23

04 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3233

3 8

[PATCH v15 0/2] MR2778: mfmediaengine: Add support for video effects.
by Bernhard Kölbl (＠besentv) 04 Jul '23

04 Jul '23

The test has a little inspiration from the SDK samples. -- v15: mfmediaengine: Add support for inserting video effects. mfmediaengine/tests: Add tests for video effects. https://gitlab.winehq.org/wine/wine/-/merge_requests/2778

4 6

[PATCH 0/3] MR254: hlsl: Fix constant allocation for sm1.
by Zebediah Figura (＠zfigura) 04 Jul '23

04 Jul '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/254

5 11

[PATCH 0/1] MR2228: bcryptprimitives: ProcessRng stub
by Christopher Denton (＠cdenton) 04 Jul '23

04 Jul '23

`ProcessRng` is the only publicly documented function exported by `bcryptprimitives`. This stub simply forwards it to `RtlGenRandom` in `advapi32`. Documentation: https://learn.microsoft.com/en-us/windows/win32/seccng/processprng -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2228

4 11

[PATCH v2 0/4] MR3234: winewayland.drv: part 5: window_surface flush optimizations
by Alexandros Frantzis (＠afrantzis) 04 Jul '23

04 Jul '23

This MR optimizes and makes correctness improvements to the window_surface flush implementation: 1. Implement a buffer queue to avoid constantly allocating new buffers. 2. Take into account the bounds of the window_surface flush and track per-buffer damage to reduce copying from the window_surface. 3. Copy from the window_surface only pixel data that lies within the flushed bounds. Maintain the latest contents for pixels outside these bounds, by copying them from the latest valid buffer. 4. Communicate damaged surface regions to the compositor to allow it to perform more efficient pixel data transfers (e.g., texture uploads). Thanks! -- v2: winewayland.drv: Send surface damage region to the compositor. winewayland.drv: Update only the flushed bounds from the window_surface. winewayland.drv: Track damaged buffer regions. winewayland.drv: Use a buffer queue for window_surface. https://gitlab.winehq.org/wine/wine/-/merge_requests/3234

3 10

[PATCH v4 0/2] MR3157: include: Introduce wine_dbgstr_hstring and debugstr_hstring.
by Alex Henrie (＠alexhenrie) 04 Jul '23

04 Jul '23

This replaces Wine's 14 copies of debugstr_hstring. -- v4: include: Introduce wine_dbgstr_hstring and debugstr_hstring. include: Use correct header guard name in winstring.h. https://gitlab.winehq.org/wine/wine/-/merge_requests/3157

2 2

[PATCH v2 0/1] MR3085: vbscript: Use correct pointer type in add_match (scan-build).
by Alex Henrie (＠alexhenrie) 04 Jul '23

04 Jul '23

-- v2: vbscript: Use correct pointer type in add_match (scan-build). https://gitlab.winehq.org/wine/wine/-/merge_requests/3085

2 1

[PATCH 0/10] MR3210: d3dx9/tests cleanup
by Matteo Bruni (＠Mystral) 04 Jul '23

04 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3210

3 11

[PATCH v3 0/1] MR3049: user32: Ignore invalid parameters in DrawTextEx when HDC is invalid
by Fabian Maurer (＠DarkShadow44) 04 Jul '23

04 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47089 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- v3: user32: Ignore invalid parameters in DrawTextEx when HDC is invalid https://gitlab.winehq.org/wine/wine/-/merge_requests/3049

2 3

[PATCH v11 0/7] MR3189: Add windows.devices.geolocation.geolocator
by Fabian Maurer (＠DarkShadow44) 04 Jul '23

04 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55126 -- v11: windows.devices.geolocation.geolocator: Implement IWeakReference. https://gitlab.winehq.org/wine/wine/-/merge_requests/3189

4 11

[PATCH v12 0/7] MR3189: Add windows.devices.geolocation.geolocator
by Fabian Maurer (＠DarkShadow44) 04 Jul '23

04 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55126 -- v12: windows.devices.geolocation.geolocator: Implement IWeakReference. https://gitlab.winehq.org/wine/wine/-/merge_requests/3189

4 10

[PATCH v10 0/7] MR3189: Add windows.devices.geolocation.geolocator
by Fabian Maurer (＠DarkShadow44) 04 Jul '23

04 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55126 -- v10: windows.devices.geolocation.geolocator: Implement IWeakReference. https://gitlab.winehq.org/wine/wine/-/merge_requests/3189

3 13

[PATCH v14 0/2] MR2778: mfmediaengine: Add support for video effects.
by Bernhard Kölbl (＠besentv) 04 Jul '23

04 Jul '23

The test has a little inspiration from the SDK samples. -- v14: mfmediaengine: Add support for inserting video effects. https://gitlab.winehq.org/wine/wine/-/merge_requests/2778

4 11

[PATCH 0/2] MR257: vkd3d-shader: Two valgrind fixes.
by Zebediah Figura (＠zfigura) 04 Jul '23

04 Jul '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/257

5 7

[PATCH v2 0/2] MR256: vkd3d-shader/hlsl: Improvements to static expression evaluation.
by Nikolay Sivov (＠nsivov) 04 Jul '23

04 Jul '23

vkd3d-shader/hlsl: Support evaluated expressions for sample count in multisampled textures declarations. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vkd3d-shader/hlsl: Disallow certain instruction types from constant expressions. vkd3d-shader/hlsl: Support evaluated expressions for sample count in multisampled textures declarations. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/256

6 7

[PATCH v4 0/3] MR255: vkd3d-shader: Scan for the maximum temporary register in d3dbc and emit a spirv temp array accordingly.
by Zebediah Figura (＠zfigura) 04 Jul '23

04 Jul '23

``` On Margate Sands. I can connect Nothing with nothing. ``` -- v4: vkd3d-shader/d3dbc: Scan for the maximum temporary register index. vkd3d-shader: Record a global temporary count per sm4 shader. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/255

4 6

[PATCH v2 0/1] MR252: vkd3d-shader/hlsl: Add constant folding for 'rcp'.
by Nikolay Sivov (＠nsivov) 04 Jul '23

04 Jul '23

-- v2: vkd3d-shader/hlsl: Add constant folding for 'rcp'. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/252

5 4

[PATCH v3 0/3] MR251: vkd3d: Fix a few resource leaks here and there
by Giovanni Mascellani (＠giomasce) 04 Jul '23

04 Jul '23

-- v3: vkd3d: Release op data when destroying the queue. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/251

3 4

[PATCH v4 0/5] MR250: vkd3d-shader/hlsl: Declare vars individually when parsing declarations.
by Francisco Casas (＠fcasas) 04 Jul '23

04 Jul '23

In a declaration with multiple variables, the variables must be created before the initializer of the next variable is parsed. This is required for initializers such as: ``` float a = 1, b = a, c = b + 1; ``` The solution is to parse the type information in the same rule as the first variable ('a' in this case) so that it can be declared before the parser reaches the initializer for the following variables. To initialize the following variables, the type information is passed along from the first variable's struct parse_variable_def to the next and so on. --- Solves https://bugs.winehq.org/show_bug.cgi?id=54484, pointed out by @nsivov. -- v4: vkd3d-shader/hlsl: Declare vars individually when parsing struct declarations. vkd3d-shader/hlsl: Declare vars individually when parsing regular declarations. vkd3d-shader/hlsl: Split declare_vars(). tests: Test multiple variable initializers. tests: Test semantics in uniform variables. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/250

4 8

[PATCH v4 0/5] MR224: tests: Test coarse and fine derivates and demand less precision from ddx() and ddy().
by Francisco Casas (＠fcasas) 04 Jul '23

04 Jul '23

On my Nvidia GeForce GTX 1050 Ti `ddxddy.shader_test` doesn't pass because of considerably different numeric results. As Giovanni pointed out, this is because my GPU uses the fine derivate and not the coarse derivate to implement ddx() and ddy(). For this reason, the result for ddx|ddy() is quantized so that the test passes if the GPU uses either coarse or fine derivates. Additionally, tests for both ddx_coarse|ddy_coarse() and ddx_fine|ddy_fine() are added, that expect a more precise result. -- v4: vkd3d-shader/hlsl: Support fine derivates. vkd3d-shader/hlsl: Support coarse derivates. tests: Quantize regular and coarse derivate test results. tests: Make ddx() and ddy() test behave correctly for shader models < 4. tests: Test coarse and fine derivates. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/224

4 8

[PATCH 0/1] MR261: vkd3d-shader: Add compiler option to specify matrix majority.
by Nikolay Sivov (＠nsivov) 04 Jul '23

04 Jul '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/261

3 2

[PATCH v2 0/2] MR3232: d3d10core/tests: Mark test failures specific to the Vulkan or GL renderers.
by Zebediah Figura (＠zfigura) 04 Jul '23

04 Jul '23

This is obviously questionable, as it requires reaching into Wine internals in tests (beyond simply detecting whether Wine is in use). However, we are at a point where, for d3d10 and above, the Vulkan renderer works well enough in general to see real use [in fact, in my experience it usually works better than the GL renderer], and at this point I think avoiding regressions is quite important. It is currently difficult to run tests with it when the results contain so much noise, and I think we need to solve this problem, by actually marking which tests work on each backend. We could in theory expose the renderer through some adapter string, but I believe in the past applications have been sensitive about the contents of adapter strings. Fixing either renderer to reach and maintain parity is not feasible. The GL renderer is not going away, but regrettably GL as an API is abandoned by Khronos, and important features we need in order to implement some Direct3D features will probably never be introduced into GL. Moreover, the amount of effort that would be required to reach parity is not small, and itself would all need to be verified manually. -- v2: d3d10core/tests: Mark test failures specific to the Vulkan or GL renderers. https://gitlab.winehq.org/wine/wine/-/merge_requests/3232

4 4

[PATCH 0/3] MR3217: wined3d: Reuse command buffers and fences.
by Zebediah Figura (＠zfigura) 04 Jul '23

04 Jul '23

This improves performance with Batman: Arkham Knight on NVidia drivers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3217

3 4

[PATCH 0/5] MR3212: wined3d: Reduce command stream CPU usage, part 1
by Matteo Bruni (＠Mystral) 04 Jul '23

04 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3212

4 12

Re: [PATCH v3 0/6] MR3165: dxgi: Introduce a worker thread for each D3D12 swapchain (first part).
by Henri Verbeet (＠hverbeet) 04 Jul '23

04 Jul '23

> The part that doesn't thrill me is the fact that DXGI still directly accesses the VkQueue object, which I tend to see as an internal implementation detail to vkd3d. On the other hand it's nice that we don't need new API from vkd3d (even if, in the future, we were to need something other than vkQueueSubmit() and vkQueuePresentKHR()). For what it's worth, it was a fairly explicit design decision early on to expose the underlying Vulkan objects for d3d12 devices and command queues, as well as to allow the creation of d3d12 resources on top of existing Vulkan images, for the purpose of interoperation with other Vulkan code. I.e., the idea is that it should be possible to integrate vkd3d into a larger Vulkan application to draw some parts using the d3d12 API, while everything else is drawn using Vulkan. The internal queueing of command queue operations on the vkd3d level is unfortunate in that regard; ideally we just wouldn't do that. This MR could probably do a better job of explaining why we need to do that in some cases, and what kind of command queue operation sequences could result in out-of-order presentation. If we're going to need to introduce a DXGI worker thread anyway, could we just make vkd3d_acquire_vk_queue() block until there are no longer any operations queued? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3165#note_37779

1 0

[PATCH v3 0/1] MR3206: vbscript: Support one-line sub/function
by Fabian Maurer (＠DarkShadow44) 04 Jul '23

04 Jul '23

Sub / Function can be on one line, but only if there's brackets. ``` | Storage_opt tFUNCTION Identifier ArgumentsDecl BodyStatements tEND tFUNCTION ``` This leads to sometimes to `link_statements` being called with `head` being NULL, probably because now the `:` can be parsed as `Statement` in `BodyStatements`. Also note that this introduces another shift/reduce conflict, could be related, but I don't understand it well enough. Feedback would be appreciated, I'm still learning bison. -- v3: vbscript: Support one-line sub/function. https://gitlab.winehq.org/wine/wine/-/merge_requests/3206

3 2

Re: [PATCH v3 0/6] MR3165: dxgi: Introduce a worker thread for each D3D12 swapchain (first part). - approved
by Jan Sikorski (＠jsikorski) 04 Jul '23

04 Jul '23

This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3165

1 0

[PATCH v13 0/2] MR2778: mfmediaengine: Add support for video effects.
by Bernhard Kölbl (＠besentv) 04 Jul '23

04 Jul '23

The test has a little inspiration from the SDK samples. -- v13: mfmediaengine: Add support for inserting video effects. mfmediaengine/tests: Add tests for video effects. https://gitlab.winehq.org/wine/wine/-/merge_requests/2778

2 4

[PATCH v5 0/8] MR3218: wine{alsa,coreaudio,oss,pulse}: Move session_init_vols, create_session into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 04 Jul '23

04 Jul '23

-- v5: https://gitlab.winehq.org/wine/wine/-/merge_requests/3218

3 9

[PATCH 0/4] MR3234: winewayland.drv: part 5: window_surface flush optimizations
by Alexandros Frantzis (＠afrantzis) 04 Jul '23

04 Jul '23

This MR optimizes and makes correctness improvements to the window_surface flush implementation: 1. Implement a buffer queue to avoid constantly allocating new buffers. 2. Take into account the bounds of the window_surface flush and track per-buffer damage to reduce copying from the window_surface. 3. Copy from the window_surface only pixel data that lies within the flushed bounds. Maintain the latest contents for pixels outside these bounds, by copying them from the latest valid buffer. 4. Communicate damaged surface regions to the compositor to allow it to perform more efficient pixel data transfers (e.g., texture uploads). Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3234

2 4

[PATCH v4 0/1] MR3114: comctl32: Make the correct linkid from fun SYSLINK_LinkAtPt.
by Zhao Yi (＠Zhaoyi) 04 Jul '23

04 Jul '23

Add a check condition for whether the type is slLink. Signed-off-by: Zhaoyi <zhaoyi(a)uniontech.com> -- v4: comctl32: Make the correct linkid from fun SYSLINK_LinkAtPt. https://gitlab.winehq.org/wine/wine/-/merge_requests/3114

3 3

[PATCH v6 0/6] MR3220: windows.devices.bluetooth: Implement IBluetoothAdapterStatics::GetDeviceSelector().
by Mohamad Al-Jaf (＠maljaf) 04 Jul '23

04 Jul '23

Needed for Revo Scan 5. -- v6: windows.devices.bluetooth: Implement IBluetoothAdapterStatics::GetDeviceSelector(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3220

2 7

[PATCH v5 0/6] MR3220: windows.devices.bluetooth: Partially implement IBluetoothAdapterStatics::GetDeviceSelector().
by Mohamad Al-Jaf (＠maljaf) 04 Jul '23

04 Jul '23

Needed for Revo Scan 5. -- v5: windows.devices.bluetooth: Partially implement IBluetoothAdapterStatics::GetDeviceSelector(). windows.devices.bluetooth/tests: Add IBluetoothAdapterStatics::GetDeviceSelector() tests. windows.devices.bluetooth: Add IBluetoothAdapterStatics stub interface. windows.devices.bluetooth: Add stub DLL. include: Add windows.devices.bluetooth.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/3220

3 10

[PATCH 0/4] MR263: vkd3d-shader/spirv: Refactor the type system.
by Conor McCarthy (＠cmccarthy) 04 Jul '23

04 Jul '23

Shader Model 6 introduces a 16-bit float (half) type, and 16-bit and 64-bit integer types. Storing extra info in the type enum simplifies checking if a type is any integer, floating point or numeric type, and the declaration of SPIR-V types. The benefits depend on using enum vkd3d_data_type in the backend instead of vkd3d_shader_component_type. Patch 2 is difficult to split because types typically flow through to vkd3d_spirv_get_type_id(), so partial changes would require new calls to conversion functions which would be deleted again later. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/263

2 4

[PATCH v3 0/1] MR3114: comctl32: Make the correct linkid from fun SYSLINK_LinkAtPt.
by Zhao Yi (＠Zhaoyi) 04 Jul '23

04 Jul '23

Add a check condition for whether the type is slLink. Signed-off-by: Zhaoyi <zhaoyi(a)uniontech.com> -- v3: comctl32: Make the correct linkid from fun SYSLINK_LinkAtPt. https://gitlab.winehq.org/wine/wine/-/merge_requests/3114

3 4

Re: [PATCH v3 0/6] MR3165: dxgi: Introduce a worker thread for each D3D12 swapchain (first part).
by Zhiyi Zhang (＠zhiyi) 04 Jul '23

04 Jul '23

On Mon Jul 3 18:50:55 2023 +0000, Zebediah Figura wrote: > > With this implementation it should be relatively easy to present with > whatever API is available, though I don't really know how the options > you mention work, so maybe there is some additional complexity I'm not > aware of. > Sounds great :-) > The "fullscreen window styles" problem (and one of the older d3d > contributors can correct me on this) is basically that some applications > use ddraw (and other versions?) to present to a fullscreen window, > expecting the presented area to cover the whole screen, but wgl (and > Vulkan) swapchains only present to the client rect. We currently get > around this by changing the window styles to remove all the nonclient > decorations, but that breaks some applications too. What we want is a > way to present to the actual window, and part of the idea is that using > D3DKMTPresent() is the architecturally correct way to do this. > I don't quite know what the concerns are for dcomposition either. Zhiyi > was looking at that and ran into a wall, but he probably can at least > describe the problem in greater detail. > There are also some thoughts about using D3DKMTPresent() to deal more > efficiently with some cases where we currently have to do a GDI blit. > I'm fuzzy on these details though; again Henri can explain it better. What D3DKMTPresent() does is that it sends a command to the compositor/DWM to display contents. Since DWM is responsible for drawing the window decoration, it allows the nonclient decorations to be overwritten without affecting window styles. The complexity here is that we don't have a DWM. Implementing a DWM and making it work with the host WM is not trivial, if not impossible. Also, the window decoration is currently handled by the host system, for example, Mutter. Having D3DKMTPresent() is certainly more architecturally correct. That way, DWM can intercept these surfaces and do the composition without tearing and not worry about the surface lifetime. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3165#note_37742

1 0

[PATCH 0/71] MR3168: Draft: Release 8.0.2.
by Michael Stefaniuc (＠mstefani) 04 Jul '23

04 Jul '23

-- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/3168

3 3

Re: [PATCH v10 0/2] MR3074: Move getpeername() implementation to wineserver
by Chip Davis (＠cdavis5e) 04 Jul '23

04 Jul '23

Typically, `todo_wine` is removed in the commit that fixes the behavior of the underlying API function. (This may be the reason your change hasn't been merged yet.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3074#note_37738

1 0

[PATCH 0/2] MR3232: d3d10core/tests: Mark test failures specific to the Vulkan or GL renderers.
by Zebediah Figura (＠zfigura) 04 Jul '23

04 Jul '23

This is obviously questionable, as it requires reaching into Wine internals in tests (beyond simply detecting whether Wine is in use). However, we are at a point where, for d3d10 and above, the Vulkan renderer works well enough in general to see real use [in fact, in my experience it usually works better than the GL renderer], and at this point I think avoiding regressions is quite important. It is currently difficult to run tests with it when the results contain so much noise, and I think we need to solve this problem, by actually marking which tests work on each backend. We could in theory expose the renderer through some adapter string, but I believe in the past applications have been sensitive about the contents of adapter strings. Fixing either renderer to reach and maintain parity is not feasible. The GL renderer is not going away, but regrettably GL as an API is abandoned by Khronos, and important features we need in order to implement some Direct3D features will probably never be introduced into GL. Moreover, the amount of effort that would be required to reach parity is not small, and itself would all need to be verified manually. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3232

3 3

[PATCH 0/6] MR259: vkd3d-shader/dxil: Read the DXIL module.
by Conor McCarthy (＠cmccarthy) 04 Jul '23

04 Jul '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/259

3 24

Re: [PATCH v3 0/6] MR3165: dxgi: Introduce a worker thread for each D3D12 swapchain (first part). - approved
by Zebediah Figura (＠zfigura) 03 Jul '23

03 Jul '23

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3165

1 0

Re: [PATCH v3 0/1] MR3227: winedump: Add support for dumping IMPORT_OBJECT_NAME_EXPORTAS symbols. - approved
by Alexandre Julliard (＠julliard) 03 Jul '23

03 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3227

1 0

Re: [PATCH v2 0/1] MR3229: mshtml: Remove DECLSPEC_HIDDEN usage. - approved
by Alexandre Julliard (＠julliard) 03 Jul '23

03 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3229

1 0

Re: [PATCH v3 0/2] MR3207: Remove DECLSPEC_HIDDEN from scripting DLL (VBSCript/JScript) - approved
by Alexandre Julliard (＠julliard) 03 Jul '23

03 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3207

1 0

Re: [PATCH v6 0/2] MR3186: ntdll/unix: Skip address conversion for TCP sockets in try_send(). - approved
by Alexandre Julliard (＠julliard) 03 Jul '23

03 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3186

1 0

Re: [PATCH v3 0/5] MR3162: Chromium sandbox fixes - approved
by Alexandre Julliard (＠julliard) 03 Jul '23

03 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3162

1 0

Re: [PATCH v4 0/5] MR3119: uiautomationcore: Add support for raising serverside events. - approved
by Alexandre Julliard (＠julliard) 03 Jul '23

03 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3119

1 0

Re: [PATCH v2 0/1] MR3213: ntoskrnl.exe: Add PsSetLoadImageNotifyRoutineEx semi-stub. - approved
by Alexandre Julliard (＠julliard) 03 Jul '23

03 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3213

1 0

Re: [PATCH v2 0/1] MR3215: win32u: Implement EVENT_OBJECT_SHOW/HIDE for window objects. - approved
by Alexandre Julliard (＠julliard) 03 Jul '23

03 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3215

1 0

Re: [PATCH v2 0/1] MR3214: win32u: Implement marshaling for CB_GETCOMBOBOXINFO. - approved
by Alexandre Julliard (＠julliard) 03 Jul '23

03 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3214

1 0

Re: [PATCH v2 0/1] MR3225: pnputil: Add stub program. - approved
by Alexandre Julliard (＠julliard) 03 Jul '23

03 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3225

1 0

Re: [PATCH v2 0/1] MR3224: shell32: Don't overallocate in Dde_OnRequest (scan-build). - approved
by Alexandre Julliard (＠julliard) 03 Jul '23

03 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3224

1 0

Re: [PATCH v2 0/1] MR3221: dcomp: Add stub for DCompositionCreateDevice3 - approved
by Alexandre Julliard (＠julliard) 03 Jul '23

03 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3221

1 0

Re: [PATCH v3 0/3] MR3219: MSScript faking success in a few functions - approved
by Alexandre Julliard (＠julliard) 03 Jul '23

03 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3219

1 0

[PATCH v13 0/2] MR2068: comdlg32: Enable visual styles when showing IFileDialog.
by Vladislav Timonin (＠vt) 03 Jul '23

03 Jul '23

Required for !1857 to not break when comctl32 version 6 isn't requested by application (in particular, found this in [qapitrace](https://github.com/apitrace/apitrace)). Manifest resource id and assembly identity name match with Windows. For isolation purposes, activation context is disabled while emitting events. -- v13: comdlg32: Enable visual styles when showing IFileDialog. comdlg32: Return E_UNEXPECTED if IFileDialog is already shown. https://gitlab.winehq.org/wine/wine/-/merge_requests/2068

2 4

[PATCH v9 0/7] MR3189: Add windows.devices.geolocation.geolocator
by Fabian Maurer (＠DarkShadow44) 03 Jul '23

03 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55126 -- v9: windows.devices.geolocation.geolocator: Implement IWeakReference. https://gitlab.winehq.org/wine/wine/-/merge_requests/3189

2 7

Re: [PATCH v3 0/6] MR3165: dxgi: Introduce a worker thread for each D3D12 swapchain (first part).
by Zebediah Figura (＠zfigura) 03 Jul '23

03 Jul '23

> With this implementation it should be relatively easy to present with whatever API is available, though I don't really know how the options you mention work, so maybe there is some additional complexity I'm not aware of. Sounds great :-) The "fullscreen window styles" problem (and one of the older d3d contributors can correct me on this) is basically that some applications use ddraw (and other versions?) to present to a fullscreen window, expecting the presented area to cover the whole screen, but wgl (and Vulkan) swapchains only present to the client rect. We currently get around this by changing the window styles to remove all the nonclient decorations, but that breaks some applications too. What we want is a way to present to the actual window, and part of the idea is that using D3DKMTPresent() is the architecturally correct way to do this. I don't quite know what the concerns are for dcomposition either. Zhiyi was looking at that and ran into a wall, but he probably can at least describe the problem in greater detail. There are also some thoughts about using D3DKMTPresent() to deal more efficiently with some cases where we currently have to do a GDI blit. I'm fuzzy on these details though; again Henri can explain it better. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3165#note_37677

1 0

[PATCH v7 0/7] MR3189: Add windows.devices.geolocation.geolocator
by Fabian Maurer (＠DarkShadow44) 03 Jul '23

03 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55126 -- v7: windows.devices.geolocation.geolocator: Implement IWeakReference. windows.devices.geolocation.geolocator: Implement IWeakReferenceSource. windows.devices.geolocation.geolocator: Fake success for PositionChanged_add. windows.devices.geolocation.geolocator: Add stubs for IGeolocator. windows.devices.geolocation.geolocator: Add stub dll. https://gitlab.winehq.org/wine/wine/-/merge_requests/3189

2 8

[PATCH v6 0/7] MR3189: Add windows.devices.geolocation.geolocator
by Fabian Maurer (＠DarkShadow44) 03 Jul '23

03 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55126 -- v6: windows.devices.geolocation.geolocator: Implement IWeakReference. windows.devices.geolocation.geolocator: Implement IWeakReferenceSource. windows.devices.geolocation.geolocator: Fake success for PositionChanged_add. windows.devices.geolocation.geolocator: Add stubs for IGeolocator. windows.devices.geolocation.geolocator: Add stub dll. include: Add windows.devices.geolocation.geolocator. include/windows.foundation: Add double reference. https://gitlab.winehq.org/wine/wine/-/merge_requests/3189

2 7

[PATCH v5 0/7] MR3189: Add windows.devices.geolocation.geolocator
by Fabian Maurer (＠DarkShadow44) 03 Jul '23

03 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55126 -- v5: windows.devices.geolocation.geolocator: Implement IWeakReference. windows.devices.geolocation.geolocator: Implement IWeakReferenceSource. windows.devices.geolocation.geolocator: Fake success for PositionChanged_add. windows.devices.geolocation.geolocator: Add stubs for IGeolocator. https://gitlab.winehq.org/wine/wine/-/merge_requests/3189

4 38

Re: [PATCH v2 0/1] MR3206: vbscript: Support one-line sub/function
by Fabian Maurer (＠DarkShadow44) 03 Jul '23

03 Jul '23

On Mon Jul 3 17:17:31 2023 +0000, Jacek Caban wrote: > Please update the MR. Sure, I updated it with the changes you suggested. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3206#note_37644

1 0

[PATCH 0/1] MR3206: vbscript: Support one-line sub/function
by Fabian Maurer (＠DarkShadow44) 03 Jul '23

03 Jul '23

Sub / Function can be on one line, but only if there's brackets. ``` | Storage_opt tFUNCTION Identifier ArgumentsDecl BodyStatements tEND tFUNCTION ``` This leads to sometimes to `link_statements` being called with `head` being NULL, probably because now the `:` can be parsed as `Statement` in `BodyStatements`. Also note that this introduces another shift/reduce conflict, could be related, but I don't understand it well enough. Feedback would be appreciated, I'm still learning bison. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3206

3 4

[PATCH v2 0/1] MR3227: winedump: Add support for dumping IMPORT_OBJECT_NAME_EXPORTAS symbols.
by Jacek Caban (＠jacek) 03 Jul '23

03 Jul '23

This is used by ARM64EC importlibs. -- v2: winedump: Add support for dumping IMPORT_OBJECT_NAME_EXPORTAS symbols. https://gitlab.winehq.org/wine/wine/-/merge_requests/3227

2 1

[PATCH 0/1] MR3229: mshtml: Remove DECLSPEC_HIDDEN usage.
by Gabriel Ivăncescu (＠insn) 03 Jul '23

03 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3229

3 2

[PATCH v12 0/2] MR2068: comdlg32: Enable visual styles when showing IFileDialog.
by Vladislav Timonin (＠vt) 03 Jul '23

03 Jul '23

Required for !1857 to not break when comctl32 version 6 isn't requested by application (in particular, found this in [qapitrace](https://github.com/apitrace/apitrace)). Manifest resource id and assembly identity name match with Windows. For isolation purposes, activation context is disabled while emitting events. -- v12: comdlg32: Enable visual styles when showing IFileDialog. https://gitlab.winehq.org/wine/wine/-/merge_requests/2068

3 5

Re: [PATCH v3 0/6] MR3165: dxgi: Introduce a worker thread for each D3D12 swapchain (first part).
by Giovanni Mascellani (＠giomasce) 03 Jul '23

03 Jul '23

On Fri Jun 30 17:01:00 2023 +0000, Zebediah Figura wrote: > So in isolation I think the solution proposed by this patch set is fine, > and even looks prettiest. *But* what I remember from that discussion—and > Henri will undoubtedly be able to express this more eloquently—is that > the concern is > (a) we might want to do something more complicated than just > vkQueuePresent()—cf. the issues about fullscreen window styles / > presenting to the client rect. I'm not sure but this might also turn out > to be an issue for DirectComposition. > (b) we might want to plumb presentation through D3DKMTPresent() [which > may be necessary to achieve the above], and it will probably not be > possible to do any vkd3d calls from the Unix side. I pushed a new implementation incorporating the changes you're suggesting, and honestly I don't dislike it: https://gitlab.winehq.org/giomasce/wine/-/commits/chianti (only the last three commits changed in a meaningful way; or maybe at all). With this implementation it should be relatively easy to present with whatever API is available, though I don't really know how the options you mention work, so maybe there is some additional complexity I'm not aware of. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3165#note_37623

1 0

[PATCH 0/1] MR3085: vbscript: Use correct pointer type in add_match (scan-build).
by Alex Henrie (＠alexhenrie) 03 Jul '23

03 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3085

4 4

[PATCH v2 0/2] MR3207: Remove DECLSPEC_HIDDEN from scripting DLL (VBSCript/JScript)
by Alistair Leslie-Hughes (＠alesliehughes) 03 Jul '23

03 Jul '23

-- v2: vbscript: Remove DECLSPEC_HIDDEN usage. jscript: Remove DECLSPEC_HIDDEN usage. https://gitlab.winehq.org/wine/wine/-/merge_requests/3207

3 3

[PATCH 0/1] MR3227: winebuild: Add support for dumping IMPORT_OBJECT_NAME_EXPORTAS symbols.
by Jacek Caban (＠jacek) 03 Jul '23

03 Jul '23

This is used by ARM64EC importlibs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3227

2 1

[PATCH v3 0/5] MR250: vkd3d-shader/hlsl: Declare vars individually when parsing declarations.
by Francisco Casas (＠fcasas) 03 Jul '23

03 Jul '23

In a declaration with multiple variables, the variables must be created before the initializer of the next variable is parsed. This is required for initializers such as: ``` float a = 1, b = a, c = b + 1; ``` The solution is to parse the type information in the same rule as the first variable ('a' in this case) so that it can be declared before the parser reaches the initializer for the following variables. To initialize the following variables, the type information is passed along from the first variable's struct parse_variable_def to the next and so on. --- Solves https://bugs.winehq.org/show_bug.cgi?id=54484, pointed out by @nsivov. -- v3: vkd3d-shader/hlsl: Declare vars individually when parsing struct declarations. vkd3d-shader/hlsl: Declare vars individually when parsing regular declarations. vkd3d-shader/hlsl: Split declare_vars(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/250

3 7

[PATCH v4 0/9] MR3218: wine{alsa,coreaudio,oss,pulse}: Move session_init_vols, create_session, get_audio_session into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 03 Jul '23

03 Jul '23

-- v4: winepulse: Move get_audio_session into mmdevapi. https://gitlab.winehq.org/wine/wine/-/merge_requests/3218

4 13

[PATCH v4 0/6] MR3220: windows.devices.bluetooth: Partially implement IBluetoothAdapterStatics::GetDeviceSelector().
by Mohamad Al-Jaf (＠maljaf) 03 Jul '23

03 Jul '23

Needed for Revo Scan 5. -- v4: windows.devices.bluetooth: Partially implement IBluetoothAdapterStatics::GetDeviceSelector(). windows.devices.bluetooth/tests: Add IBluetoothAdapterStatics::GetDeviceSelector() tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3220

3 8

[PATCH v3 0/15] MR3157: include: Introduce wine_dbgstr_h and debugstr_h.
by Alex Henrie (＠alexhenrie) 03 Jul '23

03 Jul '23

These replace Wine's 14 copies of debugstr_hstring. -- v3: wintypes: Replace debugstr_hstring with debugstr_h. windows.ui: Replace debugstr_hstring with debugstr_h. windows.system.profile.systemmanufacturers: Replace debugstr_hstring with debugstr_h. windows.perception.stub: Replace debugstr_hstring with debugstr_h. windows.networking: Replace debugstr_hstring with debugstr_h. windows.media: Replace debugstr_hstring with debugstr_h. windows.media.speech/tests: Replace debugstr_hstring with debugstr_h. windows.media.speech: Replace debugstr_hstring with debugstr_h. windows.globalization: Replace debugstr_hstring with debugstr_h. windows.devices.enumeration: Replace debugstr_hstring with debugstr_h. threadpoolwinrt: Replace debugstr_hstring with debugstr_h. graphicscapture: Replace debugstr_hstring with debugstr_h. cryptowinrt: Replace debugstr_hstring with debugstr_h. combase: Replace debugstr_hstring with debugstr_h. include: Introduce wine_dbgstr_h and debugstr_h. https://gitlab.winehq.org/wine/wine/-/merge_requests/3157

4 17

[PATCH v3 0/6] MR3220: windows.devices.bluetooth: Partially implement IBluetoothAdapterStatics::GetDeviceSelector().
by Mohamad Al-Jaf (＠maljaf) 03 Jul '23

03 Jul '23

Needed for Revo Scan 5. -- v3: windows.devices.bluetooth: Partially implement IBluetoothAdapterStatics::GetDeviceSelector(). windows.devices.bluetooth/tests: Add IBluetoothAdapterStatics::GetDeviceSelector() tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3220

2 7

[PATCH v2 0/6] MR3220: windows.devices.bluetooth: Partially implement IBluetoothAdapterStatics::GetDeviceSelector().
by Mohamad Al-Jaf (＠maljaf) 03 Jul '23

03 Jul '23

Needed for Revo Scan 5. -- v2: windows.devices.bluetooth: Partially implement IBluetoothAdapterStatics::GetDeviceSelector(). windows.devices.bluetooth/tests: Add IBluetoothAdapterStatics::GetDeviceSelector() tests. windows.devices.bluetooth: Add IBluetoothAdapterStatics stub interface. windows.devices.bluetooth: Add stub DLL. https://gitlab.winehq.org/wine/wine/-/merge_requests/3220

2 7

[PATCH 0/1] MR3225: pnputil: Add stub program.
by Mohamad Al-Jaf (＠maljaf) 03 Jul '23

03 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55178 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3225

2 1

[PATCH 0/1] MR3224: shell32: Don't overallocate in Dde_OnRequest (scan-build).
by Alex Henrie (＠alexhenrie) 02 Jul '23

02 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3224

2 1

Re: [PATCH v3 0/3] MR3191: include: Add A2BSTR function.
by Alexandre Julliard (＠julliard) 02 Jul '23

02 Jul '23

On Sun Jul 2 20:51:00 2023 +0000, Alex Henrie wrote: > atlbase.h, atlcom.h, and atlwin.h are also C++-only in Windows, but Wine > allows them to be used in C and uses them in its own C code. I assumed > that the same logic would apply to atlconv.h, but if that doesn't work > then we may want to introduce a new helper in include/wine. We have the other headers but we use them only for the ATL implementation. They are not something we'd want to use globally. As for a new include/wine helper, there doesn't seem to be enough usage of that function to justify it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3191#note_37561

1 0

[PATCH 0/1] MR3222: localspl: Add workaround for old versions of cups.h
by Fabian Maurer (＠DarkShadow44) 02 Jul '23

02 Jul '23

Recent versions of cups.h have HTTP_STATUS_CONTINUE as enum, so defining it doesn't hurt -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3222

3 2

Re: [PATCH v3 0/3] MR3191: include: Add A2BSTR function.
by Alex Henrie (＠alexhenrie) 02 Jul '23

02 Jul '23

On Sun Jul 2 20:29:53 2023 +0000, Alexandre Julliard wrote: > A2BSTR is a C++ only macro, it's not something we'd want to use as a > standard replacement. atlbase.h, atlcom.h, and atlwin.h are also C++-only in Windows, but Wine allows them to be used in C and uses them in its own C code. I assumed that the same logic would apply to atlconv.h, but if that doesn't work then we may want to introduce a new helper in include/wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3191#note_37559

1 0

Re: [PATCH v3 0/3] MR3191: include: Add A2BSTR function.
by Alexandre Julliard (＠julliard) 02 Jul '23

02 Jul '23

On Sun Jul 2 20:29:26 2023 +0000, Michael Stefaniuc wrote: > Sorry, forgot about that A2BSTR is a C++ only macro, it's not something we'd want to use as a standard replacement. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3191#note_37558

1 0

Re: [PATCH v3 0/3] MR3191: include: Add A2BSTR function.
by Michael Stefaniuc (＠mstefani) 02 Jul '23

02 Jul '23

On Sun Jul 2 20:14:43 2023 +0000, Alex Henrie wrote: > @mstefani Thanks for the feedback. Would you be willing to remove your > downvote now that the scope of this MR has been reduced? Sorry, forgot about that -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3191#note_37557

1 0

[PATCH 0/1] MR3221: dcomp: Add stub for DCompositionCreateDevice3
by Fabian Maurer (＠DarkShadow44) 02 Jul '23

02 Jul '23

This is needed by recent chromium -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3221

2 1

Re: [PATCH v3 0/3] MR3191: include: Add A2BSTR function.
by Alex Henrie (＠alexhenrie) 02 Jul '23

02 Jul '23

On Sun Jul 2 17:27:26 2023 +0000, Michael Stefaniuc wrote: > My comment was referring to the tests where we convert ascii string literals. > The two left commits seem fine though as those don't just convert ascii > string literals in the code. > But I had just a quick look at them. @mstefani Thanks for the feedback. Would you be willing to remove your downvote now that the scope of this MR has been reduced? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3191#note_37554

1 0

2025

2024

2023

2022

wine-gitlab July 2023