July 2023 - wine-gitlab

Re: [PATCH v3 0/4] MR3423: Iphlpapi: Implement NotifyAddrChange (part 1 of 2) - approved
by Huw Davies (＠huw) 28 Jul '23

28 Jul '23

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3423

1 0

[PATCH v4 0/1] MR3104: win32u: Add DriverVersion string for GPUs to registry
by Michael Skorokhodov (＠Samsuper) 28 Jul '23

28 Jul '23

Some applications (e.g. UE4) requires the DriverVersion string in the registry. The string is taken from `dlls/wbemprox/builtin.c` -- v4: win32u: Add DriverVersion string for GPUs to registry https://gitlab.winehq.org/wine/wine/-/merge_requests/3104

4 6

[PATCH 0/1] MR3436: include: Add xamlom.idl file.
by Paul Jackson (＠mailnew4ster) 28 Jul '23

28 Jul '23

Continuation of https://gitlab.winehq.org/wine/wine/-/merge_requests/2773 I tried to address all comments. @zfigura please take a look. cc @Biswa96 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3436

3 2

[PATCH v2 0/1] MR3436: include: Add xamlom.idl file.
by Paul Jackson (＠mailnew4ster) 28 Jul '23

28 Jul '23

Continuation of https://gitlab.winehq.org/wine/wine/-/merge_requests/2773 I tried to address all comments. @zfigura please take a look. cc @Biswa96 -- v2: include: Add xamlom.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/3436

2 1

[PATCH 0/1] MR3437: include: Add windows.ui.xaml.hosting.desktopwindowxamlsource.idl file.
by Paul Jackson (＠mailnew4ster) 28 Jul '23

28 Jul '23

Continuation of https://gitlab.winehq.org/wine/wine/-/merge_requests/2959 No changes were made. @zfigura please take a look. cc @Biswa96 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3437

2 1

[PATCH 0/1] MR3435: winscard: Handle different type sizes on macOS.
by Hans Leidekker (＠hans) 28 Jul '23

28 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3435

2 1

[PATCH v4 0/5] MR283: vkd3d-shader/dxil: Implement DX instruction StoreOutput.
by Conor McCarthy (＠cmccarthy) 28 Jul '23

28 Jul '23

-- v4: vkd3d-shader/dxil: Implement DX instruction StoreOutput. vkd3d-shader/dxil: Declare shader outputs. vkd3d-shader/dxil: Implement the DXIL CALL instruction. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/283

2 5

[PATCH 0/1] MR3426: winegstreamer: Keep default decodebin queue limits for buffers and time.
by Rémi Bernon (＠rbernon) 28 Jul '23

28 Jul '23

Only make size unlimited, which fixes problems with Persona 4 while keeping the memory usage lower. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3426

4 4

[PATCH 0/2] MR3431: wined3d: Fix clears of the current render target in Vulkan
by Evan Tang (＠etang-cw) 28 Jul '23

28 Jul '23

Previously, clearing the current render target would delay the clear until the render pass was ended by something else Fixes missing UI in [Moving Out](https://store.steampowered.com/app/996770/Moving_Out/) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3431

3 3

[PATCH v4 0/10] MR281: vkd3d-shader/tpf: Replace sm4 register structs with vkd3d-shader register structs, part 1.
by Francisco Casas (＠fcasas) 27 Jul '23

27 Jul '23

Recap: I implemented relative addressing in !229, but I was suggested to handle register indexes by moving all the registers to the heap, which I did in my [nonconst-offsets-6](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/noncon… branch. A part of this implementation required !269, but I was asked to try to turn the sm4 register structs into the vkd3d-shader register structs instead, to get closer to a common low level IR. This is the first part of that transformation. The whole thing is in my [use_vkd3d_reg](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/use_vkd3d_r… branch. ~~This is built on top of !225 (the first two patches), so it may be good to get that upstream first.~~ --- This patch series aims to do the following replacements: ``` struct sm4_register -> struct vkd3d_shader_register struct sm4_dst_register -> struct vkd3d_shader_dst_param struct sm4_src_register -> struct vkd3d_shader_src_param ``` to get us closer to a common level IR and simplify the implementation of relative-addressing. To achieve this, the fields in the sm4 register structs are replaced with fields in the vkd3d-shader structs or removed altogether, one at the time. As can be seen when looking at the whole branch, it is possible to do this transformation without having to add additional fields to `struct vkd3d_shader_register`, by restricting each register type to a single `enum vkd3d_sm4_dimension` (and its src registers to a single `enum vkd3d_sm4_swizzle_type`) by default. The only exception we need so far is for sampler registers: They always have dimension NONE, except when used as arguments of gather instructions, in which case they have dimension VEC4 and SCALAR swizzle. This, and similar exceptions we may find in the future, can be handled using the opcode_info, as in 7/8 [81e17506](https://gitlab.winehq.org/fcasas/vkd3d/-/commit/81e17506ba2cb1fbf…. -- v4: vkd3d-shader/tpf: Get rid of sm4_register.dim. vkd3d-shader/tpf: Use 's' in src_info to expect sampler register with vec4 dimension. vkd3d-shader/tpf: Separate dst register write function. vkd3d-shader/tpf: Separate src register write function. vkd3d-shader/tpf: Make register_type_table an array of structs with lookup tables. vkd3d-shader/tpf: Pass ctx to sm4_encode_register(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/281

4 15

[PATCH v2 0/3] MR280: vkd3d-shader: sm1 semantic matching.
by Zebediah Figura (＠zfigura) 27 Jul '23

27 Jul '23

This is probably the most ugly and controversial bit of API. I don't really know if this is the right approach to solving this. sm4 registers match by register index, such that shaders can mostly be compiled in isolation. sm1 does not—registers may be specified in any order in the vertex and pixel shaders, and will be matched by usage and usage index. By itself this is not much of a problem. Where it gets hairy is that we want to do some degree of caching, as well as pre-compilation, and avoid recompiling either shader every time it's matched with a new one. Wine currently deals with this problem, for GLSL, by generating a "main" GLSL shader for the vertex shader, and then an extra function setup_vs_output(), and linking the two together every time a new pixel shader is used. This could in theory be used for SPIR-V, but it requires the use of extra, probably external, code to link SPIR-V shaders together, which I do not particularly anticipate being well-received. (I'm not sure how Wine deals with this problem in the ARB backend. It seems to take the pixel shader signature into account when generating the vertex shader— cf. init_output_registers()—but it doesn't take it into account when looking up a vertex shader variant? I didn't look too closely at the code, so maybe I'm missing something.) -- The vkd3d parts of this patch are quite straightforward, and looking at them, I think the design is quite intuitive in isolation. There may be some room for internal refactoring (in particular with an eye to not so much overloading the "register_index" field of struct shader_signature_element) but I'm relatively happy with the way it turned out. In isolation, that is. The Wine part is worse. I've uploaded branches for vkd3d and Wine that use this API, and correctly handle shaders with some nontrivial reordering: https://gitlab.winehq.org/zfigura/vkd3d/-/commits/himavant5 https://gitlab.winehq.org/zfigura/wine/-/commits/himavant_cb The test can be run, as before, like so: make tests/shader_runner.exe && WINE_D3D_CONFIG=renderer=vulkan wine tests/shader_runner.exe ../vkd3d/tests/hlsl/sm1-interstage-interface.shader_test The interesting Wine parts are concentrated in a single patch, 5cfb9d930f11e. The patch takes a few shortcuts, partly because I wanted not to block the vkd3d API design questions, but also because while writing it I came up with a couple of problems that I wasn't sure how to fix. There are two main problems I see: (1) This patch has the user pass the signature from the pixel shader when compiling the vertex shader, and looks up register indices already arbitrarily allocated by the pixel shader. This is problematic when trying to use this signature as a cache key, by virtue of it not being clear (or even defined) which fields are key elements and which aren't. It's also not particularly kind to lookup, on account of not being directly comparable with memcmp(). There are a few options I see: (a) Provide an internal function to compare key elements. This feels... odd, like a very special-purpose function, but perhaps workable. (b) Just make the user deal with it, and assert that all fields are key elements. (c) Use some alternative, perhaps shortened structure as a field of vkd3d_shader_next_stage_info. This has the disadvantage that it is not as simple for a hypothetical user to retrieve from the pixel shader, but we would presumably provide a function to generate one from a shader signature. This would probably also be kinder to cache lookup if it's shorter. (d) Make caching vkd3d's responsibility, to some degree. This seems daunting, but the more we optimize, the more difficult it may be to design API that allows for nice caching. (2) Assuming we use signatures, there is a memory management problem that 5cfb9d930f11e spells out. This is probably a matter of "just fix it", but I suppose another option is to take the GLSL or ARB architecture. -- April is the cruellest month, breeding Lilacs out of the dead land, mixing Memory and desire, stirring Dull roots with spring rain. -- v2: vkd3d-shader: Implement a function to build a varying map between sm1 stages. vkd3d-shader: Implement remapping shader output registers to match the next shader's semantics. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/280

3 11

[PATCH v2 0/1] MR286: vkd3d: Implement ID3D12GraphicsCommandList3 with a stub.
by Conor McCarthy (＠cmccarthy) 27 Jul '23

27 Jul '23

-- v2: vkd3d: Implement ID3D12GraphicsCommandList3 with a stub. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/286

4 3

[PATCH v5 0/3] MR267: vkd3d: Implement GetResourceTiling().
by Conor McCarthy (＠cmccarthy) 27 Jul '23

27 Jul '23

-- v5: vkd3d: Implement ID3D12Device::GetResourceTiling() for textures. vkd3d: Implement ID3D12Device::GetResourceTiling() for buffers. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/267

4 11

[PATCH v11 0/4] MR218: vkd3d-shader: Implement GetDimensions().
by Nikolay Sivov (＠nsivov) 27 Jul '23

27 Jul '23

-- v11: vkd3d-shader/tpf: Add support for writing 'resinfo' instruction. vkd3d-shader/tpf: Add support for writing 'sampleinfo' instruction. vkd3d-shader/hlsl: Parse GetDimensions() method. tests: Add some tests for GetDimensions(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/218

3 5

[PATCH 0/1] MR287: vkd3d: Implement ID3D12Fence1.
by Conor McCarthy (＠cmccarthy) 27 Jul '23

27 Jul '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/287

4 3

[PATCH v3 0/5] MR283: vkd3d-shader/dxil: Implement DX instruction StoreOutput.
by Conor McCarthy (＠cmccarthy) 27 Jul '23

27 Jul '23

-- v3: vkd3d-shader/dxil: Implement DX instruction StoreOutput. vkd3d-shader/dxil: Declare shader outputs. vkd3d-shader/dxil: Implement the DXIL CALL instruction. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/283

4 19

[PATCH v2 0/3] MR3419: wined3d: Implement a zero-safe normalize function for FFP
by Petrichor Park (＠petrathekat) 27 Jul '23

27 Jul '23

DirectX's FFP normalizes the zero vector to the zero vector, but GLSL normalizes them to all NaN. This patch creates `ffp_normalize`, which normalizes vectors but has DirectX's behavior on 0 vectors. Further patches in this set switch other calls from GLSL's `normalize` to the 0-safe version. This fixes [36564](https://bugs.winehq.org/show_bug.cgi?id=36564). -- v2: wined3d: Use ffp_normalize in shader_glsl_ffp_vertex_lighting_footer. wined3d: Use ffp_normalize in shader_glsl_ffp_vertex_lighting. wined3d: Implement a zero-safe normalize function for FFP. https://gitlab.winehq.org/wine/wine/-/merge_requests/3419

4 5

[PATCH 0/1] MR3427: winegstreamer: Avoid releasing wg_allocator memory samples twice.
by Rémi Bernon (＠rbernon) 27 Jul '23

27 Jul '23

When the sample size is too small, we were releasing it from the memory, but kept the next_sample pointer set. Later, when the transform removes the sample from the allocator, its refcount was decremented one more time, effectively leaking the sample. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3427

3 2

Re: [PATCH v3 0/4] MR3423: Iphlpapi: Implement NotifyAddrChange (part 1 of 2)
by Paul Gofman (＠gofman) 27 Jul '23

27 Jul '23

On Thu Jul 27 20:38:34 2023 +0000, Zebediah Figura wrote: > > Beyond the test included in the patches, I did roughly the following: > ptr = VirtualAlloc(NULL 4096 \* 2, PAGE_NOACCESS); VirtualProtect(ptr, > 4096, PAGE_READWRITE); params = ptr + 4096 - sizeof(\*params). And used > that pointer. So far it doesn't access it beyond the end of accessible > memory (that succeeds). > Ah yes, that definitely sounds convincing to me :-) > > It might happen that with some other values for unknown parameter it > is using more data from the structure, but IMO exploring more details > about those parameters, in the absence of any known app which uses those > functions, looks like a waste of time to me. It is relatively easy here > with nsi and was already explored for other functions so I didn't want > to break this tradition in nsi, but in general it seems impractical to > me to spend huge amount of time reversing the exact parameters of the > undocumented functions which nothing is using directly. Not feasible for > implementing larger APIs and the benefit is not obvious. And once > something is using directly in a way we don't support we can rather > easily look how and test with those parameters. > Sure. I don't think we necessarily need to figure out the unknown > parameter, or spend too much effort on reverse-engineering undocumented > things in general, or closely matching undocumented APIs. > I only get nervous about the prospect of implementing undocumented APIs > that are incorrect in ways that would be subtle or hard to debug—wrong > number of parameters, wrong struct sizes, and so on. To a degree, the > fact that an application even uses such APIs means that it's a first > place to look when debugging, but that's not exactly the kind of thing > that's trivial to notice. > > I could possibly add a fixme for nonzero unk parameter? > That sounds like a unilaterally good idea to me, at least. Now when this patchset is split in two this first part has only a stub FIXME there anyway; I will update the second part with the specific fixme for unknown parameter. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3423#note_40573

1 0

Re: [PATCH v3 0/4] MR3423: Iphlpapi: Implement NotifyAddrChange (part 1 of 2)
by Zebediah Figura (＠zfigura) 27 Jul '23

27 Jul '23

> Beyond the test included in the patches, I did roughly the following: ptr = VirtualAlloc(NULL 4096 \* 2, PAGE_NOACCESS); VirtualProtect(ptr, 4096, PAGE_READWRITE); params = ptr + 4096 - sizeof(\*params). And used that pointer. So far it doesn't access it beyond the end of accessible memory (that succeeds). Ah yes, that definitely sounds convincing to me :-) > It might happen that with some other values for unknown parameter it is using more data from the structure, but IMO exploring more details about those parameters, in the absence of any known app which uses those functions, looks like a waste of time to me. It is relatively easy here with nsi and was already explored for other functions so I didn't want to break this tradition in nsi, but in general it seems impractical to me to spend huge amount of time reversing the exact parameters of the undocumented functions which nothing is using directly. Not feasible for implementing larger APIs and the benefit is not obvious. And once something is using directly in a way we don't support we can rather easily look how and test with those parameters. Sure. I don't think we necessarily need to figure out the unknown parameter, or spend too much effort on reverse-engineering undocumented things in general, or closely matching undocumented APIs. I only get nervous about the prospect of implementing undocumented APIs that are incorrect in ways that would be subtle or hard to debug—wrong number of parameters, wrong struct sizes, and so on. To a degree, the fact that an application even uses such APIs means that it's a first place to look when debugging, but that's not exactly the kind of thing that's trivial to notice. > I could possibly add a fixme for nonzero unk parameter? That sounds like a unilaterally good idea to me, at least. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3423#note_40571

1 0

Re: [PATCH v3 0/4] MR3423: Iphlpapi: Implement NotifyAddrChange (part 1 of 2)
by Paul Gofman (＠gofman) 27 Jul '23

27 Jul '23

Beyond the test included in the patches, I did roughly the following: ptr = VirtualAlloc(NULL 4096 * 2, PAGE_NOACCESS); VirtualProtect(ptr, 4096, PAGE_READWRITE); params = ptr + 4096 - sizeof(*params). And used that pointer. So far it doesn't access it beyond the end of accessible memory (that succeeds). It might happen that with some other values for unknown parameter it is using more data from the structure, but IMO exploring more details about those parameters, in the absence of any known app which uses those functions, looks like a waste of time to me. It is relatively easy here with nsi and was already explored for other functions so I didn't want to break this tradition in nsi, but in general it seems impractical to me to spend huge amount of time reversing the exact parameters of the undocumented functions which nothing is using directly. Not feasible for implementing larger APIs and the benefit is not obvious. And once something is using directly in a way we don't support we can rather easily look how and test with those parameters. I could possibly add a fixme for nonzero unk parameter? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3423#note_40570

1 0

Re: [PATCH v3 0/4] MR3423: Iphlpapi: Implement NotifyAddrChange (part 1 of 2)
by Zebediah Figura (＠zfigura) 27 Jul '23

27 Jul '23

Do we know for sure that the Ex version includes only those five parameters? It seems surprising that they'd reroll the API without adding anything. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3423#note_40569

1 0

Re: [PATCH v3 0/4] MR3423: Iphlpapi: Implement NotifyAddrChange (part 1 of 2)
by Paul Gofman (＠gofman) 27 Jul '23

27 Jul '23

On Thu Jul 27 08:45:24 2023 +0000, Huw Davies wrote: > > So far I don't have anything for the other iphlpapi notification > functions (e. g., NotifyIpInterfaceChange). > I suspect the newer notifications like this one use the > `Nsi(De)RegisterChangeNotification()` api instead. Yes, it seems like it, I was just reasoning on how that could work (most notably, those notifications will need to deliver changed row). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3423#note_40564

1 0

Re: [PATCH v3 0/4] MR3423: Iphlpapi: Implement NotifyAddrChange (part 1 of 2)
by Paul Gofman (＠gofman) 27 Jul '23

27 Jul '23

v2: - split the MR (stop after handle caching commit); - test and add NsiRequestChangeNotificationEx (and move the implementation there); - Mind alphabetical sort when adding NsiCancelChangeNotification. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3423#note_40563

1 0

[PATCH v2 0/4] MR3423: Iphlpapi: Implement NotifyAddrChange (part 1 of 2)
by Paul Gofman (＠gofman) 27 Jul '23

27 Jul '23

-- v2: nsi: Cache nsi device handle. nsi/tests: Add test for change notifications. nsi: Add stub for NsiCancelChangeNotification. nsi: Add stubs for NsiRequestChangeNotification[Ex]. https://gitlab.winehq.org/wine/wine/-/merge_requests/3423

2 4

[PATCH 0/1] MR3429: po: Update Finnish translation.
by Lauri Kenttä (＠lauri.kentta) 27 Jul '23

27 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3429

2 1

[PATCH v22 0/2] MR3391: mshtml: implement window.MutationObserver with MutationObserver stub
by Yuxuan Shui (＠yshui) 27 Jul '23

27 Jul '23

This get us pass the "Update your browser" blocker in adobe's sign-in page. The page itself doesn't make use of `window.MutationObserver`. However the sign-in page is still broken. -- v22: mshtml: add stubs for MutationObserver methods mshtml: implement window.MutationObserver with MutationObserver stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3391

3 3

[PATCH v21 0/2] MR3391: mshtml: implement window.MutationObserver with MutationObserver stub
by Yuxuan Shui (＠yshui) 27 Jul '23

27 Jul '23

This get us pass the "Update your browser" blocker in adobe's sign-in page. The page itself doesn't make use of `window.MutationObserver`. However the sign-in page is still broken. -- v21: mshtml: add stubs for MutationObserver methods mshtml: implement window.MutationObserver with MutationObserver stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3391

3 3

[PATCH v23 0/1] MR3074: Move getpeername() implementation to wineserver
by Ally Sommers (＠dropbear) 27 Jul '23

27 Jul '23

`getpeername()` is currently handled in ntdll. This merge request changes ntdll to forward `getpeername()` to wineserver. The implementation utilises new `peer_addr` and `peer_addr_len` fields in wineserver's `struct sock`. This fixes multiple `todo_wine`s in `ws2_32/tests` and allows for more accurate peer names to be provided in case the address the socket is bound to on the Unix side does not match what `bind()` was called with on the Windows side. *This merge request was originally intended to be included in !2786 (Add support for AF_UNIX sockets) but was split into its own merge request because this is not an insignificant change.* -- v23: server: Move getpeername() implementation from ntdll/unix. https://gitlab.winehq.org/wine/wine/-/merge_requests/3074

3 2

[PATCH v20 0/2] MR3391: mshtml: implement window.MutationObserver with MutationObserver stub
by Yuxuan Shui (＠yshui) 27 Jul '23

27 Jul '23

This get us pass the "Update your browser" blocker in adobe's sign-in page. The page itself doesn't make use of `window.MutationObserver`. However the sign-in page is still broken. -- v20: mshtml: add stubs for MutationObserver methods mshtml: implement window.MutationObserver with MutationObserver stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3391

4 4

[PATCH 0/1] MR3395: Draft: programs/klist: Migrate to KerbQueryTicketCacheExMessage.
by Maxim Karasev (＠mxkrsv) 27 Jul '23

27 Jul '23

Depends on !3393 to work properly, but should build as is. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3395

3 2

[PATCH v4 0/3] MR3105: Add a few additional nullchecks (Coverity)
by Fabian Maurer (＠DarkShadow44) 27 Jul '23

27 Jul '23

-- v4: mmdevapi: Add nullcheck for parameter that can be null (Coverity) winealsa: Remove superflous check wineoss: Remove superflous check https://gitlab.winehq.org/wine/wine/-/merge_requests/3105

4 8

[PATCH v6 0/5] MR219: vkd3d-shader: Implement tex2Dproj().
by Nikolay Sivov (＠nsivov) 27 Jul '23

27 Jul '23

-- v6: vkd3d-shader/hlsl: Implement texCUBEproj(). vkd3d-shader/d3dbc: Disallow 1D sampler types when writing sampler declaration. vkd3d-shader/hlsl: Implement tex3Dproj(). vkd3d-shader/hlsl: Implement tex1Dproj(). vkd3d-shader/hlsl: Implement tex2Dproj(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/219

2 5

[PATCH v18 0/2] MR3391: mshtml: implement window.MutationObserver with MutationObserver stub
by Yuxuan Shui (＠yshui) 27 Jul '23

27 Jul '23

This get us pass the "Update your browser" blocker in adobe's sign-in page. The page itself doesn't make use of `window.MutationObserver`. However the sign-in page is still broken. -- v18: mshtml: add stubs for MutationObserver methods mshtml: implement window.MutationObserver with MutationObserver stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3391

4 5

[PATCH v4 0/1] MR3323: win32u: Don't clip captured mouse pointer only if it's done by the system.
by Gabriel Ivăncescu (＠insn) 27 Jul '23

27 Jul '23

-- v4: win32u: Don't clip captured mouse pointer if it's done by the system. https://gitlab.winehq.org/wine/wine/-/merge_requests/3323

3 2

[PATCH v19 0/2] MR3391: mshtml: implement window.MutationObserver with MutationObserver stub
by Yuxuan Shui (＠yshui) 27 Jul '23

27 Jul '23

This get us pass the "Update your browser" blocker in adobe's sign-in page. The page itself doesn't make use of `window.MutationObserver`. However the sign-in page is still broken. -- v19: mshtml: add stubs for MutationObserver methods mshtml: implement window.MutationObserver with MutationObserver stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3391

2 2

[PATCH v17 0/2] MR3391: mshtml: implement window.MutationObserver with MutationObserver stub
by Yuxuan Shui (＠yshui) 27 Jul '23

27 Jul '23

This get us pass the "Update your browser" blocker in adobe's sign-in page. The page itself doesn't make use of `window.MutationObserver`. However the sign-in page is still broken. -- v17: mshtml: add stubs for MutationObserver methods mshtml: implement window.MutationObserver with MutationObserver stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3391

3 9

Re: [PATCH v3 0/6] MR3413: Assorted spelling fixes - approved
by Alexandre Julliard (＠julliard) 27 Jul '23

27 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3413

1 0

Re: [PATCH v2 0/1] MR3402: imm32: Hide the composition window if the string is empty. - approved
by Alexandre Julliard (＠julliard) 27 Jul '23

27 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3402

1 0

Re: [PATCH v6 0/1] MR3393: dlls/kerberos: Implement KerbQueryTicketCacheExMessage. - approved
by Alexandre Julliard (＠julliard) 27 Jul '23

27 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3393

1 0

Re: [PATCH v3 0/1] MR3389: Use PCSC framework instead of pcsclite on macOS - approved
by Alexandre Julliard (＠julliard) 27 Jul '23

27 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3389

1 0

Re: [PATCH v3 0/1] MR3415: mfmediaengine: Add the trailing linefeed to a WARN() message. - approved
by Alexandre Julliard (＠julliard) 27 Jul '23

27 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3415

1 0

Re: [PATCH v2 0/1] MR3417: mshtml: Add some basic documentation for the dispex and its vtbl. - approved
by Alexandre Julliard (＠julliard) 27 Jul '23

27 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3417

1 0

Re: [PATCH v2 0/1] MR3414: winex11.drv: Add a trailing linefeed to a WARN() message. - approved
by Alexandre Julliard (＠julliard) 27 Jul '23

27 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3414

1 0

Re: [PATCH v2 0/1] MR3412: ntdll/tests: Fix the NtSetInformationFile() test on Windows 10 <= 1709. - approved
by Alexandre Julliard (＠julliard) 27 Jul '23

27 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3412

1 0

Re: [PATCH v2 0/1] MR3411: dinput: Unacquire only DISCL_FOREGROUND devices on foreground changes. - approved
by Alexandre Julliard (＠julliard) 27 Jul '23

27 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3411

1 0

Re: [PATCH v4 0/3] MR3396: msvcrt: Further locale cleanups. - approved
by Alexandre Julliard (＠julliard) 27 Jul '23

27 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3396

1 0

Re: [PATCH v4 0/1] MR3398: gdiplus: Prevent infinite loops due to floating point inaccuracy - approved
by Alexandre Julliard (＠julliard) 27 Jul '23

27 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3398

1 0

Re: [PATCH v6 0/2] MR3363: windowscodecs: Handle PNG histogram (hIST) chunk type. - approved
by Alexandre Julliard (＠julliard) 27 Jul '23

27 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3363

1 0

Re: [PATCH v4 0/1] MR3379: ntdll: Match Windows used block filling. - approved
by Alexandre Julliard (＠julliard) 27 Jul '23

27 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3379

1 0

Re: [PATCH v2 0/1] MR3406: winegstreamer: Use a fixed size type for wg_sample data pointer. - approved
by Alexandre Julliard (＠julliard) 27 Jul '23

27 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3406

1 0

Re: [PATCH v2 0/4] MR3345: wined3d: Move struct wined3d_gl_info to struct wined3d_adapter_gl. - approved
by Alexandre Julliard (＠julliard) 27 Jul '23

27 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3345

1 0

Re: [PATCH v3 0/1] MR3343: d3d11/tests: Mark test failures specific to the Vulkan or GL renderers. - approved
by Alexandre Julliard (＠julliard) 27 Jul '23

27 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3343

1 0

Re: [PATCH v3 0/4] MR3342: wined3d: Stateblock refactoring. - approved
by Alexandre Julliard (＠julliard) 27 Jul '23

27 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3342

1 0

Re: [PATCH v2 0/1] MR3404: userenv: Fix setting ALLUSERSPROFILE and ProgramData in CreateEnvironmentBlock. - approved
by Alexandre Julliard (＠julliard) 27 Jul '23

27 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3404

1 0

Re: [PATCH v2 0/9] MR3401: win32u: Use user message packing for more messages. - approved
by Alexandre Julliard (＠julliard) 27 Jul '23

27 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3401

1 0

Re: [PATCH v2 0/3] MR3400: Remove macro in win16 dlls - approved
by Alexandre Julliard (＠julliard) 27 Jul '23

27 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3400

1 0

Re: [PATCH v3 0/1] MR3399: nsiproxy.sys: Detect wireless interface type on Linux. - approved
by Alexandre Julliard (＠julliard) 27 Jul '23

27 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3399

1 0

Re: [PATCH v4 0/11] MR3380: mmdevapi: Implement AudioClient_Create. - approved
by Alexandre Julliard (＠julliard) 27 Jul '23

27 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3380

1 0

Re: [PATCH v2 0/1] MR285: vkd3d: Handle the case where a descriptor is null and is concurrently written non-null. - approved
by Alexandre Julliard (＠julliard) 27 Jul '23

27 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/285

1 0

Re: [PATCH v2 0/5] MR284: hlsl: Replace bare list pointers with hlsl_block, part 6. - approved
by Alexandre Julliard (＠julliard) 27 Jul '23

27 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/284

1 0

[PATCH 0/3] MR3419: wined3d: Implement a zero-safe normalize function for FFP
by Petrichor Park (＠petrathekat) 27 Jul '23

27 Jul '23

DirectX's FFP normalizes the zero vector to the zero vector, but GLSL normalizes them to all NaN. This patch creates `ffp_normalize`, which normalizes vectors but has DirectX's behavior on 0 vectors. Further patches in this set switch other calls from GLSL's `normalize` to the 0-safe version. This fixes [36564](https://bugs.winehq.org/show_bug.cgi?id=36564). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3419

6 7

[PATCH v3 0/1] MR3104: win32u: Add DriverVersion string for GPUs to registry
by Michael Skorokhodov (＠Samsuper) 27 Jul '23

27 Jul '23

Some applications (e.g. UE4) requires the DriverVersion string in the registry. The string is taken from `dlls/wbemprox/builtin.c` -- v3: win32u: Add DriverVersion string for GPUs to registry https://gitlab.winehq.org/wine/wine/-/merge_requests/3104

2 2

[PATCH 0/1] MR3425: msvcp140_codecvt_ids: Add stub DLL.
by Mohamad Al-Jaf (＠maljaf) 27 Jul '23

27 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55344 It looks like the exports are just variables. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3425

3 2

[PATCH 0/1] MR3424: msxml3: Accept ValidateOnParse property.
by Jactry Zeng (＠jactry) 27 Jul '23

27 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3424

4 3

[PATCH v3 0/1] MR3323: win32u: Don't clip captured mouse pointer only if it's done by the system.
by Gabriel Ivăncescu (＠insn) 27 Jul '23

27 Jul '23

-- v3: win32u: Don't clip captured mouse pointer only if it's done by the system. https://gitlab.winehq.org/wine/wine/-/merge_requests/3323

4 3

[PATCH v3 0/9] MR281: vkd3d-shader/tpf: Replace sm4 register structs with vkd3d-shader register structs, part 1.
by Francisco Casas (＠fcasas) 27 Jul '23

27 Jul '23

Recap: I implemented relative addressing in !229, but I was suggested to handle register indexes by moving all the registers to the heap, which I did in my [nonconst-offsets-6](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/noncon… branch. A part of this implementation required !269, but I was asked to try to turn the sm4 register structs into the vkd3d-shader register structs instead, to get closer to a common low level IR. This is the first part of that transformation. The whole thing is in my [use_vkd3d_reg](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/use_vkd3d_r… branch. ~~This is built on top of !225 (the first two patches), so it may be good to get that upstream first.~~ --- This patch series aims to do the following replacements: ``` struct sm4_register -> struct vkd3d_shader_register struct sm4_dst_register -> struct vkd3d_shader_dst_param struct sm4_src_register -> struct vkd3d_shader_src_param ``` to get us closer to a common level IR and simplify the implementation of relative-addressing. To achieve this, the fields in the sm4 register structs are replaced with fields in the vkd3d-shader structs or removed altogether, one at the time. As can be seen when looking at the whole branch, it is possible to do this transformation without having to add additional fields to `struct vkd3d_shader_register`, by restricting each register type to a single `enum vkd3d_sm4_dimension` (and its src registers to a single `enum vkd3d_sm4_swizzle_type`) by default. The only exception we need so far is for sampler registers: They always have dimension NONE, except when used as arguments of gather instructions, in which case they have dimension VEC4 and SCALAR swizzle. This, and similar exceptions we may find in the future, can be handled using the opcode_info, as in 7/8 [81e17506](https://gitlab.winehq.org/fcasas/vkd3d/-/commit/81e17506ba2cb1fbf…. -- v3: vkd3d-shader/tpf: Get rid of sm4_register.dim. vkd3d-shader/tpf: Use 's' in src_info to expect sampler register with vec4 dimension. vkd3d-shader/tpf: Separate dst register write function. vkd3d-shader/tpf: Separate src register write function. vkd3d-shader/tpf: Make register_type_table an array of structs. vkd3d-shader/tpf: Use struct vkd3d_shader_register_index in sm4_register.idx[]. vkd3d-shader/tpf: Allow passing NULL register type on hlsl_sm4_register_from_semantic(). vkd3d-shader/tpf: Use enum vkd3d_shader_register_type in sm4_register.type. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/281

4 13

[PATCH 0/8] MR3423: Iphlpapi: Implement NotifyAddrChange.
by Paul Gofman (＠gofman) 27 Jul '23

27 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3423

3 14

[PATCH v10 0/4] MR218: vkd3d-shader: Implement GetDimensions().
by Nikolay Sivov (＠nsivov) 27 Jul '23

27 Jul '23

-- v10: vkd3d-shader/tpf: Add support for writing 'resinfo' instruction. vkd3d-shader/tpf: Add support for writing 'sampleinfo' instruction. vkd3d-shader/hlsl: Parse GetDimensions() method. tests: Add some tests for GetDimensions(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/218

3 6

[PATCH v2 0/6] MR3413: Assorted spelling fixes
by Francois Gouget (＠fgouget) 27 Jul '23

27 Jul '23

-- v2: dbghelp/tests: Fix the case of a comment. winewayland.drv: Fix the spelling of a comment. https://gitlab.winehq.org/wine/wine/-/merge_requests/3413

5 11

[PATCH v7 0/1] MR3392: comctl32/listview: Reset bNoItemMetrics to TRUE to make sure that listview items can be arranged.
by Zhao Yi (＠Zhaoyi) 27 Jul '23

27 Jul '23

Same as MR !2394 Signed-off-by: Zhao Yi zhaoyi(a)uniontech.com -- v7: comctl32/listview: Reset bNoItemMetrics to TRUE to make sure that listview items can be arranged. https://gitlab.winehq.org/wine/wine/-/merge_requests/3392

2 1

[PATCH 0/3] MR288: hlsl: Some fixes caught by Wine tests.
by Zebediah Figura (＠zfigura) 27 Jul '23

27 Jul '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/288

3 5

[PATCH v2 0/2] MR3369: mf/tests: Test sample processing for MPEG4 media sink.
by Ziqing Hui (＠zhui) 27 Jul '23

27 Jul '23

-- v2: mf/tests: Test sample processing for MPEG4 media sink. mf/tests: Use IMFMediaEventGenerator interface in event wait helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/3369

4 7

[PATCH v6 0/1] MR3392: comctl32/listview: Reset bNoItemMetrics to TRUE in LISTVIEW_DeleteAllItems() to arrange listview items.
by Zhao Yi (＠Zhaoyi) 27 Jul '23

27 Jul '23

Same as MR !2394 Signed-off-by: Zhao Yi zhaoyi(a)uniontech.com -- v6: comctl32/listview: Reset bNoItemMetrics to TRUE in LISTVIEW_DeleteAllItems() to arrange listview items. https://gitlab.winehq.org/wine/wine/-/merge_requests/3392

2 1

[PATCH v5 0/1] MR3392: comctl32/listview: Set bNoItemMetrics to TRUE in LISTVIEW_DeleteAllItems().
by Zhao Yi (＠Zhaoyi) 27 Jul '23

27 Jul '23

Same as MR !2394 Signed-off-by: Zhao Yi zhaoyi(a)uniontech.com -- v5: comctl32/listview: Set bNoItemMetrics to TRUE in LISTVIEW_DeleteAllItems(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3392

3 3

[PATCH 0/1] MR2910: winegstreamer: Add stubs for MPEG4 muxer.
by Ziqing Hui (＠zhui) 27 Jul '23

27 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2910

5 21

Re: [PATCH v3 0/1] MR3319: evr: Leave critical section before waiting for streaming thread.
by Nikolay Sivov (＠nsivov) 26 Jul '23

26 Jul '23

On Wed Jul 26 19:17:48 2023 +0000, Nikolay Sivov wrote: > I had to learn what's going on in there once again. I think what we need > to do is basically stop using 'presenter->cs' in the streaming thread > entirely, MFVP_MESSAGE_ENDSTREAMING handling will remain unchanged. > This means two things: > - queue itself should be protected with its own lock; > - video_presenter_process_input() should not be called in the streaming > thread all. Instead it could be called right in > video_presenter_allocator_cb_NotifyRelease(), with appropriate locking. It's slightly more complicated, I can see now why EVRM_PROCESS_INPUT was added - it was probably to avoid interacting with tracking thread. The point still stands, I think we'll need to remove remaining presenter lock from streaming thread, one way or another. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3319#note_40394

1 0

[PATCH v16 0/2] MR3391: mshtml: implement window.MutationObserver with MutationObserver stub
by Yuxuan Shui (＠yshui) 26 Jul '23

26 Jul '23

This get us pass the "Update your browser" blocker in adobe's sign-in page. The page itself doesn't make use of `window.MutationObserver`. However the sign-in page is still broken. -- v16: mshtml: add stubs for MutationObserver methods mshtml: implement window.MutationObserver with MutationObserver stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3391

3 4

Re: [PATCH v3 0/1] MR3319: evr: Leave critical section before waiting for streaming thread.
by Nikolay Sivov (＠nsivov) 26 Jul '23

26 Jul '23

On Wed Jul 26 17:26:57 2023 +0000, Santino Mazza wrote: > Oh I just saw that we have `PRESENTER_MIXER_HAS_INPUT` flag and is set > when it receives the `MFVP_MESSAGE_PROCESSINPUTNOTIFY` message, but when > the streaming thread receives the `EVRM_PROCESS_INPUT` message it > doesn't set that flag, shouldn't we set that flag and check for it > before waiting for the thread? I had to learn what's going on in there once again. I think what we need to do is basically stop using 'presenter->cs' in the streaming thread entirely, MFVP_MESSAGE_ENDSTREAMING handling will remain unchanged. This means two things: - queue itself should be protected with its own lock; - video_presenter_process_input() should not be called in the streaming thread all. Instead it could be called right in video_presenter_allocator_cb_NotifyRelease(), with appropriate locking. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3319#note_40382

1 0

[PATCH v15 0/2] MR3391: mshtml: implement window.MutationObserver with MutationObserver stub
by Yuxuan Shui (＠yshui) 26 Jul '23

26 Jul '23

This get us pass the "Update your browser" blocker in adobe's sign-in page. The page itself doesn't make use of `window.MutationObserver`. However the sign-in page is still broken. -- v15: mshtml: add stubs for MutationObserver methods mshtml: implement window.MutationObserver with MutationObserver stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3391

3 9

Re: [PATCH v3 0/1] MR3319: evr: Leave critical section before waiting for streaming thread.
by Santino Mazza (＠tati1454) 26 Jul '23

26 Jul '23

On Wed Jul 26 17:25:19 2023 +0000, Santino Mazza wrote: > mmm, what about adding a timeout for WaitForSingleObject and do the > LeaveCriticalSection if the timeout passed? Not sure how long it should be. Oh I just saw that we have `PRESENTER_MIXER_HAS_INPUT` flag and is set when it receives the `MFVP_MESSAGE_PROCESSINPUTNOTIFY` message, but when the streaming thread receives the `EVRM_PROCESS_INPUT` message it doesn't set that flag, shouldn't we set that flag and check for it before waiting for the thread? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3319#note_40361

1 0

[PATCH v2 0/9] MR3418: Draft: Add tryok() for tests that may need multiple attempts to succeed
by Francois Gouget (＠fgouget) 26 Jul '23

26 Jul '23

This is meant to simplify testing conditions that generally hold true but may occasionally fail due to interference from external factors (such as processes that start / stop, network connections being opened / closed, etc). The trick is to loop a few times on the set of flaky conditions until they succeed. During the last attempt all failures are recorded as usual, while in the previous runs, the tryok() failures area ignored but cause one more attempt to be made. The simplest case looks like this: LOOP_ON_FLAKY_TESTS(3) { // ok() failures are never ignored and not retried ok(..., "check 1", ...); // tryok() failures are ignored except on the last attempt tryok(..., "check 2", ...); } There is also: * attempt_retry() which marks the current attempt as failed as if calling tryok(0), and returns true if another attempt can be made. * attempt_failed() which returns true if an ok() call failed. --- This is independent from the 'flaky' mechanism which adds some naming constraints. The loop macro is still called LOOP_ON_FLAKY_TESTS() despite being unrelated to the flaky mechanism. The attempt_retry() and attempt_failed() macro names also don't make it obvious that they are related to tryok(). I think this mechanism is better than the flaky one because a flaky test can go bad without anyone noticing, whereas if a tryok() starts failing systematically it will cause a real failure. The other side of that coin is that, unlike flaky, the tryok() mechanism does not entirely eliminate the possibility of getting a failure, it just reduces it; though by adjusting the maximum number of attempts one can achieve an arbitrarily low failure rate. For instance if an ok() call fails 10% of the time and one wants a maximum of 1 in a million failure rate, use LOOP_ON_FLAKY_TESTS(6). The cost is an increased run time in the worst case. This also limits the use of this mechanism to tests that have a reasonably low failure rate to start with (otherwise one has to loop too many times). Also note that there are cases where looping essentially reduce the failure rate to zero. For instance ieframe:webbrowser fails if IE creates a net session while the test is counting them. But IE only creates the one net session on start up so trying even one more time should guarantee that the test will succeed. Other cases like scheduling delays and the creation of network connections are more probabilistic in nature. Maybe a comment in test.h should offer some guideline as to the target failure rate. Eventually this may replace the flaky mechanism but that depends on how well it works in practice and how practical it is to loop on flaky tests. It seems to be going well in the few cases I looked at. But I think this mechanism has value even if the two end up coexisting indefinitely. This MR uses the tryok() in some actual tests for illustration and testing purposes. The final MR will probably split most of those off to separate MRs. -- v2: mmdevapi/tests: Replace flaky with tryok() in the capture tests. mmdevapi/tests: Replace flaky with tryok() in the render tests. quartz/tests: Replace flaky() with tryok() to work around scheduling delays. DEBUG ieframe/tests: tryok() framework testing ground. ieframe/tests: Work around a network session race condition. advapi32/tests: Replace the custom loop with tryok() mechanism. https://gitlab.winehq.org/wine/wine/-/merge_requests/3418

4 11

Re: [PATCH v3 0/1] MR3319: evr: Leave critical section before waiting for streaming thread.
by Santino Mazza (＠tati1454) 26 Jul '23

26 Jul '23

On Wed Jul 26 15:17:52 2023 +0000, Nikolay Sivov wrote: > This should be arranged differently, you can't generally assume that > you've entered this lock when calling the helper. mmm, what about adding a timeout for WaitForSingleObject and do the LeaveCriticalSection if the timeout passed? Not sure how long it should be. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3319#note_40359

1 0

[PATCH v5 0/5] MR219: vkd3d-shader: Implement tex2Dproj().
by Nikolay Sivov (＠nsivov) 26 Jul '23

26 Jul '23

-- v5: vkd3d-shader/hlsl: Implement texCUBEproj(). vkd3d-shader/d3dbc: Disallow 1D sampler types when writing sampler declaration. vkd3d-shader/hlsl: Implement tex3Dproj(). vkd3d-shader/hlsl: Implement tex1Dproj(). vkd3d-shader/hlsl: Implement tex2Dproj(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/219

2 5

Re: [PATCH v3 0/1] MR3319: evr: Leave critical section before waiting for streaming thread.
by Santino Mazza (＠tati1454) 26 Jul '23

26 Jul '23

On Wed Jul 26 15:17:52 2023 +0000, Nikolay Sivov wrote: > This does hang on my system, but is it reliable or is it depending on > calls made close one after another in time? It's definitely not a reliable way to test for this behavior, but I'm not sure how could I do it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3319#note_40353

1 0

Re: [PATCH v3 0/1] MR3319: evr: Leave critical section before waiting for streaming thread.
by Nikolay Sivov (＠nsivov) 26 Jul '23

26 Jul '23

Nikolay Sivov (@nsivov) commented about dlls/evr/presenter.c: > > PostThreadMessageW(presenter->thread.tid, EVRM_STOP, 0, 0); > > + /* Make sure streaming thread is not blocked by critical section before waiting for it. */ > + LeaveCriticalSection(&presenter->cs); > WaitForSingleObject(presenter->thread.hthread, INFINITE); > CloseHandle(presenter->thread.hthread); > + EnterCriticalSection(&presenter->cs); > This should be arranged differently, you can't generally assume that you've entered this lock when calling the helper. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3319#note_40348

1 0

Re: [PATCH v3 0/1] MR3319: evr: Leave critical section before waiting for streaming thread.
by Nikolay Sivov (＠nsivov) 26 Jul '23

26 Jul '23

Nikolay Sivov (@nsivov) commented about dlls/evr/tests/evr.c: > ok(diff <= 5, "Unexpected %lu%% diff\n", diff); > CoTaskMemFree(data); > > + /* Test behaviour when sending ENDSTREAMING message while processing input. */ > + hr = MFCreateVideoSampleFromSurface((IUnknown *)surface, &sample); > + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); > + IDirect3DSurface9_Release(surface); > + > + hr = IMFTransform_ProcessInput(mixer, 0, sample, 0); > + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); > + hr = IMFVideoPresenter_ProcessMessage(presenter, MFVP_MESSAGE_PROCESSINPUTNOTIFY, 0); > + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); > + IMFSample_Release(sample); > + > hr = IMFVideoPresenter_ProcessMessage(presenter, MFVP_MESSAGE_ENDSTREAMING, 0); > ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); This does hang on my system, but is it reliable or is it depending on calls made close one after another in time? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3319#note_40347

1 0

[PATCH v5 0/1] MR3393: dlls/kerberos: Implement KerbQueryTicketCacheExMessage.
by Maxim Karasev (＠mxkrsv) 26 Jul '23

26 Jul '23

Ensured to work with both the current `klist` implementation and the one modified to use KerbQueryTicketCacheExMessage. Patch for `klist` will be sent separately. -- v5: dlls/kerberos: Implement KerbQueryTicketCacheExMessage. https://gitlab.winehq.org/wine/wine/-/merge_requests/3393

3 2

[PATCH 0/9] MR3418: Draft: Add tryok() for tests that may need multiple attempts to succeed
by Francois Gouget (＠fgouget) 26 Jul '23

26 Jul '23

This is meant to simplify testing conditions that generally hold true but may occasionally fail due to interference from external factors (such as processes that start / stop, network connections being opened / closed, etc). The trick is to loop a few times on the set of flaky conditions until they succeed. During the last attempt all failures are recorded as usual, while in the previous runs, the tryok() failures area ignored but cause one more attempt to be made. The simplest case looks like this: LOOP_ON_FLAKY_TESTS(3) { // ok() failures are never ignored and not retried ok(..., "check 1", ...); // tryok() failures are ignored except on the last attempt tryok(..., "check 2", ...); } There is also: * attempt_retry() which marks the current attempt as failed as if calling tryok(0), and returns true if another attempt can be made. * attempt_failed() which returns true if an ok() call failed. --- This is independent from the 'flaky' mechanism which adds some naming constraints. The loop macro is still called LOOP_ON_FLAKY_TESTS() despite being unrelated to the flaky mechanism. The attempt_retry() and attempt_failed() macro names also don't make it obvious that they are related to tryok(). I think this mechanism is better than the flaky one because a flaky test can go bad without anyone noticing, whereas if a tryok() starts failing systematically it will cause a real failure. The other side of that coin is that, unlike flaky, the tryok() mechanism does not entirely eliminate the possibility of getting a failure, it just reduces it; though by adjusting the maximum number of attempts one can achieve an arbitrarily low failure rate. For instance if an ok() call fails 10% of the time and one wants a maximum of 1 in a million failure rate, use LOOP_ON_FLAKY_TESTS(6). The cost is an increased run time in the worst case. This also limits the use of this mechanism to tests that have a reasonably low failure rate to start with (otherwise one has to loop too many times). Also note that there are cases where looping essentially reduce the failure rate to zero. For instance ieframe:webbrowser fails if IE creates a net session while the test is counting them. But IE only creates the one net session on start up so trying even one more time should guarantee that the test will succeed. Other cases like scheduling delays and the creation of network connections are more probabilistic in nature. Maybe a comment in test.h should offer some guideline as to the target failure rate. Eventually this may replace the flaky mechanism but that depends on how well it works in practice and how practical it is to loop on flaky tests. It seems to be going well in the few cases I looked at. But I think this mechanism has value even if the two end up coexisting indefinitely. This MR uses the tryok() in some actual tests for illustration and testing purposes. The final MR will probably split most of those off to separate MRs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3418

3 10

[PATCH v2 0/1] MR3415: mfmediaengine: Add the trailing linefeed to a WARN() message.
by Francois Gouget (＠fgouget) 26 Jul '23

26 Jul '23

-- v2: mfmediaengine: Add the trailing linefeed to a WARN() message. https://gitlab.winehq.org/wine/wine/-/merge_requests/3415

3 3

[PATCH v4 0/2] MR240: vkd3d-shader: Add constant folding for the 'dot' operation.
by Nikolay Sivov (＠nsivov) 26 Jul '23

26 Jul '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v4: vkd3d-shader: Add constant folding for 'dp2add' operation. vkd3d-shader: Add constant folding for the 'dot' operation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/240

2 2

[PATCH v2 0/5] MR283: vkd3d-shader/dxil: Implement DX instruction StoreOutput.
by Conor McCarthy (＠cmccarthy) 26 Jul '23

26 Jul '23

-- v2: vkd3d-shader/dxil: Implement DX instruction StoreOutput. vkd3d-shader/dxil: Declare shader outputs. vkd3d-shader/dxil: Implement the DXIL CALL instruction. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/283

3 7

[PATCH v14 0/2] MR3391: mshtml: implement window.MutationObserver with MutationObserver stub
by Yuxuan Shui (＠yshui) 26 Jul '23

26 Jul '23

This get us pass the "Update your browser" blocker in adobe's sign-in page. The page itself doesn't make use of `window.MutationObserver`. However the sign-in page is still broken. -- v14: mshtml: add stubs for MutationObserver methods mshtml: implement window.MutationObserver with MutationObserver stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3391

4 11

[PATCH 0/1] MR3417: mshtml: Add some basic documentation for the dispex and its vtbl.
by Gabriel Ivăncescu (＠insn) 26 Jul '23

26 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3417

3 2

[PATCH v4 0/1] MR3392: comctl32/listview: Set bNoItemMetrics to TRUE in LISTVIEW_DeleteAllItems().
by Zhao Yi (＠Zhaoyi) 26 Jul '23

26 Jul '23

Same as MR !2394 Signed-off-by: Zhaoyi zhaoyi(a)uniontech.com -- v4: comctl32/listview: Set bNoItemMetrics to TRUE in LISTVIEW_DeleteAllItems(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3392

4 4

[PATCH 0/1] MR3409: mshtml: add some clarification to dispex_static_data_vtbl_t
by Yuxuan Shui (＠yshui) 26 Jul '23

26 Jul '23

Split from !3391, @insn -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3409

4 5

[PATCH 0/8] MR3408: mshtml: Implement Cycle Collection for all mshtml objects (dispex), part 1.
by Gabriel Ivăncescu (＠insn) 26 Jul '23

26 Jul '23

This is first part in a series that implements Cycle Collection for every mshtml object (dispex) and cleans up rest of the code based on it, which is obviously needed due to dynamic props and other extra object-specific refs. In an effort to split it up as much as possible, since it already has quite a lot of restructuring and changes, some of the earlier patches will introduce temporary leaks or cyclic refs, but that's because we'll later handle them properly with the dispex CC. These shouldn't affect behavior, though, so it shouldn't pose problems for functionality. Nodes are, initially, not changed much (other than to make it compatible with the dispex) to keep changes as small as possible. They still use their own CC mechanism and refcounting, which is hackish but that is solved in a follow-up MR, so it's temporary only. Eventually, every object (including nodes) will use the dispex's vtbl to do its Cycle Collection, except for stuff like outer window (which is a special case). In this first part, the objects that are using the node CC will have no-op dispex CC methods since they are using the node's, but this is temporary only. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3408

3 12

[PATCH v4 0/1] MR3393: dlls/kerberos: Implement KerbQueryTicketCacheExMessage.
by Maxim Karasev (＠mxkrsv) 26 Jul '23

26 Jul '23

Ensured to work with both the current `klist` implementation and the one modified to use KerbQueryTicketCacheExMessage. Patch for `klist` will be sent separately. -- v4: dlls/kerberos: Implement KerbQueryTicketCacheExMessage. https://gitlab.winehq.org/wine/wine/-/merge_requests/3393

4 3

[PATCH v2 0/1] MR3389: Use PCSC framework instead of pcsclite on macOS
by Gijs Vermeulen (＠gverm) 26 Jul '23

26 Jul '23

This framework is present in all macOS SDKs we support, starting at macOS 10.13 and still present in macOS Sonoma. Getting pcsclite completely working correctly is a lot harder on macOS and this would give us better integration. -- v2: configure: Use PCSC.framework when pcsclite is not available on macOS. https://gitlab.winehq.org/wine/wine/-/merge_requests/3389

3 3

[PATCH 0/1] MR3414: winex11.drv: Add a trailing linefeed to a WARN() message.
by Francois Gouget (＠fgouget) 26 Jul '23

26 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3414

3 2

2025

2024

2023

2022

wine-gitlab July 2023