July 2023 - wine-gitlab

[PATCH 0/1] MR3415: mfmediaengine: Add the trailing linefeed to a WARN() message.
by Francois Gouget (＠fgouget) 26 Jul '23

26 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3415

3 2

[PATCH 0/1] MR286: vkd3d: Implement ID3D12GraphicsCommandList3 with a stub.
by Conor McCarthy (＠cmccarthy) 26 Jul '23

26 Jul '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/286

3 2

[PATCH 0/4] MR3413: Assorted spelling fixes
by Francois Gouget (＠fgouget) 26 Jul '23

26 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3413

2 4

[PATCH 0/1] MR3361: gitlab: Skip amstream:amstream since it fails systematically.
by Francois Gouget (＠fgouget) 26 Jul '23

26 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55283 --- It has been causing every merge request to get a GitLab CI error ever since the move to Debian 12 on 2023-07-10. That makes the GitLab CI pretty horrible. If there is a quick fix for this issue then this MR can be ignored. Otherwise, since there is no way to tell the GitLab CI that a specific test is expected to crash or fail in a certain way, there is no other option than to skip the test entirely until it works again. Side-note: Finding failures in the GitLab CI logs is quite annoying. As far as I can tell the only way not to miss any is to perform a set of four searches: - "Test f" -> regular failures - "todo " -> Todo tests that unexpectedly succeed - "ne (2" -> Timeouts (and test units with 2 failures) - "ne (-" -> Crashes (with or without an 'unhandled exception' line) If anyone has an emacs macro to automate this... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3361

4 4

[PATCH 0/1] MR3412: ntdll/tests: Fix the NtSetInformationFile() test on Windows 10 <= 1709.
by Francois Gouget (＠fgouget) 26 Jul '23

26 Jul '23

It does not support FileDispositionInformationEx and returns various error codes. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55331 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3412

2 1

[PATCH v3 0/2] MR3392: comctl32/listview: Set bNoItemMetrics to TRUE in LISTVIEW_DeleteAllItems().
by Zhao Yi (＠Zhaoyi) 26 Jul '23

26 Jul '23

Same as MR !2394 Signed-off-by: Zhaoyi zhaoyi(a)uniontech.com -- v3: comctl32/listview: Set bNoItemMetrics to TRUE in LISTVIEW_DeleteAllItems(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3392

5 8

[PATCH 0/1] MR285: vkd3d: Handle the case where a descriptor is null and is concurrently written non-null.
by Conor McCarthy (＠cmccarthy) 26 Jul '23

26 Jul '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/285

4 3

[PATCH v2 0/1] MR3323: win32u: Don't clip captured mouse pointer only if it's done by the system.
by Gabriel Ivăncescu (＠insn) 26 Jul '23

26 Jul '23

-- v2: win32u: Don't clip captured mouse pointer only if it's done by the system. https://gitlab.winehq.org/wine/wine/-/merge_requests/3323

4 3

[PATCH 0/1] MR3411: dinput: Unacquire only DISCL_FOREGROUND devices on foreground changes.
by Rémi Bernon (＠rbernon) 26 Jul '23

26 Jul '23

Fixes broken input in Final Fantasy XIII after main window focus loss. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3411

2 1

[PATCH v3 0/3] MR3396: msvcrt: Further locale cleanups.
by Victor Hermann Chiletto (＠vitorhnn) 26 Jul '23

26 Jul '23

Fixes a memory leak and cleans up some other parts of MR !3050. -- v3: msvcrt: Remove uses of wcsncpy from locale_to_sname. https://gitlab.winehq.org/wine/wine/-/merge_requests/3396

2 4

[PATCH v2 0/3] MR3396: msvcrt: Further locale cleanups.
by Victor Hermann Chiletto (＠vitorhnn) 26 Jul '23

26 Jul '23

Fixes a memory leak and cleans up some other parts of MR !3050. -- v2: msvcrt: Remove uses of wcsncpy from locale_to_sname. https://gitlab.winehq.org/wine/wine/-/merge_requests/3396

4 8

[PATCH v3 0/2] MR3105: Add a few additional nullchecks (Coverity)
by Fabian Maurer (＠DarkShadow44) 26 Jul '23

26 Jul '23

-- v3: wineoss: Remove superflous check mmdevapi: Add nullcheck for parameter that can be null (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/3105

4 5

[PATCH v13 0/2] MR3391: mshtml: implement window.MutationObserver with MutationObserver stub
by Yuxuan Shui (＠yshui) 26 Jul '23

26 Jul '23

This get us pass the "Update your browser" blocker in adobe's sign-in page. The page itself doesn't make use of `window.MutationObserver`. However the sign-in page is still broken. -- v13: mshtml: add stubs for MutationObserver methods mshtml: implement window.MutationObserver with MutationObserver stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3391

3 3

[PATCH v12 0/1] MR3391: mshtml: implement window.MutationObserver with MutationObserver stub
by Yuxuan Shui (＠yshui) 25 Jul '23

25 Jul '23

This get us pass the "Update your browser" blocker in adobe's sign-in page. The page itself doesn't make use of `window.MutationObserver`. However the sign-in page is still broken. -- v12: mshtml: implement window.MutationObserver with MutationObserver stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3391

3 5

[PATCH v3 0/2] MR3351: mfmediaengine: Implement RemoveAllEffects().
by Bernhard Kölbl (＠besentv) 25 Jul '23

25 Jul '23

-- v3: mfmediaengine: Implement RemoveAllEffects(). mfmediaengine/tests: Add tests for RemoveAllEffects(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3351

3 6

[PATCH v3 0/1] MR3407: gdiplus: Disable StringFormatFlagsLineLimit
by David Kahurani (＠kahurani) 25 Jul '23

25 Jul '23

Builtin gdiplus behaves as documented but tests are indicating that Windows behaviour sometimes differs from the documentation. I believe this issue is at least one of the contributing issues to bug https://bugs.winehq.org/show_bug.cgi?id=46947, if not the sole issue. I propose that this flag be disabled until it is well understood. I noticed as issue with DrawString seeming to ignore the flag sometimes(sometimes the text fits without any noticeable defects which I believe is the case with the program in the bug) and sometimes even drawing clipped text with the flag on. Other times it works as expected. I can't seem to find a pattern to identify that could be used to predict its behaviour. Signed-off-by: David Kahurani k.kahurani(a)gmail.com -- v3: gdiplus: Disable StringFormatFlagsLineLimit https://gitlab.winehq.org/wine/wine/-/merge_requests/3407

3 3

[PATCH v3 0/1] MR3398: gdiplus: Prevent infinite loops due to floating point inaccuracy
by Fabian Maurer (＠DarkShadow44) 25 Jul '23

25 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52492 -- v3: gdiplus: Prevent infinite loops due to floating point inaccuracy https://gitlab.winehq.org/wine/wine/-/merge_requests/3398

4 4

Re: [PATCH v5 0/2] MR3363: windowscodecs: Handle PNG histogram (hIST) chunk type. - approved
by Esme Povirk (＠madewokherd) 25 Jul '23

25 Jul '23

This merge request was approved by Esme Povirk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3363

1 0

[PATCH v11 0/1] MR3391: mshtml: implement window.MutationObserver with MutationObserver stub
by Yuxuan Shui (＠yshui) 25 Jul '23

25 Jul '23

This get us pass the "Update your browser" blocker in adobe's sign-in page. The page itself doesn't make use of `window.MutationObserver`. However the sign-in page is still broken. -- v11: mshtml: implement window.MutationObserver with MutationObserver stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3391

3 2

[PATCH v3 0/1] MR3379: ntdll: Match Windows used block filling.
by Paul Gofman (＠gofman) 25 Jul '23

25 Jul '23

-- v3: ntdll: Match Windows used block filling. https://gitlab.winehq.org/wine/wine/-/merge_requests/3379

3 3

[PATCH 0/1] MR3410: advpack: Add nullcheck for parameter that can be null (Coverity)
by Fabian Maurer (＠DarkShadow44) 25 Jul '23

25 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3410

2 1

[PATCH v2 0/1] MR3379: ntdll: Match Windows used block filling.
by Paul Gofman (＠gofman) 25 Jul '23

25 Jul '23

-- v2: ntdll: Match Windows used block filling. https://gitlab.winehq.org/wine/wine/-/merge_requests/3379

4 7

[PATCH 0/1] MR3406: winegstreamer: Use a fixed size type for wg_sample data pointer.
by Rémi Bernon (＠rbernon) 25 Jul '23

25 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3406

3 2

[PATCH 0/1] MR268: vkd3d-shader/hlsl: Handle vector arguments in fmod().
by Nikolay Sivov (＠nsivov) 25 Jul '23

25 Jul '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/268

3 3

[PATCH 0/1] MR3379: ntdll: Match Windows used block filling.
by Paul Gofman (＠gofman) 25 Jul '23

25 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3379

3 4

[PATCH v2 0/2] MR3405: server: Use the capture window as cursor window if it is set.
by Rémi Bernon (＠rbernon) 25 Jul '23

25 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55306 -- v2: server: Use the capture window as cursor window if it is set. server: Update the desktop cursor position / window on click. https://gitlab.winehq.org/wine/wine/-/merge_requests/3405

2 2

[PATCH v2 0/1] MR3407: gdiplus: Disable StringFormatFlagsLineLimit
by David Kahurani (＠kahurani) 25 Jul '23

25 Jul '23

Builtin gdiplus behaves as documented but tests are indicating that Windows behaviour sometimes differs from the documentation. I believe this issue is at least one of the contributing issues to bug https://bugs.winehq.org/show_bug.cgi?id=46947, if not the sole issue. I propose that this flag be disabled until it is well understood. I noticed as issue with DrawString seeming to ignore the flag sometimes(sometimes the text fits without any noticeable defects which I believe is the case with the program in the bug) and sometimes even drawing clipped text with the flag on. Other times it works as expected. I can't seem to find a pattern to identify that could be used to predict its behaviour. Signed-off-by: David Kahurani k.kahurani(a)gmail.com -- v2: gdiplus: Disable StringFormatFlagsLineLimit https://gitlab.winehq.org/wine/wine/-/merge_requests/3407

3 2

[PATCH 0/1] MR3407: gdiplus: Disable StringFormatFlagsLineLimit
by David Kahurani (＠kahurani) 25 Jul '23

25 Jul '23

Builtin gdiplus behaves as documented but tests are indicating that Windows behaviour sometimes differs from the documentation. I believe this issue is at least one of the contributing issues to bug https://bugs.winehq.org/show_bug.cgi?id=46947, if not the sole issue. I propose that this flag be disabled until it is well understood. Signed-off-by: David Kahurani k.kahurani(a)gmail.com -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3407

3 2

[PATCH 0/1] MR3389: Use PCSC framework instead of pcsclite on macOS
by Gijs Vermeulen (＠gverm) 25 Jul '23

25 Jul '23

This framework is present in all macOS SDKs we support, starting at macOS 10.13 and still present in macOS Sonoma. Getting pcsclite completely working correctly is a lot harder on macOS and this would give us better integration. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3389

3 8

[PATCH 0/5] MR284: hlsl: Replace bare list pointers with hlsl_block, part 6.
by Zebediah Figura (＠zfigura) 25 Jul '23

25 Jul '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/284

4 7

[PATCH v5 0/1] MR279: vkd3d: Implement ID3D12Device1.
by Conor McCarthy (＠cmccarthy) 25 Jul '23

25 Jul '23

-- v5: vkd3d: Implement ID3D12Device1 with stubs. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/279

3 2

[PATCH 0/1] MR3405: server: Use the capture window as cursor window if it is set.
by Rémi Bernon (＠rbernon) 25 Jul '23

25 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55306 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3405

2 1

[PATCH 0/1] MR3403: server: Revert "server: Avoid using SOL_IPX to detect whether IPX is supported."
by Fotios Valasiadis (＠fvalasiad) 25 Jul '23

25 Jul '23

This reverts commit 41cc117b3f37ab4b9b4ac8a815cd2a496d38fb4b. This commit broke musl support. With the changes introduced, the following code evaluates to the #else branch without checking for SO_DEFAULT_HEADERS resulting in an error. server/sock.c +1888 ``` \#ifdef HAS_IPX int ipx_type = protocol - WS_NSPROTO_IPX; \#ifdef SOL_IPX setsockopt( sockfd, SOL_IPX, IPX_TYPE, &ipx_type, sizeof(ipx_type) ); \#else struct ipx val; /* Should we retrieve val using a getsockopt call and then * set the modified one? */ val.ipx_pt = ipx_type; setsockopt( sockfd, 0, SO_DEFAULT_HEADERS, &val, sizeof(val) ); \#endif \#endif ``` I propose reverting the commit, but we could probably alter the macro in the code section provided to match the changes relevant github issue: https://github.com/void-linux/void-packages/pull/45202 Signed-off-by: Fotios Valasiadis <fvalasiad(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3403

3 4

[PATCH v4 0/3] MR267: vkd3d: Implement GetResourceTiling().
by Conor McCarthy (＠cmccarthy) 25 Jul '23

25 Jul '23

-- v4: vkd3d: Implement ID3D12Device::GetResourceTiling() for textures. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/267

3 9

[PATCH v2 0/1] MR3393: dlls/kerberos: Implement KerbQueryTicketCacheExMessage.
by Maxim Karasev (＠mxkrsv) 25 Jul '23

25 Jul '23

Ensured to work with both the current `klist` implementation and the one modified to use KerbQueryTicketCacheExMessage. Patch for `klist` will be sent separately. -- v2: dlls/kerberos: Implement KerbQueryTicketCacheExMessage. https://gitlab.winehq.org/wine/wine/-/merge_requests/3393

3 3

[PATCH 0/4] MR3345: wined3d: Move struct wined3d_gl_info to struct wined3d_adapter_gl.
by Zebediah Figura (＠zfigura) 25 Jul '23

25 Jul '23

Get rid of the last few places in common code that read it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3345

3 5

[PATCH v8 0/1] MR3391: mshtml: implement window.MutationObserver with MutationObserver stub
by Yuxuan Shui (＠yshui) 25 Jul '23

25 Jul '23

This get us pass the "Update your browser" blocker in adobe's sign-in page. The page itself doesn't make use of `window.MutationObserver`. However the sign-in page is still broken. -- v8: mshtml: implement window.MutationObserver with MutationObserver stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3391

3 8

[PATCH v2 0/1] MR3343: d3d11/tests: Mark test failures specific to the Vulkan or GL renderers.
by Zebediah Figura (＠zfigura) 25 Jul '23

25 Jul '23

-- v2: d3d11/tests: Mark test failures specific to the Vulkan or GL renderers. https://gitlab.winehq.org/wine/wine/-/merge_requests/3343

4 3

[PATCH v2 0/4] MR3342: wined3d: Stateblock refactoring.
by Zebediah Figura (＠zfigura) 25 Jul '23

25 Jul '23

-- v2: wined3d: Store push constants in wined3d_buffers in struct wined3d_state. https://gitlab.winehq.org/wine/wine/-/merge_requests/3342

4 7

[PATCH v2 0/2] MR3397: Draft: ucrtbase: Do not modify rewind's stack arguments on i386.
by Victor Hermann Chiletto (＠vitorhnn) 25 Jul '23

25 Jul '23

[A mod for Fallout: New Vegas relies on rewind not modifying the first argument passed to it.](https://github.com/jazzisparis/UIO-User-Interface-Organizer/blob/426d9… Since it only links to api-ms-win-crt-stdio I've kept the thunk usage to just ucrtbase. -- v2: msvcrt, ucrtbase: Introduce wine_i386_rewind. ucrtbase/tests: Test some details about rewind's ABI. https://gitlab.winehq.org/wine/wine/-/merge_requests/3397

3 6

[PATCH 0/3] MR3396: msvcrt: Further locale cleanups.
by Victor Hermann Chiletto (＠vitorhnn) 25 Jul '23

25 Jul '23

Fixes a memory leak and cleans up some other parts of MR !3050. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3396

3 4

[PATCH 0/1] MR3404: userenv: Fix setting ALLUSERSPROFILE and ProgramData in CreateEnvironmentBlock.
by Piotr Caban (＠piotr) 25 Jul '23

25 Jul '23

This syncs the code with dlls/ntdll/unix/env.c add_registry_environment. It fixes ALLUSERSPROFILE and ProgramData environment variables value in services. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3404

2 1

[PATCH v4 0/3] MR417: riched20: Add font fallback support.
by Jactry Zeng (＠jactry) 25 Jul '23

25 Jul '23

Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> -- v4: riched20: Add font fallbacks for CJK. riched20: Add font fallback support. riched20: Use OpenType functions for painting and generating script tags. https://gitlab.winehq.org/wine/wine/-/merge_requests/417

4 10

[PATCH v2 0/3] MR3105: Add a few additional nullchecks (Coverity)
by Fabian Maurer (＠DarkShadow44) 25 Jul '23

25 Jul '23

-- v2: wineoss: Remove superflous check advpack: Add nullcheck for parameter that can be null (Coverity) mmdevapi: Add nullcheck for parameter that can be null (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/3105

4 7

[PATCH 0/9] MR3401: win32u: Use user message packing for more messages.
by Jacek Caban (＠jacek) 25 Jul '23

25 Jul '23

Continuation of !3388. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3401

3 10

[PATCH 0/1] MR3402: imm32: Hide the composition window if the string is empty.
by Rémi Bernon (＠rbernon) 25 Jul '23

25 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55258 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3402

2 1

[PATCH v2 0/1] MR3399: nsiproxy.sys: Detect wireless interface type on Linux.
by Paul Gofman (＠gofman) 25 Jul '23

25 Jul '23

-- v2: nsiproxy.sys: Detect wireless interface type on Linux. https://gitlab.winehq.org/wine/wine/-/merge_requests/3399

3 3

[PATCH v9 0/4] MR218: vkd3d-shader: Implement GetDimensions().
by Nikolay Sivov (＠nsivov) 25 Jul '23

25 Jul '23

-- v9: vkd3d-shader/tpf: Add support for writing 'resinfo' instruction. vkd3d-shader/tpf: Add support for writing 'sampleinfo' instruction. vkd3d-shader/hlsl: Parse GetDimensions() method. tests: Add some tests for GetDimensions(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/218

3 5

[PATCH 0/3] MR3400: Remove macro in win16 dlls
by Alistair Leslie-Hughes (＠alesliehughes) 25 Jul '23

25 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3400

2 3

[PATCH v3 0/11] MR3380: mmdevapi: Implement AudioClient_Create.
by Davide Beatrici (＠davidebeatrici) 25 Jul '23

25 Jul '23

-- v3: winepulse: Remove GetAudioSessionWrapper. wineoss: Remove GetAudioSessionWrapper. winecoreaudio: Remove GetAudioSessionWrapper. winealsa: Remove GetAudioSessionWrapper. mmdevapi: Implement AudioClient_Create. mmdevapi: Introduce wine_unix_call helper. mmdevapi: Import get_device_name_from_guid() from driver. winepulse: Export get_device_name_from_guid(). wineoss: Export get_device_name_from_guid(). winecoreaudio: Export get_device_name_from_guid(). winealsa: Export get_device_name_from_guid(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3380

3 12

[PATCH 0/1] MR3399: nsiproxy.sys: Detect wireless interface type on Linux.
by Paul Gofman (＠gofman) 25 Jul '23

25 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3399

2 2

[PATCH 0/1] MR3398: gdiplus: Prevent infinite loops due to floating point inaccuracy
by Fabian Maurer (＠DarkShadow44) 24 Jul '23

24 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52492 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3398

3 2

[PATCH v4 0/2] MR3363: windowscodecs: Handle PNG histogram (hIST) chunk type.
by Jeffrey Smith (＠whydoubt) 24 Jul '23

24 Jul '23

-- v4: windowscodecs: Handle PNG histogram (hIST) chunk type. https://gitlab.winehq.org/wine/wine/-/merge_requests/3363

3 4

Re: [PATCH v2 0/1] MR3383: winevulkan: Update to VK spec version 1.3.259. - approved
by Alexandre Julliard (＠julliard) 24 Jul '23

24 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3383

1 0

Re: [PATCH v2 0/1] MR3377: po: Update Lithuanian translation - approved
by Alexandre Julliard (＠julliard) 24 Jul '23

24 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3377

1 0

Re: [PATCH v2 0/1] MR3378: httpapi/tests: Do not test that a local TCP port is closed. - approved
by Alexandre Julliard (＠julliard) 24 Jul '23

24 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3378

1 0

Re: [PATCH v2 0/2] MR3384: ws2_32: Move the event reset in WSAEnumNetworkEvents() to the server. - approved
by Alexandre Julliard (＠julliard) 24 Jul '23

24 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3384

1 0

Re: [PATCH v2 0/5] MR3385: ws2_32/tests: Various test fixes. - approved
by Alexandre Julliard (＠julliard) 24 Jul '23

24 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3385

1 0

Re: [PATCH v2 0/1] MR3394: gdiplus: Make flatten_bezier iterative - approved
by Alexandre Julliard (＠julliard) 24 Jul '23

24 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3394

1 0

Re: [PATCH v3 0/5] MR3362: uiautomationcore: Add support for invoking COM event handlers and implement IUIAutomationFocusChangedEventHandler methods. - approved
by Alexandre Julliard (＠julliard) 24 Jul '23

24 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3362

1 0

Re: [PATCH v3 0/1] MR3387: gdiplus/font: Fix GdipGetLogFontW/A with gdi_transform - approved
by Alexandre Julliard (＠julliard) 24 Jul '23

24 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3387

1 0

Re: [PATCH v2 0/1] MR3209: xmllite: Eliminate DECLSPEC_HIDDEN. - approved
by Alexandre Julliard (＠julliard) 24 Jul '23

24 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3209

1 0

Re: [PATCH v2 0/2] MR3253: mf/tests: Miscellaneous fixes. - approved
by Alexandre Julliard (＠julliard) 24 Jul '23

24 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3253

1 0

Re: [PATCH v2 0/6] MR3359: gdiplus: Set GIF properties correctly. - approved
by Alexandre Julliard (＠julliard) 24 Jul '23

24 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3359

1 0

Re: [PATCH v2 0/3] MR3386: quartz, amstream: Three patches for amstream tests. - approved
by Alexandre Julliard (＠julliard) 24 Jul '23

24 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3386

1 0

Re: [PATCH v2 0/2] MR3278: windows.networking.hostname: Duplicate passed HSTRING in IHostNameFactory::CreateHostName(). - approved
by Alexandre Julliard (＠julliard) 24 Jul '23

24 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3278

1 0

Re: [PATCH v4 0/7] MR3271: windows.devices.usb: Implement IUsbDeviceStatics::GetDeviceSelectorVidPidOnly(). - approved
by Alexandre Julliard (＠julliard) 24 Jul '23

24 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3271

1 0

Re: [PATCH v2 0/5] MR3388: win32u: Introduce new message packing for user callbacks. - approved
by Alexandre Julliard (＠julliard) 24 Jul '23

24 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3388

1 0

Re: [PATCH v2 0/5] MR282: hlsl: Replace bare list pointers with hlsl_block, part 5. - approved
by Alexandre Julliard (＠julliard) 24 Jul '23

24 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/282

1 0

Re: [PATCH v9 0/4] MR261: vkd3d-shader: Add compiler option to specify matrix majority. - approved
by Alexandre Julliard (＠julliard) 24 Jul '23

24 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/261

1 0

Re: [PATCH v6 0/4] MR260: vkd3d: Prepare for buffering of command list commands. - approved
by Alexandre Julliard (＠julliard) 24 Jul '23

24 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/260

1 0

[PATCH 0/2] MR3394: gdiplus: Make flatten_bezier iterative
by Fabian Maurer (＠DarkShadow44) 24 Jul '23

24 Jul '23

Recursive code is pretty hard to debug, so I do think this makes sense. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3394

4 5

[PATCH v2 0/5] MR3362: uiautomationcore: Add support for invoking COM event handlers and implement IUIAutomationFocusChangedEventHandler methods.
by Connor McAdams (＠cmcadams) 24 Jul '23

24 Jul '23

-- v2: uiautomationcore: Implement IUIAutomation::{Add/Remove}FocusChangedEventHandler. https://gitlab.winehq.org/wine/wine/-/merge_requests/3362

3 7

[PATCH v2 0/1] MR3387: gdiplus/font: Fix GdipGetLogFontW/A with gdi_transform
by David Kahurani (＠kahurani) 24 Jul '23

24 Jul '23

These APIs should take into consideration the gdi_transform when calculating font properties Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v2: gdiplus/font: Fix GdipGetLogFontW/A with gdi_transform https://gitlab.winehq.org/wine/wine/-/merge_requests/3387

4 3

[PATCH v3 0/2] MR3363: windowscodecs: Handle PNG histogram (hIST) chunk type.
by Jeffrey Smith (＠whydoubt) 24 Jul '23

24 Jul '23

-- v3: windowscodecs: Handle PNG histogram (hIST) chunk type. https://gitlab.winehq.org/wine/wine/-/merge_requests/3363

3 3

[PATCH v7 0/2] MR3381: server: Try isolate wineserver directory.
by Konstantin Demin (＠rockdrilla) 24 Jul '23

24 Jul '23

try following locations for wineserver directory: - `${XDG_RUNTIME_DIR}/wine` - `/run/user/${uid}/wine` - `${TMPDIR}/wine` - only if `${TMPDIR}` is owned by user - `${TMPDIR}/.wine-${uid}` - `/tmp/.wine-${uid}` Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=39013 Signed-off-by: Konstantin Demin <rockdrilla(a)gmail.com> -- v7: server: Replace secure_getenv() with getenv(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3381

2 2

[PATCH v7 0/1] MR3391: mshtml: implement window.MutationObserver with MutationObserver stub
by Yuxuan Shui (＠yshui) 24 Jul '23

24 Jul '23

This get us pass the "Update your browser" blocker in adobe's sign-in page. The page itself doesn't make use of `window.MutationObserver`. However the sign-in page is still broken. -- v7: mshtml: implement window.MutationObserver with MutationObserver stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3391

2 1

[PATCH 0/2] MR3397: Draft: ucrtbase: Do not modify rewind's stack arguments on i386.
by Victor Hermann Chiletto (＠vitorhnn) 24 Jul '23

24 Jul '23

[A mod for Fallout: New Vegas relies on rewind not modifying the first argument passed to it.](https://github.com/jazzisparis/UIO-User-Interface-Organizer/blob/426d9… Since it only links to api-ms-win-crt-stdio I've kept the thunk usage to just ucrtbase. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3397

3 3

[PATCH v6 0/1] MR3391: mshtml: implement window.MutationObserver with MutationObserver stub
by Yuxuan Shui (＠yshui) 24 Jul '23

24 Jul '23

This get us pass the "Update your browser" blocker in adobe's sign-in page. The page itself doesn't make use of `window.MutationObserver`. However the sign-in page is still broken. -- v6: mshtml: implement window.MutationObserver with MutationObserver stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3391

4 10

[PATCH 0/1] MR3209: xmllite: Eliminate DECLSPEC_HIDDEN.
by Jinoh Kang (＠iamahuman) 24 Jul '23

24 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3209

3 2

[PATCH 0/5] MR282: hlsl: Replace bare list pointers with hlsl_block, part 5.
by Zebediah Figura (＠zfigura) 24 Jul '23

24 Jul '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/282

5 8

[PATCH v8 0/4] MR261: vkd3d-shader: Add compiler option to specify matrix majority.
by Nikolay Sivov (＠nsivov) 24 Jul '23

24 Jul '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v8: vkd3d-compiler: Add CLI option to specify default matrix packing order. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/261

3 6

[PATCH v5 0/4] MR260: vkd3d: Prepare for buffering of command list commands.
by Conor McCarthy (＠cmccarthy) 24 Jul '23

24 Jul '23

-- v5: vkd3d: Add a pending execution count to struct d3d12_command_signature. tests: Test releasing the command signature immediately after use. vkd3d: Store the command buffer in the allocator upon creation. vkd3d: Move descriptor heap tracking to d3d12_command_list_set_descriptor_table(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/260

3 5

[PATCH v2 0/8] MR281: vkd3d-shader/tpf: Replace sm4 register structs with vkd3d-shader register structs, part 1.
by Francisco Casas (＠fcasas) 24 Jul '23

24 Jul '23

Recap: I implemented relative addressing in !229, but I was suggested to handle register indexes by moving all the registers to the heap, which I did in my [nonconst-offsets-6](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/noncon… branch. A part of this implementation required !269, but I was asked to try to turn the sm4 register structs into the vkd3d-shader register structs instead, to get closer to a common low level IR. This is the first part of that transformation. The whole thing is in my [use_vkd3d_reg](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/use_vkd3d_r… branch. This is built on top of !225 (the first two patches), so it may be good to get that upstream first. --- This patch series aims to do the following replacements: ``` struct sm4_register -> struct vkd3d_shader_register struct sm4_dst_register -> struct vkd3d_shader_dst_param struct sm4_src_register -> struct vkd3d_shader_src_param ``` to get us closer to a common level IR and simplify the implementation of relative-addressing. To achieve this, the fields in the sm4 register structs are replaced with fields in the vkd3d-shader structs or removed altogether, one at the time. As can be seen when looking at the whole branch, it is possible to do this transformation without having to add additional fields to `struct vkd3d_shader_register`, by restricting each register type to a single `enum vkd3d_sm4_dimension` (and its src registers to a single `enum vkd3d_sm4_swizzle_type`) by default. The only exception we need so far is for sampler registers: They always have dimension NONE, except when used as arguments of gather instructions, in which case they have dimension VEC4 and SCALAR swizzle. This, and similar exceptions we may find in the future, can be handled using the opcode_info, as in 7/8 [81e17506](https://gitlab.winehq.org/fcasas/vkd3d/-/commit/81e17506ba2cb1fbf…. -- v2: vkd3d-shader/tpf: Get rid of sm4_register.dim. vkd3d-shader/tpf: Use 's' in src_info to expect sampler register with vec4 dimension. vkd3d-shader/tpf: Separate dst register write function. vkd3d-shader/tpf: Separate src register write function. vkd3d-shader/tpf: Make register_type_table an array of structs. vkd3d-shader/tpf: Use struct vkd3d_shader_register_index in sm4_register.idx[]. vkd3d-shader/tpf: Use enum vkd3d_shader_register_type in sm4_register.type. vkd3d-shader/tpf: Rename VKD3D_SM4_SWIZZLE_NONE as VKD3D_SM4_SWIZZLE_MASK4. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/281

5 20

[PATCH v4 0/1] MR279: vkd3d: Implement ID3D12Device1.
by Conor McCarthy (＠cmccarthy) 24 Jul '23

24 Jul '23

-- v4: vkd3d: Implement ID3D12Device1 with stubs. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/279

4 3

[PATCH v3 0/3] MR267: vkd3d: Implement GetResourceTiling().
by Conor McCarthy (＠cmccarthy) 24 Jul '23

24 Jul '23

-- v3: vkd3d: Implement ID3D12Device::GetResourceTiling() for textures. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/267

3 4

[PATCH v5 0/1] MR3391: mshtml: implement window.MutationObserver with MutationObserver stub
by Yuxuan Shui (＠yshui) 24 Jul '23

24 Jul '23

This get us pass the "Update your browser" blocker in adobe's sign-in page. The page itself doesn't make use of `window.MutationObserver`. However the sign-in page is still broken. -- v5: mshtml: implement window.MutationObserver with MutationObserver stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3391

3 7

[PATCH v6 0/2] MR3381: server: Try isolate wineserver directory.
by Konstantin Demin (＠rockdrilla) 24 Jul '23

24 Jul '23

try following locations for wineserver directory: - `${XDG_RUNTIME_DIR}/wine` - `/run/user/${uid}/wine` - `${TMPDIR}/wine` - only if `${TMPDIR}` is owned by user - `${TMPDIR}/.wine-${uid}` - `/tmp/.wine-${uid}` Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=39013 Signed-off-by: Konstantin Demin <rockdrilla(a)gmail.com> -- v6: server: Replace secure_getenv() with getenv(). server: Try isolate wineserver directory. https://gitlab.winehq.org/wine/wine/-/merge_requests/3381

2 2

[PATCH v5 0/1] MR3381: server: Try isolate wineserver directory.
by Konstantin Demin (＠rockdrilla) 24 Jul '23

24 Jul '23

try following locations for wineserver directory: - `${XDG_RUNTIME_DIR}/wine` - `/run/user/${uid}/wine` - `${TMPDIR}/wine` - only if `${TMPDIR}` is owned by user - `${TMPDIR}/.wine-${uid}` - `/tmp/.wine-${uid}` Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=39013 Signed-off-by: Konstantin Demin <rockdrilla(a)gmail.com> -- v5: server: Try isolate wineserver directory. https://gitlab.winehq.org/wine/wine/-/merge_requests/3381

3 5

[PATCH v4 0/1] MR3391: mshtml: implement window.MutationObserver with MutationObserver stub
by Yuxuan Shui (＠yshui) 24 Jul '23

24 Jul '23

This get us pass the "Update your browser" blocker in adobe's sign-in page. The page itself doesn't make use of `window.MutationObserver`. However the sign-in page is still broken. -- v4: mshtml: implement window.MutationObserver with MutationObserver stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3391

4 10

[PATCH 0/1] MR3393: dlls/kerberos: Implement KerbQueryTicketCacheExMessage.
by Maxim Karasev (＠mxkrsv) 24 Jul '23

24 Jul '23

Ensured to work with both the current `klist` implementation and the one modified to use KerbQueryTicketCacheExMessage. Patch for `klist` will be sent separately. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3393

2 1

[PATCH v3 0/1] MR3391: mshtml: implement window.MutationObserver with MutationObserver stub
by Yuxuan Shui (＠yshui) 24 Jul '23

24 Jul '23

This get us pass the "Update your browser" blocker in adobe's sign-in page. The page itself doesn't make use of `window.MutationObserver`. However the sign-in page is still broken. -- v3: mshtml: implement window.MutationObserver with MutationObserver stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3391

3 11

[PATCH v2 0/10] MR3380: mmdevapi: Implement AudioClient_Create.
by Davide Beatrici (＠davidebeatrici) 24 Jul '23

24 Jul '23

-- v2: winepulse: Remove GetAudioEndpoint and GetAudioSessionWrapper. wineoss: Remove GetAudioEndpoint and GetAudioSessionWrapper. winecoreaudio: Remove GetAudioEndpoint and GetAudioSessionWrapper. winealsa: Remove GetAudioEndpoint and GetAudioSessionWrapper. mmdevapi: Implement AudioClient_Create. https://gitlab.winehq.org/wine/wine/-/merge_requests/3380

3 13

[PATCH 0/2] MR3253: mf/tests: Miscellaneous fixes.
by Rémi Bernon (＠rbernon) 24 Jul '23

24 Jul '23

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/3245 as they are unrelated. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3253

3 4

[PATCH 0/2] MR3392: comctl32/listview: Set bNoItemMetrics to TRUE in LISTVIEW_DeleteAllItems().
by Zhao Yi (＠Zhaoyi) 24 Jul '23

24 Jul '23

Same patch as !2394 Signed-off-by: Zhaoyi zhaoyi(a)uniontech.com -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3392

3 3

[PATCH v2 0/1] MR3391: mshtml: implement window.MutationObserver with MutationObserver stub
by Yuxuan Shui (＠yshui) 24 Jul '23

24 Jul '23

This get us pass the "Update your browser" blocker in adobe's sign-in page. The page itself doesn't make use of `window.MutationObserver`. However the sign-in page is still broken. -- v2: mshtml: implement window.MutationObserver with MutationObserver stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3391

3 3

[PATCH 0/1] MR3391: mshtml: implement window.MutationObserver with MutationObserver stub
by Yuxuan Shui (＠yshui) 24 Jul '23

24 Jul '23

This get us pass the "Update your browser" blocker in adobe's sign-in page. The page itself doesn't make use of `window.MutationObserver`. However the sign-in page is still broken. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3391

2 1

[PATCH v2 0/3] MR3330: xinput: Fix WRC9 crashing on start
by Etaash Mathamsetty (＠etaash.mathamsetty) 24 Jul '23

24 Jul '23

This MR fixes WRC9 crashing on start with builtin xinput, since the game uses UWP xinput the ordinal numbers don't match up, so I decided to put these new exports with `@ stdcall` instead. When running winedump on the windows native dll, they don't have these exports at all :/ -- v2: xinput1_3: Add stub for XInputDestroy. xinput1_3: Add semi-stub for XInputSetStateEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/3330

5 12

[PATCH v3 0/7] MR3271: windows.devices.usb: Implement IUsbDeviceStatics::GetDeviceSelectorVidPidOnly().
by Mohamad Al-Jaf (＠maljaf) 24 Jul '23

24 Jul '23

Needed for Lenovo Ready for Assistant. -- v3: windows.devices.usb/tests: Add IUsbDeviceStatics::GetDeviceSelectorVidPidOnly() tests. windows.devices.usb: Implement IUsbDeviceStatics::GetDeviceSelectorVidPidOnly(). windows.devices.usb: Add IUsbDeviceStatics stub interface. windows.devices.usb: Add stub DLL. include: Add windows.devices.usb.idl file. include: Add support for IAsyncOperation parameterized type IBuffer. include: Add support for IAsyncOperation UINT32. https://gitlab.winehq.org/wine/wine/-/merge_requests/3271

3 9

[PATCH 0/5] MR3388: win32u: Introduce new message packing for user callbacks.
by Jacek Caban (＠jacek) 24 Jul '23

24 Jul '23

We currently try to preserve message's lparam value in win32u. This is inherited from user32 and it was needed in the past, but with !493 (and !646), this is mostly covered by leaving win32u out of winproc calls whenever possible. According to tests, native win32k almost never attempts to preserve lparam and copies its content instead (with a few exceptions for messages passing strings). Implementing that in Wine will provide a nice way to fix problem from bug 55152. This is the first patch in the series that will implement it. Since user callback requirements are different than server communication, the series incrementally decouples them. I created https://gitlab.winehq.org/jacek/wine/-/commits/win32u-msg/ with complete conversion for a better context. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3388

3 6

2025

2024

2023

2022

wine-gitlab July 2023