July 2023 - wine-gitlab

Re: [PATCH v2 0/1] MR3145: ntdll: Inherit ConsoleHandle only by CUI processes.
by Jacek Caban (＠jacek) 10 Jul '23

10 Jul '23

> It is indeed Wine-specific, but on Windows it isn't as much of a problem because AllocConsole gives you the same cmd you would use normally, while wineconsole is inferior to a normal terminal. I think that what you're looking for is `AttachConsole`. Depending details of process hierarchy, something `if (!AttachConsole(ATTACH_PARENT_PROCESS)) AllocConsole()` instead of plain `AllocConsole` should do what you want both on Windows and Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3145#note_38575

1 0

[PATCH v39 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 10 Jul '23

10 Jul '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are supported by this patch. -- v39: ws2_32/tests: Add test for AF_UNIX sockets fix. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ntdll/unix: Add support for AF_UNIX sockets to multiple functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

3 9

[PATCH v10 0/3] MR3075: winegstreamer: Implement Wow64 entrypoints in the Unix library.
by Kurt Kartaltepe (＠kkartaltepe) 10 Jul '23

10 Jul '23

This also converts the opaque pointers passed across the PE->Unix interface to opaque types represented as UINT64 which store the unix side pointer. This makes the thunking simpler and should avoid anyone accidently dereferencing the unix pointer in the PE code. This was tested with warcraft 3 (1.26, the last non-reforged release), and is consistent with the standard 32bit build. ~~But since movies on warcraft 3 are broken in standard 32bit builds I could only test that that the gstreamer graph gets built up similarly and not verify the video playback. Id appreciate if someone knew of a working exercise of the gstreamer code.~~ it works great, the issue with cinematics ended up being related to modesetting under xwayland, running with a virtual desktop in winecfg confirms playback working perfectly. -- v10: winegstreamer: Implement Wow64 entrypoints in the Unix library. winegstreamer: Replace ambiguously sized/aligned elements winegstreamer: Replace pointers with handles in PE->Unix transition https://gitlab.winehq.org/wine/wine/-/merge_requests/3075

3 4

Re: [PATCH v3 0/2] MR3259: Add environment variable to isolate WINEPREFIX at creation
by Fabian Maurer (＠DarkShadow44) 10 Jul '23

10 Jul '23

On Mon Jul 10 16:57:51 2023 +0000, Alex Henrie wrote: > If thread safety matters here, could you use strtok_r? I'm not sure if it does, just wanted to make sure there is no race conditions. Not sure why I missed strtok_r, thanks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3259#note_38565

1 0

Re: [PATCH v2 0/1] MR3145: ntdll: Inherit ConsoleHandle only by CUI processes.
by eric pouech (＠epo) 10 Jul '23

10 Jul '23

On Mon Jul 10 16:55:59 2023 +0000, Vladislav Timonin wrote: > > we should test the behavior of ctrl-c > I'm bit late to be reporting this :smile:, but Ctrl-C in (probably all) > `-mwindows` Wine apps is now ignored (`winecfg`, `regedit`, etc). On the > Windows apps side of things, at least Notepad++ also doesn't close on Ctrl-C. this https://gitlab.winehq.org/wine/wine/-/merge_requests/3290 should help -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3145#note_38560

1 0

[PATCH 0/4] MR3289: wine{alsa,coreaudio,oss,pulse}: Set zero_bits correctly for large address aware applications on Wow64.
by Brendan Shanks (＠bshanks) 10 Jul '23

10 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3289

3 5

[PATCH 0/2] MR3259: Add environment variable to isolate WINEPREFIX at creation
by Fabian Maurer (＠DarkShadow44) 10 Jul '23

10 Jul '23

I'm aware that winecfg allows unlinking of symlinked folders, but this is very annoying when regularly recreating WINEPREFIXES. This change makes it easy to isolate those folders from the start. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3259

3 4

Re: [PATCH v2 0/1] MR3145: ntdll: Inherit ConsoleHandle only by CUI processes.
by Vladislav Timonin (＠vt) 10 Jul '23

10 Jul '23

> we should test the behavior of ctrl-c I'm bit late to be reporting this :smile:, but Ctrl-C in (probably all) `-mwindows` Wine apps is now ignored (`winecfg`, `regedit`, etc). On the Windows apps side of things, at least Notepad++ also doesn't close on Ctrl-C. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3145#note_38548

1 0

[PATCH v4 0/7] MR259: vkd3d-shader/dxil: Read the DXIL module.
by Conor McCarthy (＠cmccarthy) 10 Jul '23

10 Jul '23

-- v4: vkd3d-shader/dxil: Read function bodies. vkd3d-shader/dxil: Read numeric constants. vkd3d-shader/dxil: Read global function declarations. vkd3d-shader/dxil: Validate the module format version. vkd3d-shader/dxil: Read the value symbol table. vkd3d-shader/dxil: Read the type table. vkd3d-shader/dxil: Use size_t where applicable. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/259

4 11

Re: [PATCH v2 0/1] MR3145: ntdll: Inherit ConsoleHandle only by CUI processes.
by eric pouech (＠epo) 10 Jul '23

10 Jul '23

On Mon Jul 10 15:59:56 2023 +0000, Jakub Staroń wrote: > It is indeed Wine-specific, but on Windows it isn't as much of a problem > because AllocConsole gives you the same cmd you would use normally, > while wineconsole is inferior to a normal terminal. Also is there any > reason to explicitly block console output on GUI apps? If I understand > it correctly on Windows it's done because otherwise a new console window > is created, wine doesn't do that though? all these four configurations should behave the same way regarding log output: 1) app on wine being run from a unix shell 2) app on wine being from with wineconsole 3) app on wine being run from a cmd window 4) app on windows being run from a cmd window if you see a discrepancy in output between 2 of these four items, please report (or even better file a bug report) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3145#note_38542

1 0

[PATCH 0/1] MR3279: gdiplus: Dash pattern scaling does not shrink below line width 1.0.
by Jeffrey Smith (＠whydoubt) 10 Jul '23

10 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3279

3 2

Re: [PATCH v2 0/1] MR3145: ntdll: Inherit ConsoleHandle only by CUI processes.
by Jakub Staroń (＠js6pak) 10 Jul '23

10 Jul '23

On Mon Jul 10 14:53:19 2023 +0000, Jacek Caban wrote: > Is it some Wine-specific use case? I think that something like that > would not work on Windows. It is indeed Wine-specific, but on Windows it isn't as much of a problem because AllocConsole gives you the same cmd you would use normally, while wineconsole is inferior to a normal terminal. Also is there any reason to explicitly block console output on GUI apps? If I understand it correctly on Windows it's done because otherwise a new console window is created, wine doesn't do that though? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3145#note_38539

1 0

[PATCH v11 0/1] MR2710: ntdll: Implement efficiency class reporting for intel hybrid CPUs.
by Torge Matthies (＠tmatthies) 10 Jul '23

10 Jul '23

Signed-off-by: Torge Matthies <tmatthies(a)codeweavers.com> -- v11: ntdll: Implement efficiency class reporting for intel hybrid CPUs. https://gitlab.winehq.org/wine/wine/-/merge_requests/2710

3 3

Re: [PATCH v2 0/1] MR3145: ntdll: Inherit ConsoleHandle only by CUI processes.
by Jacek Caban (＠jacek) 10 Jul '23

10 Jul '23

On Mon Jul 10 14:53:19 2023 +0000, Jakub Staroń wrote: > I know it's relying on broken behavior but before this PR it was nice to > be able to log to the terminal from GUI apps (!3022 would be a much > nicer solution for that). Does anyone know if there is a workaround to > be still able to do that? My main issue is that wineconsole is way > slower than normal terminal emulators. Is it some Wine-specific use case? I think that something like that would not work on Windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3145#note_38531

1 0

Re: [PATCH v10 0/1] MR2710: ntdll: Implement efficiency class reporting for intel hybrid CPUs.
by Huw Davies (＠huw) 10 Jul '23

10 Jul '23

Huw Davies (@huw) commented about dlls/ntdll/unix/system.c: > + performance_cores = calloc(16, sizeof(ULONG)); > + if (!performance_cores) goto done; > + performance_cores_capacity = 16; > + > + while (!feof(fpcore_list) && op == ',') > + { > + if (!fscanf(fpcore_list, "%u %c ", &beg, &op)) break; > + if (op == '-') fscanf(fpcore_list, "%u %c ", &end, &op); > + else end = beg; > + > + for(i = beg; i <= end; i++) > + { > + if (i / 32 > performance_cores_capacity) > + { > + p = realloc(performance_cores, performance_cores_capacity * 2 * sizeof(ULONG)); > + if (!p) break; At this point one might as well return from the function. ```suggestion:-0+0 if (!p) goto done; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2710#note_38529

1 0

Re: [PATCH v2 0/1] MR3145: ntdll: Inherit ConsoleHandle only by CUI processes.
by Jakub Staroń (＠js6pak) 10 Jul '23

10 Jul '23

I know it's relying on broken behavior but before this PR it was nice to be able to log to the terminal from GUI apps (!3022 would be a much nicer solution for that). Does anyone know if there is a workaround to be still able to do that? My main issue is that wineconsole is way slower than normal terminal emulators. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3145#note_38528

1 0

[PATCH v8 0/1] MR3275: po: Add Georgian translation.
by Ekaterine Papava (＠EkaterinePapava) 10 Jul '23

10 Jul '23

po: Add Georgian translation. -- v8: po: Add Georgian translation. https://gitlab.winehq.org/wine/wine/-/merge_requests/3275

2 1

[PATCH v7 0/2] MR3275: po: Add Georgian translation.
by Ekaterine Papava (＠EkaterinePapava) 10 Jul '23

10 Jul '23

po: Add Georgian translation. -- v7: Update ka.po: Fix accelerator string https://gitlab.winehq.org/wine/wine/-/merge_requests/3275

2 4

[PATCH 0/5] MR3284: win32u: Always use NtCallbackReturn to return result from client callbacks.
by Jacek Caban (＠jacek) 10 Jul '23

10 Jul '23

We needed an alternative mechanism for cases when we couldn't assume that we're running on Unix stack. It's no longer needed, so we can get rid of it now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3284

3 6

[PATCH 0/1] MR241: vkd3d-shader/spirv: Add support for VKD3DSIM_LINEAR_NOPERSPECTIVE_SAMPLE interpolation qualifier.
by Andrey Gusev (＠agusev) 10 Jul '23

10 Jul '23

Used by F1 2018. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/241

5 5

[PATCH 0/1] MR253: vkd3d-shader/hlsl: Skip unallocated variables when looking for reservation conflicts.
by Zebediah Figura (＠zfigura) 10 Jul '23

10 Jul '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/253

4 4

[PATCH v6 0/1] MR3275: po: Add Georgian translation.
by Ekaterine Papava (＠EkaterinePapava) 10 Jul '23

10 Jul '23

po: Add Georgian translation. -- v6: po: Add Georgian translation. https://gitlab.winehq.org/wine/wine/-/merge_requests/3275

4 3

[PATCH 0/1] MR3286: wow64: Return STATUS_NOT_IMPLEMENTED from wow64_NtSetInformationToken().
by Sven Baars (＠sbaars) 10 Jul '23

10 Jul '23

This fixes the advapi32 tests on WoW64. This way it matches NtSetInformationToken. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3286

2 1

[PATCH 0/1] MR3285: wineboot: Always attempt setup for all machine types
by Billy Laws (＠bylaws) 10 Jul '23

10 Jul '23

Without this, wineboot would bail out on ARM64 in the case where x86_64 WOW is not available but i386 is, leaving an incomplete prefix without any clear error. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3285

2 1

[PATCH 0/1] MR3283: wow64win: Call NtUserSetClassLongPtr() from wow64_NtUserSetClassLongPtr().
by Sven Baars (＠sbaars) 10 Jul '23

10 Jul '23

This fixes the user32:class tests on WoW64. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3283

3 2

Re: [PATCH v5 0/1] MR2228: bcryptprimitives: ProcessPrng stub - approved
by Hans Leidekker (＠hans) 10 Jul '23

10 Jul '23

This merge request was approved by Hans Leidekker. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2228

1 0

[PATCH 0/9] MR3281: Remove DECLSPEC_HIDDEN macro.
by Alistair Leslie-Hughes (＠alesliehughes) 10 Jul '23

10 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3281

2 9

[PATCH 0/1] MR3267: win32u: Set zero_bits correctly for large address aware applications on Wow64.
by Brendan Shanks (＠bshanks) 10 Jul '23

10 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3267

3 2

[PATCH 0/1] MR3274: wineps: Buffer data sent to printer port.
by Piotr Caban (＠piotr) 10 Jul '23

10 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3274

3 2

[PATCH 0/1] MR3273: wineps: Fix SetTextJustification playback with 0 count parameter.
by Piotr Caban (＠piotr) 10 Jul '23

10 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55078 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3273

4 3

[PATCH v2 0/7] MR3271: windows.devices.usb: Implement IUsbDeviceStatics::GetDeviceSelectorVidPidOnly().
by Mohamad Al-Jaf (＠maljaf) 10 Jul '23

10 Jul '23

Needed for Lenovo Ready for Assistant. -- v2: windows.devices.usb/tests: Add IUsbDeviceStatics::GetDeviceSelectorVidPidOnly() tests. windows.devices.usb: Implement IUsbDeviceStatics::GetDeviceSelectorVidPidOnly(). windows.devices.usb: Add IUsbDeviceStatics stub interface. windows.devices.usb: Add stub DLL. include: Add windows.devices.usb.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/3271

2 10

[PATCH v10 0/1] MR3114: comctl32: Make sure the type is sLink to increase id.
by Zhao Yi (＠Zhaoyi) 10 Jul '23

10 Jul '23

Fix the issue of incorrect linkid calculation due to a lack of judgment on the current type. Signed-off-by: Zhaoyi <zhaoyi(a)uniontech.com> -- v10: comctl32/tests: Add a test case to get syslinkid. https://gitlab.winehq.org/wine/wine/-/merge_requests/3114

2 1

Re: [PATCH v5 0/8] MR3249: windows.networking.hostname: Implement IHostNameFactory::CreateHostName().
by Mohamad Al-Jaf (＠maljaf) 10 Jul '23

10 Jul '23

On Sat Jul 8 07:23:37 2023 +0000, Rémi Bernon wrote: > You should only call `WindowsDeleteString` if the refcount gets to 0 > (and then you should also free the hostname, which I also missed). Yeah, sorry for missing that. I've just been very burned out with life in general. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3249#note_38470

1 0

[PATCH v4 0/2] MR3275: po: Add Georgian translation.
by Ekaterine Papava (＠EkaterinePapava) 10 Jul '23

10 Jul '23

po: Add Georgian translation. -- v4: Update ka.po https://gitlab.winehq.org/wine/wine/-/merge_requests/3275

3 4

[PATCH v3 0/1] MR3275: po: Add Georgian translation.
by Ekaterine Papava (＠EkaterinePapava) 10 Jul '23

10 Jul '23

po: Add Georgian translation. -- v3: po: Add Georgian translation. https://gitlab.winehq.org/wine/wine/-/merge_requests/3275

4 3

[PATCH v2 0/1] MR3275: po: Add Georgian translation.
by Ekaterine Papava (＠EkaterinePapava) 10 Jul '23

10 Jul '23

po: Add Georgian translation. -- v2: po: Add Georgian translation. https://gitlab.winehq.org/wine/wine/-/merge_requests/3275

3 3

[PATCH 0/2] MR3275: po: Add Georgian translation
by EkaterinePapava (＠EkaterinePapava) 10 Jul '23

10 Jul '23

po: Add Georgian translation -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3275

4 4

Re: [PATCH v9 0/2] MR3114: comctl32: Make sure the type is sLink to increase id.
by Zhiyi Zhang (＠zhiyi) 10 Jul '23

10 Jul '23

On Mon Jul 10 01:45:21 2023 +0000, Zhao Yi wrote: > Thank you for reviewing my code and I will fix the above issue later. There is no need to rush this. Please take your time to carefully review the code by yourself before submitting it for review. Look out for coding style issues and review each line you've changed. Overall, the fix looks good. Thanks for your work. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3114#note_38455

1 0

Re: [PATCH v9 0/2] MR3114: comctl32: Make sure the type is sLink to increase id.
by Zhiyi Zhang (＠zhiyi) 10 Jul '23

10 Jul '23

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/syslink.c: > HWND hWndSysLink; > > /* Only Unicode will do here */ > - hWndSysLink = CreateWindowExW(0, WC_LINK, L"Head <a href=\"link1\">Name1</a> Middle <a href=\"link2\">Name2</a> Tail", > + hWndSysLink = CreateWindowExW(0, WC_LINK, L"Head <a href=\"link1\">Name1</a> Middle <a href=\"link2\">Name2</a> Middle <a href=\"link3\">Name3</a> Tail", Do you really need to create a link3? Can't you use link2? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3114#note_38454

1 0

Re: [PATCH v9 0/2] MR3114: comctl32: Make sure the type is sLink to increase id.
by Zhiyi Zhang (＠zhiyi) 10 Jul '23

10 Jul '23

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/syslink.c: > +static void test_GETSYSLINKID(void) > +{ > + HWND hwnd; > + int point; > + > + hwnd = create_syslink(WS_CHILD | WS_TABSTOP | WS_VISIBLE, hWndParent); > + ok(hwnd != NULL, "Failed to create SysLink window.\n"); > + > + /*the test point of link3(x=120 y=20).*/ > + point = ((20 << 16) | 120); > + > + SendMessageA(hwnd, WM_LBUTTONDOWN, 1, (LPARAM)point); > + > + g_linkid = 0; > + SendMessageA(hwnd, WM_LBUTTONUP, 0, (LPARAM)point); > + todo_wine ok(g_linkid == 2, "GETSYSLINKID was not processed correctly!\n"); Rename g_linkid to g_link_id. Rename the function to test_link_id(). Change this line to todo_wine ok(g_link_id == 2, "Got unexpected link id %d.\n", g_link_id); -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3114#note_38453

1 0

Re: [PATCH v9 0/2] MR3114: comctl32: Make sure the type is sLink to increase id.
by Zhiyi Zhang (＠zhiyi) 10 Jul '23

10 Jul '23

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/syslink.c: > } > > defwndproc_counter++; > - ret = DefWindowProcW(hwnd, message, wParam, lParam); > + switch(message) You only need to record nml->item.iLink so you don't really need to process the message. So you can move this switch statement before defwndproc_counter++ and let the DefWindowProcW() handle it. Basically, add a switch statement, record nml->item.iLink from WM_NOTIFY, and break on other messages. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3114#note_38452

1 0

Re: [PATCH v9 0/2] MR3114: comctl32: Make sure the type is sLink to increase id.
by Zhiyi Zhang (＠zhiyi) 10 Jul '23

10 Jul '23

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/syslink.c: > You can change the commit subject to "comctl32/syslink: Check item type before increasing link ID in SYSLINK_LinkAtPt()." -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3114#note_38451

1 0

Re: [PATCH v9 0/2] MR3114: comctl32: Make sure the type is sLink to increase id.
by Zhao Yi (＠Zhaoyi) 10 Jul '23

10 Jul '23

On Mon Jul 10 01:38:24 2023 +0000, Zhiyi Zhang wrote: > Remove the extra space before ; Thank you for reviewing my code and I will fix the above issue later. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3114#note_38450

1 0

Re: [PATCH v9 0/2] MR3114: comctl32: Make sure the type is sLink to increase id.
by Zhiyi Zhang (＠zhiyi) 10 Jul '23

10 Jul '23

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/syslink.c: > } > > defwndproc_counter++; > - ret = DefWindowProcW(hwnd, message, wParam, lParam); > + switch(message) > + { > + case WM_NOTIFY: > + { > + NMLINK *nml = ((NMLINK*)lParam); > + if (nml && NM_CLICK == nml->hdr.code) > + { > + g_linkid = nml->item.iLink ; Remove the extra space before ; -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3114#note_38449

1 0

Re: [PATCH v9 0/2] MR3114: comctl32: Make sure the type is sLink to increase id.
by Zhiyi Zhang (＠zhiyi) 10 Jul '23

10 Jul '23

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/syslink.c: > } > > defwndproc_counter++; > - ret = DefWindowProcW(hwnd, message, wParam, lParam); > + switch(message) > + { > + case WM_NOTIFY: > + { > + NMLINK *nml = ((NMLINK*)lParam); Change "NMLINK*" to "NMLINK *" -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3114#note_38448

1 0

Re: [PATCH v9 0/2] MR3114: comctl32: Make sure the type is sLink to increase id.
by Zhiyi Zhang (＠zhiyi) 10 Jul '23

10 Jul '23

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/syslink.c: > DestroyWindow(hwnd); > } > > +static void test_GETSYSLINKID(void) > +{ > + HWND hwnd; > + int point; > + > + hwnd = create_syslink(WS_CHILD | WS_TABSTOP | WS_VISIBLE, hWndParent); > + ok(hwnd != NULL, "Failed to create SysLink window.\n"); > + > + /*the test point of link3(x=120 y=20).*/ Add a space after /* and before */ -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3114#note_38447

1 0

Re: [PATCH v9 0/2] MR3114: comctl32: Make sure the type is sLink to increase id.
by Zhiyi Zhang (＠zhiyi) 10 Jul '23

10 Jul '23

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/syslink.c: > DestroyWindow(hwnd); > } > > +static void test_GETSYSLINKID(void) > +{ > + HWND hwnd; > + int point; > + > + hwnd = create_syslink(WS_CHILD | WS_TABSTOP | WS_VISIBLE, hWndParent); > + ok(hwnd != NULL, "Failed to create SysLink window.\n"); > + > + /*the test point of link3(x=120 y=20).*/ > + point = ((20 << 16) | 120); You can use MAKELPARAM(120, 20) here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3114#note_38446

1 0

[PATCH 0/1] MR3276: user32/tests: Remove DrawTextEx tests that overrun stack variable
by Fabian Maurer (＠DarkShadow44) 09 Jul '23

09 Jul '23

Fixes regression introduced by 35c8f15bc67f7602438fe0c39a69ff6ddf6b8297 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55215 We already test for an invalid pointer, those tests don't really help. The test against DrawTextA crashes on windows sometimes, the other test shows that windows probably just overruns the stack variable: `textheight = DrawTextExA((HDC)0xdeadbeef, (LPSTR)0xdeadbeef, 100, &rect, 0, 0);` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3276

2 1

[PATCH v4 0/8] MR3050: msvcrt: Switch to using snames for create_locinfo.
by Victor Hermann Chiletto (＠vitorhnn) 09 Jul '23

09 Jul '23

This MR attempts to bring Wine's handling of `setlocale` and `_create_locale` more in line with the behavior of native >= `msvcr110`. It does this by replacing the usage of the LCID based `GetLocaleInfo` with the sname based `GetLocaleInfoEx`. `GetLocaleInfo` doesn't support neutral locales, even on native, which causes problems with neutral Chinese locales like `zh-Hans` and `zh-Hant`. It also improves the accuracy of the internal `__lc_locale_name_func`, as tests indicate that it returns `LOCALE_SNAME`s instead of ISO 639 language names. Potential future improvements: * Modifying the generation of the `pclmap` and `pcumap` fields of `threadlocaleinfostruct` to work on WCHARs. * I've done some changes to `__thread_data` which make it not fully match native, I'll submit a follow up which fixes this. -- v4: make_unicode: rename Hong Kong SAR China to Hong Kong SAR to match native behavior. msvcrt: Use GetLocaleInfoEx to compare locale info. msvcrt: Remap synonyms to snames. msvcrt: Skip exhaustive locale search with valid snames. msvcrt: Convert locale_to_LCID to snames. msvcrt: Use snames instead of LCIDs in create_locinfo. msvcr120/tests: Check ___lc_locale_name_func with neutral Chinese locales. msvcr110/tests: Add tests for new setlocale behaviors. https://gitlab.winehq.org/wine/wine/-/merge_requests/3050

3 13

Re: [PATCH v4 0/1] MR3049: user32: Ignore invalid parameters in DrawTextEx when HDC is invalid
by Francois Gouget (＠fgouget) 09 Jul '23

09 Jul '23

This introduces a new test failure on Windows as predicted by the TestBot: https://bugs.winehq.org/show_bug.cgi?id=55215 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3049#note_38430

1 0

2025

2024

2023

2022

wine-gitlab July 2023