July 2023 - wine-gitlab

Re: [PATCH v15 0/7] MR3189: Add windows.devices.geolocation.geolocator
by Mohamad Al-Jaf (＠maljaf) 06 Jul '23

06 Jul '23

Mohamad Al-Jaf (@maljaf) commented about dlls/windows.devices.geolocation.geolocator/Makefile.in: > +MODULE = windows.devices.geolocation.geolocator.dll Isn't this supposed to be in `geolocation.dll`? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3189#note_38255

1 0

Re: [PATCH v15 0/7] MR3189: Add windows.devices.geolocation.geolocator - approved
by Alexandre Julliard (＠julliard) 06 Jul '23

06 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3189

1 0

Re: [PATCH v2 0/1] MR3258: wow64win: Fix NULL buffer handling in wow64_NtUserBuildHimcList. - approved
by Alexandre Julliard (＠julliard) 06 Jul '23

06 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3258

1 0

Re: [PATCH v3 0/1] MR3058: kerberos: Avoid potentially uninitialized variable (clang-scan) - approved
by Alexandre Julliard (＠julliard) 06 Jul '23

06 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3058

1 0

Re: [PATCH v2 0/1] MR3250: include: Add IsReparseTagNameSurrogate. - approved
by Alexandre Julliard (＠julliard) 06 Jul '23

06 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3250

1 0

Re: [PATCH v2 0/1] MR3248: include: Add REPARSE_(GUID_)DATA_BUFFER and related constants. - approved
by Alexandre Julliard (＠julliard) 06 Jul '23

06 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3248

1 0

Re: [PATCH v2 0/1] MR3252: dbghelp: Use nameless union/structs. - approved
by Alexandre Julliard (＠julliard) 06 Jul '23

06 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3252

1 0

Re: [PATCH v3 0/5] MR3256: Use nameless structs/unions for VARIANT struct (Clang build fixes) - approved
by Alexandre Julliard (＠julliard) 06 Jul '23

06 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3256

1 0

Re: [PATCH v2 0/3] MR3254: Remove DECLSPEC_HIDDEN for internet dll - approved
by Alexandre Julliard (＠julliard) 06 Jul '23

06 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3254

1 0

Re: [PATCH v4 0/4] MR3234: winewayland.drv: part 5: window_surface flush optimizations - approved
by Alexandre Julliard (＠julliard) 06 Jul '23

06 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3234

1 0

Re: [PATCH v7 0/1] MR1153: winex11.drv: Correctly handle clipping for fullscreen windows. - approved
by Alexandre Julliard (＠julliard) 06 Jul '23

06 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1153

1 0

Re: [PATCH v4 0/1] MR3085: vbscript: Use correct pointer type in add_match (scan-build). - approved
by Alexandre Julliard (＠julliard) 06 Jul '23

06 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3085

1 0

Re: [PATCH v17 0/2] MR2778: mfmediaengine: Add support for video effects. - approved
by Alexandre Julliard (＠julliard) 06 Jul '23

06 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2778

1 0

Re: [PATCH v2 0/4] MR3251: secur32/tests: Fix a test failure. - approved
by Alexandre Julliard (＠julliard) 06 Jul '23

06 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3251

1 0

Re: [PATCH v3 0/2] MR266: Document vkd3d_acquire_vk_queue() and vkd3d_release_vk_queue(). - approved
by Alexandre Julliard (＠julliard) 06 Jul '23

06 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/266

1 0

Re: [PATCH v2 0/1] MR262: vkd3d: Make CopyResource use a temp buffer for depth <-> color copies - approved
by Alexandre Julliard (＠julliard) 06 Jul '23

06 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/262

1 0

[PATCH v14 0/7] MR3189: Add windows.devices.geolocation.geolocator
by Fabian Maurer (＠DarkShadow44) 06 Jul '23

06 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55126 -- v14: windows.devices.geolocation.geolocator: Implement IWeakReference. windows.devices.geolocation.geolocator: Implement IWeakReferenceSource. windows.devices.geolocation.geolocator: Fake success for PositionChanged_add. windows.devices.geolocation.geolocator: Add stubs for IGeolocator. windows.devices.geolocation.geolocator: Add stub dll. include: Add windows.devices.geolocation.geolocator. include/windows.foundation: Add double reference. https://gitlab.winehq.org/wine/wine/-/merge_requests/3189

3 10

[PATCH 0/1] MR3258: wow64win: Fix NULL buffer handling in wow64_NtUserBuildHimcList.
by Jacek Caban (＠jacek) 06 Jul '23

06 Jul '23

Fixes win32u tests on wow64. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3258

2 1

[PATCH 0/1] MR3250: include: Add IsReparseTagNameSurrogate.
by Alex Henrie (＠alexhenrie) 06 Jul '23

06 Jul '23

Based on a patch by Erich E. Hoover. This is another bit of code that Wine Staging shouldn't have to keep rebasing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3250

3 2

[PATCH 0/1] MR3248: include: Add REPARSE_(GUID_)DATA_BUFFER and related constants.
by Alex Henrie (＠alexhenrie) 06 Jul '23

06 Jul '23

Based on a patch by Erich E. Hoover. Wine Staging has been carrying this code around since 2014. It should be fine to upstream it even if the rest of the [junction point patches](https://gitlab.winehq.org/wine/wine-staging/-/tree/master/patches/… aren't ready yet, and upstreaming will reduce the burden on the Staging maintainers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3248

3 3

[PATCH v2 0/1] MR3058: kerberos: Avoid potentially uninitialized variable (clang-scan)
by Fabian Maurer (＠DarkShadow44) 06 Jul '23

06 Jul '23

When there are no caches, this variable would be uninitialized. Reported by clang-scan. Not sure if that can ever happen, but IMHO initializing doesn't do harm. -- v2: kerberos: Avoid potentially uninitialized variable (clang-scan) https://gitlab.winehq.org/wine/wine/-/merge_requests/3058

2 2

[PATCH 0/3] MR3211: wined3d: Don't force going through a texture when downloading from renderbuffers.
by Matteo Bruni (＠Mystral) 06 Jul '23

06 Jul '23

It can be unnecessary at best and unsupported at worst (e.g. no ARB_texture_multisample). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3211

3 11

[PATCH 0/3] MR3254: Remove DECLSPEC_HIDDEN for internet dll
by Alistair Leslie-Hughes (＠alesliehughes) 06 Jul '23

06 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3254

3 4

[PATCH v2 0/5] MR3256: Use nameless structs/unions for VARIANT struct (Clang build fixes)
by Jacek Caban (＠jacek) 06 Jul '23

06 Jul '23

Recent nameless struct/union changes broke MSVC Clang builds. That's because `VARIANT` still doesn't skip names when `__STDC__` is defined, which is true for most configs. -- v2: include: Don't force named VARIANT members when __STDC__ is defined. https://gitlab.winehq.org/wine/wine/-/merge_requests/3256

2 5

[PATCH v3 0/4] MR3234: winewayland.drv: part 5: window_surface flush optimizations
by Alexandros Frantzis (＠afrantzis) 06 Jul '23

06 Jul '23

This MR optimizes and makes correctness improvements to the window_surface flush implementation: 1. Implement a buffer queue to avoid constantly allocating new buffers. 2. Take into account the bounds of the window_surface flush and track per-buffer damage to reduce copying from the window_surface. 3. Copy from the window_surface only pixel data that lies within the flushed bounds. Maintain the latest contents for pixels outside these bounds, by copying them from the latest valid buffer. 4. Communicate damaged surface regions to the compositor to allow it to perform more efficient pixel data transfers (e.g., texture uploads). Thanks! -- v3: winewayland.drv: Send surface damage region to the compositor. winewayland.drv: Update only the flushed bounds from the window_surface. winewayland.drv: Track damaged buffer regions. winewayland.drv: Use a buffer queue for window_surface. https://gitlab.winehq.org/wine/wine/-/merge_requests/3234

3 15

[PATCH 0/5] MR3256: Use nameless structs/unions for VARIANT struct (Clang build fixes)
by Jacek Caban (＠jacek) 06 Jul '23

06 Jul '23

Recent nameless struct/union changes broke MSVC Clang builds. That's because `VARIANT` still doesn't skip names when `__STDC__` is defined, which is true for most configs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3256

3 8

[PATCH v2 0/2] MR266: Document vkd3d_acquire_vk_queue() and vkd3d_release_vk_queue().
by Giovanni Mascellani (＠giomasce) 06 Jul '23

06 Jul '23

-- v2: demos: Use a fence to synchronize D3D12 and Vulkan work. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/266

3 4

[PATCH 0/1] MR262: vkd3d: Make CopyResource use a temp buffer for depth <-> color copies
by Evan Tang (＠etang-cw) 06 Jul '23

06 Jul '23

depth <-> color copies aren't allowed in Vulkan Uses the same handling as `CopyTextureRegion` to perform the copy -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/262

4 4

[PATCH 0/1] MR3247: d3d11/tests: Add basic test for shared resources.
by Paul Gofman (＠gofman) 06 Jul '23

06 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3247

3 2

[PATCH v2 0/10] MR3245: mf/session: Test native MFT call pattern, and request more samples from upstream if necessary.
by Rémi Bernon (＠rbernon) 06 Jul '23

06 Jul '23

This is similar to https://gitlab.winehq.org/wine/wine/-/merge_requests/2684, https://gitlab.winehq.org/wine/wine/-/merge_requests/3004 or https://gitlab.winehq.org/wine/wine/-/merge_requests/3139 but it validates the session transform node behavior with tests. The tests are added after the changes because they otherwise don't pass and making them pass would be unnecessarily complicated. I also have some local tests for MF_TOPONODE_WORKQUEUE_ID attributes and how it is supposed to behave. It basically creates new serialized work queues for every source node and assign them to every node downstream. Any sample request or processing operation is done in the associated queue. When joining streams, queues are assigned downstream one after another and the last assigned queue is used when requesting samples upstream, but when samples are received and processed downstream it looks like the current queue of the source node is used for every downstream operations. The request behavior seems to be the same when work queues are used, with round robin input requests, and single ProcessInput call followed by ProcessOutput loop until it fails. This is yet not optimally efficient, and could be improved, for the following reasons: 1) All session operations are serialized together, even unrelated streams, and ProcessInput / ProcessOutput calls may be costly and stalling the pipeline. I believe that native probably allows parallel processing of unrelated stream requests, this needs to be confirmed. 2) MFT_MESSAGE_COMMAND_DRAIN message use isn't ideal, the message forces the transform to process all queued input synchronously, which can take a long time. I haven't checked exactly what native does but I believe it instead uses MFT_MESSAGE_NOTIFY_END_OF_STREAM messages, which would allow us to notify and drain the GStreamer decoder asynchronously. 3) MFT_MESSAGE_COMMAND_DRAIN also doesn't distinguish between input streams and needs to be sent globally. It's unclear how it should be used when multiple input streams are involved, and when one stream ends its segment then start a new segment while other streams don't have yet reached EOS. MFT_MESSAGE_NOTIFY_END_OF_STREAM messages have a stream ID parameter and would be more appropriate to handle separate input streams independently. -- v2: mf/tests: Add more media session transform tests with multiple inputs. mf/tests: Add more media session transform tests with multiple outputs. mf/tests: Add some media session transform call pattern tests. mf/session: Increase the stream request count when requests are already queued. mf/session: Request more samples from upstream when necessary. mf/session: Push transform input samples one by one to ProcessInput. mf/session: Use helpers to push and pop samples for transform streams. mf/session: Flush requests in transform_node_deliver_samples when drained. mf/session: Use a helper to deliver transform node requested samples. mf/session: Use local variables to access transform node streams. https://gitlab.winehq.org/wine/wine/-/merge_requests/3245

3 12

Re: [PATCH v9 0/2] MR3114: comctl32: Make sure the type is sLink to increase id.
by Zhao Yi (＠Zhaoyi) 06 Jul '23

06 Jul '23

update the commit message. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3114#note_38122

1 0

Re: [PATCH v3 0/1] MR3085: vbscript: Use correct pointer type in add_match (scan-build). - approved
by Jacek Caban (＠jacek) 06 Jul '23

06 Jul '23

This merge request was approved by Jacek Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3085

1 0

[PATCH v3 0/9] MR3249: windows.networking.hostname: Implement IHostNameFactory::CreateHostName().
by Mohamad Al-Jaf (＠maljaf) 06 Jul '23

06 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54699 I added the complete `windows.networking.idl` file since it was small and in case it's needed for mingw build. -- v3: windows.networking.hostname: Implement IHostName::get_RawName(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3249

3 13

[PATCH v16 0/2] MR2778: mfmediaengine: Add support for video effects.
by Bernhard Kölbl (＠besentv) 06 Jul '23

06 Jul '23

The test has a little inspiration from the SDK samples. -- v16: mfmediaengine: Add support for inserting video effects. mfmediaengine/tests: Add tests for video effects. https://gitlab.winehq.org/wine/wine/-/merge_requests/2778

3 5

[PATCH v8 0/4] MR3075: winegstreamer: Implement Wow64 entrypoints in the Unix library.
by Kurt Kartaltepe (＠kkartaltepe) 06 Jul '23

06 Jul '23

This also converts the opaque pointers passed across the PE->Unix interface to opaque types represented as UINT64 which store the unix side pointer. This makes the thunking simpler and should avoid anyone accidently dereferencing the unix pointer in the PE code. This was tested with warcraft 3 (1.26, the last non-reforged release), and is consistent with the standard 32bit build. ~~But since movies on warcraft 3 are broken in standard 32bit builds I could only test that that the gstreamer graph gets built up similarly and not verify the video playback. Id appreciate if someone knew of a working exercise of the gstreamer code.~~ it works great, the issue with cinematics ended up being related to modesetting under xwayland, running with a virtual desktop in winecfg confirms playback working perfectly. -- v8: Fixup: define sized bool and enums in params Fixup: assert struct sizes with bool/enum Fixup: designated initializers winegstreamer: Implement Wow64 entrypoints in the Unix library. https://gitlab.winehq.org/wine/wine/-/merge_requests/3075

3 6

[PATCH 0/1] MR3252: dbghelp: Use nameless union/structs.
by eric pouech (＠epo) 06 Jul '23

06 Jul '23

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3252

2 1

[PATCH 0/1] MR3058: kerberos: Avoid potentially uninitialized variable (clang-scan)
by Fabian Maurer (＠DarkShadow44) 06 Jul '23

06 Jul '23

When there are no caches, this variable would be uninitialized. Reported by clang-scan. Not sure if that can ever happen, but IMHO initializing doesn't do harm. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3058

4 4

[PATCH 0/4] MR3251: secur32/tests: Fix a test failure.
by Hans Leidekker (＠hans) 06 Jul '23

06 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55114 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3251

2 4

[PATCH 0/2] MR266: Document vkd3d_acquire_vk_queue() and vkd3d_release_vk_queue().
by Giovanni Mascellani (＠giomasce) 06 Jul '23

06 Jul '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/266

3 3

[PATCH v7 0/4] MR3075: winegstreamer: Implement Wow64 entrypoints in the Unix library.
by Kurt Kartaltepe (＠kkartaltepe) 06 Jul '23

06 Jul '23

This also converts the opaque pointers passed across the PE->Unix interface to opaque types represented as UINT64 which store the unix side pointer. This makes the thunking simpler and should avoid anyone accidently dereferencing the unix pointer in the PE code. This was tested with warcraft 3 (1.26, the last non-reforged release), and is consistent with the standard 32bit build. ~~But since movies on warcraft 3 are broken in standard 32bit builds I could only test that that the gstreamer graph gets built up similarly and not verify the video playback. Id appreciate if someone knew of a working exercise of the gstreamer code.~~ it works great, the issue with cinematics ended up being related to modesetting under xwayland, running with a virtual desktop in winecfg confirms playback working perfectly. -- v7: Fixup: define sized bool and enums in params Fixup: assert struct sizes with bool/enum Fixup: designated initializers winegstreamer: Implement Wow64 entrypoints in the Unix library. https://gitlab.winehq.org/wine/wine/-/merge_requests/3075

2 4

[PATCH v2 0/9] MR3249: windows.networking.hostname: Implement IHostNameFactory::CreateHostName().
by Mohamad Al-Jaf (＠maljaf) 06 Jul '23

06 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54699 I added the complete `windows.networking.idl` file since it was small and in case it's needed for mingw build. -- v2: windows.networking.hostname: Implement IHostName::get_RawName(). windows.networking.hostname: Implement IHostNameFactory::CreateHostName(). windows.networking.hostname/tests: Add IHostNameFactory::CreateHostName() tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3249

2 10

[PATCH 0/9] MR3249: windows.networking.hostname: Implement IHostNameFactory::CreateHostName().
by Mohamad Al-Jaf (＠maljaf) 06 Jul '23

06 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54699 I added the complete `windows.networking.idl` file since it was small and in case it's needed for mingw build. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3249

2 9

[PATCH v13 0/7] MR3189: Add windows.devices.geolocation.geolocator
by Fabian Maurer (＠DarkShadow44) 05 Jul '23

05 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55126 -- v13: windows.devices.geolocation.geolocator: Implement IWeakReference. https://gitlab.winehq.org/wine/wine/-/merge_requests/3189

4 12

Re: [PATCH v6 0/1] MR1153: winex11.drv: Correctly handle clipping for fullscreen windows. - approved
by Rémi Bernon (＠rbernon) 05 Jul '23

05 Jul '23

This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1153

1 0

Re: [PATCH v6 0/1] MR1153: winex11.drv: Correctly handle clipping for fullscreen windows.
by Rémi Bernon (＠rbernon) 05 Jul '23

05 Jul '23

On Wed Jul 5 17:57:30 2023 +0000, Gabriel Ivăncescu wrote: > Ok I'll send one with just the win32u change. I didn't even know there > was a fullscreen clip option, guess I'll just use that. :-) By default it is off but Wine still sometimes decides to clip cursor when windows are fullscreen. There's a limited use for that and I don't even know why it's there because it's only enabled if there's a single monitor. I suspect it is to handle the case where the host screen has a task bar that isn't part of Wine virtual screen or something like that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1153#note_38070

1 0

Re: [PATCH v2 0/1] MR3216: cmd: Allow numbered redirects at the beginning of a line. - approved
by Alexandre Julliard (＠julliard) 05 Jul '23

05 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3216

1 0

Re: [PATCH v4 0/1] MR3049: user32: Ignore invalid parameters in DrawTextEx when HDC is invalid - approved
by Alexandre Julliard (＠julliard) 05 Jul '23

05 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3049

1 0

Re: [PATCH v8 0/3] MR383: widl: Add basic support for the [deprecated] attribute. - approved
by Alexandre Julliard (＠julliard) 05 Jul '23

05 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/383

1 0

Re: [PATCH v2 0/1] MR3241: winex11: Use gdi_display consistently for client_window requests. - approved
by Alexandre Julliard (＠julliard) 05 Jul '23

05 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3241

1 0

Re: [PATCH v2 0/1] MR3243: user32/tests: Fix a WM_DISPLAYCHANGE broken() condition. - approved
by Alexandre Julliard (＠julliard) 05 Jul '23

05 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3243

1 0

2025

2024

2023

2022

wine-gitlab July 2023