July 2023 - wine-gitlab

Re: [PATCH v2 0/1] MR3236: winhttp: Use specific types insted of sizeof(ULONG_PTR) in alloc_handle. - approved
by Alexandre Julliard (＠julliard) 05 Jul '23

05 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3236

1 0

Re: [PATCH v3 0/2] MR3232: d3d10core/tests: Mark test failures specific to the Vulkan or GL renderers. - approved
by Alexandre Julliard (＠julliard) 05 Jul '23

05 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3232

1 0

Re: [PATCH v2 0/1] MR3223: winspool: Declare JobW as a void pointer in SetJobA. - approved
by Alexandre Julliard (＠julliard) 05 Jul '23

05 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3223

1 0

Re: [PATCH v2 0/5] MR3240: Remove DECLSPEC_HIDDEN usage. - approved
by Alexandre Julliard (＠julliard) 05 Jul '23

05 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3240

1 0

Re: [PATCH v3 0/6] MR3204: ole/com Remove DECLSPEC_HIDDEN macro. - approved
by Alexandre Julliard (＠julliard) 05 Jul '23

05 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3204

1 0

Re: [PATCH v2 0/7] MR3233: Remove DECLSPEC_HIDDEN in DirectShow - approved
by Alexandre Julliard (＠julliard) 05 Jul '23

05 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3233

1 0

Re: [PATCH v4 0/6] MR258: hlsl: Replace bare list pointers with hlsl_block, part 2. - approved
by Alexandre Julliard (＠julliard) 05 Jul '23

05 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/258

1 0

[PATCH 0/9] MR3245: mf/session: Test native MFT call pattern, and request more samples from upstream if necessary.
by Rémi Bernon (＠rbernon) 05 Jul '23

05 Jul '23

This is similar to https://gitlab.winehq.org/wine/wine/-/merge_requests/2684, https://gitlab.winehq.org/wine/wine/-/merge_requests/3004 or https://gitlab.winehq.org/wine/wine/-/merge_requests/3139 but it validates the session transform node behavior with tests. The tests are added after the changes because they otherwise don't pass and making them pass would be unnecessarily complicated. I also have some local tests for MF_TOPONODE_WORKQUEUE_ID attributes and how it is supposed to behave. It basically creates new serialized work queues for every source node and assign them to every node downstream. Any sample request or processing operation is done in the associated queue. When joining streams, queues are assigned downstream one after another and the last assigned queue is used when requesting samples upstream, but when samples are received and processed downstream it looks like the current queue of the source node is used for every downstream operations. The request behavior seems to be the same when work queues are used, with round robin input requests, and single ProcessInput call followed by ProcessOutput loop until it fails. This is yet not optimally efficient, and could be improved, for the following reasons: 1) All session operations are serialized together, even unrelated streams, and ProcessInput / ProcessOutput calls may be costly and stalling the pipeline. I believe that native probably allows parallel processing of unrelated stream requests, this needs to be confirmed. 2) MFT_MESSAGE_COMMAND_DRAIN message use isn't ideal, the message forces the transform to process all queued input synchronously, which can take a long time. I haven't checked exactly what native does but I believe it instead uses MFT_MESSAGE_NOTIFY_END_OF_STREAM messages, which would allow us to notify and drain the GStreamer decoder asynchronously. 3) MFT_MESSAGE_COMMAND_DRAIN also doesn't distinguish between input streams and needs to be sent globally. It's unclear how it should be used when multiple input streams are involved, and when one stream ends its segment then start a new segment while other streams don't have yet reached EOS. MFT_MESSAGE_NOTIFY_END_OF_STREAM messages have a stream ID parameter and would be more appropriate to handle separate input streams independently. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3245

4 12

[PATCH 0/1] MR3228: Update heap.c removed return NULL at line 985. Prevents Wing Commander...
by James Carthew (＠dmjc) 05 Jul '23

05 Jul '23

Update heap.c removed return NULL at line 985. Prevents Wing Commander Prophecy and Secret Ops for loading/playing. Fixes WINE bug 55176. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3228

4 3

[PATCH v5 0/1] MR1153: winex11.drv: Correctly handle clipping for fullscreen windows.
by Gabriel Ivăncescu (＠insn) 05 Jul '23

05 Jul '23

When we are clipping (due to fullscreen), certain operations are bugged (such as creating another window on top, grabbing the window during a size-move operation, changing mouse capture, etc) so we must temporarily unclip first. Seems unclipping it temporarily during such operation is enough to fix this. This probably wasn't very obvious in practice because most times "fullscreen" means a single non-resizeable window with no menus and so on (e.g. fullscreen games), but that's not always the case. -- v5: win32u: Don't clip fullscreen windows while capturing mouse pointer. https://gitlab.winehq.org/wine/wine/-/merge_requests/1153

2 1

[PATCH v4 0/2] MR1153: winex11.drv: Correctly handle clipping for fullscreen windows.
by Gabriel Ivăncescu (＠insn) 05 Jul '23

05 Jul '23

When we are clipping (due to fullscreen), certain operations are bugged (such as creating another window on top, grabbing the window during a size-move operation, changing mouse capture, etc) so we must temporarily unclip first. Seems unclipping it temporarily during such operation is enough to fix this. This probably wasn't very obvious in practice because most times "fullscreen" means a single non-resizeable window with no menus and so on (e.g. fullscreen games), but that's not always the case. -- v4: win32u: Don't clip fullscreen windows while capturing mouse pointer. winex11: Don't clip while creating X Window. https://gitlab.winehq.org/wine/wine/-/merge_requests/1153

3 6

[PATCH v14 0/1] MR3074: Move getpeername() implementation to wineserver
by Ally Sommers (＠dropbear) 05 Jul '23

05 Jul '23

`getpeername()` is currently handled in ntdll. This merge request changes ntdll to forward `getpeername()` to wineserver. The implementation utilises new `peer_addr` and `peer_addr_len` fields in wineserver's `struct sock`. This fixes multiple `todo_wine`s in `ws2_32/tests` and allows for more accurate peer names to be provided in case the address the socket is bound to on the Unix side does not match what `bind()` was called with on the Windows side. *This merge request was originally intended to be included in !2786 (Add support for AF_UNIX sockets) but was split into its own merge request because this is not an insignificant change.* -- v14: server: Move getpeername() implementation from ntdll/unix. https://gitlab.winehq.org/wine/wine/-/merge_requests/3074

3 2

[PATCH v35 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 05 Jul '23

05 Jul '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are supported by this patch. -- v35: ws2_32/tests: Add test for AF_UNIX sockets fix. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to connect() to abstract AF_UNIX sockets. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ntdll/unix: Add support for AF_UNIX sockets to multiple functions. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

4 9

[PATCH v7 0/3] MR383: widl: Add basic support for the [deprecated] attribute.
by Bernhard Kölbl (＠besentv) 05 Jul '23

05 Jul '23

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v7: include: Add VoiceCommandSet runtimeclass with it's dependencies. include: Add Windows.Phone.PhoneContract api contract. widl: Add basic support for the [deprecated] attribute. https://gitlab.winehq.org/wine/wine/-/merge_requests/383

3 4

[PATCH v6 0/3] MR383: widl: Add basic support for the [deprecated] attribute.
by Bernhard Kölbl (＠besentv) 05 Jul '23

05 Jul '23

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v6: include: Add VoiceCommandSet runtimeclass with it's dependencies. https://gitlab.winehq.org/wine/wine/-/merge_requests/383

4 9

[PATCH v5 0/3] MR383: widl: Add basic support for the [deprecated] attribute.
by Bernhard Kölbl (＠besentv) 05 Jul '23

05 Jul '23

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v5: include: Add VoiceCommandSet runtimeclass with it's dependencies. include: Add Windows.Phone.PhoneContract api contract. widl: Add basic support for the [deprecated] attribute. https://gitlab.winehq.org/wine/wine/-/merge_requests/383

2 4

[PATCH 0/21] MR221: Draft: vkd3d: Implement tiled resources
by Conor McCarthy (＠cmccarthy) 05 Jul '23

05 Jul '23

Depends on branch tiled_resource1, MR 216. The first new commit is "Add tests for GetResourceTiling()." -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/221

2 22

[PATCH v4 0/3] MR383: widl: Add basic support for the [deprecated] attribute.
by Bernhard Kölbl (＠besentv) 05 Jul '23

05 Jul '23

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v4: include: Add VoiceCommandSet runtimeclass with it's dependencies. include: Add Windows.Phone.PhoneContract api contract. widl: Add basic support for the [deprecated] attribute. https://gitlab.winehq.org/wine/wine/-/merge_requests/383

3 5

[PATCH 0/6] MR3139: mf/session: Introduce new asynchronous MFT wrapper.
by Rémi Bernon (＠rbernon) 05 Jul '23

05 Jul '23

This is the first part of a series implementing an asynchronous MFT wrapper around the synchronous session transforms. The idea is to use the async MFT behavior for all the session transforms. I believe this is generally useful, and goes in the direction of support native async MFT, although there is none at the moment, and it will also improve the behavior of the session with decoder transforms. These MFT do not generate a sample for each input samples, and may require more input to be requested. Using the async MFT behavior, we would generate METransformInputNeeded events when appropriate, and the session would react to them and request more samples from upstream. Similarly, producing output will trigger METransformOutputAvailable events, and the session can react to these events and push the samples downstream if there were requested, or queue them. Moreover, for very large video decoding or video processing, the synchronous transform may be performing slowly, and this currently blocks the session callbacks, causing stutter in the playback. Using the async MFT, we can process samples asynchronously, in the multi threaded queue. The complete async_transform implementation can be seen in the https://gitlab.winehq.org/rbernon/wine/-/commits/mr/mf-async-transform branch. I also have a local tree with fully working decoder MFTs, but it requires more changes elsewhere and some media source refactor. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3139

4 11

[PATCH v3 0/5] MR383: Draft: widl: Add basic support for the [deprecated] attribute.
by Bernhard Kölbl (＠besentv) 05 Jul '23

05 Jul '23

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v3: include: Add VoiceCommandSet runtimeclass with it's dependencies. include: Add Windows.Phone.PhoneContract api contract. fixup! widl: Add basic support for the [deprecated] attribute. fixup! winedump: Add support for dumping IMPORT_OBJECT_NAME_EXPORTAS symbols. widl: Add basic support for the [deprecated] attribute. https://gitlab.winehq.org/wine/wine/-/merge_requests/383

2 5

[PATCH v3 0/6] MR258: hlsl: Replace bare list pointers with hlsl_block, part 2.
by Zebediah Figura (＠zfigura) 05 Jul '23

05 Jul '23

-- v3: vkd3d-shader/hlsl: Free the "iter" block pointer on success in create_loop(). vkd3d-shader/hlsl: Return a hlsl_block from the "expr_statement" and "expr" rules. vkd3d-shader/hlsl: Return a hlsl_block from the "jump_statement" rule. vkd3d-shader/hlsl: Return a hlsl_block from the "selection_statement" rule. vkd3d-shader/hlsl: Return a hlsl_block from the "loop_statement" rule. vkd3d-shader/hlsl: Return a hlsl_block from the "statement" rule. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/258

3 7

[PATCH v2 0/1] MR2228: bcryptprimitives: ProcessRng stub
by Christopher Denton (＠cdenton) 05 Jul '23

05 Jul '23

`ProcessRng` is the only publicly documented function exported by `bcryptprimitives`. This stub simply forwards it to `RtlGenRandom` in `advapi32`. Documentation: https://learn.microsoft.com/en-us/windows/win32/seccng/processprng -- v2: bcryptprimitives: ProcessRng stub https://gitlab.winehq.org/wine/wine/-/merge_requests/2228

3 8

[PATCH 0/1] MR3243: user32/tests: Fix a WM_DISPLAYCHANGE broken() condition.
by Francois Gouget (＠fgouget) 05 Jul '23

05 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3243

2 1

[PATCH 0/1] MR3236: winhttp: Use specific types insted of sizeof(ULONG_PTR) in alloc_handle.
by Alex Henrie (＠alexhenrie) 05 Jul '23

05 Jul '23

Resolves a scan-build warning. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3236

3 2

Re: [PATCH v2 0/1] MR383: widl: Add basic support for the [deprecated] attribute.
by Bernhard Kölbl (＠besentv) 05 Jul '23

05 Jul '23

On Wed Jul 6 09:01:08 2022 +0000, Rémi Bernon wrote: > If we don't have anything to define it to, maybe it's not really worth > generating anything to the header yet and only keep the parsing support? I did it like this because idk if we support `__declspec(deprecated(x))` . -- https://gitlab.winehq.org/wine/wine/-/merge_requests/383#note_37972

1 0

[PATCH 0/2] MR265: vkd3d-shader/hlsl: Add some more constant folding operations.
by Nikolay Sivov (＠nsivov) 05 Jul '23

05 Jul '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/265

3 4

[PATCH v7 0/2] MR3114: comctl32: Make the correct linkid from fun SYSLINK_LinkAtPt.
by Zhao Yi (＠Zhaoyi) 05 Jul '23

05 Jul '23

Add a check condition for whether the type is slLink. Signed-off-by: Zhaoyi <zhaoyi(a)uniontech.com> -- v7: comctl32: Make the correct linkid from fun SYSLINK_LinkAtPt. https://gitlab.winehq.org/wine/wine/-/merge_requests/3114

2 2

[PATCH v6 0/1] MR3114: comctl32: Make the correct linkid from fun SYSLINK_LinkAtPt.
by Zhao Yi (＠Zhaoyi) 05 Jul '23

05 Jul '23

Add a check condition for whether the type is slLink. Signed-off-by: Zhaoyi <zhaoyi(a)uniontech.com> -- v6: comctl32/tests: Add a test program to get syslinkid. https://gitlab.winehq.org/wine/wine/-/merge_requests/3114

2 1

[PATCH v4 0/3] MR245: vkd3d-shader/hlsl: Add support for 'break' and 'continue' jumps in loops.
by Nikolay Sivov (＠nsivov) 05 Jul '23

05 Jul '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v4: vkd3d-shader/tpf: Write 'continue' instruction. vkd3d-shader/hlsl: Parse 'continue' statement. vkd3d-shader/hlsl: Allow 'break' instructions in loops. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/245

4 28

[PATCH 0/1] MR3241: winex11: Use gdi_display consistently for client_window requests.
by Rémi Bernon (＠rbernon) 05 Jul '23

05 Jul '23

And synchronize with thread display when necessary. The rationale is that client_window are created using the gdi_display, and OpenGL/Vulkan using gdi_display it is probably safer that any X11 request for them is done on the gdi_display. Then we need to properly synchronize the requests that involve client_window and whole_window, such as reparenting requests, as whole_window is created, and related requests make, using the thread display. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3241

2 1

[PATCH 0/5] MR3240: Remove DECLSPEC_HIDDEN usage.
by Alistair Leslie-Hughes (＠alesliehughes) 05 Jul '23

05 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3240

2 5

[PATCH v2 0/6] MR3204: ole/com Remove DECLSPEC_HIDDEN macro.
by Alistair Leslie-Hughes (＠alesliehughes) 05 Jul '23

05 Jul '23

-- v2: combase: Remove DECLSPEC_HIDDEN usage. oledlg: Remove DECLSPEC_HIDDEN usage. oleacc: Remove DECLSPEC_HIDDEN usage. oleaut32: Remove DECLSPEC_HIDDEN usage. ole32: Remove DECLSPEC_HIDDEN usage. oledb32: Remove DECLSPEC_HIDDEN usage. https://gitlab.winehq.org/wine/wine/-/merge_requests/3204

2 6

[PATCH v5 0/1] MR3114: comctl32: Make the correct linkid from fun SYSLINK_LinkAtPt.
by Zhao Yi (＠Zhaoyi) 05 Jul '23

05 Jul '23

Add a check condition for whether the type is slLink. Signed-off-by: Zhaoyi <zhaoyi(a)uniontech.com> -- v5: comctl32: Make the correct linkid from fun SYSLINK_LinkAtPt. https://gitlab.winehq.org/wine/wine/-/merge_requests/3114

4 8

[PATCH v13 0/1] MR3074: Move getpeername() implementation to wineserver
by Ally Sommers (＠dropbear) 05 Jul '23

05 Jul '23

`getpeername()` is currently handled in ntdll. This merge request changes ntdll to forward `getpeername()` to wineserver. The implementation utilises new `peer_addr` and `peer_addr_len` fields in wineserver's `struct sock`. This fixes multiple `todo_wine`s in `ws2_32/tests` and allows for more accurate peer names to be provided in case the address the socket is bound to on the Unix side does not match what `bind()` was called with on the Windows side. *This merge request was originally intended to be included in !2786 (Add support for AF_UNIX sockets) but was split into its own merge request because this is not an insignificant change.* -- v13: server: Move getpeername() implementation from ntdll/unix. https://gitlab.winehq.org/wine/wine/-/merge_requests/3074

2 1

[PATCH 0/1] MR3223: winspool: Declare JobW as a void pointer in SetJobA.
by Alex Henrie (＠alexhenrie) 05 Jul '23

05 Jul '23

To reduce the number of casts required and avoid a scan-build warning. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3223

3 2

[PATCH 0/1] MR3160: wineps.drv: Not set dc_top should not affect printing failed
by 张顾在 (＠linkmecry) 05 Jul '23

05 Jul '23

Not set dc_top should not affect printing failed -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3160

4 12

[PATCH 0/6] MR3204: ole/com Remove DECLSPEC_HIDDEN macro.
by Alistair Leslie-Hughes (＠alesliehughes) 05 Jul '23

05 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3204

4 9

[PATCH v12 0/1] MR3074: Move getpeername() implementation to wineserver
by Ally Sommers (＠dropbear) 05 Jul '23

05 Jul '23

`getpeername()` is currently handled in ntdll. This merge request changes ntdll to forward `getpeername()` to wineserver. The implementation utilises new `peer_addr` and `peer_addr_len` fields in wineserver's `struct sock`. This fixes multiple `todo_wine`s in `ws2_32/tests` and allows for more accurate peer names to be provided in case the address the socket is bound to on the Unix side does not match what `bind()` was called with on the Windows side. *This merge request was originally intended to be included in !2786 (Add support for AF_UNIX sockets) but was split into its own merge request because this is not an insignificant change.* -- v12: server: Move getpeername() implementation from ntdll/unix. https://gitlab.winehq.org/wine/wine/-/merge_requests/3074

3 2

[PATCH v34 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 05 Jul '23

05 Jul '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are supported by this patch. -- v34: ws2_32/tests: Add test for AF_UNIX sockets fix. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to connect() to abstract AF_UNIX sockets. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ntdll/unix: Add support for AF_UNIX sockets to multiple functions. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

3 8

[PATCH v11 0/1] MR3074: Move getpeername() implementation to wineserver
by Ally Sommers (＠dropbear) 05 Jul '23

05 Jul '23

`getpeername()` is currently handled in ntdll. This merge request changes ntdll to forward `getpeername()` to wineserver. The implementation utilises new `peer_addr` and `peer_addr_len` fields in wineserver's `struct sock`. This fixes multiple `todo_wine`s in `ws2_32/tests` and allows for more accurate peer names to be provided in case the address the socket is bound to on the Unix side does not match what `bind()` was called with on the Windows side. *This merge request was originally intended to be included in !2786 (Add support for AF_UNIX sockets) but was split into its own merge request because this is not an insignificant change.* -- v11: server: Move getpeername() implementation from ntdll/unix. https://gitlab.winehq.org/wine/wine/-/merge_requests/3074

3 2

[PATCH 0/1] MR3235: d3d11: Add support for D3D11_FEATURE_FORMAT_SUPPORT2.
by Andrey Gusev (＠agusev) 05 Jul '23

05 Jul '23

Used by Assassin's Creed: Odyssey, Days Gone, F1 2018, Stray, etc. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3235

3 2

[PATCH 0/1] MR264: vkd3d-shader/ir: Rename vkd3d_shader_instruction to ir_instr.
by Zebediah Figura (＠zfigura) 04 Jul '23

04 Jul '23

There are a few motivations for this: * Identifiers beginning with vkd3d_shader_ look like external API. Changing the prefix makes it clear that this is an internal API. * vkd3d_shader is a very long prefix, which is annoying to type [not least because "vkd3d" itself is an unwieldy name.] This is also a motivation for shortening "instruction" to "instr". * The "vkd3d_instruction" is increasingly growing from a simple parsed representation of sm4 bytecode, to a proper IR in its own right—e.g. we are using it for sm1 and sm6, are performing passes over it, and we have plans to extend its scope further, e.g. to HLSL compilation. Give it a name that reflects and clearly communicates what it is. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/264

2 2

[PATCH v2 0/5] MR3149: widl: Don't crash if an interface is missing an uuid
by Fabian Maurer (＠DarkShadow44) 04 Jul '23

04 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55123 -- v2: widl: Don't crash if an interface is missing an uuid include/roparameterizediid: Make interfaces local include/mpegtype: Make IMpegAudioDecoder local include/amvideo: Make IFullScreenVideo local widl: Don't crash if an interface is empty https://gitlab.winehq.org/wine/wine/-/merge_requests/3149

5 26

[PATCH v6 0/10] MR2993: Draft: comdlg32: IFileDialog navigation bar control. Part 1.
by Vladislav Timonin (＠vt) 04 Jul '23

04 Jul '23

Redo of !1857, as suggested, the plan is to split original MR in half, breadcrumbs in first (this) MR, and address edit in another. The changes are mostly cleanup (formatting, renaming, unused variables, missing free). Visually, it hasn't changed from original MR, part 1 changes are: ![](/uploads/42fa717ce6f7adb40d6b0dcbbe0878fa/changes-1-3.png) And part 2: ![](/uploads/cbdaa2d4b5b8945587e1f761a4609a08/changes-2.png) Part 2 branch can be found [here](https://gitlab.winehq.org/vt/wine/-/commits/fd-navbar-part2). Requires !2068, otherwise if application doesn't request comctl v6 (e.g. qapitrace), navigation bar will look like this: ![no-comctl-v6](/uploads/03e6a8b6dcf827114157e79640e49fea/no-comctl-v6.png) Closes: - https://bugs.winehq.org/show_bug.cgi?id=29912 - https://bugs.winehq.org/show_bug.cgi?id=54812 - https://bugs.winehq.org/show_bug.cgi?id=50338 (partially? fully with address edit?) MR changes: - v2 - changed the gap between buttons to be scaled with DPI - v3 - DPI scale the gap in layout calculation in breadcrumbs commit, missed it earlier - remove padding from layout calculation, `GetWindowRect` was unintentionally returning double padding, 4px from `hspacing` in `itemdlg.c:update_layout`, and another 4px from somewhere else - drop `comdlg32: Keep IExplorerBrowser in IFileDialog focused after Backspace.` hack - retain IExplorerBrowser view focus in IFileDialog when creating new view - redirect navigation bar buttons focus back to the previous window - v4 - rename background to frame - calculate overflow button width into separate variable, [will come in handy in part 2](https://gitlab.winehq.org/vt/wine/-/commit/998b6987500edda02d6a9177c7da2… - simplify show-at-least-N-crumbs logic - drop `comdlg32: Prevent arrow navigation of IFileDialog navigation bar buttons.` - drop `comdlg32: Don't paint focus rect in IFileDialog navigation bar buttons.` - add tab navigation - avoid taking button focus by sending `VK_SPACE` instead - v5 - rebase on current master - rename `NAVBAR_ButtonProc`/`BUTTON_SUBCLASS_ID` into `NAVBAR_PushButtonProc`/`PUSHBUTTON_SUBCLASS_ID`, describes it more accurately - remove brackets in `WM_LBUTTONDOWN`/`WM_LBUTTONDBLCLK` in `NAVBAR_PushButtonProc`, for some consistency, usually not placing them if I don't have to - swap `SWP_NOSIZE | SWP_NOMOVE` to `SWP_NOMOVE | SWP_NOSIZE` in tab navigation commit, so that it matches the argument order - add `LAYOUT_ITEMS_N` define for use in `BeginDeferWindowPos`, to update the number of items in a single place instead of 2 or 3 Description edits: - v2 - Updated the changes image (by splitting it) - Added MR changes - v3 - Added description edits - Updated the changes image again (forgot the overflow button change) -- v6: comdlg32: Avoid taking focus on LMB click in IFileDialog navigation bar buttons. comdlg32: Add tab navigation to IFileDialog navigation bar. comdlg32: Retain IExplorerBrowser view focus in IFileDialog when creating new view. comdlg32: Add breadcrumb overflow menu to IFileDialog navigation bar. comdlg32: Add inner border to breadcrumbs in IFileDialog navigation bar. comdlg32: Always show at least 2 crumbs in IFileDialog navigation bar. comdlg32: Reuse address breadcrumbs in IFileDialog navigation bar. comdlg32: Add address breadcrumbs to IFileDialog navigation bar. comdlg32: Add go up button to IFileDialog navigation bar. comdlg32: Add IFileDialog navigation bar control. https://gitlab.winehq.org/wine/wine/-/merge_requests/2993

3 13

[PATCH 0/1] MR3237: uiautomationcore: Fix signatures of IWineUia* functions (gcc).
by Alex Henrie (＠alexhenrie) 04 Jul '23

04 Jul '23

long is 64 bits when not compiling with MinGW. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3237

2 3

Re: [PATCH v3 0/3] MR3191: include: Add A2BSTR function. - closed
by Alex Henrie (＠alexhenrie) 04 Jul '23

04 Jul '23

This merge request was closed by Alex Henrie. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3191

1 0

Re: [PATCH v5 0/2] MR3157: include: Introduce wine_dbgstr_hstring and debugstr_hstring. - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3157

1 0

Re: [PATCH v3 0/1] MR3094: taskmgr: graph.c refactor - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3094

1 0

Re: [PATCH v2 0/1] MR3155: shell32: Make sure wcmd has enough space to hold the string. - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3155

1 0

Re: [PATCH v3 0/3] MR2965: {server, ws2_32, ntdll}: Avoid using SOL_IPX to detect whether IPX is supported - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2965

1 0

2025

2024

2023

2022

wine-gitlab July 2023