July 2023 - wine-gitlab

Re: [PATCH v14 0/2] MR2068: comdlg32: Enable visual styles when showing IFileDialog. - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2068

1 0

Re: [PATCH v2 0/10] MR3210: d3dx9/tests cleanup - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3210

1 0

Re: [PATCH v2 0/3] MR3217: wined3d: Reuse command buffers and fences. - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3217

1 0

Re: [PATCH v2 0/5] MR3212: wined3d: Reduce command stream CPU usage, part 1 - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3212

1 0

Re: [PATCH v4 0/6] MR3165: dxgi: Introduce a worker thread for each D3D12 swapchain (first part). - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3165

1 0

Re: [PATCH v4 0/1] MR3206: vbscript: Support one-line sub/function - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3206

1 0

Re: [PATCH v7 0/6] MR3220: windows.devices.bluetooth: Implement IBluetoothAdapterStatics::GetDeviceSelector(). - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3220

1 0

Re: [PATCH v6 0/8] MR3218: wine{alsa,coreaudio,oss,pulse}: Move session_init_vols, create_session into mmdevapi. - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3218

1 0

Re: [PATCH v2 0/3] MR254: hlsl: Fix constant allocation for sm1. - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/254

1 0

Re: [PATCH v2 0/2] MR257: vkd3d-shader: Two valgrind fixes. - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/257

1 0

Re: [PATCH v3 0/2] MR256: vkd3d-shader/hlsl: Improvements to static expression evaluation. - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/256

1 0

Re: [PATCH v5 0/3] MR255: vkd3d-shader: Scan for the maximum temporary register in d3dbc and emit a spirv temp array accordingly. - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/255

1 0

Re: [PATCH v3 0/1] MR252: vkd3d-shader/hlsl: Add constant folding for 'rcp'. - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/252

1 0

Re: [PATCH v4 0/3] MR251: vkd3d: Fix a few resource leaks here and there - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/251

1 0

Re: [PATCH v5 0/5] MR250: vkd3d-shader/hlsl: Declare vars individually when parsing declarations. - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/250

1 0

Re: [PATCH v5 0/5] MR224: tests: Test coarse and fine derivates and demand less precision from ddx() and ddy(). - approved
by Alexandre Julliard (＠julliard) 04 Jul '23

04 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/224

1 0

[PATCH 0/7] MR3233: Remove DECLSPEC_HIDDEN in DirectShow
by Alistair Leslie-Hughes (＠alesliehughes) 04 Jul '23

04 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3233

3 8

[PATCH v15 0/2] MR2778: mfmediaengine: Add support for video effects.
by Bernhard Kölbl (＠besentv) 04 Jul '23

04 Jul '23

The test has a little inspiration from the SDK samples. -- v15: mfmediaengine: Add support for inserting video effects. mfmediaengine/tests: Add tests for video effects. https://gitlab.winehq.org/wine/wine/-/merge_requests/2778

4 6

[PATCH 0/3] MR254: hlsl: Fix constant allocation for sm1.
by Zebediah Figura (＠zfigura) 04 Jul '23

04 Jul '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/254

5 11

[PATCH 0/1] MR2228: bcryptprimitives: ProcessRng stub
by Christopher Denton (＠cdenton) 04 Jul '23

04 Jul '23

`ProcessRng` is the only publicly documented function exported by `bcryptprimitives`. This stub simply forwards it to `RtlGenRandom` in `advapi32`. Documentation: https://learn.microsoft.com/en-us/windows/win32/seccng/processprng -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2228

4 11

[PATCH v2 0/4] MR3234: winewayland.drv: part 5: window_surface flush optimizations
by Alexandros Frantzis (＠afrantzis) 04 Jul '23

04 Jul '23

This MR optimizes and makes correctness improvements to the window_surface flush implementation: 1. Implement a buffer queue to avoid constantly allocating new buffers. 2. Take into account the bounds of the window_surface flush and track per-buffer damage to reduce copying from the window_surface. 3. Copy from the window_surface only pixel data that lies within the flushed bounds. Maintain the latest contents for pixels outside these bounds, by copying them from the latest valid buffer. 4. Communicate damaged surface regions to the compositor to allow it to perform more efficient pixel data transfers (e.g., texture uploads). Thanks! -- v2: winewayland.drv: Send surface damage region to the compositor. winewayland.drv: Update only the flushed bounds from the window_surface. winewayland.drv: Track damaged buffer regions. winewayland.drv: Use a buffer queue for window_surface. https://gitlab.winehq.org/wine/wine/-/merge_requests/3234

3 10

[PATCH v4 0/2] MR3157: include: Introduce wine_dbgstr_hstring and debugstr_hstring.
by Alex Henrie (＠alexhenrie) 04 Jul '23

04 Jul '23

This replaces Wine's 14 copies of debugstr_hstring. -- v4: include: Introduce wine_dbgstr_hstring and debugstr_hstring. include: Use correct header guard name in winstring.h. https://gitlab.winehq.org/wine/wine/-/merge_requests/3157

2 2

[PATCH v2 0/1] MR3085: vbscript: Use correct pointer type in add_match (scan-build).
by Alex Henrie (＠alexhenrie) 04 Jul '23

04 Jul '23

-- v2: vbscript: Use correct pointer type in add_match (scan-build). https://gitlab.winehq.org/wine/wine/-/merge_requests/3085

2 1

[PATCH 0/10] MR3210: d3dx9/tests cleanup
by Matteo Bruni (＠Mystral) 04 Jul '23

04 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3210

3 11

[PATCH v3 0/1] MR3049: user32: Ignore invalid parameters in DrawTextEx when HDC is invalid
by Fabian Maurer (＠DarkShadow44) 04 Jul '23

04 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47089 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- v3: user32: Ignore invalid parameters in DrawTextEx when HDC is invalid https://gitlab.winehq.org/wine/wine/-/merge_requests/3049

2 3

[PATCH v11 0/7] MR3189: Add windows.devices.geolocation.geolocator
by Fabian Maurer (＠DarkShadow44) 04 Jul '23

04 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55126 -- v11: windows.devices.geolocation.geolocator: Implement IWeakReference. https://gitlab.winehq.org/wine/wine/-/merge_requests/3189

4 11

[PATCH v12 0/7] MR3189: Add windows.devices.geolocation.geolocator
by Fabian Maurer (＠DarkShadow44) 04 Jul '23

04 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55126 -- v12: windows.devices.geolocation.geolocator: Implement IWeakReference. https://gitlab.winehq.org/wine/wine/-/merge_requests/3189

4 10

[PATCH v10 0/7] MR3189: Add windows.devices.geolocation.geolocator
by Fabian Maurer (＠DarkShadow44) 04 Jul '23

04 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55126 -- v10: windows.devices.geolocation.geolocator: Implement IWeakReference. https://gitlab.winehq.org/wine/wine/-/merge_requests/3189

3 13

[PATCH v14 0/2] MR2778: mfmediaengine: Add support for video effects.
by Bernhard Kölbl (＠besentv) 04 Jul '23

04 Jul '23

The test has a little inspiration from the SDK samples. -- v14: mfmediaengine: Add support for inserting video effects. https://gitlab.winehq.org/wine/wine/-/merge_requests/2778

4 11

[PATCH 0/2] MR257: vkd3d-shader: Two valgrind fixes.
by Zebediah Figura (＠zfigura) 04 Jul '23

04 Jul '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/257

5 7

[PATCH v2 0/2] MR256: vkd3d-shader/hlsl: Improvements to static expression evaluation.
by Nikolay Sivov (＠nsivov) 04 Jul '23

04 Jul '23

vkd3d-shader/hlsl: Support evaluated expressions for sample count in multisampled textures declarations. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vkd3d-shader/hlsl: Disallow certain instruction types from constant expressions. vkd3d-shader/hlsl: Support evaluated expressions for sample count in multisampled textures declarations. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/256

6 7

[PATCH v4 0/3] MR255: vkd3d-shader: Scan for the maximum temporary register in d3dbc and emit a spirv temp array accordingly.
by Zebediah Figura (＠zfigura) 04 Jul '23

04 Jul '23

``` On Margate Sands. I can connect Nothing with nothing. ``` -- v4: vkd3d-shader/d3dbc: Scan for the maximum temporary register index. vkd3d-shader: Record a global temporary count per sm4 shader. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/255

4 6

[PATCH v2 0/1] MR252: vkd3d-shader/hlsl: Add constant folding for 'rcp'.
by Nikolay Sivov (＠nsivov) 04 Jul '23

04 Jul '23

-- v2: vkd3d-shader/hlsl: Add constant folding for 'rcp'. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/252

5 4

[PATCH v3 0/3] MR251: vkd3d: Fix a few resource leaks here and there
by Giovanni Mascellani (＠giomasce) 04 Jul '23

04 Jul '23

-- v3: vkd3d: Release op data when destroying the queue. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/251

3 4

[PATCH v4 0/5] MR250: vkd3d-shader/hlsl: Declare vars individually when parsing declarations.
by Francisco Casas (＠fcasas) 04 Jul '23

04 Jul '23

In a declaration with multiple variables, the variables must be created before the initializer of the next variable is parsed. This is required for initializers such as: ``` float a = 1, b = a, c = b + 1; ``` The solution is to parse the type information in the same rule as the first variable ('a' in this case) so that it can be declared before the parser reaches the initializer for the following variables. To initialize the following variables, the type information is passed along from the first variable's struct parse_variable_def to the next and so on. --- Solves https://bugs.winehq.org/show_bug.cgi?id=54484, pointed out by @nsivov. -- v4: vkd3d-shader/hlsl: Declare vars individually when parsing struct declarations. vkd3d-shader/hlsl: Declare vars individually when parsing regular declarations. vkd3d-shader/hlsl: Split declare_vars(). tests: Test multiple variable initializers. tests: Test semantics in uniform variables. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/250

4 8

[PATCH v4 0/5] MR224: tests: Test coarse and fine derivates and demand less precision from ddx() and ddy().
by Francisco Casas (＠fcasas) 04 Jul '23

04 Jul '23

On my Nvidia GeForce GTX 1050 Ti `ddxddy.shader_test` doesn't pass because of considerably different numeric results. As Giovanni pointed out, this is because my GPU uses the fine derivate and not the coarse derivate to implement ddx() and ddy(). For this reason, the result for ddx|ddy() is quantized so that the test passes if the GPU uses either coarse or fine derivates. Additionally, tests for both ddx_coarse|ddy_coarse() and ddx_fine|ddy_fine() are added, that expect a more precise result. -- v4: vkd3d-shader/hlsl: Support fine derivates. vkd3d-shader/hlsl: Support coarse derivates. tests: Quantize regular and coarse derivate test results. tests: Make ddx() and ddy() test behave correctly for shader models < 4. tests: Test coarse and fine derivates. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/224

4 8

[PATCH 0/1] MR261: vkd3d-shader: Add compiler option to specify matrix majority.
by Nikolay Sivov (＠nsivov) 04 Jul '23

04 Jul '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/261

3 2

[PATCH v2 0/2] MR3232: d3d10core/tests: Mark test failures specific to the Vulkan or GL renderers.
by Zebediah Figura (＠zfigura) 04 Jul '23

04 Jul '23

This is obviously questionable, as it requires reaching into Wine internals in tests (beyond simply detecting whether Wine is in use). However, we are at a point where, for d3d10 and above, the Vulkan renderer works well enough in general to see real use [in fact, in my experience it usually works better than the GL renderer], and at this point I think avoiding regressions is quite important. It is currently difficult to run tests with it when the results contain so much noise, and I think we need to solve this problem, by actually marking which tests work on each backend. We could in theory expose the renderer through some adapter string, but I believe in the past applications have been sensitive about the contents of adapter strings. Fixing either renderer to reach and maintain parity is not feasible. The GL renderer is not going away, but regrettably GL as an API is abandoned by Khronos, and important features we need in order to implement some Direct3D features will probably never be introduced into GL. Moreover, the amount of effort that would be required to reach parity is not small, and itself would all need to be verified manually. -- v2: d3d10core/tests: Mark test failures specific to the Vulkan or GL renderers. https://gitlab.winehq.org/wine/wine/-/merge_requests/3232

4 4

[PATCH 0/3] MR3217: wined3d: Reuse command buffers and fences.
by Zebediah Figura (＠zfigura) 04 Jul '23

04 Jul '23

This improves performance with Batman: Arkham Knight on NVidia drivers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3217

3 4

[PATCH 0/5] MR3212: wined3d: Reduce command stream CPU usage, part 1
by Matteo Bruni (＠Mystral) 04 Jul '23

04 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3212

4 12

Re: [PATCH v3 0/6] MR3165: dxgi: Introduce a worker thread for each D3D12 swapchain (first part).
by Henri Verbeet (＠hverbeet) 04 Jul '23

04 Jul '23

> The part that doesn't thrill me is the fact that DXGI still directly accesses the VkQueue object, which I tend to see as an internal implementation detail to vkd3d. On the other hand it's nice that we don't need new API from vkd3d (even if, in the future, we were to need something other than vkQueueSubmit() and vkQueuePresentKHR()). For what it's worth, it was a fairly explicit design decision early on to expose the underlying Vulkan objects for d3d12 devices and command queues, as well as to allow the creation of d3d12 resources on top of existing Vulkan images, for the purpose of interoperation with other Vulkan code. I.e., the idea is that it should be possible to integrate vkd3d into a larger Vulkan application to draw some parts using the d3d12 API, while everything else is drawn using Vulkan. The internal queueing of command queue operations on the vkd3d level is unfortunate in that regard; ideally we just wouldn't do that. This MR could probably do a better job of explaining why we need to do that in some cases, and what kind of command queue operation sequences could result in out-of-order presentation. If we're going to need to introduce a DXGI worker thread anyway, could we just make vkd3d_acquire_vk_queue() block until there are no longer any operations queued? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3165#note_37779

1 0

[PATCH v3 0/1] MR3206: vbscript: Support one-line sub/function
by Fabian Maurer (＠DarkShadow44) 04 Jul '23

04 Jul '23

Sub / Function can be on one line, but only if there's brackets. ``` | Storage_opt tFUNCTION Identifier ArgumentsDecl BodyStatements tEND tFUNCTION ``` This leads to sometimes to `link_statements` being called with `head` being NULL, probably because now the `:` can be parsed as `Statement` in `BodyStatements`. Also note that this introduces another shift/reduce conflict, could be related, but I don't understand it well enough. Feedback would be appreciated, I'm still learning bison. -- v3: vbscript: Support one-line sub/function. https://gitlab.winehq.org/wine/wine/-/merge_requests/3206

3 2

Re: [PATCH v3 0/6] MR3165: dxgi: Introduce a worker thread for each D3D12 swapchain (first part). - approved
by Jan Sikorski (＠jsikorski) 04 Jul '23

04 Jul '23

This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3165

1 0

[PATCH v13 0/2] MR2778: mfmediaengine: Add support for video effects.
by Bernhard Kölbl (＠besentv) 04 Jul '23

04 Jul '23

The test has a little inspiration from the SDK samples. -- v13: mfmediaengine: Add support for inserting video effects. mfmediaengine/tests: Add tests for video effects. https://gitlab.winehq.org/wine/wine/-/merge_requests/2778

2 4

[PATCH v5 0/8] MR3218: wine{alsa,coreaudio,oss,pulse}: Move session_init_vols, create_session into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 04 Jul '23

04 Jul '23

-- v5: https://gitlab.winehq.org/wine/wine/-/merge_requests/3218

3 9

[PATCH 0/4] MR3234: winewayland.drv: part 5: window_surface flush optimizations
by Alexandros Frantzis (＠afrantzis) 04 Jul '23

04 Jul '23

This MR optimizes and makes correctness improvements to the window_surface flush implementation: 1. Implement a buffer queue to avoid constantly allocating new buffers. 2. Take into account the bounds of the window_surface flush and track per-buffer damage to reduce copying from the window_surface. 3. Copy from the window_surface only pixel data that lies within the flushed bounds. Maintain the latest contents for pixels outside these bounds, by copying them from the latest valid buffer. 4. Communicate damaged surface regions to the compositor to allow it to perform more efficient pixel data transfers (e.g., texture uploads). Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3234

2 4

[PATCH v4 0/1] MR3114: comctl32: Make the correct linkid from fun SYSLINK_LinkAtPt.
by Zhao Yi (＠Zhaoyi) 04 Jul '23

04 Jul '23

Add a check condition for whether the type is slLink. Signed-off-by: Zhaoyi <zhaoyi(a)uniontech.com> -- v4: comctl32: Make the correct linkid from fun SYSLINK_LinkAtPt. https://gitlab.winehq.org/wine/wine/-/merge_requests/3114

3 3

[PATCH v6 0/6] MR3220: windows.devices.bluetooth: Implement IBluetoothAdapterStatics::GetDeviceSelector().
by Mohamad Al-Jaf (＠maljaf) 04 Jul '23

04 Jul '23

Needed for Revo Scan 5. -- v6: windows.devices.bluetooth: Implement IBluetoothAdapterStatics::GetDeviceSelector(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3220

2 7

[PATCH v5 0/6] MR3220: windows.devices.bluetooth: Partially implement IBluetoothAdapterStatics::GetDeviceSelector().
by Mohamad Al-Jaf (＠maljaf) 04 Jul '23

04 Jul '23

Needed for Revo Scan 5. -- v5: windows.devices.bluetooth: Partially implement IBluetoothAdapterStatics::GetDeviceSelector(). windows.devices.bluetooth/tests: Add IBluetoothAdapterStatics::GetDeviceSelector() tests. windows.devices.bluetooth: Add IBluetoothAdapterStatics stub interface. windows.devices.bluetooth: Add stub DLL. include: Add windows.devices.bluetooth.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/3220

3 10

[PATCH 0/4] MR263: vkd3d-shader/spirv: Refactor the type system.
by Conor McCarthy (＠cmccarthy) 04 Jul '23

04 Jul '23

Shader Model 6 introduces a 16-bit float (half) type, and 16-bit and 64-bit integer types. Storing extra info in the type enum simplifies checking if a type is any integer, floating point or numeric type, and the declaration of SPIR-V types. The benefits depend on using enum vkd3d_data_type in the backend instead of vkd3d_shader_component_type. Patch 2 is difficult to split because types typically flow through to vkd3d_spirv_get_type_id(), so partial changes would require new calls to conversion functions which would be deleted again later. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/263

2 4

2025

2024

2023

2022

wine-gitlab July 2023