July 2023 - wine-gitlab

[PATCH v4 0/1] MR3392: comctl32/listview: Set bNoItemMetrics to TRUE in LISTVIEW_DeleteAllItems().
by Zhao Yi (＠Zhaoyi) 26 Jul '23

26 Jul '23

Same as MR !2394 Signed-off-by: Zhaoyi zhaoyi(a)uniontech.com -- v4: comctl32/listview: Set bNoItemMetrics to TRUE in LISTVIEW_DeleteAllItems(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3392

4 4

[PATCH 0/1] MR3409: mshtml: add some clarification to dispex_static_data_vtbl_t
by Yuxuan Shui (＠yshui) 26 Jul '23

26 Jul '23

Split from !3391, @insn -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3409

4 5

[PATCH 0/8] MR3408: mshtml: Implement Cycle Collection for all mshtml objects (dispex), part 1.
by Gabriel Ivăncescu (＠insn) 26 Jul '23

26 Jul '23

This is first part in a series that implements Cycle Collection for every mshtml object (dispex) and cleans up rest of the code based on it, which is obviously needed due to dynamic props and other extra object-specific refs. In an effort to split it up as much as possible, since it already has quite a lot of restructuring and changes, some of the earlier patches will introduce temporary leaks or cyclic refs, but that's because we'll later handle them properly with the dispex CC. These shouldn't affect behavior, though, so it shouldn't pose problems for functionality. Nodes are, initially, not changed much (other than to make it compatible with the dispex) to keep changes as small as possible. They still use their own CC mechanism and refcounting, which is hackish but that is solved in a follow-up MR, so it's temporary only. Eventually, every object (including nodes) will use the dispex's vtbl to do its Cycle Collection, except for stuff like outer window (which is a special case). In this first part, the objects that are using the node CC will have no-op dispex CC methods since they are using the node's, but this is temporary only. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3408

3 12

[PATCH v4 0/1] MR3393: dlls/kerberos: Implement KerbQueryTicketCacheExMessage.
by Maxim Karasev (＠mxkrsv) 26 Jul '23

26 Jul '23

Ensured to work with both the current `klist` implementation and the one modified to use KerbQueryTicketCacheExMessage. Patch for `klist` will be sent separately. -- v4: dlls/kerberos: Implement KerbQueryTicketCacheExMessage. https://gitlab.winehq.org/wine/wine/-/merge_requests/3393

4 3

[PATCH v2 0/1] MR3389: Use PCSC framework instead of pcsclite on macOS
by Gijs Vermeulen (＠gverm) 26 Jul '23

26 Jul '23

This framework is present in all macOS SDKs we support, starting at macOS 10.13 and still present in macOS Sonoma. Getting pcsclite completely working correctly is a lot harder on macOS and this would give us better integration. -- v2: configure: Use PCSC.framework when pcsclite is not available on macOS. https://gitlab.winehq.org/wine/wine/-/merge_requests/3389

3 3

[PATCH 0/1] MR3414: winex11.drv: Add a trailing linefeed to a WARN() message.
by Francois Gouget (＠fgouget) 26 Jul '23

26 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3414

3 2

[PATCH 0/1] MR3415: mfmediaengine: Add the trailing linefeed to a WARN() message.
by Francois Gouget (＠fgouget) 26 Jul '23

26 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3415

3 2

[PATCH 0/1] MR286: vkd3d: Implement ID3D12GraphicsCommandList3 with a stub.
by Conor McCarthy (＠cmccarthy) 26 Jul '23

26 Jul '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/286

3 2

[PATCH 0/4] MR3413: Assorted spelling fixes
by Francois Gouget (＠fgouget) 26 Jul '23

26 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3413

2 4

[PATCH 0/1] MR3361: gitlab: Skip amstream:amstream since it fails systematically.
by Francois Gouget (＠fgouget) 26 Jul '23

26 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55283 --- It has been causing every merge request to get a GitLab CI error ever since the move to Debian 12 on 2023-07-10. That makes the GitLab CI pretty horrible. If there is a quick fix for this issue then this MR can be ignored. Otherwise, since there is no way to tell the GitLab CI that a specific test is expected to crash or fail in a certain way, there is no other option than to skip the test entirely until it works again. Side-note: Finding failures in the GitLab CI logs is quite annoying. As far as I can tell the only way not to miss any is to perform a set of four searches: - "Test f" -> regular failures - "todo " -> Todo tests that unexpectedly succeed - "ne (2" -> Timeouts (and test units with 2 failures) - "ne (-" -> Crashes (with or without an 'unhandled exception' line) If anyone has an emacs macro to automate this... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3361

4 4

[PATCH 0/1] MR3412: ntdll/tests: Fix the NtSetInformationFile() test on Windows 10 <= 1709.
by Francois Gouget (＠fgouget) 26 Jul '23

26 Jul '23

It does not support FileDispositionInformationEx and returns various error codes. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55331 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3412

2 1

[PATCH v3 0/2] MR3392: comctl32/listview: Set bNoItemMetrics to TRUE in LISTVIEW_DeleteAllItems().
by Zhao Yi (＠Zhaoyi) 26 Jul '23

26 Jul '23

Same as MR !2394 Signed-off-by: Zhaoyi zhaoyi(a)uniontech.com -- v3: comctl32/listview: Set bNoItemMetrics to TRUE in LISTVIEW_DeleteAllItems(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3392

5 8

[PATCH 0/1] MR285: vkd3d: Handle the case where a descriptor is null and is concurrently written non-null.
by Conor McCarthy (＠cmccarthy) 26 Jul '23

26 Jul '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/285

4 3

[PATCH v2 0/1] MR3323: win32u: Don't clip captured mouse pointer only if it's done by the system.
by Gabriel Ivăncescu (＠insn) 26 Jul '23

26 Jul '23

-- v2: win32u: Don't clip captured mouse pointer only if it's done by the system. https://gitlab.winehq.org/wine/wine/-/merge_requests/3323

4 3

[PATCH 0/1] MR3411: dinput: Unacquire only DISCL_FOREGROUND devices on foreground changes.
by Rémi Bernon (＠rbernon) 26 Jul '23

26 Jul '23

Fixes broken input in Final Fantasy XIII after main window focus loss. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3411

2 1

[PATCH v3 0/3] MR3396: msvcrt: Further locale cleanups.
by Victor Hermann Chiletto (＠vitorhnn) 26 Jul '23

26 Jul '23

Fixes a memory leak and cleans up some other parts of MR !3050. -- v3: msvcrt: Remove uses of wcsncpy from locale_to_sname. https://gitlab.winehq.org/wine/wine/-/merge_requests/3396

2 4

[PATCH v2 0/3] MR3396: msvcrt: Further locale cleanups.
by Victor Hermann Chiletto (＠vitorhnn) 26 Jul '23

26 Jul '23

Fixes a memory leak and cleans up some other parts of MR !3050. -- v2: msvcrt: Remove uses of wcsncpy from locale_to_sname. https://gitlab.winehq.org/wine/wine/-/merge_requests/3396

4 8

[PATCH v3 0/2] MR3105: Add a few additional nullchecks (Coverity)
by Fabian Maurer (＠DarkShadow44) 26 Jul '23

26 Jul '23

-- v3: wineoss: Remove superflous check mmdevapi: Add nullcheck for parameter that can be null (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/3105

4 5

[PATCH v13 0/2] MR3391: mshtml: implement window.MutationObserver with MutationObserver stub
by Yuxuan Shui (＠yshui) 26 Jul '23

26 Jul '23

This get us pass the "Update your browser" blocker in adobe's sign-in page. The page itself doesn't make use of `window.MutationObserver`. However the sign-in page is still broken. -- v13: mshtml: add stubs for MutationObserver methods mshtml: implement window.MutationObserver with MutationObserver stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3391

3 3

[PATCH v12 0/1] MR3391: mshtml: implement window.MutationObserver with MutationObserver stub
by Yuxuan Shui (＠yshui) 25 Jul '23

25 Jul '23

This get us pass the "Update your browser" blocker in adobe's sign-in page. The page itself doesn't make use of `window.MutationObserver`. However the sign-in page is still broken. -- v12: mshtml: implement window.MutationObserver with MutationObserver stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3391

3 5

[PATCH v3 0/2] MR3351: mfmediaengine: Implement RemoveAllEffects().
by Bernhard Kölbl (＠besentv) 25 Jul '23

25 Jul '23

-- v3: mfmediaengine: Implement RemoveAllEffects(). mfmediaengine/tests: Add tests for RemoveAllEffects(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3351

3 6

[PATCH v3 0/1] MR3407: gdiplus: Disable StringFormatFlagsLineLimit
by David Kahurani (＠kahurani) 25 Jul '23

25 Jul '23

Builtin gdiplus behaves as documented but tests are indicating that Windows behaviour sometimes differs from the documentation. I believe this issue is at least one of the contributing issues to bug https://bugs.winehq.org/show_bug.cgi?id=46947, if not the sole issue. I propose that this flag be disabled until it is well understood. I noticed as issue with DrawString seeming to ignore the flag sometimes(sometimes the text fits without any noticeable defects which I believe is the case with the program in the bug) and sometimes even drawing clipped text with the flag on. Other times it works as expected. I can't seem to find a pattern to identify that could be used to predict its behaviour. Signed-off-by: David Kahurani k.kahurani(a)gmail.com -- v3: gdiplus: Disable StringFormatFlagsLineLimit https://gitlab.winehq.org/wine/wine/-/merge_requests/3407

3 3

[PATCH v3 0/1] MR3398: gdiplus: Prevent infinite loops due to floating point inaccuracy
by Fabian Maurer (＠DarkShadow44) 25 Jul '23

25 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52492 -- v3: gdiplus: Prevent infinite loops due to floating point inaccuracy https://gitlab.winehq.org/wine/wine/-/merge_requests/3398

4 4

Re: [PATCH v5 0/2] MR3363: windowscodecs: Handle PNG histogram (hIST) chunk type. - approved
by Esme Povirk (＠madewokherd) 25 Jul '23

25 Jul '23

This merge request was approved by Esme Povirk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3363

1 0

[PATCH v11 0/1] MR3391: mshtml: implement window.MutationObserver with MutationObserver stub
by Yuxuan Shui (＠yshui) 25 Jul '23

25 Jul '23

This get us pass the "Update your browser" blocker in adobe's sign-in page. The page itself doesn't make use of `window.MutationObserver`. However the sign-in page is still broken. -- v11: mshtml: implement window.MutationObserver with MutationObserver stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3391

3 2

[PATCH v3 0/1] MR3379: ntdll: Match Windows used block filling.
by Paul Gofman (＠gofman) 25 Jul '23

25 Jul '23

-- v3: ntdll: Match Windows used block filling. https://gitlab.winehq.org/wine/wine/-/merge_requests/3379

3 3

[PATCH 0/1] MR3410: advpack: Add nullcheck for parameter that can be null (Coverity)
by Fabian Maurer (＠DarkShadow44) 25 Jul '23

25 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3410

2 1

[PATCH v2 0/1] MR3379: ntdll: Match Windows used block filling.
by Paul Gofman (＠gofman) 25 Jul '23

25 Jul '23

-- v2: ntdll: Match Windows used block filling. https://gitlab.winehq.org/wine/wine/-/merge_requests/3379

4 7

[PATCH 0/1] MR3406: winegstreamer: Use a fixed size type for wg_sample data pointer.
by Rémi Bernon (＠rbernon) 25 Jul '23

25 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3406

3 2

[PATCH 0/1] MR268: vkd3d-shader/hlsl: Handle vector arguments in fmod().
by Nikolay Sivov (＠nsivov) 25 Jul '23

25 Jul '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/268

3 3

[PATCH 0/1] MR3379: ntdll: Match Windows used block filling.
by Paul Gofman (＠gofman) 25 Jul '23

25 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3379

3 4

[PATCH v2 0/2] MR3405: server: Use the capture window as cursor window if it is set.
by Rémi Bernon (＠rbernon) 25 Jul '23

25 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55306 -- v2: server: Use the capture window as cursor window if it is set. server: Update the desktop cursor position / window on click. https://gitlab.winehq.org/wine/wine/-/merge_requests/3405

2 2

[PATCH v2 0/1] MR3407: gdiplus: Disable StringFormatFlagsLineLimit
by David Kahurani (＠kahurani) 25 Jul '23

25 Jul '23

Builtin gdiplus behaves as documented but tests are indicating that Windows behaviour sometimes differs from the documentation. I believe this issue is at least one of the contributing issues to bug https://bugs.winehq.org/show_bug.cgi?id=46947, if not the sole issue. I propose that this flag be disabled until it is well understood. I noticed as issue with DrawString seeming to ignore the flag sometimes(sometimes the text fits without any noticeable defects which I believe is the case with the program in the bug) and sometimes even drawing clipped text with the flag on. Other times it works as expected. I can't seem to find a pattern to identify that could be used to predict its behaviour. Signed-off-by: David Kahurani k.kahurani(a)gmail.com -- v2: gdiplus: Disable StringFormatFlagsLineLimit https://gitlab.winehq.org/wine/wine/-/merge_requests/3407

3 2

[PATCH 0/1] MR3407: gdiplus: Disable StringFormatFlagsLineLimit
by David Kahurani (＠kahurani) 25 Jul '23

25 Jul '23

Builtin gdiplus behaves as documented but tests are indicating that Windows behaviour sometimes differs from the documentation. I believe this issue is at least one of the contributing issues to bug https://bugs.winehq.org/show_bug.cgi?id=46947, if not the sole issue. I propose that this flag be disabled until it is well understood. Signed-off-by: David Kahurani k.kahurani(a)gmail.com -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3407

3 2

[PATCH 0/1] MR3389: Use PCSC framework instead of pcsclite on macOS
by Gijs Vermeulen (＠gverm) 25 Jul '23

25 Jul '23

This framework is present in all macOS SDKs we support, starting at macOS 10.13 and still present in macOS Sonoma. Getting pcsclite completely working correctly is a lot harder on macOS and this would give us better integration. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3389

3 8

[PATCH 0/5] MR284: hlsl: Replace bare list pointers with hlsl_block, part 6.
by Zebediah Figura (＠zfigura) 25 Jul '23

25 Jul '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/284

4 7

[PATCH v5 0/1] MR279: vkd3d: Implement ID3D12Device1.
by Conor McCarthy (＠cmccarthy) 25 Jul '23

25 Jul '23

-- v5: vkd3d: Implement ID3D12Device1 with stubs. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/279

3 2

[PATCH 0/1] MR3405: server: Use the capture window as cursor window if it is set.
by Rémi Bernon (＠rbernon) 25 Jul '23

25 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55306 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3405

2 1

[PATCH 0/1] MR3403: server: Revert "server: Avoid using SOL_IPX to detect whether IPX is supported."
by Fotios Valasiadis (＠fvalasiad) 25 Jul '23

25 Jul '23

This reverts commit 41cc117b3f37ab4b9b4ac8a815cd2a496d38fb4b. This commit broke musl support. With the changes introduced, the following code evaluates to the #else branch without checking for SO_DEFAULT_HEADERS resulting in an error. server/sock.c +1888 ``` \#ifdef HAS_IPX int ipx_type = protocol - WS_NSPROTO_IPX; \#ifdef SOL_IPX setsockopt( sockfd, SOL_IPX, IPX_TYPE, &ipx_type, sizeof(ipx_type) ); \#else struct ipx val; /* Should we retrieve val using a getsockopt call and then * set the modified one? */ val.ipx_pt = ipx_type; setsockopt( sockfd, 0, SO_DEFAULT_HEADERS, &val, sizeof(val) ); \#endif \#endif ``` I propose reverting the commit, but we could probably alter the macro in the code section provided to match the changes relevant github issue: https://github.com/void-linux/void-packages/pull/45202 Signed-off-by: Fotios Valasiadis <fvalasiad(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3403

3 4

[PATCH v4 0/3] MR267: vkd3d: Implement GetResourceTiling().
by Conor McCarthy (＠cmccarthy) 25 Jul '23

25 Jul '23

-- v4: vkd3d: Implement ID3D12Device::GetResourceTiling() for textures. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/267

3 9

[PATCH v2 0/1] MR3393: dlls/kerberos: Implement KerbQueryTicketCacheExMessage.
by Maxim Karasev (＠mxkrsv) 25 Jul '23

25 Jul '23

Ensured to work with both the current `klist` implementation and the one modified to use KerbQueryTicketCacheExMessage. Patch for `klist` will be sent separately. -- v2: dlls/kerberos: Implement KerbQueryTicketCacheExMessage. https://gitlab.winehq.org/wine/wine/-/merge_requests/3393

3 3

[PATCH 0/4] MR3345: wined3d: Move struct wined3d_gl_info to struct wined3d_adapter_gl.
by Zebediah Figura (＠zfigura) 25 Jul '23

25 Jul '23

Get rid of the last few places in common code that read it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3345

3 5

[PATCH v8 0/1] MR3391: mshtml: implement window.MutationObserver with MutationObserver stub
by Yuxuan Shui (＠yshui) 25 Jul '23

25 Jul '23

This get us pass the "Update your browser" blocker in adobe's sign-in page. The page itself doesn't make use of `window.MutationObserver`. However the sign-in page is still broken. -- v8: mshtml: implement window.MutationObserver with MutationObserver stub https://gitlab.winehq.org/wine/wine/-/merge_requests/3391

3 8

[PATCH v2 0/1] MR3343: d3d11/tests: Mark test failures specific to the Vulkan or GL renderers.
by Zebediah Figura (＠zfigura) 25 Jul '23

25 Jul '23

-- v2: d3d11/tests: Mark test failures specific to the Vulkan or GL renderers. https://gitlab.winehq.org/wine/wine/-/merge_requests/3343

4 3

[PATCH v2 0/4] MR3342: wined3d: Stateblock refactoring.
by Zebediah Figura (＠zfigura) 25 Jul '23

25 Jul '23

-- v2: wined3d: Store push constants in wined3d_buffers in struct wined3d_state. https://gitlab.winehq.org/wine/wine/-/merge_requests/3342

4 7

[PATCH v2 0/2] MR3397: Draft: ucrtbase: Do not modify rewind's stack arguments on i386.
by Victor Hermann Chiletto (＠vitorhnn) 25 Jul '23

25 Jul '23

[A mod for Fallout: New Vegas relies on rewind not modifying the first argument passed to it.](https://github.com/jazzisparis/UIO-User-Interface-Organizer/blob/426d9… Since it only links to api-ms-win-crt-stdio I've kept the thunk usage to just ucrtbase. -- v2: msvcrt, ucrtbase: Introduce wine_i386_rewind. ucrtbase/tests: Test some details about rewind's ABI. https://gitlab.winehq.org/wine/wine/-/merge_requests/3397

3 6

[PATCH 0/3] MR3396: msvcrt: Further locale cleanups.
by Victor Hermann Chiletto (＠vitorhnn) 25 Jul '23

25 Jul '23

Fixes a memory leak and cleans up some other parts of MR !3050. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3396

3 4

[PATCH 0/1] MR3404: userenv: Fix setting ALLUSERSPROFILE and ProgramData in CreateEnvironmentBlock.
by Piotr Caban (＠piotr) 25 Jul '23

25 Jul '23

This syncs the code with dlls/ntdll/unix/env.c add_registry_environment. It fixes ALLUSERSPROFILE and ProgramData environment variables value in services. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3404

2 1

[PATCH v4 0/3] MR417: riched20: Add font fallback support.
by Jactry Zeng (＠jactry) 25 Jul '23

25 Jul '23

Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> -- v4: riched20: Add font fallbacks for CJK. riched20: Add font fallback support. riched20: Use OpenType functions for painting and generating script tags. https://gitlab.winehq.org/wine/wine/-/merge_requests/417

4 10

[PATCH v2 0/3] MR3105: Add a few additional nullchecks (Coverity)
by Fabian Maurer (＠DarkShadow44) 25 Jul '23

25 Jul '23

-- v2: wineoss: Remove superflous check advpack: Add nullcheck for parameter that can be null (Coverity) mmdevapi: Add nullcheck for parameter that can be null (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/3105

4 7

2025

2024

2023

2022

wine-gitlab July 2023