July 2023 - wine-gitlab

[PATCH 0/2] MR3278: windows.networking.hostname: Duplicate passed HSTRING in IHostNameFactory::CreateHostName().
by Mohamad Al-Jaf (＠maljaf) 24 Jul '23

24 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3278

3 3

Re: [PATCH v5 0/8] MR3249: windows.networking.hostname: Implement IHostNameFactory::CreateHostName().
by Rémi Bernon (＠rbernon) 24 Jul '23

24 Jul '23

On Mon Jul 10 05:32:36 2023 +0000, Mohamad Al-Jaf wrote: > Yeah, sorry for missing that. I've just been very burned out with life > in general. It's alright :slight_smile: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3249#note_39901

1 0

Re: [PATCH v2 0/0] MR2394: comctl32: Fix the problem that listview cannot display all files. - closed
by Zhao Yi (＠Zhaoyi) 24 Jul '23

24 Jul '23

This merge request was closed by Zhao Yi. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2394

1 0

[PATCH v4 0/1] MR3381: server: Try isolate wineserver directory.
by Konstantin Demin (＠rockdrilla) 24 Jul '23

24 Jul '23

try following locations for wineserver directory: - `${XDG_RUNTIME_DIR}/wine` - `/run/user/${uid}/wine` - `${TMPDIR}/wine` - only if `${TMPDIR}` is owned by user - `${TMPDIR}/.wine-${uid}` - `/tmp/.wine-${uid}` Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=39013 Signed-off-by: Konstantin Demin <rockdrilla(a)gmail.com> -- v4: server: Try isolate wineserver directory. https://gitlab.winehq.org/wine/wine/-/merge_requests/3381

3 2

[PATCH v3 0/1] MR3381: server: Try isolate wineserver directory.
by Konstantin Demin (＠rockdrilla) 24 Jul '23

24 Jul '23

try following locations for wineserver directory: - `${XDG_RUNTIME_DIR}/wine` - `/run/user/${uid}/wine` - `${TMPDIR}/wine` - only if `${TMPDIR}` is owned by user - `${TMPDIR}/.wine-${uid}` - `/tmp/.wine-${uid}` Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=39013 Signed-off-by: Konstantin Demin <rockdrilla(a)gmail.com> -- v3: server: Try isolate wineserver directory. https://gitlab.winehq.org/wine/wine/-/merge_requests/3381

3 2

[PATCH v2 0/1] MR3390: ntdll: Correctly handle pread short reads
by Aidan Hobson Sayers (＠aidanhs) 24 Jul '23

24 Jul '23

The read and pread syscalls are permitted to return fewer bytes than requested (unlike the fread libc call which will only perform a short read on error or EOF). This is most likely to occur when binaries are located on slower filesystems (e.g. NFS or 9pfs) ffab9d9 is a relatively recent regression here, but a lot of the code appears to be much older (e.g. the read call in 341b7dc) In this MR I've focused on ntdll, but I see a lot of similar mishandling of the pread return value in `server/`. I will raise a bug as I don't intend to create a follow up MR at this time. -- v2: ntdll: Correctly handle pread short reads https://gitlab.winehq.org/wine/wine/-/merge_requests/3390

3 2

[PATCH 0/1] MR3390: ntdll: Correctly handle pread short reads
by Aidan Hobson Sayers (＠aidanhs) 23 Jul '23

23 Jul '23

The read and pread syscalls are permitted to return fewer bytes than requested (unlike the fread libc call which will only perform a short read on error or EOF). This is most likely to occur when binaries are located on slower filesystems (e.g. NFS or 9pfs) ffab9d9 is a relatively recent regression here, but a lot of the code appears to be much older (e.g. the read call in 341b7dc) In this MR I've focused on ntdll, but I see a lot of similar mishandling of the pread return value in `server/`. I will raise a bug as I don't intend to create a follow up MR at this time. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3390

3 2

[PATCH v2 0/1] MR3363: windowscodecs: Handle PNG histogram (hIST) chunk type.
by Jeffrey Smith (＠whydoubt) 23 Jul '23

23 Jul '23

-- v2: windowscodecs: PROPVARIANT fields should use CoTaskMem allocation. https://gitlab.winehq.org/wine/wine/-/merge_requests/3363

3 2

[PATCH 0/1] MR3387: gdiplus/font: Fix GdipGetLogFontW/A with gdi_transform
by David Kahurani (＠kahurani) 23 Jul '23

23 Jul '23

These APIs should take into consideration the gdi_transform when calculating font properties Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3387

3 2

[PATCH 0/3] MR3386: quartz, amstream: Three patches for amstream tests.
by Zebediah Figura (＠zfigura) 23 Jul '23

23 Jul '23

The leak fixes seem to resolve bug 55283. It's very concerning that address space pressure is already that high, but... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3386

2 3

[PATCH v2 0/2] MR3381: server: Try isolate wineserver directory.
by Konstantin Demin (＠rockdrilla) 22 Jul '23

22 Jul '23

try following locations for wineserver directory: - `${XDG_RUNTIME_DIR}/wine` - `/run/user/${uid}/wine` - `${TMPDIR}/wine` - only if `${TMPDIR}` is owned by user - `${TMPDIR}/.wine-${uid}` - `/tmp/.wine-${uid}` Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=39013 Signed-off-by: Konstantin Demin <rockdrilla(a)gmail.com> -- v2: server: Avoid wineserver directory race. https://gitlab.winehq.org/wine/wine/-/merge_requests/3381

2 2

[PATCH v2 0/1] MR3382: winebuild: Zero space between Wine signature and PE header in "builtin" files.
by Konstantin Demin (＠rockdrilla) 22 Jul '23

22 Jul '23

Signed-off-by: Konstantin Demin <rockdrilla(a)gmail.com> -- v2: winebuild: Zero space between Wine signature and PE header in "builtin" files. https://gitlab.winehq.org/wine/wine/-/merge_requests/3382

2 1

[PATCH 0/6] MR3359: gdiplus: Set GIF properties correctly.
by Jeffrey Smith (＠whydoubt) 22 Jul '23

22 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3359

3 10

[PATCH 0/1] MR3363: windowscodecs: Handle PNG histogram (hIST) chunk type.
by Jeffrey Smith (＠whydoubt) 22 Jul '23

22 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3363

3 2

[PATCH v2 0/1] MR3368: where: Implement search with default options.
by Alex Henrie (＠alexhenrie) 22 Jul '23

22 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55282 -- v2: where: Implement search with default options. https://gitlab.winehq.org/wine/wine/-/merge_requests/3368

2 1

[PATCH 0/5] MR3362: uiautomationcore: Add support for invoking COM event handlers and implement IUIAutomationFocusChangedEventHandler methods.
by Connor McAdams (＠cmcadams) 22 Jul '23

22 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3362

3 6

[PATCH 0/5] MR3385: ws2_32/tests: Various test fixes.
by Zebediah Figura (＠zfigura) 22 Jul '23

22 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3385

2 5

[PATCH 0/2] MR3384: ws2_32: Move the event reset in WSAEnumNetworkEvents() to the server.
by Zebediah Figura (＠zfigura) 22 Jul '23

22 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3384

2 2

[PATCH 0/1] MR3383: winevulkan: Update to VK spec version 1.3.259.
by Georg Lehmann (＠DadSchoorse) 22 Jul '23

22 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3383

2 1

[PATCH 0/1] MR3381: server: Try isolate wineserver directory.
by Konstantin Demin (＠rockdrilla) 22 Jul '23

22 Jul '23

try following locations for wineserver directory: - `${XDG_RUNTIME_DIR}/wine` - `/run/user/${uid}/wine` - `${TMPDIR}/wine` - only if `${TMPDIR}` is owned by user - `${TMPDIR}/.wine-${uid}` - `/tmp/.wine-${uid}` Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=39013 Signed-off-by: Konstantin Demin <rockdrilla(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3381

3 2

[PATCH 0/1] MR3382: winebuild: Zero space between Wine signature and PE header in "builtin" files.
by Konstantin Demin (＠rockdrilla) 22 Jul '23

22 Jul '23

Signed-off-by: Konstantin Demin <rockdrilla(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3382

2 1

[PATCH 0/11] MR3380: mmdevapi: Implement AudioClient_Create.
by Davide Beatrici (＠davidebeatrici) 22 Jul '23

22 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3380

2 12

Re: [PATCH v5 0/2] MR3260: mmdevapi: Implement get_audio_session.
by Davide Beatrici (＠davidebeatrici) 22 Jul '23

22 Jul '23

On Wed Jul 19 19:55:17 2023 +0000, Davide Beatrici wrote: > The function declaration. For that reason I believe it's not worth > removing the comment, as it's only going to increase the amount of > changes in the commit/MR. !3380 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3260#note_39797

1 0

[PATCH 0/2] MR3369: mf/tests: Test sample processing for MPEG4 media sink.
by Ziqing Hui (＠zhui) 22 Jul '23

22 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3369

3 17

[PATCH 0/1] MR3378: httpapi/tests: Do not test that a local TCP port is closed.
by Zebediah Figura (＠zfigura) 22 Jul '23

22 Jul '23

I suspect the intent of this test was to verify that httpapi really doesn't bind to that port. That HttpAddUrlToUrlGroup() fails implies this, but paranoia in a case like this is rarely unwarranted. However, this test cannot reliably succeed; some other operating system component may open a TCP port in the meantime, and it appears that on Windows 10 this does in fact happen. Since the goal of the test is just extra paranoia, I don't think it's worth keeping. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55127 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3378

2 1

[PATCH 0/1] MR3377: po: Update Lithuanian translation
by Aurimas Fišeras (＠AurimasF) 21 Jul '23

21 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3377

3 2

Re: [PATCH v2 0/1] MR3376: user32/tests: Change display mode for correct monitor in check_preferred_mode(). - approved
by Alexandre Julliard (＠julliard) 21 Jul '23

21 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3376

1 0

Re: [PATCH v3 0/1] MR3370: win32u/tests: Add tests for handling LPARAM in window procs and hooks. - approved
by Alexandre Julliard (＠julliard) 21 Jul '23

21 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3370

1 0

Re: [PATCH v2 0/3] MR3375: msvcrt: setlocale fixes - approved
by Alexandre Julliard (＠julliard) 21 Jul '23

21 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3375

1 0

Re: [PATCH v2 0/1] MR3373: services: Exit early in process_send_start_message if ConnectNamedPipe fails. - approved
by Alexandre Julliard (＠julliard) 21 Jul '23

21 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3373

1 0

Re: [PATCH v3 0/2] MR3365: ntdll: Avoid storing a second ctx copy in the aarch64 raise trampoline - approved
by Alexandre Julliard (＠julliard) 21 Jul '23

21 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3365

1 0

Re: [PATCH v3 0/1] MR3374: include/ntsecapi.h: Add more Kerberos cache info types. - approved
by Alexandre Julliard (＠julliard) 21 Jul '23

21 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3374

1 0

Re: [PATCH v13 0/1] MR3347: klist: Add a program that lists Kerberos tickets. - approved
by Alexandre Julliard (＠julliard) 21 Jul '23

21 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3347

1 0

Re: [PATCH v2 0/1] MR3371: winevulkan: Update to VK spec version 1.3.258. - approved
by Alexandre Julliard (＠julliard) 21 Jul '23

21 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3371

1 0

Re: [PATCH v3 0/5] MR3366: sapi: Implement more tts functionality. - approved
by Alexandre Julliard (＠julliard) 21 Jul '23

21 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3366

1 0

Re: [PATCH v2 0/1] MR3364: po: Update Lithuanian translation. - approved
by Alexandre Julliard (＠julliard) 21 Jul '23

21 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3364

1 0

[PATCH 0/3] MR3375: msvcrt: setlocale fixes
by Piotr Caban (＠piotr) 21 Jul '23

21 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3375

3 7

[PATCH 0/1] MR3376: user32/tests: Change display mode for correct monitor in check_preferred_mode().
by Paul Gofman (＠gofman) 21 Jul '23

21 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55065 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3376

2 1

[PATCH v2 0/1] MR3374: include/ntsecapi.h: Add more Kerberos cache info types.
by Maxim Karasev (＠mxkrsv) 21 Jul '23

21 Jul '23

-- v2: include/ntsecapi.h: Add more Kerberos cache info types. https://gitlab.winehq.org/wine/wine/-/merge_requests/3374

2 1

Re: [PATCH v2 0/1] MR3312: programs/start: Allow Ctrl-C to terminate GUI applications (/exec mode).
by eric pouech (＠epo) 21 Jul '23

21 Jul '23

@jacek sorry I somehow missed your comment on the other MR I'm not sure I like the patch as is... - I wonder if kernelbase.CtrlRoutine should only be called for CUI programs... MSDN doc is as usual imprecise (it speaks about all descendants, and all descendants attached to the same console) - quick test show that a GUI process isn't killed by GenerateConsoleCtrlEvent + tested parent + console, cp_flags=0 and pgid = parent's pgid + tested parent + console, cp_flags=detached + new group, pgid = child.id => it doesn't fully anwser whether CtrlRoutine is called or not for GUI - it assumes pgid are inherited for gui (but we don't have proper tests AFAICT) moreover it means that we'd want two different behaviors when receiving SIGINT (whether it's a genuine unix signal or one sent by the server if we follow the tests result above) perhaps, the solution would be in the default_ctrl_handler to only terminate the program if attached to a console, or in the program group of a unix console remark: Wine unix console is the sole case where launching a GUI program from command line doesn't return immediately to prompt (native & builtin cmd implementation only wait on CUI programs completion). But that's conform to unix behavior. note: I'm not even sure tweeking with setsid whould be useful as anyway the unix console is in raw mode, so only conhost regenerates the signals -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3312#note_39749

1 0

[PATCH 0/1] MR3374: include/ntsecapi.h: add more Kerberos cache info types.
by Maxim Karasev (＠mxkrsv) 21 Jul '23

21 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3374

2 1

[PATCH v2 0/1] MR3370: win32u/tests: Add tests for handling LPARAM in window procs and hooks.
by Jacek Caban (＠jacek) 21 Jul '23

21 Jul '23

-- v2: win32u/tests: Add tests for handling LPARAM in window procs and hooks. https://gitlab.winehq.org/wine/wine/-/merge_requests/3370

2 1

[PATCH v2 0/2] MR3365: ntdll: Pass the trampoline ctx to the exception dispatcher on aarch64.
by Billy Laws (＠bylaws) 21 Jul '23

21 Jul '23

CFI directives allow the context stored on the stack by raise_func_trampoline to be used to unwind to any exception handlers as required when dispatching an exception. As the dispatcher may change its input context in e.g. BTCpuResetToConsistentState and these changes also need to be used when unwinding make sure to pass this copy of the context to KiUserExceptionDispatcher as opposed to the copy initially stored on the stack, which is not taken into account when unwinding. -- v2: ntdll: Avoid storing a second ctx copy in the aarch64 raise trampoline ntdll: Add aarch64 DWARF register definitions. https://gitlab.winehq.org/wine/wine/-/merge_requests/3365

2 3

[PATCH 0/1] MR3373: services: Exit early in process_send_start_message if ConnectNamedPipe fails.
by Piotr Caban (＠piotr) 21 Jul '23

21 Jul '23

HasOverlappedIoCompleted returns true after CancelIo call. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3373

2 1

Re: [PATCH v2 0/1] MR3312: programs/start: Allow Ctrl-C to terminate GUI applications (/exec mode).
by Jacek Caban (＠jacek) 21 Jul '23

21 Jul '23

What about my suggestion from !3290? Something like the attached [patch](/uploads/86c669e3c725b4f009338e80379552f4/patch.diff) should make it work, but we'd probably need some adjustments to `setsid` heuristics as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3312#note_39734

1 0

[PATCH 0/1] MR3371: winevulkan: Update to VK spec version 1.3.258.
by Georg Lehmann (＠DadSchoorse) 21 Jul '23

21 Jul '23

This does not enable VK_NV_device_generated_commands_compute because the extension will likely see an API breaking naming fix. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3371

2 1

[PATCH 0/1] MR3370: win32u/tests: Add tests for handling LPARAM in window procs and hooks.
by Jacek Caban (＠jacek) 21 Jul '23

21 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3370

2 1

Re: [PATCH v2 0/1] MR3312: programs/start: Allow Ctrl-C to terminate GUI applications (/exec mode).
by eric pouech (＠epo) 21 Jul '23

21 Jul '23

rebased in order to get rid of error of compilation on mac failure on amstream is still present: looks like a generic issue when exiting gstreamer in 32bit (can repro locally without that MR applied) @julliard need to do something else? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3312#note_39733

1 0

[PATCH 0/1] MR3365: ntdll: Pass the trampoline ctx to the exception dispatcher on aarch64.
by Billy Laws (＠bylaws) 21 Jul '23

21 Jul '23

CFI directives allow the context stored on the stack by raise_func_trampoline to be used to unwind to any exception handlers as required when dispatching an exception. As the dispatcher may change its input context in e.g. BTCpuResetToConsistentState and these changes also need to be used when unwinding make sure to pass this copy of the context to KiUserExceptionDispatcher as opposed to the copy initially stored on the stack, which is not taken into account when unwinding. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3365

3 3

Re: [PATCH v2 0/5] MR3366: sapi: Implement more tts functionality. - approved
by Huw Davies (＠huw) 21 Jul '23

21 Jul '23

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3366

1 0

2025

2024

2023

2022

wine-gitlab July 2023