July 2023 - wine-gitlab

[PATCH v2 0/2] MR3232: d3d10core/tests: Mark test failures specific to the Vulkan or GL renderers.
by Zebediah Figura (＠zfigura) 04 Jul '23

04 Jul '23

This is obviously questionable, as it requires reaching into Wine internals in tests (beyond simply detecting whether Wine is in use). However, we are at a point where, for d3d10 and above, the Vulkan renderer works well enough in general to see real use [in fact, in my experience it usually works better than the GL renderer], and at this point I think avoiding regressions is quite important. It is currently difficult to run tests with it when the results contain so much noise, and I think we need to solve this problem, by actually marking which tests work on each backend. We could in theory expose the renderer through some adapter string, but I believe in the past applications have been sensitive about the contents of adapter strings. Fixing either renderer to reach and maintain parity is not feasible. The GL renderer is not going away, but regrettably GL as an API is abandoned by Khronos, and important features we need in order to implement some Direct3D features will probably never be introduced into GL. Moreover, the amount of effort that would be required to reach parity is not small, and itself would all need to be verified manually. -- v2: d3d10core/tests: Mark test failures specific to the Vulkan or GL renderers. https://gitlab.winehq.org/wine/wine/-/merge_requests/3232

4 4

[PATCH 0/3] MR3217: wined3d: Reuse command buffers and fences.
by Zebediah Figura (＠zfigura) 04 Jul '23

04 Jul '23

This improves performance with Batman: Arkham Knight on NVidia drivers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3217

3 4

[PATCH 0/5] MR3212: wined3d: Reduce command stream CPU usage, part 1
by Matteo Bruni (＠Mystral) 04 Jul '23

04 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3212

4 12

Re: [PATCH v3 0/6] MR3165: dxgi: Introduce a worker thread for each D3D12 swapchain (first part).
by Henri Verbeet (＠hverbeet) 04 Jul '23

04 Jul '23

> The part that doesn't thrill me is the fact that DXGI still directly accesses the VkQueue object, which I tend to see as an internal implementation detail to vkd3d. On the other hand it's nice that we don't need new API from vkd3d (even if, in the future, we were to need something other than vkQueueSubmit() and vkQueuePresentKHR()). For what it's worth, it was a fairly explicit design decision early on to expose the underlying Vulkan objects for d3d12 devices and command queues, as well as to allow the creation of d3d12 resources on top of existing Vulkan images, for the purpose of interoperation with other Vulkan code. I.e., the idea is that it should be possible to integrate vkd3d into a larger Vulkan application to draw some parts using the d3d12 API, while everything else is drawn using Vulkan. The internal queueing of command queue operations on the vkd3d level is unfortunate in that regard; ideally we just wouldn't do that. This MR could probably do a better job of explaining why we need to do that in some cases, and what kind of command queue operation sequences could result in out-of-order presentation. If we're going to need to introduce a DXGI worker thread anyway, could we just make vkd3d_acquire_vk_queue() block until there are no longer any operations queued? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3165#note_37779

1 0

[PATCH v3 0/1] MR3206: vbscript: Support one-line sub/function
by Fabian Maurer (＠DarkShadow44) 04 Jul '23

04 Jul '23

Sub / Function can be on one line, but only if there's brackets. ``` | Storage_opt tFUNCTION Identifier ArgumentsDecl BodyStatements tEND tFUNCTION ``` This leads to sometimes to `link_statements` being called with `head` being NULL, probably because now the `:` can be parsed as `Statement` in `BodyStatements`. Also note that this introduces another shift/reduce conflict, could be related, but I don't understand it well enough. Feedback would be appreciated, I'm still learning bison. -- v3: vbscript: Support one-line sub/function. https://gitlab.winehq.org/wine/wine/-/merge_requests/3206

3 2

Re: [PATCH v3 0/6] MR3165: dxgi: Introduce a worker thread for each D3D12 swapchain (first part). - approved
by Jan Sikorski (＠jsikorski) 04 Jul '23

04 Jul '23

This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3165

1 0

[PATCH v13 0/2] MR2778: mfmediaengine: Add support for video effects.
by Bernhard Kölbl (＠besentv) 04 Jul '23

04 Jul '23

The test has a little inspiration from the SDK samples. -- v13: mfmediaengine: Add support for inserting video effects. mfmediaengine/tests: Add tests for video effects. https://gitlab.winehq.org/wine/wine/-/merge_requests/2778

2 4

[PATCH v5 0/8] MR3218: wine{alsa,coreaudio,oss,pulse}: Move session_init_vols, create_session into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 04 Jul '23

04 Jul '23

-- v5: https://gitlab.winehq.org/wine/wine/-/merge_requests/3218

3 9

[PATCH 0/4] MR3234: winewayland.drv: part 5: window_surface flush optimizations
by Alexandros Frantzis (＠afrantzis) 04 Jul '23

04 Jul '23

This MR optimizes and makes correctness improvements to the window_surface flush implementation: 1. Implement a buffer queue to avoid constantly allocating new buffers. 2. Take into account the bounds of the window_surface flush and track per-buffer damage to reduce copying from the window_surface. 3. Copy from the window_surface only pixel data that lies within the flushed bounds. Maintain the latest contents for pixels outside these bounds, by copying them from the latest valid buffer. 4. Communicate damaged surface regions to the compositor to allow it to perform more efficient pixel data transfers (e.g., texture uploads). Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3234

2 4

[PATCH v4 0/1] MR3114: comctl32: Make the correct linkid from fun SYSLINK_LinkAtPt.
by Zhao Yi (＠Zhaoyi) 04 Jul '23

04 Jul '23

Add a check condition for whether the type is slLink. Signed-off-by: Zhaoyi <zhaoyi(a)uniontech.com> -- v4: comctl32: Make the correct linkid from fun SYSLINK_LinkAtPt. https://gitlab.winehq.org/wine/wine/-/merge_requests/3114

3 3

2025

2024

2023

2022

wine-gitlab July 2023