July 2023 - wine-gitlab

Re: [PATCH v2 0/1] MR3360: shell32: Improve shell copy and delete items functions, notifications.
by Huw Campbell (＠HuwCampbell) 29 Jul '23

29 Jul '23

I had a review from the ReactOS guys with some suggestions, but before I make them is there any interest in taking up maintenance changes like the for the shell? Who should I ping for a review? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3360#note_40686

1 0

[PATCH 0/8] MR3449: Misc Remove DECLSPEC_HIDDEN usage.
by Alistair Leslie-Hughes (＠alesliehughes) 29 Jul '23

29 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3449

2 8

[PATCH 0/1] MR3445: server: Open files in blocking mode in create_file
by Aidan Hobson Sayers (＠aidanhs) 29 Jul '23

29 Jul '23

This fixes a bug in wine when running on 9pfs where short reads would occur, causing binaries to be loaded incorrectly. All other filesystems on Linux ignore O_NONBLOCK for regular files, so this should not affect them. Thanks to Paul Gofman for the advice on this fix. --- Ref https://gitlab.winehq.org/wine/wine/-/merge_requests/3390 for my original attempt at fixing this, particularly https://gitlab.winehq.org/wine/wine/-/merge_requests/3390#note_40093 which describes the strange situation `O_NONBLOCK` finds itself in on filesystems. The risk with this MR is that fifo, unix sockets or other special files opened via `open_unix_file` in ntdll will now have changed behaviour - but my quick look suggests that this is unlikely, as `open_unix_file` is only used for: - `dlls/ntdll/unix/file.c`: `NtCreateFile` and `NtDeleteFile` - `dlls/ntdll/unix/process.c`: loading PE information and getting a dirfd for the current directory - `dlls/ntdll/unix/env.c`: `open_nls_data_file` - `dlls/ntdll/unix/loader.c`: dll load functions - `dlls/ntdll/unix/registry.c`: `NtLoadKeyEx` cc @gofman -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3445

4 5

[PATCH 0/1] MR3447: ntdll/unix: NtTerminateThread should accept NULL handle
by Ake Rehnman (＠ake.rehnman) 29 Jul '23

29 Jul '23

Resolves https://bugs.winehq.org/show_bug.cgi?id=55352 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3447

2 1

[PATCH v3 0/1] MR3425: msvcp140_codecvt_ids: Add DLL.
by Mohamad Al-Jaf (＠maljaf) 28 Jul '23

28 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55344 It looks like the exports are just variables. -- v3: msvcp140_codecvt_ids: Add DLL. https://gitlab.winehq.org/wine/wine/-/merge_requests/3425

3 3

[PATCH v3 0/1] MR3390: ntdll: Correctly handle pread short reads
by Aidan Hobson Sayers (＠aidanhs) 28 Jul '23

28 Jul '23

The read and pread syscalls are permitted to return fewer bytes than requested (unlike the fread libc call which will only perform a short read on error or EOF). This is most likely to occur when binaries are located on slower filesystems (e.g. NFS or 9pfs) ffab9d9 is a relatively recent regression here, but a lot of the code appears to be much older (e.g. the read call in 341b7dc) In this MR I've focused on ntdll, but I see a lot of similar mishandling of the pread return value in `server/`. I will raise a bug as I don't intend to create a follow up MR at this time. -- v3: ntdll: Correctly handle pread short reads https://gitlab.winehq.org/wine/wine/-/merge_requests/3390

4 13

[PATCH 0/2] MR3432: windowscodecs: PNG tIME chunk
by Jeffrey Smith (＠whydoubt) 28 Jul '23

28 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3432

3 3

Re: [PATCH v2 0/2] MR3431: wined3d: Fix clears of the current render target in Vulkan
by Evan Tang (＠etang-cw) 28 Jul '23

28 Jul '23

On Fri Jul 28 02:22:22 2023 +0000, **** wrote: > Marvin replied on the mailing list: > ``` > Hi, > It looks like your patch introduced the new failures shown below. > Please investigate and fix them before resubmitting your patch. > If they are not new, fixing them anyway would help a lot. Otherwise > please ask for the known failures list to be updated. > The tests also ran into some preexisting test failures. If you know how > to fix them that would be helpful. See the TestBot job for the details: > The full results can be found at: > https://testbot.winehq.org/JobDetails.pl?Key=135341 > Your paranoid android. > === debian11 (32 bit zh:CN report) === > Report validation errors: > d3d11:d3d11 crashed (c0000005) > ``` This looks like https://bugs.winehq.org/show_bug.cgi?id=53217 so I don't think it's new -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3431#note_40653

1 0

Re: [PATCH v2 0/2] MR3431: wined3d: Fix clears of the current render target in Vulkan
by Zebediah Figura (＠zfigura) 28 Jul '23

28 Jul '23

Hah, hilariously, I noticed this when examining the vulkan draw code, but never got farther than writing a (far less expansive) test... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3431#note_40652

1 0

Re: [PATCH v2 0/2] MR3431: wined3d: Fix clears of the current render target in Vulkan - approved
by Zebediah Figura (＠zfigura) 28 Jul '23

28 Jul '23

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3431

1 0

2025

2024

2023

2022

wine-gitlab July 2023