July 2023 - wine-gitlab

[PATCH v2 0/3] MR3330: xinput: Fix WRC9 crashing on start
by Etaash Mathamsetty (＠etaash.mathamsetty) 24 Jul '23

24 Jul '23

This MR fixes WRC9 crashing on start with builtin xinput, since the game uses UWP xinput the ordinal numbers don't match up, so I decided to put these new exports with `@ stdcall` instead. When running winedump on the windows native dll, they don't have these exports at all :/ -- v2: xinput1_3: Add stub for XInputDestroy. xinput1_3: Add semi-stub for XInputSetStateEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/3330

5 12

[PATCH v3 0/7] MR3271: windows.devices.usb: Implement IUsbDeviceStatics::GetDeviceSelectorVidPidOnly().
by Mohamad Al-Jaf (＠maljaf) 24 Jul '23

24 Jul '23

Needed for Lenovo Ready for Assistant. -- v3: windows.devices.usb/tests: Add IUsbDeviceStatics::GetDeviceSelectorVidPidOnly() tests. windows.devices.usb: Implement IUsbDeviceStatics::GetDeviceSelectorVidPidOnly(). windows.devices.usb: Add IUsbDeviceStatics stub interface. windows.devices.usb: Add stub DLL. include: Add windows.devices.usb.idl file. include: Add support for IAsyncOperation parameterized type IBuffer. include: Add support for IAsyncOperation UINT32. https://gitlab.winehq.org/wine/wine/-/merge_requests/3271

3 9

[PATCH 0/5] MR3388: win32u: Introduce new message packing for user callbacks.
by Jacek Caban (＠jacek) 24 Jul '23

24 Jul '23

We currently try to preserve message's lparam value in win32u. This is inherited from user32 and it was needed in the past, but with !493 (and !646), this is mostly covered by leaving win32u out of winproc calls whenever possible. According to tests, native win32k almost never attempts to preserve lparam and copies its content instead (with a few exceptions for messages passing strings). Implementing that in Wine will provide a nice way to fix problem from bug 55152. This is the first patch in the series that will implement it. Since user callback requirements are different than server communication, the series incrementally decouples them. I created https://gitlab.winehq.org/jacek/wine/-/commits/win32u-msg/ with complete conversion for a better context. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3388

3 6

[PATCH 0/2] MR3278: windows.networking.hostname: Duplicate passed HSTRING in IHostNameFactory::CreateHostName().
by Mohamad Al-Jaf (＠maljaf) 24 Jul '23

24 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3278

3 3

Re: [PATCH v5 0/8] MR3249: windows.networking.hostname: Implement IHostNameFactory::CreateHostName().
by Rémi Bernon (＠rbernon) 24 Jul '23

24 Jul '23

On Mon Jul 10 05:32:36 2023 +0000, Mohamad Al-Jaf wrote: > Yeah, sorry for missing that. I've just been very burned out with life > in general. It's alright :slight_smile: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3249#note_39901

1 0

Re: [PATCH v2 0/0] MR2394: comctl32: Fix the problem that listview cannot display all files. - closed
by Zhao Yi (＠Zhaoyi) 24 Jul '23

24 Jul '23

This merge request was closed by Zhao Yi. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2394

1 0

[PATCH v4 0/1] MR3381: server: Try isolate wineserver directory.
by Konstantin Demin (＠rockdrilla) 24 Jul '23

24 Jul '23

try following locations for wineserver directory: - `${XDG_RUNTIME_DIR}/wine` - `/run/user/${uid}/wine` - `${TMPDIR}/wine` - only if `${TMPDIR}` is owned by user - `${TMPDIR}/.wine-${uid}` - `/tmp/.wine-${uid}` Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=39013 Signed-off-by: Konstantin Demin <rockdrilla(a)gmail.com> -- v4: server: Try isolate wineserver directory. https://gitlab.winehq.org/wine/wine/-/merge_requests/3381

3 2

[PATCH v3 0/1] MR3381: server: Try isolate wineserver directory.
by Konstantin Demin (＠rockdrilla) 24 Jul '23

24 Jul '23

try following locations for wineserver directory: - `${XDG_RUNTIME_DIR}/wine` - `/run/user/${uid}/wine` - `${TMPDIR}/wine` - only if `${TMPDIR}` is owned by user - `${TMPDIR}/.wine-${uid}` - `/tmp/.wine-${uid}` Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=39013 Signed-off-by: Konstantin Demin <rockdrilla(a)gmail.com> -- v3: server: Try isolate wineserver directory. https://gitlab.winehq.org/wine/wine/-/merge_requests/3381

3 2

[PATCH v2 0/1] MR3390: ntdll: Correctly handle pread short reads
by Aidan Hobson Sayers (＠aidanhs) 24 Jul '23

24 Jul '23

The read and pread syscalls are permitted to return fewer bytes than requested (unlike the fread libc call which will only perform a short read on error or EOF). This is most likely to occur when binaries are located on slower filesystems (e.g. NFS or 9pfs) ffab9d9 is a relatively recent regression here, but a lot of the code appears to be much older (e.g. the read call in 341b7dc) In this MR I've focused on ntdll, but I see a lot of similar mishandling of the pread return value in `server/`. I will raise a bug as I don't intend to create a follow up MR at this time. -- v2: ntdll: Correctly handle pread short reads https://gitlab.winehq.org/wine/wine/-/merge_requests/3390

3 2

[PATCH 0/1] MR3390: ntdll: Correctly handle pread short reads
by Aidan Hobson Sayers (＠aidanhs) 23 Jul '23

23 Jul '23

The read and pread syscalls are permitted to return fewer bytes than requested (unlike the fread libc call which will only perform a short read on error or EOF). This is most likely to occur when binaries are located on slower filesystems (e.g. NFS or 9pfs) ffab9d9 is a relatively recent regression here, but a lot of the code appears to be much older (e.g. the read call in 341b7dc) In this MR I've focused on ntdll, but I see a lot of similar mishandling of the pread return value in `server/`. I will raise a bug as I don't intend to create a follow up MR at this time. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3390

3 2

2025

2024

2023

2022

wine-gitlab July 2023