July 2023 - wine-gitlab

[PATCH 0/3] MR269: vkd3d-shader/tpf: Combine struct sm4_dst_register and struct sm4_src_register.
by Francisco Casas (＠fcasas) 19 Jul '23

19 Jul '23

This series is basically a single patch but that requires @cmccarthy's !225 first. So, the 2 patches from !225 are included as 1/3 and 2/3. As can be implied from !225, in SM4 bytecode, all the information regarding whether the register uses a writemask, a swizzle, a dimension index, or none of these, is encoded in the register itself, and doesn't depend on the instruction nor argument position on which the register is used. The possible register encodings are given by the following diagram: ![diagram3.drawio](/uploads/db330c2f7cc47801e3c3672828ae23b9/diagram3.drawio.png) Where the swizzle_type (MASK4, VEC4, or SCALAR) only matter when the dim is VEC4. Thus, it makes sense to merge these two types of registers into a single data type as 3/3 does. This has the added benefit of removing additional writemask and swizzle_type arguments to be initialized by pointer in several helper functions. Also, this would help me to simplify a new version of !229. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/269

4 7

[PATCH 0/1] MR3357: winecoreaudio: Fix missing struct member in get_position() Wow64 thunk.
by Brendan Shanks (＠bshanks) 19 Jul '23

19 Jul '23

Fixes sporadic audio issues in 32-bit apps like Spider Solitaire, CEF, and likely others. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3357

3 3

Re: [PATCH v5 0/7] MR3328: sapi: Partially implement ISpVoice::Speak.
by Shaun Ren (＠shaunren) 19 Jul '23

19 Jul '23

On Wed Jul 19 19:09:02 2023 +0000, Huw Davies wrote: > There are a lot of changes in this MR, in particular the second commit > could do with splitting and then the MR itself would ideally be split > into two. Done. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3328#note_39522

1 0

[PATCH 0/3] MR267: vkd3d: Implement GetResourceTiling().
by Conor McCarthy (＠cmccarthy) 19 Jul '23

19 Jul '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/267

4 8

[PATCH v5 0/2] MR271: Introduce a GitLab pipeline for vkd3d
by Giovanni Mascellani (＠giomasce) 19 Jul '23

19 Jul '23

With this pipeline vkd3d automatically gets built on Linux (in an image based on Debian unstable), both in 32 and 64 bit mode. Both builds are tested with radv and llvmpipe. A number of caveats apply, though: * A number of tests currently fail in llvmpipe, so the llvmpipe jobs are marked as allowed to fail. Ideally we'll eventually fix our bugs and mark the llvmpipe ones in the tests, so that the CI tests completely pass and possible problems in the Vulkan driver are recorded at a better granularity (this is the reason why GitLab says that the pipeline is passed with warnings: the warnings are that there are jobs that failed, even if they were allowed to fail). * ~~The runners provided by the GitLab instance don't have a GPU available, so I configured my own computer (equipped with an AMD Radeon RX 5700 RX) to provide a runner with access to the GPU. This setup is not currently satisfying: for me, because I use that computer for other things and I don't like having random code submitted to it (it is theoretically sandboxed, but sandboxes are not always bullet-proof, especially if they have access to a GPU); for the users, because my computer might be unavailable at any time. I'll work on a better solution. For the time being I intend the runner to only accept jobs from the master branch; once a better solution is implemented I'd like to run the pipeline for MRs too.~~ **Fixed**, now there is a shared worker with an AMD GPU available. * While the `Dockerfile` and related assets do not necessarily need to be available in this repository, given that the CI accesses the binary image from the Docker hub anyway, I think it's still valuable to have them, so others can improve them (and for sure improvement opportunities are nowhere near missing). However, other ways to make them available can be found, if for some reason it is not liked to have them in this repository (they are not pretty!). * ~~One of the reason they are not pretty is that I have a custom hack to compile `widl` from the Wine sources without compiling (or installing from the distribution) the whole of Wine, in the interest of keeping the Docker image small (well, small-ish: Vulkan drivers, compilers and X libraries are not small anyway).~~ **A better solution was implemented** * ~~Again on the subject of the Docker image, I am currently putting the binary image in my own namespace on the Docker hub. Using the GitLab container registry in the namespace of the Wine project would probably be better, so that I am not a bottleneck in the future.~~ **Done** * ~~Even if we discount all the points above, this MR cannot be merged yet, because my runner is currently configured for my namespace only. I guess I need the intervention of a GitLab admin to fix that. However, I think there's already material enough for valuable feedback.~~ **Fixed too** -- v5: ci: Introduce a CI pipeline for GitLab. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/271

3 5

[PATCH v4 0/7] MR3328: sapi: Partially implement ISpVoice::Speak.
by Shaun Ren (＠shaunren) 19 Jul '23

19 Jul '23

-- v4: sapi: Introduce ISpTTSEngineSite stub. sapi: Implement synchronous ISpVoice::Speak. sapi: Partially implement ISpVoice::Speak SPF_ASYNC. sapi: Implement ISpVoice::Speak SPF_PURGEBEFORESPEAK. sapi: Reset empty event after queuing a task in async_queue_task. sapi: Handle queue not initialized in async_empty_queue. https://gitlab.winehq.org/wine/wine/-/merge_requests/3328

2 7

[PATCH v2 0/2] MR2853: win32u: Implement EVENT_SYSTEM_FOREGROUND
by Esme Povirk (＠madewokherd) 19 Jul '23

19 Jul '23

I expect this is going to be tricky to get in. I ran into the following issues: * test_ShowWindow behaves very strangely on Windows. It seems this isn't typical behavior, and is caused by an interaction with test_SetFocus, but I'm not sure exactly what it does to the thread state that causes this. * Many of the SetWindowPos flag combinations tested don't actually show the window on Windows, therefore they don't send EVENT_SYSTEM_FOREGROUND. I was able to reproduce this with a stand-alone test, so it seems to be normal behavior. * Windows can show a window without activating it, and Wine on X11 can't do that reliably for managed windows. * There are a couple of cases where Windows sends an event and Wine doesn't. I figure it's OK to not cover every case, but I can go back and investigate those if needed. This interacts with https://gitlab.winehq.org/wine/wine/-/merge_requests/2314, in that the tests don't really test much without it. I applied that MR for my own testing. -- v2: win32u: Implement EVENT_SYSTEM_FOREGROUND. user32: Run tests that notice focus changes early. https://gitlab.winehq.org/wine/wine/-/merge_requests/2853

3 11

[PATCH v3 0/4] MR3339: server: Cancel asyncs when the last handle in process is closed.
by Paul Gofman (＠gofman) 19 Jul '23

19 Jul '23

Supersedes !3329. -- v3: server: Cancel pipe asyncs when the last handle in process is closed. server: Cancel socket asyncs when the last handle in process is closed. ws2_32/tests: Add test for async cancel on socket's last process handle close. ntdll/tests: Add test for async cancel on pipe's last process handle close. https://gitlab.winehq.org/wine/wine/-/merge_requests/3339

2 5

[PATCH v2 0/4] MR260: vkd3d: Prepare for buffering of command list commands.
by Conor McCarthy (＠cmccarthy) 19 Jul '23

19 Jul '23

-- v2: vkd3d: Add a pending execution count to struct d3d12_command_signature. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/260

3 6

Re: [PATCH v4 0/75] MR3168: Release 8.0.2. - approved
by Alexandre Julliard (＠julliard) 19 Jul '23

19 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3168

1 0

2025

2024

2023

2022

wine-gitlab July 2023