August 2023 - wine-gitlab

[PATCH v2 0/1] MR3648: server: Set the default thread exit code to 1.
by Brendan Shanks (＠bshanks) 29 Aug '23

29 Aug '23

The default exit code is only used when a process is killed by the system or through a signal. These are exceptional cases where exit code 1 (killed by Task Manager) is more appropriate than the normal termination code of 0. Chromium does not restart helper processes that exit with code 0 (see [kill.h](https://source.chromium.org/chromium/chromium/src/+/main:base/proce…), with this fix they are restarted when killed by the system or by a signal. -- v2: server: Set the default thread exit code to 1. https://gitlab.winehq.org/wine/wine/-/merge_requests/3648

4 5

[PATCH v2 0/1] MR314: vkd3d-shader/hlsl: Add texCUBE() function.
by Nikolay Sivov (＠nsivov) 29 Aug '23

29 Aug '23

Included test is only to verify that function compiles, and is simple enough - using either texld or sample. -- v2: vkd3d-shader/hlsl: Add texCUBE() function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/314

3 2

[PATCH v6 0/2] MR271: Introduce a GitLab pipeline for vkd3d
by Giovanni Mascellani (＠giomasce) 29 Aug '23

29 Aug '23

With this pipeline vkd3d automatically gets built on Linux (in an image based on Debian unstable), both in 32 and 64 bit mode. Both builds are tested with radv and llvmpipe. A number of caveats apply, though: * A number of tests currently fail in llvmpipe, so the llvmpipe jobs are marked as allowed to fail. Ideally we'll eventually fix our bugs and mark the llvmpipe ones in the tests, so that the CI tests completely pass and possible problems in the Vulkan driver are recorded at a better granularity (this is the reason why GitLab says that the pipeline is passed with warnings: the warnings are that there are jobs that failed, even if they were allowed to fail). * ~~The runners provided by the GitLab instance don't have a GPU available, so I configured my own computer (equipped with an AMD Radeon RX 5700 RX) to provide a runner with access to the GPU. This setup is not currently satisfying: for me, because I use that computer for other things and I don't like having random code submitted to it (it is theoretically sandboxed, but sandboxes are not always bullet-proof, especially if they have access to a GPU); for the users, because my computer might be unavailable at any time. I'll work on a better solution. For the time being I intend the runner to only accept jobs from the master branch; once a better solution is implemented I'd like to run the pipeline for MRs too.~~ **Fixed**, now there is a shared worker with an AMD GPU available. * While the `Dockerfile` and related assets do not necessarily need to be available in this repository, given that the CI accesses the binary image from the Docker hub anyway, I think it's still valuable to have them, so others can improve them (and for sure improvement opportunities are nowhere near missing). However, other ways to make them available can be found, if for some reason it is not liked to have them in this repository (they are not pretty!). * ~~One of the reason they are not pretty is that I have a custom hack to compile `widl` from the Wine sources without compiling (or installing from the distribution) the whole of Wine, in the interest of keeping the Docker image small (well, small-ish: Vulkan drivers, compilers and X libraries are not small anyway).~~ **A better solution was implemented** * ~~Again on the subject of the Docker image, I am currently putting the binary image in my own namespace on the Docker hub. Using the GitLab container registry in the namespace of the Wine project would probably be better, so that I am not a bottleneck in the future.~~ **Done** * ~~Even if we discount all the points above, this MR cannot be merged yet, because my runner is currently configured for my namespace only. I guess I need the intervention of a GitLab admin to fix that. However, I think there's already material enough for valuable feedback.~~ **Fixed too** -- v6: ci: Introduce a CI pipeline for GitLab. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/271

4 6

[PATCH 0/1] MR3612: wldap32: Report success when turning off LDAP_OPT_(ENCRYPT|ROOTDSE_CACHE|SIGN).
by Alex Henrie (＠alexhenrie) 29 Aug '23

29 Aug '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55459 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3612

3 2

[PATCH 0/4] MR310: hlsl: Define some intrinsics in HLSL.
by Zebediah Figura (＠zfigura) 29 Aug '23

29 Aug '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/310

5 18

[PATCH 0/1] MR3674: mpr: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 29 Aug '23

29 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3674

2 1

[PATCH 0/1] MR3673: include: Add AudioProcessing enum in windows.media.idl.
by Biswapriyo Nath (＠Biswa96) 29 Aug '23

29 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3673

2 1

[PATCH 0/1] MR3669: comctl32: Remove DECLSPEC_HIDDEN usage.
by Alistair Leslie-Hughes (＠alesliehughes) 29 Aug '23

29 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3669

3 2

[PATCH 0/4] MR3672: appxdeploymentclient: Add IPackageManager2 stub interface.
by Mohamad Al-Jaf (＠maljaf) 29 Aug '23

29 Aug '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55403 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3672

2 4

[PATCH 0/1] MR3671: cmd: refactored setting of 'errorlevel'
by Dmitry Sokolov (＠DmitrySokolov) 28 Aug '23

28 Aug '23

Encapsulate setting of 'errorlevel' in a separate function as the first stage of fixing bug #32679 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=32679 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3671

2 1

2025

2024

2023

2022

wine-gitlab August 2023