August 2023 - wine-gitlab

Re: [PATCH v4 0/3] MR303: vkd3d-shader/hlsl: Parse "if" statement attributes. - approved
by Alexandre Julliard (＠julliard) 24 Aug '23

24 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/303

1 0

Re: [PATCH v3 0/1] MR293: vkd3d-shader/hlsl: Force sm1 inputs to be 4-component only for vertex shaders. - approved
by Alexandre Julliard (＠julliard) 24 Aug '23

24 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/293

1 0

Re: [PATCH v2 0/1] MR313: configure: Require widl >= 3.21. - approved
by Alexandre Julliard (＠julliard) 24 Aug '23

24 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/313

1 0

[PATCH 0/2] MR3655: cmd: fixed var substring in 'enableDelayedExpansion' mode
by Dmitry Sokolov (＠DmitrySokolov) 24 Aug '23

24 Aug '23

Fixed the following code: ```plaintext for %i in ... set result=%%i if "!result:~0,3!"=="10." ... ``` Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55402 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3655

2 2

[PATCH v4 0/5] MR3607: apisetschema: Add ext-ms-win-dxcore-l1-1-0.
by Mohamad Al-Jaf (＠maljaf) 24 Aug '23

24 Aug '23

Needed by Affinity Photo. The headers are needed for MinGW. -- v4: apisetschema: Add ext-ms-win-dxcore-l1-1-0. dxcore: Add DXCoreCreateAdapterFactory() stub. dxcore: Add stub DLL. include: Add dxcore.h file. include: Add dxcore_interface.h file. https://gitlab.winehq.org/wine/wine/-/merge_requests/3607

5 19

[PATCH v10 0/13] MR1074: Draft: ntdll: Improve Valgrind and GDB integration.
by Rémi Bernon (＠rbernon) 24 Aug '23

24 Aug '23

Valgrind support requires a fork, which I've published to https://gitlab.winehq.org/rbernon/valgrind. The fork implements loading DWARF debug info from PE files, instead of the old and broken upstream PDB support. I've tried to upstream these changes a long time ago but didn't receive any feedback. I think we could maybe consider keeping a fork, which I'm happy to maintain, as the changes aren't too large. We may want to investigate adding 32-on-64 support, which may require a bit more changes (to VEX specifically, because its amd64 guest doesn't support segment register manipulation). The changes here are not all related to Valgrind, and I'll create separate MR for those which may make sense independently from Valgrind / GDB. Also included is a suppression file to silent some annoying false positives, many of which are coming from the cross-stack accesses during syscalls, which are confusing Valgrind's stack heuristics. One can try this out with something like: `WINELOADERNOEXEC=1 valgrind --suppressions=tools/valgrind.supp wine64/loader/wine64 wine64/programs/winecfg/winecfg.exe` -- v10: ntdll: Avoid writing to invalid memory in i386 unix dispatcher. ntdll: Fix incorrect i386 call_user_mode_callback CFI. ntdll: Avoid marking freed block header as undefined for valgrind. ntdll: Force HEAP_TAIL_CHECKING_ENABLED flag with valgrind. ntdll: Fix valgrind notifications from ntdll.so. ntdll: Import valgrind headers for PE side ntdll. loader: Implement SystemTap RTLD probes. configure.ac: Check for systemtap sys/sdt.h header. gitlab: Install systemtap-sdt-dev packages. ntdll: Maintain a PE module link map and expose it to GDB. ntdll: Pass a UNICODE_STRING to load_builtin and virtual_map_image. loader: Expose a shadow copy of ld.so link map to GDB. ntdll: Add .cfi_signal_frame to __wine_syscall_dispatcher. https://gitlab.winehq.org/wine/wine/-/merge_requests/1074

2 14

[PATCH 0/1] MR311: vkd3d: Do not flush descriptor heaps stored in the command list when the array size is exceeded.
by Conor McCarthy (＠cmccarthy) 24 Aug '23

24 Aug '23

An earlier patch introduced a bug which overflows the descriptor heap array. The array should not be emptied here in case the list is resubmitted, so just flush the new heap. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/311

3 2

[PATCH 0/1] MR309: tests: Test CopyResource depth to color
by Evan Tang (＠etang-cw) 24 Aug '23

24 Aug '23

Test case for !262 -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/309

3 2

[PATCH v6 0/1] MR308: vkd3d-shader/hlsl: Initialize unused constant values in compilation passes.
by Francisco Casas (＠fcasas) 24 Aug '23

24 Aug '23

Even though the uninitialized values shouldn't be used in the output binary program, they still show up in it, and affect the checksum, so we better make them zeroes. This error was reported by valgrind: ``` libtool --mode=execute valgrind --track-origins=yes vkd3d-build/tests/shader_runner vkd3d/tests/hlsl/static-initializer.shader_test ``` ``` ==46180== Conditional jump or move depends on uninitialised value(s) ==46180== at 0x48D98C7: parse_dxbc.isra.0 (dxbc.c:182) ==46180== by 0x48DA044: vkd3d_shader_parse_dxbc (dxbc.c:308) ==46180== by 0x488D1B6: vkd3d_shader_parse_dxbc_source_type (vkd3d_shader_utils.h:37) ==46180== by 0x488D1B6: create_shader_stage.isra.0 (state.c:1988) ==46180== by 0x48926B6: d3d12_pipeline_state_init_graphics (state.c:3084) ==46180== by 0x4893A96: d3d12_pipeline_state_create_graphics (state.c:3280) ==46180== by 0x4878498: d3d12_device_CreateGraphicsPipelineState (device.c:2619) ==46180== by 0x1FFEFFECC7: ??? ==46180== by 0xE8: ??? ==46180== by 0x47: ??? ==46180== by 0x61: ??? ==46180== by 0x660066000000023: ??? ==46180== by 0x661066100000044: ??? ==46180== Uninitialised value was created by a stack allocation ==46180== at 0x48F3FF0: hlsl_fold_constant_swizzles (hlsl_constant_ops.c:1010) ``` Thank you valgrind! :smile: -- v6: vkd3d-shader/tpf: Avoid reading constant value components beyond type's width (Valgrind). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/308

4 4

[PATCH v3 0/3] MR303: vkd3d-shader/hlsl: Parse "if" statement attributes.
by Nikolay Sivov (＠nsivov) 24 Aug '23

24 Aug '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: vkd3d-shader/hlsl: Change warning code for unknown loop attributes. vkd3d-shader/hlsl: Parse "if" statement attributes. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/303

4 6

2025

2024

2023

2022

wine-gitlab August 2023