August 2023 - wine-gitlab

Re: [PATCH v3 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Zhiyi Zhang (＠zhiyi) 23 Aug '23

23 Aug '23

On Wed Aug 23 02:47:48 2023 +0000, Zhiyi Zhang wrote: > Even with a custom source with MFMEDIASOURCE_CAN_PAUSE reported. Still, > no MESessionStopped events are sent. I also tested with the media source > created from IMFSourceResolver::CreateObjectFromByteStream() with > test.mp4 and got the same result. So it seems to be that is merely how > IMFMediaSession calls IMFMediaSource. Stops the source first and then > start it. But with a single IMFMediaSource::Start() achieving the same > result. Do we really need to stop the sources first when performing a seek? Stopping sources first does eliminate the need to add an OBJ_STATE_SEEKING state though. I decided to do it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3572#note_43132

1 0

[PATCH v3 0/3] MR308: vkd3d-shader/hlsl: Initialize unused constant values in compilation passes.
by Francisco Casas (＠fcasas) 23 Aug '23

23 Aug '23

Even though the uninitialized values shouldn't be used in the output binary program, they still show up in it, and affect the checksum, so we better make them zeroes. This error was reported by valgrind: ``` libtool --mode=execute valgrind --track-origins=yes vkd3d-build/tests/shader_runner vkd3d/tests/hlsl/static-initializer.shader_test ``` ``` ==46180== Conditional jump or move depends on uninitialised value(s) ==46180== at 0x48D98C7: parse_dxbc.isra.0 (dxbc.c:182) ==46180== by 0x48DA044: vkd3d_shader_parse_dxbc (dxbc.c:308) ==46180== by 0x488D1B6: vkd3d_shader_parse_dxbc_source_type (vkd3d_shader_utils.h:37) ==46180== by 0x488D1B6: create_shader_stage.isra.0 (state.c:1988) ==46180== by 0x48926B6: d3d12_pipeline_state_init_graphics (state.c:3084) ==46180== by 0x4893A96: d3d12_pipeline_state_create_graphics (state.c:3280) ==46180== by 0x4878498: d3d12_device_CreateGraphicsPipelineState (device.c:2619) ==46180== by 0x1FFEFFECC7: ??? ==46180== by 0xE8: ??? ==46180== by 0x47: ??? ==46180== by 0x61: ??? ==46180== by 0x660066000000023: ??? ==46180== by 0x661066100000044: ??? ==46180== Uninitialised value was created by a stack allocation ==46180== at 0x48F3FF0: hlsl_fold_constant_swizzles (hlsl_constant_ops.c:1010) ``` Thank you valgrind! :smile: -- v3: vkd3d-shader/tpf: Avoid reading constant value components beyond type's width. vkd3d-shader/hlsl: Initialize unused constant components to zero. vkd3d-shader/hlsl: Initialize all constant values in hlsl_fold_constant_swizzles(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/308

3 5

Re: [PATCH v3 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Zhiyi Zhang (＠zhiyi) 23 Aug '23

23 Aug '23

On Mon Aug 21 10:13:21 2023 +0000, Nikolay Sivov wrote: > Maybe sources do not always have MFMEDIASOURCE_CAN_PAUSE. Even with a custom source with MFMEDIASOURCE_CAN_PAUSE reported. Still, no MESessionStopped events are sent. I also tested with the media source created from IMFSourceResolver::CreateObjectFromByteStream() with test.mp4 and got the same result. So it seems to be that is merely how IMFMediaSession calls IMFMediaSource. Stops the source first and then start it. But with a single IMFMediaSource::Start() achieving the same result. Do we really need to stop the sources first when performing a seek? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3572#note_43129

1 0

[PATCH 0/7] MR3636: winegstreamer: Implement wg_muxer.
by Ziqing Hui (＠zhui) 23 Aug '23

23 Aug '23

Since 1.20, gst_element_request_pad_simple is available and gst_element_get_request_pad is marked as deprecated. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3636

3 9

[PATCH 0/1] MR3635: kernelbase: Add GetPackagePathByFullName stub.
by Etaash Mathamsetty (＠etaash.mathamsetty) 23 Aug '23

23 Aug '23

Required by webview2 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3635

2 1

[PATCH v2 0/5] MR3621: GdipCreateBitmapFromICON fixes part 1/2
by Jeffrey Smith (＠whydoubt) 22 Aug '23

22 Aug '23

-- v2: gdiplus: Fix GdipCreateBitmapFromICON return status with mask-only icon. gdiplus/tests: Add test for mask-only icon with GdipCreateBitmapFromHICON. gdiplus/tests: Add test for cursor with GdipCreateBitmapFromHICON. gdiplus/tests: Create helper function for testing image attributes. gdiplus/tests: Simplify ICONINFO initialization. https://gitlab.winehq.org/wine/wine/-/merge_requests/3621

3 7

Re: [PATCH v2 0/1] MR3611: gdiplus: set Tahoma font in case MS Sans Serif is missing
by Jeffrey Smith (＠whydoubt) 22 Aug '23

22 Aug '23

On Tue Aug 22 20:24:18 2023 +0000, Esme Povirk wrote: > It doesn't matter what happens on Windows when Microsoft Sans Serif is > missing, because current Windows will always have Microsoft Sans Serif available. That Windows always has it available (under normal circumstances) is irrelevant to my point. It is very useful in that either result can remove one branch of investigation, as I already unpacked. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3611#note_43094

1 0

Re: [PATCH v2 0/1] MR3611: gdiplus: set Tahoma font in case MS Sans Serif is missing
by Esme Povirk (＠madewokherd) 22 Aug '23

22 Aug '23

On Tue Aug 22 20:24:18 2023 +0000, Jeffrey Smith wrote: > That is good to know. Two more things that could help the investigation. > 1. What happens on Windows if you force Arial (I assume by removing > Microsoft Sans Serif)? > * If also broken, it indicates that the game just does not work with Arial. > * If it works, it indicates something in wine (besides font > selection) is not behaving like native, and that finding how it differs > is what remains. > 2. What happens on Wine if Microsoft Sans Serif is available? It doesn't matter what happens on Windows when Microsoft Sans Serif is missing, because current Windows will always have Microsoft Sans Serif available. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3611#note_43092

1 0

Re: [PATCH v2 0/2] MR3632: wmic: Fix output when redirected to pipe. - approved
by Alexandre Julliard (＠julliard) 22 Aug '23

22 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3632

1 0

Re: [PATCH v4 0/9] MR3605: include: Add WinRT IPackageManager / IPackage3 definitions. - approved
by Alexandre Julliard (＠julliard) 22 Aug '23

22 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3605

1 0

2025

2024

2023

2022

wine-gitlab August 2023