August 2023 - wine-gitlab

[PATCH 0/1] MR3620: crypt32: Fix CMS SignedData encoding.
by Torge Matthies (＠tmatthies) 21 Aug '23

21 Aug '23

Several items here were encoded conditionally even though they aren't marked as optional in the spec. I put the tests into the same commit as the fix because the helper function used throughout the file, check_param, does not support marking only some of the tests inside of it as todo_wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3620

2 1

[PATCH 0/2] MR3616: cmd: added support of for loop's var names %%1, fixed expansion of outer var loop name inside inner loop
by Dmitry Sokolov (＠DmitrySokolov) 21 Aug '23

21 Aug '23

Visual Studio's native tool command prompt uses these FOR loop variables: %%1, %%2. This fix allows to use %%1 var in FOR loops.case. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55401 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3616

3 3

[PATCH v4 0/4] MR3563: server: Symlink CurrentControlSet to ControlSet001
by Torge Matthies (＠tmatthies) 21 Aug '23

21 Aug '23

Signed-off-by: Torge Matthies <openglfreak(a)googlemail.com> -- v4: loader: Add Default, Failed, and LastKnownGood values to HKLM\System\Select. server: Update existing prefixes to use a symlink for HKLM\System\CurrentControlSet. server: Create link from HKLM\System\CurrentControlSet to ControlSet001. advapi32/tests: Add test for CurrentControlSet link. https://gitlab.winehq.org/wine/wine/-/merge_requests/3563

2 5

[PATCH 0/1] MR3618: shell32: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 20 Aug '23

20 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3618

2 1

[PATCH v6 0/4] MR3554: mmdevapi: fixes for Yousician
by David McFarland (＠corngood) 20 Aug '23

20 Aug '23

Since Yousician's last update, it was throwing an error when initialising audio output. Unfortunately I don't have access to the old version, but they seem to have dropped win<10 support, and are using only IAudioClient3_InitializeSharedAudioStream. They also use IDeviceTopology to get the type of the first output connector. This is the bare minimum I needed to get it working. -- v6: mmdevapi: add stub for IDeviceTopology mmdevapi/tests: add test for IDeviceTopology mmdevapi: implement IAudioClient3_InitializeSharedAudioStream mmdevapi/tests: add test for AudioClient3_InitializeSharedAudioStream https://gitlab.winehq.org/wine/wine/-/merge_requests/3554

3 6

Re: [PATCH v3 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Nikolay Sivov (＠nsivov) 20 Aug '23

20 Aug '23

On Sun Aug 20 15:35:54 2023 +0000, Zhiyi Zhang wrote: > > Actually, did you test this with a custom source? > No. I will look into that. Thanks. > > depending on a the player state it's either Stop->Start->Pause or Stop->Start > IMFMediaSession::Start() always starts the session though. It does. What I mean is when player (I tried mfplay one) is stopped, SetPosition() does not do anything, only stores specified position. When it's playing, source is stopped and the started at new position, when it's paused source is stopped, started at new position, and then paused. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3572#note_42794

1 0

Re: [PATCH v3 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Zhiyi Zhang (＠zhiyi) 20 Aug '23

20 Aug '23

> Actually, did you test this with a custom source? No. I will look into that. Thanks. > depending on a the player state it's either Stop->Start->Pause or Stop->Start IMFMediaSession::Start() always starts the session though. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3572#note_42793

1 0

[PATCH v2 0/1] MR3403: server: Revert "server: Avoid using SOL_IPX to detect whether IPX is supported."
by Fotios Valasiadis (＠fvalasiad) 20 Aug '23

20 Aug '23

This reverts commit 41cc117b3f37ab4b9b4ac8a815cd2a496d38fb4b. This commit broke musl support. With the changes introduced, the following code evaluates to the #else branch without checking for SO_DEFAULT_HEADERS resulting in an error. server/sock.c +1888 ``` \#ifdef HAS_IPX int ipx_type = protocol - WS_NSPROTO_IPX; \#ifdef SOL_IPX setsockopt( sockfd, SOL_IPX, IPX_TYPE, &ipx_type, sizeof(ipx_type) ); \#else struct ipx val; /* Should we retrieve val using a getsockopt call and then * set the modified one? */ val.ipx_pt = ipx_type; setsockopt( sockfd, 0, SO_DEFAULT_HEADERS, &val, sizeof(val) ); \#endif \#endif ``` I propose reverting the commit, but we could probably alter the macro in the code section provided to match the changes relevant github issue: https://github.com/void-linux/void-packages/pull/45202 Signed-off-by: Fotios Valasiadis <fvalasiad(a)gmail.com> -- v2: server: Check for SO_DEFAULT_HEADERS before using it. https://gitlab.winehq.org/wine/wine/-/merge_requests/3403

4 10

Re: [PATCH v3 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Nikolay Sivov (＠nsivov) 20 Aug '23

20 Aug '23

Actually, did you test this with a custom source? What I see on Windows is that Start(new_position): * stops the source; * flushes; * starts again with new position. I noticed this extra stop when I tried mfplay API to see what SetPosition() is doing - depending on a the player state it's either Stop->Start->Pause or Stop->Start. Turns out this might be what session does internally. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3572#note_42791

1 0

[PATCH v3 0/2] MR3525: ntdll: allow NULL timeout in NtCreateNamedPipeFile.
by Etaash Mathamsetty (＠etaash.mathamsetty) 20 Aug '23

20 Aug '23

Saw that this was allowed on MSDN and checked with a windows machine -- v3: ntdll/tests: Add NULL timeout test for NtCreateNamedPipeFile. https://gitlab.winehq.org/wine/wine/-/merge_requests/3525

2 3

2025

2024

2023

2022

wine-gitlab August 2023