September 2023 - wine-gitlab

[PATCH v2 0/4] MR3334: Add vccorlib140.dll stub dll.
by Etaash Mathamsetty (＠etaash.mathamsetty) 07 Aug '25

07 Aug '25

When using native xinput in WRC9, vccorlib is needed to make sure xinput doesn't crash. -- v2: wincorlib: Add stub for platform_details_uninit_data. wincorlib: Add stub for platform_details_init_data. vccorlib140: Add stub dll. wincorlib: Add stub dll. https://gitlab.winehq.org/wine/wine/-/merge_requests/3334

4 10

[PATCH v19 0/5] MR820: Implement application hives
by Santino Mazza (＠tati1454) 31 May '25

31 May '25

-- v19: kernelbase: Implement RegLoadAppKey. ntdll: Implement REG_APP_HIVE flag server: Create \REGISTRY\A hive. ntdll: Rename NtLoadKeyEx parameters. ntdll: Pass filename to server in NtLoadKeyEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/820

5 15

[PATCH v4 0/4] MR2127: ntdll: Load known dlls from system directory
by Paul Gofman (＠gofman) 07 May '25

07 May '25

The practical issue I am trying to solve is the following scenario (encountered with a game using some Uplay plugin) which has regressed with apisets implementation in Wine. The game imports ucrtbase.dll. Then, a plugin calls GetModuleHandle("api-ms-win-crt-runtime-l1-1-0.dll") and expects GetProcAddress("\_crt_atexit") to succeed on the returned handle. The problem is that the game has ucrtbase.dll in its .exe directory. That one currently gets loaded. Then, find_dll_file() resolves api-ms-win-crt-runtime-l1-1-0.dll to the ucrtbase with a full path in system32 and tries to find that one (this part matches Windows behaviour as far as tests show). Since we have ucrtbase loaded with another path this results in NULL module handle. Windows maintains the list of "Known DLLs" (probably aimed for speeding up processes startup by using pre-mapped dll images for commonly used system dlls). On Windows, known dlls have specifics in load path resolution when dll name doesn't contain path (relative or full): - they are loaded from system directory even if there is another dll with the same name in priority search path; - they are found even if library search paths do not contain system directory; Those "Known DLLs" are basically listed in HKLM\\System\\CurrentControlSet\\Control\\Session Manager\KnownDLLs registry key. But the actual list of "known dlls" is bigger (probably includes all dependencies of those listed under registry key). The full actual list of "known dlls" is in '\\KnownDlls\' directory object which contains image sections under dll names. Most notably, ucrtbase.dll (which is of the concern in the regression) is not listed in registry but is present in \\KnownDlls. Technically nothing prevents us from implementing these mechanics and creating directory object with mapped load dlls, also resolving the explicitly listed dlls' dependencies. But it is not apparent to me if that is going to improve load times noticably in Wine, and also that is worth the inherent complications until anything actually depends on that \\KnownDlls sections. So instead of implementing all of that throughout the loader I added a few missing dlls to registry. The current list in this pat chset corresponds to the contents of \\KnownDlls directory on an up to date Windows 10. -- v4: ntdll: Load known dlls from system directory. loader/wine.inf: Add known dlls key. ntdll: Factor out prepend_system_dir() function. kernel32/tests: Add tests for known dlls load specifics. https://gitlab.winehq.org/wine/wine/-/merge_requests/2127

4 8

[PATCH v2 0/1] MR3868: user32/tests: Account for some messages from dual-monitor setups.
by Esme Povirk (＠madewokherd) 28 Mar '25

28 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54031 -- v2: user32/tests: Account for some messages from dual-monitor setups. https://gitlab.winehq.org/wine/wine/-/merge_requests/3868

3 2

[PATCH v7 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue
by Patrick Hibbs (＠hibbsncc1701) 24 Mar '25

24 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46012 Signed-off-by: Patrick Hibbs <hibbsncc1701(a)gmail.com> -- v7: d3dx9/tests: Implement tests for d3dx_effect_SetRawValue(). d3dx9: Implement d3dx_effect_SetRawValue https://gitlab.winehq.org/wine/wine/-/merge_requests/979

5 13

[PATCH 0/1] MR3862: user32/tests: Ignore other messages in test_broadcast.
by Esme Povirk (＠madewokherd) 18 Mar '25

18 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54194 If the SendMessageTimeout call takes a long time, we can get other messages which also set the observed wparam value. Apparently, this is especially likely on Windows 7. This also removes the (wParam == 0xbaadbeef) check which may have been intended to serve the same goal but doesn't work because the observed wParam value is still assigned. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3862

3 2

[PATCH 0/1] MR3857: d3d11/tests: Properly mark the indexed sample position test as succeeding with the Vulkan backend.
by Henri Verbeet (＠hverbeet) 16 Mar '25

16 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3857

4 4

[PATCH v3 0/2] MR3833: iphlpapi/tests: Quadruple the buffer size in a GetAdaptersAddresses() test.
by Hans Leidekker (＠hans) 16 Mar '25

16 Mar '25

As shown by the testbot, doubling is not always sufficient. -- v3: iphlpapi/tests: Call GetExtendedTcp/UdpTable() in a loop. https://gitlab.winehq.org/wine/wine/-/merge_requests/3833

3 4

[PATCH v2 0/2] MR3833: iphlpapi/tests: Quadruple the buffer size in a GetAdaptersAddresses() test.
by Hans Leidekker (＠hans) 16 Mar '25

16 Mar '25

As shown by the testbot, doubling is not always sufficient. -- v2: iphlpapi/tests: Call GetExtendedTcp/UdpTable() in a loop. iphlpapi/tests: Call GetAdaptersAddresses() in a loop. https://gitlab.winehq.org/wine/wine/-/merge_requests/3833

4 6

[PATCH 0/1] MR3838: kernel32/tests: Allow a 0 removed entry count in the completion test.
by Francois Gouget (＠fgouget) 16 Mar '25

16 Mar '25

This matches the ntdll:file fix. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54554 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3838

3 2

2025

2024

2023

2022

wine-gitlab September 2023