September 2023 - wine-gitlab

[PATCH v19 0/5] MR820: Implement application hives
by Santino Mazza (＠tati1454) 31 May '25

31 May '25

-- v19: kernelbase: Implement RegLoadAppKey. ntdll: Implement REG_APP_HIVE flag server: Create \REGISTRY\A hive. ntdll: Rename NtLoadKeyEx parameters. ntdll: Pass filename to server in NtLoadKeyEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/820

5 15

[PATCH v4 0/4] MR2127: ntdll: Load known dlls from system directory
by Paul Gofman (＠gofman) 07 May '25

07 May '25

The practical issue I am trying to solve is the following scenario (encountered with a game using some Uplay plugin) which has regressed with apisets implementation in Wine. The game imports ucrtbase.dll. Then, a plugin calls GetModuleHandle("api-ms-win-crt-runtime-l1-1-0.dll") and expects GetProcAddress("\_crt_atexit") to succeed on the returned handle. The problem is that the game has ucrtbase.dll in its .exe directory. That one currently gets loaded. Then, find_dll_file() resolves api-ms-win-crt-runtime-l1-1-0.dll to the ucrtbase with a full path in system32 and tries to find that one (this part matches Windows behaviour as far as tests show). Since we have ucrtbase loaded with another path this results in NULL module handle. Windows maintains the list of "Known DLLs" (probably aimed for speeding up processes startup by using pre-mapped dll images for commonly used system dlls). On Windows, known dlls have specifics in load path resolution when dll name doesn't contain path (relative or full): - they are loaded from system directory even if there is another dll with the same name in priority search path; - they are found even if library search paths do not contain system directory; Those "Known DLLs" are basically listed in HKLM\\System\\CurrentControlSet\\Control\\Session Manager\KnownDLLs registry key. But the actual list of "known dlls" is bigger (probably includes all dependencies of those listed under registry key). The full actual list of "known dlls" is in '\\KnownDlls\' directory object which contains image sections under dll names. Most notably, ucrtbase.dll (which is of the concern in the regression) is not listed in registry but is present in \\KnownDlls. Technically nothing prevents us from implementing these mechanics and creating directory object with mapped load dlls, also resolving the explicitly listed dlls' dependencies. But it is not apparent to me if that is going to improve load times noticably in Wine, and also that is worth the inherent complications until anything actually depends on that \\KnownDlls sections. So instead of implementing all of that throughout the loader I added a few missing dlls to registry. The current list in this pat chset corresponds to the contents of \\KnownDlls directory on an up to date Windows 10. -- v4: ntdll: Load known dlls from system directory. loader/wine.inf: Add known dlls key. ntdll: Factor out prepend_system_dir() function. kernel32/tests: Add tests for known dlls load specifics. https://gitlab.winehq.org/wine/wine/-/merge_requests/2127

4 8

[PATCH v2 0/1] MR3868: user32/tests: Account for some messages from dual-monitor setups.
by Esme Povirk (＠madewokherd) 28 Mar '25

28 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54031 -- v2: user32/tests: Account for some messages from dual-monitor setups. https://gitlab.winehq.org/wine/wine/-/merge_requests/3868

3 2

[PATCH v7 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue
by Patrick Hibbs (＠hibbsncc1701) 24 Mar '25

24 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46012 Signed-off-by: Patrick Hibbs <hibbsncc1701(a)gmail.com> -- v7: d3dx9/tests: Implement tests for d3dx_effect_SetRawValue(). d3dx9: Implement d3dx_effect_SetRawValue https://gitlab.winehq.org/wine/wine/-/merge_requests/979

5 13

[PATCH 0/1] MR3862: user32/tests: Ignore other messages in test_broadcast.
by Esme Povirk (＠madewokherd) 18 Mar '25

18 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54194 If the SendMessageTimeout call takes a long time, we can get other messages which also set the observed wparam value. Apparently, this is especially likely on Windows 7. This also removes the (wParam == 0xbaadbeef) check which may have been intended to serve the same goal but doesn't work because the observed wParam value is still assigned. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3862

3 2

[PATCH 0/1] MR3857: d3d11/tests: Properly mark the indexed sample position test as succeeding with the Vulkan backend.
by Henri Verbeet (＠hverbeet) 16 Mar '25

16 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3857

4 4

[PATCH v3 0/2] MR3833: iphlpapi/tests: Quadruple the buffer size in a GetAdaptersAddresses() test.
by Hans Leidekker (＠hans) 16 Mar '25

16 Mar '25

As shown by the testbot, doubling is not always sufficient. -- v3: iphlpapi/tests: Call GetExtendedTcp/UdpTable() in a loop. https://gitlab.winehq.org/wine/wine/-/merge_requests/3833

3 4

[PATCH v2 0/2] MR3833: iphlpapi/tests: Quadruple the buffer size in a GetAdaptersAddresses() test.
by Hans Leidekker (＠hans) 16 Mar '25

16 Mar '25

As shown by the testbot, doubling is not always sufficient. -- v2: iphlpapi/tests: Call GetExtendedTcp/UdpTable() in a loop. iphlpapi/tests: Call GetAdaptersAddresses() in a loop. https://gitlab.winehq.org/wine/wine/-/merge_requests/3833

4 6

[PATCH 0/1] MR3838: kernel32/tests: Allow a 0 removed entry count in the completion test.
by Francois Gouget (＠fgouget) 16 Mar '25

16 Mar '25

This matches the ntdll:file fix. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54554 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3838

3 2

[PATCH 0/1] MR3837: quartz/tests: Fix segfault in changed3ddevice test.
by Alfred Agrell (＠Alcaro) 16 Mar '25

16 Mar '25

Fixes regression from https://gitlab.winehq.org/wine/wine/-/merge_requests/3792 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3837

4 4

[PATCH 0/1] MR3835: winscard/tests: Skip tests when SCardListReadersA() returns an empty list.
by Hans Leidekker (＠hans) 16 Mar '25

16 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3835

3 2

[PATCH 0/1] MR3834: wpcap/tests: Accept another return value from pcap_can_set_rfmon().
by Hans Leidekker (＠hans) 16 Mar '25

16 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3834

3 2

[PATCH 0/2] MR3833: iphlpapi/tests: Quadruple the buffer size in a GetAdaptersAddresses() test.
by Hans Leidekker (＠hans) 16 Mar '25

16 Mar '25

As shown by the testbot, doubling is not always sufficient. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3833

4 6

[PATCH 0/2] MR3822: user32/tests: Account for ignored messages during wait.
by Esme Povirk (＠madewokherd) 15 Mar '25

15 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53435 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3822

3 4

[PATCH 0/1] MR3818: Draft: urlmon: test http with auto redirect disabled, and CreateBinding
by Yuxuan Shui (＠yshui) 15 Mar '25

15 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3818

4 9

[PATCH 0/1] MR3817: ntdll/test: Updated link test to reflect Windows 11 behaviour.
by Joel Holdsworth (＠jhol) 15 Mar '25

15 Mar '25

Signed-off-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3817

3 2

[PATCH 0/1] MR3801: user32/tests: Detect win7's broken GetQueueStatus behavior.
by Esme Povirk (＠madewokherd) 15 Mar '25

15 Mar '25

Unlike most of these user32:msg failures, this one is consistent. No bug report for this specifically but https://bugs.winehq.org/show_bug.cgi?id=53434 comments 3 and 4 has related info. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3801

3 2

[PATCH v2 0/1] MR3783: user32/tests: Register test_hvredraw class in temp desktop.
by Esme Povirk (＠madewokherd) 15 Mar '25

15 Mar '25

Windows v1709 has a bug that breaks GetClassLong on a different desktop from where the class was registered. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55539 -- v2: user32/tests: Register test_hvredraw class in temp desktop. https://gitlab.winehq.org/wine/wine/-/merge_requests/3783

3 3

[PATCH 0/2] MR3788: iphlpapi/tests: Call GetAdaptersAddresses() in a loop.
by Hans Leidekker (＠hans) 15 Mar '25

15 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54588 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3788

4 4

[PATCH 0/1] MR3783: user32/tests: Register test_hvredraw class in temp desktop.
by Esme Povirk (＠madewokherd) 10 Mar '25

10 Mar '25

Windows v1709 has a bug that breaks GetClassLong on a different desktop from where the class was registered. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55539 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3783

4 5

[PATCH v2 0/1] MR3774: gdiplus/tests: Extend DrawImage scaling tests.
by Bartosz Kosiorek (＠gang65) 10 Mar '25

10 Mar '25

Changing the colour of the second pixel of the source bitmap clarifies the incorrect behaviour of PixelOffsetMode Half and HighQuality. This also provides better proof that PixelOffsetMode None and Fast are implemented correctly. Extending tests is starting point for further improvements of implementation pixel offset modes to match implementation from native gdiplus. -- v2: gdiplus/tests: Extend DrawImage scaling tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3774

4 4

[PATCH 0/2] MR3735: user32/tests: Wait for GetMessage call to complete.
by Esme Povirk (＠madewokherd) 09 Mar '25

09 Mar '25

It's possible otherwise for the second message to be sent before GetMessage removes a posted message from the queue, in which case GetMessage processes both sent messages. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54407 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3735

3 3

[PATCH 0/1] MR3720: wtsapi/tests: Use a heap buffer for the user SID.
by Hans Leidekker (＠hans) 09 Mar '25

09 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55227 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3720

3 2

[PATCH 0/1] MR3721: webservices/tests: Fully initialize xmlstr.
by Hans Leidekker (＠hans) 09 Mar '25

09 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3721

3 2

[PATCH 0/1] MR3719: d3d9/tests: Don't fail d3d9ex if the window manager restores focus too soon.
by Stefan Dösinger (＠stefan) 09 Mar '25

09 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3719

5 5

[PATCH v4 0/4] MR3675: dmsynth/tests: Test the synthesizer components and render some samples from MIDI.
by Rémi Bernon (＠rbernon) 09 Mar '25

09 Mar '25

-- v4: dmsynth/tests: Test DirectMusicSynth class in isolation. dmsynth/tests: Test DirectMusicSynthSink class in isolation. dmsynth/tests: Import and use a check_interface helper. dmsynth/tests: Avoid dynamic format string. https://gitlab.winehq.org/wine/wine/-/merge_requests/3675

4 10

[PATCH 0/1] MR3131: gdiplus: Fix gif shows misplaced.
by Jiajin Cui (＠jin-king1) 04 Mar '25

04 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54271 Signed-off-by: Jiajin Cui <cuijiajin(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3131

3 6

[PATCH 0/3] MR3124: Move periodic registry save out of wineserver
by Paul Gofman (＠gofman) 25 Feb '25

25 Feb '25

The problem is that registry save is a very heavy operation (scheduled each 30sec in wineserver) during which server doesn't process any requests and the whole prefix is stalled for the duration of the operation. For some reference, the process takes from 50-100ms here up to 1-1.5sec with default initial registry (after some registry modifications which trigger actual registry flush), depending on the filesystem type and state (as huge time may be spent in file close / rename). With the same registry after this patchset the server part (flush_key returning the whole registry data) is taking ~4-5mcs, measured from the client side so that already includes data transfer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3124

5 9

[PATCH 0/1] MR3109: imm32: Don't export internal variables.
by Alex Henrie (＠alexhenrie) 24 Jan '25

24 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3109

6 22

[PATCH v2 0/2] MR825: winex11.drv: optimize repeated ClipCursor calls
by Jan Klötzke (＠jkloetzke) 18 Dec '24

18 Dec '24

At least Doom 64 calls ClipCursor() with identical parameters repeatedly, which seems to cause a considerable overhead. Together with high polling rate mouse input this causes the game to almost freeze while the mouse is being moved. So if the clipping did not change we can bail out early because it will not cause any observable difference anyway. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46976 Signed-off-by: Jan Klötzke <jan(a)kloetzke.net> -- v2: winex11.drv: optimize repeated ClipCursor calls winex11.drv: create win32 clipping window only once https://gitlab.winehq.org/wine/wine/-/merge_requests/825

5 8

[PATCH v2 0/2] MR475: server: Fix object name resolution of \Device\Null.
by Jinoh Kang (＠iamahuman) 05 Dec '24

05 Dec '24

This simplifies future tests that check for object name of devices. -- v2: server: Fix object name resolution of \Device\Null. server: Make explicit the ownership of the unix_name buffer. https://gitlab.winehq.org/wine/wine/-/merge_requests/475

3 4

[PATCH v2 0/3] MR698: d2d1: Implement transform graph.
by Ziqing Hui (＠zhui) 01 Dec '24

01 Dec '24

-- v2: d2d1: Implement nodes connection for ID2D1TransformGraph. d2d1: Implement nodes adding and removal for ID2D1TransformGraph. d2d1/tests: Add more tests for ID2D1TransformGraph. https://gitlab.winehq.org/wine/wine/-/merge_requests/698

2 6

[PATCH 0/1] MR3226: comctl32/edit: Scroll caret on Ctrl+A.
by Vladislav Timonin (＠vt) 28 Nov '24

28 Nov '24

Every other use of `EDIT_EM_SetSel` updates caret position by calling `EDIT_EM_ScrollCaret` or `EDIT_SetCaretPos`. Fixes caret blinking in the middle when selecting all text. ![changes](/uploads/019bce6c12e0378d391e1253ecbaf9c6/changes.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3226

4 6

[PATCH 0/1] MR1121: winhttp: Fix missing reference upcount
by Yuan Yao (＠yaoyuan.0553) 28 Nov '24

28 Nov '24

The reference count of host is supposed to go up by one in netconn_create. The missing ref increment causes error handling paths where netconn_close or release_host is called to prematurely decrement the ref count of host to zero. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1121

4 6

[PATCH v4 0/3] MR3547: Common Controls: Fix balloon tooltips
by Carl Bialorucki (＠cbialorucki) 26 Nov '24

26 Nov '24

Fixes balloon tooltips so that they can be drawn outside of the work area (required for system tray icons) and improves the shape of the tooltips so that they resemble their shape on Windows. -- v4: Diff reduce https://gitlab.winehq.org/wine/wine/-/merge_requests/3547

4 4

[PATCH v5 0/1] MR1139: ntoskrnl.exe: add KeNumberProcessors export.
by Etaash Mathamsetty (＠etaash.mathamsetty) 19 Nov '24

19 Nov '24

I haven't seen any software that uses this, but some older software out there might use it, so it's good idea to export it. -- v5: ntoskrnl.exe: add KeNumberProcessors export. https://gitlab.winehq.org/wine/wine/-/merge_requests/1139

4 4

[PATCH v12 0/1] MR1989: wininet: Allow UTC as a timezone.
by Etaash Mathamsetty (＠etaash.mathamsetty) 17 Nov '24

17 Nov '24

this should fix ubisoft connect outputting unknown timezone UTC in logs -- v12: wininet: Allow UTC as a timezone. https://gitlab.winehq.org/wine/wine/-/merge_requests/1989

2 2

[PATCH v7 0/4] MR359: mmdevapi: copy ContainerID property from audio driver if available
by Claire (＠ClearlyClaire) 16 Nov '24

16 Nov '24

Some games with support for the haptic feedback and speaker features of the Sony DualSense controller select the controller's audio output by filtering on the ContainerId IMMDevice property to find one that matches the controller's HID's. This MR allows this information to be accessible from the IMMDevice's property store when the audio driver provides it (none for now, but I intend to add that feature to `winepulse.drv` and maybe `winealsa.drv`) This is made specific to containerId rather than supporting VT_CLSID on every property because Wine currently stores VT_BLOBs directly in the registry value, which does not allow us to safely disambiguate between VT_CLSID and VT_BLOB values when reading from registry. -- v7: mmdevapi: Invalidate ContainerID of unavailable audio devices. https://gitlab.winehq.org/wine/wine/-/merge_requests/359

6 11

[PATCH 0/2] MR482: advapi32/tests: Test kernel object security with the primary token as well.
by Jinoh Kang (＠iamahuman) 09 Nov '24

09 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/482

2 3

[PATCH 0/1] MR474: server: Default the token owner to the token user.
by Jinoh Kang (＠iamahuman) 09 Nov '24

09 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/474

2 3

[PATCH 0/1] MR3270: winhlp32: truncate path in title bar
by Yukinari Mitsu (＠3ts75) 06 Nov '24

06 Nov '24

The buffer in the titlebar was small and the file path was truncated. Therefore, the buffer in the titlebar was expanded from 51 to 300. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3270

5 12

[PATCH v3 0/1] MR3668: cmd: fixed command chaining
by Dmitry Sokolov (＠DmitrySokolov) 06 Nov '24

06 Nov '24

Fixed the following code: ```plaintext echo 1. && echo ok || echo failed echo 2. || echo failed && echo --- & echo 3. ``` Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55489 -- v3: cmd: fixed command chaining https://gitlab.winehq.org/wine/wine/-/merge_requests/3668

4 4

[PATCH v19 0/11] MR1180: Make all kernel callbacks go through user32
by Torge Matthies (＠tmatthies) 06 Nov '24

06 Nov '24

Overwatch 2 verifies that every kernel callback that is run, lives in user32. Introduce a callback in user32 that just forwards to the other modules' callbacks. -- v19: include: Add a comment explaining why all kernel callbacks must be in user32. user32: Remove NtUserDriverCallback* kernel callbacks. winex11.drv: Route kernel callbacks through user32. winex11.drv: Pass a struct to x11drv_ime_set_result. winex11.drv: Pass a struct to x11drv_dnd_post_drop. winemac.drv: Route kernel callbacks through user32. wineandroid.drv: Route kernel callbacks through user32. opengl32: Route kernel callbacks through user32. winevulkan: Route kernel callbacks through user32. user32: Add NtUserDispatchCallback kernel callback. user.exe16: Move kernel callbacks to wow_callbacks. https://gitlab.winehq.org/wine/wine/-/merge_requests/1180

3 14

[PATCH v4 0/2] MR3671: cmd: refactored setting of 'errorlevel'
by Dmitry Sokolov (＠DmitrySokolov) 06 Nov '24

06 Nov '24

Encapsulate setting of 'errorlevel' in a separate function as the first stage of fixing bug #32679 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=32679 -- v4: cmd: fixed command chaining https://gitlab.winehq.org/wine/wine/-/merge_requests/3671

5 8

[PATCH 0/2] MR3421: win32u: Fix clip_fullscreen_window for Deus Ex
by Zsolt Vadász (＠zsoltiv) 03 Oct '24

03 Oct '24

These changes fix the camera rotation for Deus Ex. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3421

3 7

[PATCH v2 0/1] MR2657: d3d9/tests: test table fog z vs rhw with shaders, depth bias, oDepth..
by Aleksey Komarov (＠q4a) 08 Aug '24

08 Aug '24

General idea of this test is to show that a lot of factors influence the fog when transformed and untransformed vertex format was used: - Directly changing z and w (which is not equal in the corners). - Changing projection matrix that change z and w. - Using different programmable/ff vs/ps shader. - Using different depth bias. - Chaging depth in pixel shader (oDepth) may or may not affect to colors depending on the vendor implementation. - And various combinations of above. This gives `succ` in all cases on this configs: - Windows 10 with Radeon HD 8400 or Ivy Bridge GT1 (Intel HD Graphics). - Windows 7 with Radeon HD 6450. - Windows XP with GeForce Go 7300. -- v2: d3d9/tests: test table fog z vs rhw with shaders, depth bias, oDepth.. https://gitlab.winehq.org/wine/wine/-/merge_requests/2657

8 17

[PATCH 0/1] MR3047: ntdll: hook mmap for force allocate low 32-bit memory on wow64
by Fan WenJie (＠fanwenjie) 26 Jul '24

26 Jul '24

Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3047

5 5

[PATCH 0/7] MR3606: winegstreamer: Introduce a new wg_source internal interface.
by Rémi Bernon (＠rbernon) 10 Jul '24

10 Jul '24

This is the first batch of a series implementing faster media source resolution required to workaround an Unreal Engine race condition present in some games, and deterministic stream ordering that decodebin / parsebin cannot provide, which is required to expose the streams in native order, for compatibility in several other applications. I pushed the full series as a branch here: https://gitlab.winehq.org/rbernon/wine/-/commits/mr/wg-source-part-one Note that this full series is also a first step in the direction of having a simpler demuxer interface, which will be required in the future for compatibility with applications that build MF or DirectShow pipelines directly and expect the relevant components to behave as a demuxer and expose compressed media types. For now it only delays the use of wg_parser to whenever the media source is started, and matches the non-ordered streams using their media types and tags. This is a best effort solution but I don't think we can do much better for the moment. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3606

6 29

[PATCH v4 0/2] MR2120: user32: Post WM_INPUT_DEVICE_CHANGE when registering for notifications
by Evan Tang (＠etang-cw) 28 May '24

28 May '24

This seems to be relied on by some versions of [this Unreal Engine input plugin](https://www.unrealengine.com/marketplace/en-US/product/wm-input-man… Note: I'm not sure how to deal with `HID_USAGE_GENERIC_KEYPAD`, which (I think) would fall under `RIM_TYPEKEYBOARD`. Do we need to store extra info to differentiate these from `HID_USAGE_GENERIC_KEYBOARD` or is there something in the device info struct that can differentiate them? -- v4: user32: Post WM_INPUT_DEVICE_CHANGE when registering for notifications user32: Add tests for WM_INPUT_DEVICE_CHANGE messages https://gitlab.winehq.org/wine/wine/-/merge_requests/2120

3 4

[PATCH 0/2] MR3929: ntdll: Remove entries from queue in RtlWakeAddressAll().
by Paul Gofman (＠gofman) 28 May '24

28 May '24

This avoids one case of spurious wakeup of WaitOnAddress (which could be triggered by prior race on consequent WakeAddressAll and a thread trying to wake on that, leaving the waking thread in an alerted state). And fixes Resident Evil games randomly crashing due to unhandled spurious SleepConditionVariableCS wakeups. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3929

4 8

2025

2024

2023

2022

wine-gitlab September 2023