September 2023 - wine-gitlab

[PATCH 0/1] MR3920: winecoreaudio: Use os_unfair_lock when available instead of OSSpinLock.
by Brendan Shanks (＠bshanks) 22 Sep '23

22 Sep '23

OSSpinLock is deprecated, Apple recommends os_unfair_lock as the improved replacement. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3920

4 3

[PATCH v8 0/7] MR320: vkd3d-shader/dxil: Implement DX instruction LoadInput.
by Conor McCarthy (＠cmccarthy) 22 Sep '23

22 Sep '23

-- v8: vkd3d-shader/dxil: Implement DX instruction LoadInput. vkd3d-shader/dxil: Declare shader inputs. vkd3d-shader/dxbc: Load input signatures also from ISG1 chunks. vkd3d-shader/spirv: Build undefined values once. vkd3d-shader/spirv: Introduce a Static Single Assignment register type. vkd3d-shader/d3d-asm: Trace undefined registers. vkd3d-shader: Make the paramater allocator slab size at least MAX_REG_OUTPUT. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/320

2 7

[PATCH v6 0/12] MR346: Draft: tests/shader-runner: Test DXIL shaders.
by Conor McCarthy (＠cmccarthy) 22 Sep '23

22 Sep '23

This goes on top of MR 320 and 345. -- v6: tests/shader-runner: Add a '--dump-dxil' command line switch. tests/shader-runner: Test shaders with dxcompiler. tests/shader-runner: Replace immediate shader type strings with an enum. tests/shader-runner: Do not exit if a 'require' directive is not met. tests/shader-runner: Handle individual keywords in shader directives. vkd3d-shader/dxil: Implement DX instruction LoadInput. vkd3d-shader/dxil: Declare shader … [View More]

2 12

[PATCH 0/1] MR3921: ws2_32/tests: Add more tests for SO_REUSEADDR
by Ally Sommers (＠dropbear) 22 Sep '23

22 Sep '23

These are the tests from !3367 (Defer listens on addresses currently bound first by another socket). The tests marked `todo_wine` rely on a more accurate implementation of `SO_REUSEADDR`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3921

3 2

Re: [PATCH v7 0/3] MR3367: server: Defer listens on addresses currently bound first by another socket. - closed
by Ally Sommers (＠dropbear) 22 Sep '23

22 Sep '23

This merge request was closed by Ally Sommers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3367

1 0

[PATCH v59 0/6] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 22 Sep '23

22 Sep '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there.… [View More]

3 7

[PATCH 0/2] MR357: vkd3d: Fix a few tests on Intel.
by Giovanni Mascellani (＠giomasce) 21 Sep '23

21 Sep '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/357

3 3

[PATCH v3 0/2] MR354: tests: Avoid some crashes on MoltenVK.
by Giovanni Mascellani (＠giomasce) 21 Sep '23

21 Sep '23

-- v3: tests: Do not crash if the render target doesn't support MSAA 8. tests: Do not crash if a pipeline statistics query heap cannot be created. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/354

3 3

[PATCH 0/4] MR344: tests: Compile more HLSL shaders at runtime.
by Giovanni Mascellani (＠giomasce) 21 Sep '23

21 Sep '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/344

3 5

[PATCH v2 0/3] MR341: vkd3d-shader/hlsl: Add constant folding for 'fract'.
by Nikolay Sivov (＠nsivov) 21 Sep '23

21 Sep '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vkd3d-shader/hlsl: Add constant folding for 'sat'. vkd3d-shader/hlsl: Add constant folding for 'exp2'. vkd3d-shader/hlsl: Add constant folding for 'fract'. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/341

6 9

[PATCH v2 0/2] MR338: vkd3d-shader/hlsl: Correctly fold casts from float.
by Giovanni Mascellani (＠giomasce) 21 Sep '23

21 Sep '23

-- v2: vkd3d-shader/hlsl: Correctly fold casts from double. vkd3d-shader/hlsl: Correctly fold casts from float. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/338

5 8

[PATCH v5 0/2] MR336: vkd3d-shader/hlsl: Fix float modulus for vector arguments.
by Nikolay Sivov (＠nsivov) 21 Sep '23

21 Sep '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v5: vkd3d-shader/hlsl: Add constant folding for the ternary operator. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/336

5 5

Re: [PATCH v9 0/13] MR317: vkd3d-shader: Begin validating the generated IR. - approved
by Henri Verbeet (＠hverbeet) 21 Sep '23

21 Sep '23

This merge request was approved by Henri Verbeet. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/317

1 0

[PATCH 0/1] MR315: vkd3d: Add ID3D12Device2 interface.
by Andrey Gusev (＠agusev) 21 Sep '23

21 Sep '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/315

4 4

Re: [PATCH 0/1] MR355: vkd3d-shader: Rename vkd3d_shader_next_stage_info to vkd3d_shader_varying_map_info. - closed
by Henri Verbeet (＠hverbeet) 21 Sep '23

21 Sep '23

This merge request was closed by Henri Verbeet. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/355

1 0

Re: [PATCH 0/1] MR355: vkd3d-shader: Rename vkd3d_shader_next_stage_info to vkd3d_shader_varying_map_info.
by Henri Verbeet (＠hverbeet) 21 Sep '23

21 Sep '23

This was superseded by !356. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/355#note_46261

1 0

[PATCH v2 0/2] MR3896: d3d10/effect: Implement instructions used for signed integer division.
by Nikolay Sivov (＠nsivov) 21 Sep '23

21 Sep '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: d3d10/effect: Add signed integer compare instructions for expressions. d3d10/effect: Implement instructions used for signed integer division. https://gitlab.winehq.org/wine/wine/-/merge_requests/3896

3 5

Re: [PATCH v2 0/1] MR3854: winmm: Avoid use of hardcoded return values.
by Alistair Leslie-Hughes (＠alesliehughes) 21 Sep '23

21 Sep '23

What about If I changed the commit message to winmm: MCI_MapMsgAtoW return error code directly instead of a boolean. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3854#note_46256

1 0

Re: [PATCH v2 0/2] MR3917: dmime: Implement sequence track parsing. - approved
by Alexandre Julliard (＠julliard) 21 Sep '23

21 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3917

1 0

Re: [PATCH v2 0/3] MR3916: dmband: Rewrite band track parsing. - approved
by Alexandre Julliard (＠julliard) 21 Sep '23

21 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3916

1 0

Re: [PATCH v3 0/1] MR3918: msado15: Recordset::Open - Correctly update count/index values - approved
by Alexandre Julliard (＠julliard) 21 Sep '23

21 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3918

1 0

Re: [PATCH v2 0/1] MR3914: winecoreaudio: Stop using the deprecated kAudioObjectPropertyElementMaster constant. - approved
by Alexandre Julliard (＠julliard) 21 Sep '23

21 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3914

1 0

Re: [PATCH v35 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 21 Sep '23

21 Sep '23

On Thu Sep 21 20:34:12 2023 +0000, Aidan Khoury wrote: > I can for this, but we also need to check if it's a 32-bit image since > patch transforms are never applied to 64-bit images `RtlImageNtHeader` lacks proper image boundary checks for e_lfanew, so using it in this case is not safe. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46247

1 0

[PATCH v32 0/7] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 21 Sep '23

21 Sep '23

This clears up much of the todo list for mspatcha. GetFilePatchSignature* and NormalizeFileForPatchSignature have now been implemented in these changes. These changes bring better support for things like the Adobe Acrobat installer without the need for things like the winetricks mspatcha.dll native dll override. Still needed is support for interleaved streams in the LZXD decompression logic, however this is a great start to better supporting software installers that use the Windows interface … [View More]

3 8

[PATCH 0/2] MR3917: dmime: Implement sequence track parsing.
by Rémi Bernon (＠rbernon) 21 Sep '23

21 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3917

3 4

[PATCH 0/3] MR3916: dmband: Rewrite band track parsing.
by Rémi Bernon (＠rbernon) 21 Sep '23

21 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3916

4 6

[PATCH v31 0/8] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 21 Sep '23

21 Sep '23

This clears up much of the todo list for mspatcha. GetFilePatchSignature* and NormalizeFileForPatchSignature have now been implemented in these changes. These changes bring better support for things like the Adobe Acrobat installer without the need for things like the winetricks mspatcha.dll native dll override. Still needed is support for interleaved streams in the LZXD decompression logic, however this is a great start to better supporting software installers that use the Windows interface … [View More]

3 12

Re: [PATCH v3 0/5] MR356: Release 1.9. - approved
by Alexandre Julliard (＠julliard) 21 Sep '23

21 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/356

1 0

[PATCH v30 0/8] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 21 Sep '23

21 Sep '23

This clears up much of the todo list for mspatcha. GetFilePatchSignature* and NormalizeFileForPatchSignature have now been implemented in these changes. These changes bring better support for things like the Adobe Acrobat installer without the need for things like the winetricks mspatcha.dll native dll override. Still needed is support for interleaved streams in the LZXD decompression logic, however this is a great start to better supporting software installers that use the Windows interface … [View More]

4 14

[PATCH v29 0/8] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 21 Sep '23

21 Sep '23

This clears up much of the todo list for mspatcha. GetFilePatchSignature* and NormalizeFileForPatchSignature have now been implemented in these changes. These changes bring better support for things like the Adobe Acrobat installer without the need for things like the winetricks mspatcha.dll native dll override. Still needed is support for interleaved streams in the LZXD decompression logic, however this is a great start to better supporting software installers that use the Windows interface … [View More]

3 10

[PATCH v58 0/6] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 21 Sep '23

21 Sep '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there.… [View More]

3 8

[PATCH v28 0/8] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 21 Sep '23

21 Sep '23

This clears up much of the todo list for mspatcha. GetFilePatchSignature* and NormalizeFileForPatchSignature have now been implemented in these changes. These changes bring better support for things like the Adobe Acrobat installer without the need for things like the winetricks mspatcha.dll native dll override. Still needed is support for interleaved streams in the LZXD decompression logic, however this is a great start to better supporting software installers that use the Windows interface … [View More]

5 19

Re: [PATCH v7 0/3] MR3367: server: Defer listens on addresses currently bound first by another socket.
by Zebediah Figura (＠zfigura) 21 Sep '23

21 Sep '23

> Understood. Should the tests be added (`todo_wine`'d) to document the behavior discrepancy or should those only be included with the implementation if it becomes necessary to fix a real application? If you want to submit the tests alone I think they'd be accepted. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3367#note_46211

1 0

Re: [PATCH 0/6] MR3909: winewayland.drv: part 7: Basic window management
by Rémi Bernon (＠rbernon) 21 Sep '23

21 Sep '23

Looks okay I think although I find the seat locking again a bit overkill. I don't really see a scenario where a wine process would be used across seats, can this really happen on Wayland? I understand that as the event is dynamically sent we may have to support it, but I would find it simpler if we could assume that we have a seat from the start (eventually waiting for it on startup, idk), and where we'd just abort if the seat is removed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3909#note_46203

1 0

[PATCH v27 0/8] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 21 Sep '23

21 Sep '23

This clears up much of the todo list for mspatcha. GetFilePatchSignature* and NormalizeFileForPatchSignature have now been implemented in these changes. These changes bring better support for things like the Adobe Acrobat installer without the need for things like the winetricks mspatcha.dll native dll override. Still needed is support for interleaved streams in the LZXD decompression logic, however this is a great start to better supporting software installers that use the Windows interface … [View More]

3 9

[PATCH v5 0/12] MR346: Draft: tests/shader-runner: Test DXIL shaders.
by Conor McCarthy (＠cmccarthy) 21 Sep '23

21 Sep '23

This goes on top of MR 320 and 345. -- v5: tests/shader-runner: Add a '--dump-dxil' command line switch. tests/shader-runner: Test shaders with dxcompiler. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346

2 13

[PATCH v56 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 21 Sep '23

21 Sep '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there.… [View More]

4 9

Re: [PATCH v7 0/3] MR3367: server: Defer listens on addresses currently bound first by another socket.
by Ally Sommers (＠dropbear) 21 Sep '23

21 Sep '23

Understood. Should the tests be added (`todo_wine`'d) to document the behavior discrepancy or should those only be included with the implementation if it becomes necessary to fix a real application? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3367#note_46194

1 0

[PATCH v3 0/1] MR349: vkd3d-shader/ir: Remove dead code during normalisation.
by Giovanni Mascellani (＠giomasce) 21 Sep '23

21 Sep '23

-- v3: vkd3d-shader/ir: Remove dead code during normalisation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/349

3 3

Re: [PATCH v55 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 21 Sep '23

21 Sep '23

> You can't assume that the path is null-terminated. I'm pretty sure I can assume `unix_path` is null-terminated. It's ultimately provided by `wine_nt_to_unix_file_name()` (`wine_get_unix_file_name()` doesn't modify it), with the line: ```c if (*size > strlen(name)) strcpy( /* unix_path = */ nameA, name ); ``` Multiple places across other DLLs assume `wine_get_unix_file_name()` provides a null-terminated string, passing its return value to e.g. `fprintf()` and `strstr()`. > In fact … [View More]

1 0

[PATCH v2 0/2] MR345: vkd3d-shader/dxil: Fix a couple of issues.
by Conor McCarthy (＠cmccarthy) 21 Sep '23

21 Sep '23

-- v2: vkd3d-shader/dxil: Do not compile compute shaders. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/345

3 6

[PATCH v26 0/8] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 21 Sep '23

21 Sep '23

This clears up much of the todo list for mspatcha. GetFilePatchSignature* and NormalizeFileForPatchSignature have now been implemented in these changes. These changes bring better support for things like the Adobe Acrobat installer without the need for things like the winetricks mspatcha.dll native dll override. Still needed is support for interleaved streams in the LZXD decompression logic, however this is a great start to better supporting software installers that use the Windows interface … [View More]

4 10

[PATCH v2 0/2] MR354: tests: Avoid some crashes on MoltenVK.
by Giovanni Mascellani (＠giomasce) 21 Sep '23

21 Sep '23

-- v2: tests: Do not crash if the render target doesn't support MSAA 8. tests: Do not crash if a pipeline statistics query heap cannot be created. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/354

3 4

[PATCH v7 0/7] MR320: vkd3d-shader/dxil: Implement DX instruction LoadInput.
by Conor McCarthy (＠cmccarthy) 21 Sep '23

21 Sep '23

-- v7: vkd3d-shader/dxil: Implement DX instruction LoadInput. vkd3d-shader/dxil: Declare shader inputs. vkd3d-shader/dxbc: Load input signatures also from ISG1 chunks. vkd3d-shader/spirv: Build undefined values once. vkd3d-shader/spirv: Introduce a Static Single Assignment register type. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/320

3 9

[PATCH v2 0/5] MR356: Release 1.9.
by Henri Verbeet (＠hverbeet) 21 Sep '23

21 Sep '23

-- v2: Release 1.9. vkd3d-shader/d3dbc: Translate sm1 fragment outputs to system values. vkd3d-shader/dxbc: Map sm4 fragment outputs to system values based on their name. vkd3d-shader: Add definitions for more fragment output system values. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/356

3 7

Re: [PATCH v6 0/1] MR321: vkd3d-shader/hlsl: Implement intrinsic tan.
by Giovanni Mascellani (＠giomasce) 21 Sep '23

21 Sep '23

On Thu Sep 21 09:50:20 2023 +0000, Petrichor Park wrote: > Oh dear. Do I need to worry about the big scary warning at the top > saying that my merge failed? > I don't think I did this right. No, you didn't. Don't stress too much over it, though, git is nice folk, but it's a well established fact that it's not one with whom it's immediately easy to make friends. Hoping to help, here is what I would do now: ```sh git checkout master git pull # Ensure that your master is up-… [View More]

1 0

Re: [PATCH 0/6] MR3909: winewayland.drv: part 7: Basic window management
by Alexandros Frantzis (＠afrantzis) 21 Sep '23

21 Sep '23

On Thu Sep 21 09:49:58 2023 +0000, Dallas Strouse wrote: > Hi, I'm back again :P > Since it's probably about time for it, and I forgot to send that email a > while back, I might as well ask now: are there plans to make Wine use > libdecor at some point in the future, so that there are "native" window > decorations for desktops that don't provide xdg-decoration? A lot of the > work here for compositor-initiated window closing is a requirement for > that. > There may be … [View More]

1 0

[PATCH v54 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 21 Sep '23

21 Sep '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there.… [View More]

4 9

Re: [PATCH v2 0/1] MR3854: winmm: Avoid use of hardcoded return values.
by Huw Davies (＠huw) 21 Sep '23

21 Sep '23

This commit is doing more than just avoiding hardcoded return values. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3854#note_46167

1 0

Re: [PATCH 0/6] MR3909: winewayland.drv: part 7: Basic window management
by Alexandros Frantzis (＠afrantzis) 21 Sep '23

21 Sep '23

On Thu Sep 21 08:28:33 2023 +0000, Gabriele wrote: > I wonder if from this MR, we'll be able to somehow test those changes, > by using an environment variable or something similar. > I'd be very interested in testing it out as soon as it gets merged! An easy and non-intrusive way to experiment with the upstream Wayland driver is: 1. Create the registry key `HKEY_CURRENT_USER\Software\Wine\Drivers\Graphics="x11,wayland"` 2. Unset the `DISPLAY` env. variable, e.g, `DISPLAY= wine ...`, to … [View More]

1 0

2025

2024

2023

2022

wine-gitlab September 2023