September 2023 - wine-gitlab

Re: [PATCH v2 0/1] MR3874: dbghelp: Check that dwarf unwinder did actually unwind. - approved
by Alexandre Julliard (＠julliard) 18 Sep '23

18 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3874

1 0

Re: [PATCH v2 0/1] MR3879: include: Add missing WinEvent definitions. - approved
by Alexandre Julliard (＠julliard) 18 Sep '23

18 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3879

1 0

Re: [PATCH v2 0/1] MR3878: server: Return WSAEOPNOTSUPP on listen() if the socket's type is SOCK_DGRAM - approved
by Alexandre Julliard (＠julliard) 18 Sep '23

18 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3878

1 0

Re: [PATCH v3 0/1] MR3868: user32/tests: Account for some messages from dual-monitor setups. - approved
by Alexandre Julliard (＠julliard) 18 Sep '23

18 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3868

1 0

Re: [PATCH v2 0/1] MR3867: mfreadwrite/reader: Update to IMFSourceReaderEx. - approved
by Alexandre Julliard (＠julliard) 18 Sep '23

18 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3867

1 0

Re: [PATCH v4 0/1] MR1170: wbemprox: Fix out-of-bounds access caused by codepoints above U+00FF. - approved
by Alexandre Julliard (＠julliard) 18 Sep '23

18 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1170

1 0

Re: [PATCH v2 0/1] MR3859: d3d10/effect: Implement 'mov' opcode for expressions. - approved
by Alexandre Julliard (＠julliard) 18 Sep '23

18 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3859

1 0

Re: [PATCH v3 0/8] MR3852: dmusic: Parse instrument waves and download them to the port. - approved
by Alexandre Julliard (＠julliard) 18 Sep '23

18 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3852

1 0

Re: [PATCH v2 0/1] MR3861: gdiplus: Copy the compound array in GdipClonePen(). - approved
by Alexandre Julliard (＠julliard) 18 Sep '23

18 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3861

1 0

Re: [PATCH v2 0/3] MR3819: uiautomationcore: Implement UiaHasServerSideProvider. - approved
by Alexandre Julliard (＠julliard) 18 Sep '23

18 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3819

1 0

[PATCH v2 0/2] MR3866: gdiplus: Fix GdipCreateFont character set initialization.
by Jeffrey Smith (＠whydoubt) 18 Sep '23

18 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=34789 -- v2: gdiplus: Fix GdipCreateFont character set initialization. gdiplus/tests: Test GdipCreateFont character set initialization. https://gitlab.winehq.org/wine/wine/-/merge_requests/3866

3 4

Re: [PATCH v6 0/3] MR347: Fill in more missing details in d3d12.idl - approved
by Alexandre Julliard (＠julliard) 18 Sep '23

18 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/347

1 0

Re: [PATCH v2 0/1] MR350: vkd3d-shader: Hide support for DXIL sources. - approved
by Alexandre Julliard (＠julliard) 18 Sep '23

18 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/350

1 0

Re: [PATCH v2 0/1] MR348: tests: Relax the precision of some tests so that they pass on MoltenVK. - approved
by Alexandre Julliard (＠julliard) 18 Sep '23

18 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/348

1 0

[PATCH v6 0/1] MR3367: server: Ignore EADDRINUSE from listen() unless the provided socket is wildcarded.
by Ally Sommers (＠dropbear) 18 Sep '23

18 Sep '23

This fixes a `todo_wine` in ws2_32's socket tests. -- v6: server: Defer listens on addresses currently bound first by another socket. https://gitlab.winehq.org/wine/wine/-/merge_requests/3367

4 4

[PATCH v6 0/3] MR3855: Fixes for ntlea
by Yuxuan Shui (＠yshui) 18 Sep '23

18 Sep '23

Make functions ntlea needs to patch hotpatchable. And add a asm wrapper for `GetWindowLongA` to workaround an assumption ntlea made. -- v6: user32: add hotpatchable wrapper for GetWindowLongA https://gitlab.winehq.org/wine/wine/-/merge_requests/3855

2 4

[PATCH v5 0/3] MR3855: Fixes for ntlea
by Yuxuan Shui (＠yshui) 18 Sep '23

18 Sep '23

Make functions ntlea needs to patch hotpatchable. And add a asm wrapper for `GetWindowLongA` to workaround an assumption ntlea made. -- v5: user32: add hotpatchable wrapper for GetWindowLongA https://gitlab.winehq.org/wine/wine/-/merge_requests/3855

5 9

[PATCH v27 0/1] MR3074: Move getpeername() implementation to wineserver
by Ally Sommers (＠dropbear) 18 Sep '23

18 Sep '23

`getpeername()` is currently handled in ntdll. This merge request changes ntdll to forward `getpeername()` to wineserver. The implementation utilises new `peer_addr` and `peer_addr_len` fields in wineserver's `struct sock`. This fixes multiple `todo_wine`s in `ws2_32/tests` and allows for more accurate peer names to be provided in case the address the socket is bound to on the Unix side does not match what `bind()` was called with on the Windows side. *This merge request was originally intended to be included in !2786 (Add support for AF_UNIX sockets) but was split into its own merge request because this is not an insignificant change.* -- v27: server: Move getpeername() implementation from ntdll/unix. https://gitlab.winehq.org/wine/wine/-/merge_requests/3074

4 6

[PATCH v5 0/2] MR3877: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 18 Sep '23

18 Sep '23

-- v5: gdiplus/tests: add tests of InterpolationMode Bilinear for GdipDrawImagePointsRect gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect https://gitlab.winehq.org/wine/wine/-/merge_requests/3877

3 6

[PATCH v3 0/4] MR3836: Added definitions and initial tests for FileRenameInformationEx and FileLinkInformationEx
by Joel Holdsworth (＠jhol) 18 Sep '23

18 Sep '23

This patch-set adds the definitions and struct modifications required to eventually implement `FileRenameInformationEx` and `FileLinkInformationEx`. The initial tests are copies of the tests for `FileRenameInformation` and `FileLinkInformation`, but with the `ReplaceIfExists` field replaced with the equivalient `Flag` value: `FILE_RENAME_REPLACE_IF_EXISTS` or `FILE_LINK_REPLACE_IF_EXISTS` respectively. -- v3: ntdll/tests: Test both FileLinkInformation and FileLinkInformationEx in test_file_link_information. include: Add flags to FILE_LINK_INFORMATION used by FileLinkInformationEx. ntdll/tests: Test both FileRenameInformation and FileRenameInformationEx in test_file_rename_information. https://gitlab.winehq.org/wine/wine/-/merge_requests/3836

4 7

Re: [PATCH v4 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Jeffrey Smith (＠whydoubt) 18 Sep '23

18 Sep '23

On Mon Sep 18 17:52:49 2023 +0000, Zebediah Figura wrote: > Why are we adding one here? That doesn't look right. I think I see what the intent is, but it is unnecessarily 'clever'. It would be clearer to use something like a `BOOL modified`, and ultimately `return modified ? NORMALIZE_RESULT_SUCCESS_MODIFIED : NORMALIZE_RESULT_SUCCESS;` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_45774

1 0

[PATCH v3 0/3] MR3855: Fixes for ntlea
by Yuxuan Shui (＠yshui) 18 Sep '23

18 Sep '23

Make functions ntlea needs to patch hotpatchable. And add a asm wrapper for `GetWindowLongA` to workaround an assumption ntlea made. -- v3: user32: add hotpatchable wrapper for GetWindowLongA https://gitlab.winehq.org/wine/wine/-/merge_requests/3855

3 6

Re: [PATCH v4 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Zebediah Figura (＠zfigura) 18 Sep '23

18 Sep '23

Zebediah Figura (@zfigura) commented about dlls/mspatcha/pecoff.h: > +ULONG image_rva_to_file_offset( > + IMAGE_NT_HEADERS32 UNALIGNED *nt_headers, ULONG rva, PUCHAR image_base, ULONG image_size); > + > +ULONG image_directory_rva_and_size( > + IMAGE_NT_HEADERS32 UNALIGNED *nt_header, USHORT directory_entry, ULONG *directory_size, > + PUCHAR image_base, ULONG image_size); > + > +ULONG image_directory_offset_and_size( > + IMAGE_NT_HEADERS32 UNALIGNED *nt_header, USHORT directory_entry, ULONG *directory_size, > + PUCHAR image_base, ULONG image_size); > + > +PVOID image_rva_to_mapped_address( > + IMAGE_NT_HEADERS32 UNALIGNED *nt_headers, ULONG rva, PVOID image_base, ULONG image_size); > + > +PVOID image_directory_mapped_address( > + IMAGE_NT_HEADERS32 UNALIGNED *nt_headers, USHORT directory_entry, ULONG *directory_size, I don't think we need another C or header file for these. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_45765

1 0

Re: [PATCH v4 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Zebediah Figura (＠zfigura) 18 Sep '23

18 Sep '23

Zebediah Figura (@zfigura) commented about dlls/mspatcha/pa19.c: > + } > + } > + > + for (i = 0; i < retain_range_count; ++i) { > + if (retain_range_array[i].OffsetInOldFile <= old_file_size > + && (retain_range_array[i].OffsetInOldFile + retain_range_array[i].LengthInBytes) <= old_file_size) > + { > + memset(&old_file_buffer[retain_range_array[i].OffsetInOldFile], > + 0, > + retain_range_array[i].LengthInBytes); > + result = NORMALIZE_RESULT_SUCCESS; > + } > + } > + } > + > + return result + 1; Why are we adding one here? That doesn't look right. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_45764

1 0

Re: [PATCH v4 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Zebediah Figura (＠zfigura) 18 Sep '23

18 Sep '23

Zebediah Figura (@zfigura) commented about dlls/mspatcha/pa19.c: > + BYTE *old_file_buffer, ULONG old_file_size, > + ULONG option_flags, PATCH_OPTION_DATA *option_data, > + ULONG new_image_base, ULONG new_image_time, > + const PATCH_IGNORE_RANGE *ignore_range_array, ULONG ignore_range_count, > + const PATCH_RETAIN_RANGE *retain_range_array, ULONG retain_range_count) > +{ > + int result = 0; > + ULONG i; > + IMAGE_NT_HEADERS32 UNALIGNED *nt_headers; > + > + UNREFERENCED_PARAMETER(option_data); > + > + TRACE("normalizing image at 0x%p with options 0x%lX, new base 0x%lX, new time %lu", > + old_file_buffer, option_flags, new_image_base, new_image_time); > + > + if (old_file_buffer && old_file_size) Early return would save you a level of indentation here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_45763

1 0

Re: [PATCH v4 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Zebediah Figura (＠zfigura) 18 Sep '23

18 Sep '23

Zebediah Figura (@zfigura) commented about dlls/mspatcha/pa19.c: > + if (size_in_bytes & 1) { > + sum += *buffer; > + } > + > + return (WORD)(HIWORD(sum) + LOWORD(sum)); > +} > + > +/* Normalizes a given 32-bit PE image to render a stream that is common. */ > +int normalize_old_file_image( > + BYTE *old_file_buffer, ULONG old_file_size, > + ULONG option_flags, PATCH_OPTION_DATA *option_data, > + ULONG new_image_base, ULONG new_image_time, > + const PATCH_IGNORE_RANGE *ignore_range_array, ULONG ignore_range_count, > + const PATCH_RETAIN_RANGE *retain_range_array, ULONG retain_range_count) > +{ > + int result = 0; You defined symbolic constants; why not use them here? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_45762

1 0

Re: [PATCH v4 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Zebediah Figura (＠zfigura) 18 Sep '23

18 Sep '23

Zebediah Figura (@zfigura) commented about dlls/mspatcha/pa19.c: > + return (WORD)(HIWORD(sum) + LOWORD(sum)); > +} > + > +/* Normalizes a given 32-bit PE image to render a stream that is common. */ > +int normalize_old_file_image( > + BYTE *old_file_buffer, ULONG old_file_size, > + ULONG option_flags, PATCH_OPTION_DATA *option_data, > + ULONG new_image_base, ULONG new_image_time, > + const PATCH_IGNORE_RANGE *ignore_range_array, ULONG ignore_range_count, > + const PATCH_RETAIN_RANGE *retain_range_array, ULONG retain_range_count) > +{ > + int result = 0; > + ULONG i; > + IMAGE_NT_HEADERS32 UNALIGNED *nt_headers; > + > + UNREFERENCED_PARAMETER(option_data); We don't need this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_45761

1 0

Re: [PATCH v4 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Zebediah Figura (＠zfigura) 18 Sep '23

18 Sep '23

Zebediah Figura (@zfigura) commented about dlls/mspatcha/pa19.c: > + ++import_desc; > + } > + } > + > + /* Mark the .idata section as writable */ > + section_table = IMAGE_FIRST_SECTION(nt_headers); > + section_count = nt_headers->FileHeader.NumberOfSections; > + for (ULONG i = 0; i < section_count; i++) > + { > + if ((PUCHAR)&section_table[i] < mapped_image > + || (PUCHAR)&section_table[i] > (mapped_image_end - sizeof(IMAGE_SECTION_HEADER))) { > + throw_pe_fmt_exception(); > + } > + > + /* tolower hack check for ".idata " */ > + if ((*((ULONGLONG UNALIGNED *)&section_table[i].Name) | 0x2020202020202020) == 0x202061746164692E) { Why is this a hack? (Why are we not doing a string comparison?) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_45760

1 0

Re: [PATCH v4 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Zebediah Figura (＠zfigura) 18 Sep '23

18 Sep '23

Zebediah Figura (@zfigura) commented about dlls/mspatcha/pa19.c: > + } > + > + nt_headers->OptionalHeader.ImageBase = (DWORD)new_image_base; > + result = TRUE; > + > + reloc_dir_remaining = (LONG)reloc_dir_size; > + while (reloc_dir_remaining > 0) { > + > + if (reloc_block->SizeOfBlock <= (ULONG)reloc_dir_remaining > + && reloc_block->SizeOfBlock > sizeof(IMAGE_BASE_RELOCATION)) > + { > + reloc_block_base = (IMAGE_BASE_RELOCATION UNALIGNED *)(mapped_image_base + > + image_rva_to_file_offset(nt_headers, reloc_block->VirtualAddress, mapped_image_base, mapped_image_size)); > + if (reloc_block_base) > + { > + reloc = (USHORT UNALIGNED *)((PUCHAR)reloc_block + sizeof(IMAGE_BASE_RELOCATION)); I don't think we want UNALIGNED, not least because it doesn't do anything on non-MSVC compilers. If any of these actually can be unaligned (can they?) then I think we should just use memcpy. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_45759

1 0

Re: [PATCH v4 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Zebediah Figura (＠zfigura) 18 Sep '23

18 Sep '23

Zebediah Figura (@zfigura) commented about dlls/mspatcha/mspatcha_main.c: > { > - FIXME("stub - %p, %lu, %lx, %p, %lu, %lu, %lu, %p, %lu, %p\n", file_buffer, file_size, flags, options, new_coff_base, > - new_coff_time, ignore_range_count, ignore_range, retain_range_count, retain_range); > - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > - return 0; > + int result; > + > + result = normalize_old_file_image( > + file_buffer, file_size, > + option_flags, option_data, > + new_coff_base, new_coff_time, > + ignore_range_array, ignore_range_count, > + retain_range_array, retain_range_count); > + > + return result; > } The column limit is larger than 50 characters. No need to reflow to make it shorter. I'd advocate for keeping a trace in any API entry point. The 'result' variable is useless. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_45758

1 0

[PATCH v4 0/2] MR3259: Add environment variable to isolate WINEPREFIX at creation
by Fabian Maurer (＠DarkShadow44) 18 Sep '23

18 Sep '23

I'm aware that winecfg allows unlinking of symlinked folders, but this is very annoying when regularly recreating WINEPREFIXES. This change makes it easy to isolate those folders from the start. -- v4: ntdll: Add environment variable to prevent symlinking dosdevices/z: shell32: Add environment variable to prevent symlinking home folders https://gitlab.winehq.org/wine/wine/-/merge_requests/3259

2 2

[PATCH v5 0/2] MR3151: widl: Prevent infinite loop when structure contains array of itself
by Fabian Maurer (＠DarkShadow44) 18 Sep '23

18 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55115 -- v5: widl: In type_has_full_pointer recurse for pointer types as well widl: Prevent infinite loop when structure contains array of itself https://gitlab.winehq.org/wine/wine/-/merge_requests/3151

2 3

[PATCH 0/11] MR3881: mshtml: Preparatory work for converting more node vtbl methods to dispex.
by Gabriel Ivăncescu (＠insn) 18 Sep '23

18 Sep '23

This is mostly just no-ops moving stuff around except for last patch, so they're in a consistent ordering for when we'll replace them to dispex vtbl methods, keeping those patches smaller and more obvious what they change. Next MR will convert query_interface (and maybe destructor, QI will need a bit more prep work first). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3881

3 12

[PATCH v4 0/2] MR3151: widl: Prevent infinite loop when structure contains array of itself
by Fabian Maurer (＠DarkShadow44) 18 Sep '23

18 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55115 -- v4: widl: In type_has_full_pointer recurse for pointer types as well widl: Prevent infinite loop when structure contains array of itself https://gitlab.winehq.org/wine/wine/-/merge_requests/3151

3 7

[PATCH 0/1] MR3875: msvcp110: Add _Winerror_map implementation.
by Piotr Caban (＠piotr) 18 Sep '23

18 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3875

3 2

[PATCH v3 0/7] MR3851: dmime: Better implement DMUS_PMSG message processing.
by Rémi Bernon (＠rbernon) 18 Sep '23

18 Sep '23

-- v3: dmime: Pass the DMUS_PMSG through the performance graph. dmime: Rename DMUS_PMSGToItem to message_from_DMUS_PMSG. dmime: Remove unnecessary struct message members. dmime: Use a struct list to keep performance messages. dmime: Get rid of the DMUS_PMSGItem typedef. dmime: Convert DMUS_PMSG music and reference times in SendPMsg. dmime/tests: Test that SendPMsg also converts reference time. https://gitlab.winehq.org/wine/wine/-/merge_requests/3851

3 9

[PATCH 0/2] MR3882: msvcr110: Use Context blocking functions in _StructuredTaskCollection class.
by Piotr Caban (＠piotr) 18 Sep '23

18 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3882

2 2

[PATCH v3 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 18 Sep '23

18 Sep '23

This clears up much of the todo list for mspatcha. GetFilePatchSignature* and NormalizeFileForPatchSignature have now been implemented in these changes. These changes bring better support for things like the Adobe Acrobat installer without the need for things like the winetricks mspatcha.dll native dll override. Still needed is support for interleaved streams in the LZXD decompression logic, however this is a great start to better supporting software installers that use the Windows interface for creating and applying patches to files. -- v3: Add vscode workspace setup https://gitlab.winehq.org/wine/wine/-/merge_requests/3870

3 4

[PATCH v5 0/1] MR3367: server: Ignore EADDRINUSE from listen() unless the provided socket is wildcarded.
by Ally Sommers (＠dropbear) 18 Sep '23

18 Sep '23

This fixes a `todo_wine` in ws2_32's socket tests. -- v5: server: Defer listens on addresses currently bound first by another socket. https://gitlab.winehq.org/wine/wine/-/merge_requests/3367

3 2

[PATCH v2 0/4] MR3836: Added definitions and initial tests for FileRenameInformationEx and FileLinkInformationEx
by Joel Holdsworth (＠jhol) 18 Sep '23

18 Sep '23

This patch-set adds the definitions and struct modifications required to eventually implement `FileRenameInformationEx` and `FileLinkInformationEx`. The initial tests are copies of the tests for `FileRenameInformation` and `FileLinkInformation`, but with the `ReplaceIfExists` field replaced with the equivalient `Flag` value: `FILE_RENAME_REPLACE_IF_EXISTS` or `FILE_LINK_REPLACE_IF_EXISTS` respectively. -- v2: ntdll/tests: Test both FileLinkInformation and FileLinkInformationEx in test_file_link_information. include: Add flags to FILE_LINK_INFORMATION used by FileLinkInformationEx. ntdll/tests: Test both FileRenameInformation and FileRenameInformationEx in test_file_rename_information. include: Add flags to FILE_RENAME_INFORMATION used by FileRenameInformationEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/3836

4 8

[PATCH v3 0/2] MR3877: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 18 Sep '23

18 Sep '23

-- v3: gdiplus/tests: add tests of InterpolationMode Bilinear for GdipDrawImagePointsRect gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect https://gitlab.winehq.org/wine/wine/-/merge_requests/3877

3 3

[PATCH v2 0/1] MR3873: tools/winebuild: Force CIE content on x86_64.
by eric pouech (＠epo) 18 Sep '23

18 Sep '23

Force as to emit expected CIE/FDE information for x86_64 CPU in .debug_frame section. This has been unveiled by 425bd55b02e375b9ac8f79b254ce3ca5c9e72719 (before this commit, the .cfi directives where not emitted by winebuild). x86_64-w64-mingw32-as on x86_64 emits "strange" unwinding information (from winebuild). 00000000 0000000000000014 ffffffff CIE Version: 1 Augmentation: "" Code alignment factor: 1 Data alignment factor: -8 Return address column: 32 DW_CFA_def_cfa: r7 (rsp) ofs 8 DW_CFA_offset: r32 (xmm15) at cfa-8 DW_CFA_nop DW_CFA_nop DW_CFA_nop DW_CFA_nop DW_CFA_nop DW_CFA_nop Consequence: in unwinding, xmm15 gets updated, but rip isn't, causing an infinite loop in dbghelp. Wine-Bug-Id: https://bugs.winehq.org/show_bug.cgi?id=55560 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v2: tools/winebuild: Emit SEH unwind information instead of dwarf. https://gitlab.winehq.org/wine/wine/-/merge_requests/3873

2 1

[PATCH v5 0/3] MR347: Fill in more missing details in d3d12.idl
by Martin Storsjö (＠mstorsjo) 18 Sep '23

18 Sep '23

-- v5: include: Add UUIDs for use with D3D12EnableExperimentalFeatures. include: Add the ID3D12GraphicsCommandList{5,6,7} interfaces. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/347

3 5

[PATCH 0/1] MR350: vkd3d-shader: Hide support for DXIL sources.
by Henri Verbeet (＠hverbeet) 18 Sep '23

18 Sep '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/350

2 2

[PATCH 0/1] MR3879: include: Add missing WinEvent definitions.
by Connor McAdams (＠cmcadams) 18 Sep '23

18 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3879

2 1

[PATCH 0/1] MR3878: server: Return WSAEOPNOTSUPP on listen() if the socket's type is SOCK_DGRAM
by Ally Sommers (＠dropbear) 18 Sep '23

18 Sep '23

On Windows, `listen()` throws `WSAEOPNOTSUPP` when provided with a `SOCK_DGRAM` socket. Wine currently only throws `WSAEOPNOTSUPP` if the socket is bound; otherwise it throws `WSAEINVAL`. This patch modifies the `IOCTL_AFD_LISTEN` case in wineserver's `sock_ioctl()` throw `WSAEOPNOTSUPP` if it's passed an unbound `SOCK_DGRAM` socket. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3878

3 2

[PATCH v2 0/1] MR3877: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 18 Sep '23

18 Sep '23

-- v2: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect https://gitlab.winehq.org/wine/wine/-/merge_requests/3877

3 2

[PATCH v4 0/1] MR3871: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 18 Sep '23

18 Sep '23

-- v4: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect https://gitlab.winehq.org/wine/wine/-/merge_requests/3871

3 3

[PATCH 0/1] MR348: tests: Relax the precision of some tests so that they pass on MoltenVK.
by Giovanni Mascellani (＠giomasce) 18 Sep '23

18 Sep '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/348

3 2

[PATCH 0/1] MR3877: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 18 Sep '23

18 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3877

3 2

2025

2024

2023

2022

wine-gitlab September 2023